Most params are formally deprecated here. This was originally planned
for MDL-80042, but I realised that having an emit, and final param is a
very useful option going forward.
This patch also moves the is_deprecated(), and related methods to the
\core\deprecated attribute.
* We need to bump the plugin version in order for
\core\task\manager::reset_scheduled_tasks_for_component() to be run
and clear the removed legacy scheduled task.
Following MDL-52846 this now finally deprecates and removes the
following classes:
- \core\task\legacy_plugin_cron_task.
- \mod_quiz\task\legacy_quiz_reports_cron
- \mod_quiz\task\legacy_quiz_accessrules_cron
- \mod_workshop\task\legacy_workshop_allocation_cron
Please, use the Task API instead:
https://moodledev.io/docs/apis/subsystems/task
This also removes the corresponding and specific to legacy cron strings
from mod_quiz and mod_workshop.
Following MDL-52846 this now finally deprecates and removes the
functions:
- cron_execute_plugin_type()
- cron_bc_hack_plugin_functions()
Please, use the Task API instead:
https://moodledev.io/docs/apis/subsystems/task
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@const is not a valid phpdoc tag and @var should be used to
document both classes properties and constants (no matter how
weird that may sound, heh).
Link to (draft right now) PHP-FIG:
https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#518-var
So, with this commit we are just replacing all uses by the correct
@var one. Note that the type is entirely optional, in fact I think
that there isn't much need of it for constants because it's obvious
for both humans and machines which the type is. But, as far as it's
also correct to specify it, we haven't modified that detail.
The only detail modified are the cases where the constant name was
specified in the phpdoc, that's not needed, hence, the names have
been removed from there when present (a couple of cases).
In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.
Following MDL-65835 this now finally deprecates and removes the
functions:
- plagiarism_save_form_elements(), please use
{plugin name}_coursemodule_edit_post_actions() instead
- plagiarism_get_form_elements_module(), please use
{plugin name}_coursemodule_standard_elements() instead.
- plagiarism_plugin::get_form_elements_module(), please
use {plugin name}_coursemodule_edit_post_actions() instead.
- plagiarism_plugin::save_form_elements(), please use
{plugin name}_coursemodule_standard_elements() instead.
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Sara Arjona