572ca40ce7
MDL-74301 eslint: Enable 'reportUnusedDisableDirectives' eslint setting
...
This will warn on unused /* eslint-disable */ statements.
2023-07-03 15:21:53 +01:00
04f8fdd021
MDL-77164 various: fix javascript AMD module name
2023-04-13 09:43:15 +01:00
1e8c579812
MDL-61458 tool_lp: remove custom cohort autocomplete form selector.
...
The previous commit replaced the only remaining usage of it with the
equivalent core cohort form element. Prior to that, 21a0008f
2023-02-28 15:45:20 +00:00
ea5638c354
MDL-74348 tool_lp: fix dialogue height and add scroll
2022-04-05 11:08:14 +02:00
349312143d
MDL-72013 js: Fix jsdocs to meet stricter eslint
2021-10-21 13:28:00 +08:00
4f422785c6
MDL-71113 javascript: Improve basic JS Documentation
2021-06-18 09:38:05 +08:00
92179b7057
MDL-71113 js: Fix all jsdoc warnings
2021-06-18 09:38:05 +08:00
63a66eb2ce
MDL-69134 competencies: Behat fails randomly opening dialogues
2020-07-08 09:21:44 +08:00
dafa2c6aa5
MDL-66378 competency: Add pending promises to competency chooser
2019-08-19 08:16:41 +08:00
89da9b4900
MDL-65154 competencies: Filter course competencies
...
Add an activity filter to the course competencies screen.
2019-05-06 09:34:25 +08:00
8aff6f6f14
MDL-63876 badges: Coding style
...
Add comments to document function params and template example context.
2019-03-29 11:31:15 +08:00
15e6a76e6f
MDL-63876 competencies: Use direct URL
...
Instead of showing competencies in a dialogue, give them their own full url to
display the competency in the framework it belongs to. This is useful for exported
data that won't have access to javascript.
2019-03-29 11:31:15 +08:00
da5e19a128
MDL-63876 badges: Do not call tool_lp directly
2019-03-29 11:31:15 +08:00
f4524f8da3
MDL-59845 tool_lp: Add js tracking around UI refresh
2018-05-02 09:15:43 +08:00
d9dff92fef
MDL-59761 eslint: Auto-fix some minor lint warnings
2017-09-06 08:53:50 +01:00
08c2360e4a
MDL-57139 competencies: ensure promise best practices
2017-06-01 10:27:59 +01:00
7b02521c39
MDL-56435 boost: Better styling for competencies in boost
...
Changes
- add custom-select to all select fields
- add btn btn-primary/secondary to all buttons
- add list-inline to all lists with inline class
- style dropdowns like a bootstrap menu
- add col-md-6 to span6
2016-11-14 10:31:01 +08:00
207136f279
MDL-56684 competencies: Boost for competency templates
...
Add BS4 markup to all competencies templates. Also tweaked the template library to make it
easier in future when modifying templates and reloading.
2016-11-04 14:45:58 +00:00
5602dc1735
MDL-54944 js: ensure functions are consistent in return val
...
Mostly we are being incosnistent when giving an early-exit shortcut.
Detected by http://eslint.org/docs/rules/consistent-return
2016-07-07 12:11:07 +01:00
7b7d55e11a
MDL-54944 js: split variable intialisations in multiple lines
...
To increase code clarity, we don't allow multiple intilisations to be
confused with each other.
Detected by http://eslint.org/docs/rules/one-var-declaration-per-line
2016-07-07 12:11:06 +01:00
2d2b6c9d22
MDL-54944 js: remove uncessary .call() uses
...
Detected by http://eslint.org/docs/rules/no-useless-call
2016-07-07 12:11:06 +01:00
b1c4d0f2d7
MDL-54944 js: Remove uncessary bind() calls
...
Most of these cases, we are already capturing this in a temporary
variable, so the bind becomes uncessary.
Discovered by http://eslint.org/docs/rules/no-extra-bind
2016-07-07 12:11:06 +01:00
9f5f3dcc83
MDL-54944 js: Fix spacing of objects coding style
...
Fixed by http://eslint.org/docs/rules/object-curly-spacing
2016-07-07 12:11:05 +01:00
037de71996
MDL-54944 eslint: Add rules from Policy decision
...
Also bump eslint to v2.13.1 and make the version explicit in
package.json
2016-07-07 12:10:49 +01:00
c96f55e6f9
MDL-54939 amd: fix lint issues
...
Mostly correcting jsdoc, some other line wrapping rules and empty
functions.
2016-06-17 09:03:18 +01:00
35be582696
MDL-54939 amd: Fix lint issues fixable with eslint --fix
2016-06-16 19:33:00 +01:00
3adb62b727
MDL-52127 js: check amd files with eslint grunt task
...
I have spent quite a lot of time working through the current list of
eslint options and configuring them for Moodle style and I think this is
a very good basis to start us at (as well as taking some of out jshint
options out with https://www.npmjs.com/package/polyjuice ). Thanks to
Andrew Nicols, Mark Johnson and Frédéric Massart for some refinements.
With this configuration the grunt build will fail if errors are present
in the js (though you can of course tell jshint to ignore some errors,
as I have done in admin/tool/lp/amd/src/competency_rule_points.js and
defining the Y global in lib/amd/src/yui.js ).
The grunt task will not report warnings by default, but a new
--show-lint-warnings flag will help achieve that. Editor
integrations/stanadalone eslint tool will surely be a better way of
getting eslint errors rather than using the grunt task.
2016-06-11 10:14:35 +01:00
6e91817178
MDL-54721 report_competency: Do not ignore the first user selection
2016-05-26 17:54:52 +08:00
2239883b56
MDL-53293 tool_lp: Destroy dragdrop instance before re-creating
2016-05-11 08:19:39 +08:00
8ec64e757e
Merge branch 'MDL-53989-master' of git://github.com/ryanwyllie/moodle
2016-05-09 07:37:09 +08:00
fd83879728
MDL-53989 cbe: CMD + click selection for competency picker
2016-05-06 04:40:02 +00:00
be8b9189c4
MDL-53730 JavaScript: Fix for competency autoselect issue.
...
When trying to select a user or competency the first select
would not work. Worked fine on the second select. This fixes
that problem and tidies up the code.
2016-05-06 09:27:32 +08:00
f6ab2b87e6
Merge branch 'MDL-53879-master' of git://github.com/FMCorz/moodle
2016-04-29 12:18:05 +01:00
0bb7552429
MDL-53494 tool_lp: Set correct competency and user ID attributes
...
Sets the correct competency and user ID data attributes for the list of
user competencies in the plan.
2016-04-29 12:18:04 +01:00
8ea0f17ae9
MDL-53879 competency: Remove limit on framework depth
2016-04-28 16:41:24 +08:00
60a9993bce
MDL-53494 tool_lp: Fix dialogue display when plan is completed
2016-04-27 09:09:52 +01:00
587580a0df
Merge branch 'MDL-53494_master' of https://github.com/StudiUM/moodle
2016-04-26 11:31:55 +01:00
6e233df58e
Merge branch 'MDL-53667-master' of git://github.com/FMCorz/moodle
2016-04-26 11:38:00 +08:00
ee0ca65f4e
MDL-53678 tool_lp: Dropdown list plan displays horizontal scroll bar
2016-04-22 13:51:52 -04:00
7fbbd771f7
MDL-53494 tool_lp: user_competency_in_plan page should be in a popup
2016-04-22 12:32:46 -04:00
4474c87401
MDL-53451 competency: Removing sneaky whitespaces
2016-04-19 12:21:36 +08:00
e912927d7b
MDL-53667 tool_lp: Use event delegate for competency dialogue
...
This was causing dramatical performance issues when the module
was loaded hundreds of times on the same page, causing each instance
to detach and attach a new event listener.
2016-04-18 14:52:48 +08:00
1e99f31e33
MDL-53654 competency: Provide a way to delete evidence
2016-04-18 11:06:47 +08:00
5f887f4b96
MDL-53528 tool_lp: Allow user to choose parent when creating competency
2016-04-18 11:06:01 +08:00
81de839f37
MDL-53700 competency: Migrating external functions to core
2016-04-18 11:05:59 +08:00
67bc0eaf38
MDL-53700 competency: Migrate main classes to core
2016-04-18 11:05:59 +08:00
4a4bda6d2d
MDL-53567 tool_lp: Close menubar on click
...
This patch enables the closing of the menubar when a menu item is
clicked or when any other element outside the menubar is clicked.
2016-04-18 10:59:01 +08:00
d57c079a6c
MDL-53551 tool_lp: Can't have a read-only view of competency frameworks
2016-04-18 10:59:01 +08:00
9785dd8174
MDL-53452 tool_lp: Change update_course_competency_settings param to stdClass
...
Allows for future settings to be added without changing the function signature.
2016-04-18 10:59:00 +08:00
5cb320c10b
MDL-53452 competencies: Remove suggestion feature (except tests).
2016-04-18 10:58:59 +08:00
Ruslan Kabalin