Commit Graph

111 Commits

Author SHA1 Message Date
Tim Hunt 00102dba3e MDL-48146 quiz settings: fix non-percent feedback boundaries 2014-11-12 15:47:07 +00:00
Tim Hunt a733c2ce43 MDL-37998 quiz settings: disableif rules should account for overrides.
Some form fields are disabled if only one attempt is allowed. However,
there may be an override allowing some students more attempts. We need
to account for that possiblity when setting up the disabled if rules.

Note the disabledIf is good for usability on this complex form, which is
why I don't just want to get rid of them.
2014-09-22 16:24:51 +01:00
Tim Hunt 9ec7a71661 MDL-45273 remove the need for quiz settings.php to include locallib.php. 2014-04-29 11:16:44 +01:00
Tim Hunt 4dc30936f7 MDL-44811 quiz settings form title: change for consistency.
Thanks to Fred for poining out that most other activities use the work
Appearance for these sorts of settings.
2014-03-28 18:02:02 +00:00
Dan Poltawski a59b2e18d8 Merge branch '44180-27' of git://github.com/samhemelryk/moodle 2014-03-05 12:47:17 +08:00
Sam Hemelryk 01773a6d00 MDL-44180 mod_quiz: unified @package use 2014-03-03 08:37:06 +13:00
Tim Hunt 73465743f9 MDL-44278 Quiz time overrides: use the same step everywhere.
On the main form, you could select to the nearest minute. On
the override form you could only select to the nearest 5 minutes.
2014-02-28 08:58:58 +01:00
Tim Hunt c590848158 MDL-42880 quiz settings: remove unnecessary disabledif rules.
These rules were causing problems in the case where the form was
sumitted with validation errors. In that case, the During the attempt ->
The attempt checkbox was becoming unset, and hence the other During the
attmept checkboxes became disabled, and the values were not saved.

Thanks to Sam Marshall for suggesting this fix.
2013-11-15 15:09:25 +00:00
Damyon Wiese 0c0dfa8fbd MDL-40668 tinymce: Remove collapsable editor options
We have an alternative (pdw toolbars)
Also, allow tinymce to be collapsed down to a single row.
2013-08-13 10:54:36 +08:00
Dan Poltawski 2504dfd61d Merge branch 'MDL-39155' of https://github.com/jacks92/moodle 2013-06-11 15:38:37 +08:00
Jayesh Anandani 1ecd3c304d MDL-39155 Quiz: Provide 3 image-size options on the settings page 2013-05-10 08:38:13 +05:30
Dan Poltawski a74cd33160 MDL-39422 mod_forms: prevent long coruse module names
To prevent ugly DB errors.
2013-04-30 17:41:36 +01:00
Tim Hunt d823a63db0 MDL-39167 quiz access rules: need to validate their settings.
We were missing the hook in the form validation method. We had them
everywhere else they were needed.
2013-04-17 14:24:38 +01:00
Tim Hunt f9e5471273 MDL-38337 quiz: respect maximum grade config for new quizzes. 2013-03-08 21:36:27 +00:00
Tim Hunt e58b2c326b MDL-38093 quiz settings: make overall feeback editors collapsible. 2013-02-18 18:13:51 +00:00
Thanh Le d18f78b046 MDL-35794 quiz: config for whether Outcomes are advanced settings 2012-12-22 17:38:45 +00:00
Joseph Rezeau 26efb4888f MDL-37114 quiz form validation: feedback boundaries.
The feedback boundaries must either be a number or a percentage.
We were not correctly validating the non-percentage case.
2012-12-15 10:44:51 +00:00
Petr Škoda f387bb9bb7 MDL-34741 use 2in3 in mod_quiz 2012-08-11 20:40:09 +02:00
Rajesh Taneja 61cca0b7fc MDL-32940 libraries: Replaced deprecated PARAM_NUMBER with PARAM_FLOAT 2012-07-23 17:21:05 +08:00
Dan Poltawski 203d255116 Merge branch 'MDL-33393' of git://github.com/timhunt/moodle
Conflicts:
	mod/quiz/lang/en/quiz.php
2012-06-12 17:00:09 +08:00
Tim Hunt a6866c7e9f MDL-32783 quiz overdue handling: enforce end of grace period
The summary page was not enforcing the end of the grace period. If the
user had the summary page open, then they coudl still stubmit after the
end of the grace period.

Also, the editing form was not validating that the quiz grace period was
greater than quiz|graceperiodmin in the quiz configuration, and that
should be checked, so I added it.

I fear that processattempt.php is becoming very spaghetti-like with all
the timing rules, it really needs to be refactored, but not 2 weeks
before the 2.3 release. (When refactoring, we really need unit tests for
this.)
2012-06-07 19:17:07 +01:00
Tim Hunt d9552ab44f MDL-33393 quiz overdue handling: improve strings and add help 2012-06-07 17:33:46 +01:00
Tim Hunt 9e83f3d11d MDL-32788 quiz: clean up codechecker issues before the 2.3 release. 2012-05-04 15:12:23 +01:00
Dan Poltawski fdf26a0ec0 MDL-3030 mod_quiz: fix training whitespace 2012-04-30 11:05:29 +08:00
Tim Hunt 87427d9c7c MDL-3030 quiz overdue handling: new settings on quiz form and admin. 2012-04-27 15:07:23 +01:00
Tim Hunt 84da4788fd MDL-3030 quiz settings: reorganise form before adding new fields. 2012-04-27 15:07:22 +01:00
Tim Hunt ce74dcc3b6 MDL-32299 quiz mod_form: help icons for the review options 2012-04-05 16:25:32 +01:00
Sam Hemelryk ef844d0a15 Merge branch 'w12_MDL-32094_m23_phpstrict' of git://github.com/skodak/moodle 2012-03-20 16:47:17 +13:00
Petr Skoda fabbf4398b MDL-32094 some nasty quickforms hacks that should help with E_STRICT
Note: we have stopped tracking our QuickForms hacks long ago.
2012-03-18 18:39:37 +01:00
Charles Fulton 33c8d37b6f MDL-11047 quiz: enable sequential navigation 2012-03-15 10:09:27 -07:00
Glenn Ansley 7493a4bb3b MDL-31448 Replaced incorrect PHP comment 2012-01-31 14:39:23 -05:00
Tim Hunt 4344c5d5d9 MDL-29627 quiz old popup int column => new browsersecurity column.
The new column store more meaningful string constants.
2011-10-13 11:13:18 +01:00
Tim Hunt 1d9e1a3c06 MDL-29627 refactor the way the rules are constructed from the quiz. 2011-10-13 11:13:14 +01:00
Tim Hunt c18ba64c3e MDL-29627 load the existing settings when the quiz settings are re-edited. 2011-10-13 11:13:08 +01:00
Tim Hunt b83c32d39f MDL-29627 quiz access plugins can add fields to mod_form and save the data. 2011-10-13 11:13:06 +01:00
Tim Hunt 71c4154a98 MDL-26567 no grade category option on the quiz settings form.
Also, refine the standard_grading_coursemodule_elements method to add a
help string.

AMOS BEGIN
 CPY [gradecategory,grades],[gradecategoryonmodform,grades]
AMOS END
2011-09-20 11:10:34 +01:00
Tim Hunt 81522abd63 MDL-28166 fix some more instances of my favourite becuase typo. 2011-07-06 14:19:25 +01:00
Tim Hunt aac80ff319 MDL-20636 fix most of the remaining codechecker issues in mod/quiz and lib/questionlib.php. 2011-05-13 00:33:44 +01:00
Tim Hunt bb28e3bc5e MDL-27408 Moved the question engine install/upgrade code into the proper place.
I have tested upgrade from the previous development version, and a clean install. Upgrade from 2.0 still needs more work.
2011-05-12 18:58:50 +01:00
Tim Hunt 25a03faaca MDL-20636 fix many code-checker issues in mod/quiz. 2011-05-12 00:30:25 +01:00
Tim Hunt d0e25622bd MDL-20636 Two gradeboundary 0%s on the quiz editing form. One shoudl be a HTML editor. #392
This was a weird variable aliasing issue.
2011-04-11 14:40:04 +01:00
Tim Hunt 06cd11a989 MDL-20636 Fix scope of quiz edit form data_preprocessing. 2011-03-28 11:40:15 +01:00
Tim Hunt c7df5006b9 MDL-20636 Add lots of missing public/protected/private. 2011-03-23 16:22:25 +00:00
Tim Hunt ff58648f8a MDL-20636 Fix problem editing truefalse questions. #298
Also, fix a notice on the quiz editing form.
2011-03-21 12:42:54 +00:00
Tim Hunt c5c16a2c81 MDL-26324 Existing overall feedback on non-graded quizzes prevents editing 2011-03-04 17:50:31 +00:00
Tim Hunt a17b297d60 MDL-20636 Add missing defined('MOODLE_INTERNAL') || die(); 2011-02-23 16:00:20 +00:00
Tim Hunt ba6438471b MDL-20636 Fix top of file boilerplate in mod/quiz. 2011-02-21 16:13:25 +00:00
Tim Hunt a13d4fbd20 MDL-20636 Fix lots of minor quiz editing glitches. 2011-02-11 17:36:30 +00:00
Tim Hunt 1493619923 MDL-20636 Review option defaults in the admin settings. 2011-02-10 18:35:42 +00:00
Tim Hunt 167f1562f8 MDL-20636 Merge and fix quiz unit tests. 2011-02-09 20:18:21 +00:00