Commit Graph

25 Commits

Author SHA1 Message Date
Mark Nielsen 39c01271f0 MDL-46051 mod_lti: Not enough data passed to lti_extend_lti_services 2014-08-19 17:08:59 +02:00
Frederic Massart 2d121036cc MDL-45463 mod_lti: Prevent XML entity injections from provider 2014-07-07 13:00:39 +01:00
Marina Glancy d5bc7b66e9 MDL-44403 events: MDL-44403 events: bug fix in legacy event data for unknown_service_api_called 2014-03-04 15:16:19 +08:00
Sam Hemelryk 2b17ec3d62 MDL-41178 mod_lti: unified @package use 2014-02-16 11:52:18 +13:00
Mark Nielsen 4d7a2c9e1c MDL-36224: Minor updates to LTI
* No debug display on service.php
* Send a 400 header on error
2013-11-08 14:35:31 +08:00
Chris Scribner 976b5bca31 MDL-36224: Add support for pluggable extensions to add new LTI services 2013-11-08 14:35:31 +08:00
Charles Severance ba0f89e168 MDL-40531 mod_lti: Various 1.1/1.1.1 fixes. 2013-10-19 02:57:12 +02:00
Adrian Greeve b97d94ffbb MDL-39962 - Events: Replace lefacy event lti_unknown_service_api call. 2013-09-24 10:08:28 +08:00
Mark Nielsen 135b624b0c MDL-40005: LTI module uses Apache specific function for retrieving request headers 2013-07-24 09:07:14 -07:00
Ankit Agarwal c288a3dbf8 MDL-34467 lti: Repalce all instances of get_context_instanc() with respective context_XXX::instance() 2012-07-27 13:27:13 +08:00
Eloy Lafuente (stronk7) 27e5ce8b9f Merge branch 'MDL-30328' of git://github.com/scriby/moodle 2011-11-21 02:22:40 +01:00
Chris Scribner 8f45215d1c MDL-20534 lti: B28 - Update attribution headers. 2011-11-17 16:29:50 -05:00
Charles Severance ddcfda87d6 MDL-20534
I ran the software through the certification and caught a few nits:

The error return is 'failure' not 'error'
The spec says that it needs to return 'failure' for out of range or non-numeric grades
The result score needs a language tag, hard-coded as 'en'
Setting a grade multiplied by 100 but reading the grade did not divide by 100
All those are now fixed with this patch as well as this bit of cruft:

I removed the "extension service url" as it is not implemented in service.php

Feel free to review and adjust - probably the one place you might want to refactor
is that I put code to catch out-of-range-and non-numeric in
lti_parse_grade_replace_message and threw an exception on error and then caught
it in service.php and sent back the 'failure' message. Feel free to refactor a
bit if you see this done in a cleaner manner.
2011-11-17 10:34:23 -05:00
Eloy Lafuente (stronk7) fabd4fcf53 MDL-20534 lti: A4, add some todos towards unified Oauth 2011-11-06 22:05:11 -05:00
Eloy Lafuente (stronk7) ea04a9f989 MDL-20534 lti: A3, coding style + some scope, constructors 2011-11-06 22:02:26 -05:00
Chris Scribner e27cb316aa MDL-20534 lti: A3, whitespace fixes (Changes by stronk7) 2011-11-06 22:00:40 -05:00
Chris Scribner 61eb12d4df MDL-20534 lti: A3, copyright and DOS lf fixed 2011-11-06 21:51:06 -05:00
Chris Scribner a0ba4ec675 Add unsupported service support. 2011-11-06 20:42:03 -05:00
Chris Scribner 020eea1be8 Updating web service verification method to work for LTI messages that don't send a source id.
Adding extension so other plugins can handle LTI web service calls.
2011-11-06 20:41:59 -05:00
Chris Scribner 60bd82f61d Tested grade reading and deleting. Fixed bugs. 2011-11-06 20:41:56 -05:00
Chris Scribner f4f711d79b Updating LTI submission viewer 2011-11-06 20:41:54 -05:00
Chris Scribner b69dc42951 Fixing a couple issues with grade receipt 2011-11-06 20:41:51 -05:00
Chris Scribner 996b0fd961 Updates to lti plugin & progress on instructor management of course tools. 2011-11-06 20:41:50 -05:00
Chris Scribner b9b2e7bbf8 Adding oauth body code (from Chuck), implemented outcome services (only replaceResult tested) 2011-11-06 20:41:49 -05:00
Chris Scribner 73300339b0 Renaming plugin to lti from blti 2011-11-06 20:41:46 -05:00