Commit Graph

97 Commits

Author SHA1 Message Date
Dan Marsden ca602b6beb MDL-31366 Feedback: decode htmlchars on output to excel 2014-07-11 13:28:59 +12:00
Andreas Grabs 34a46904c2 MDL-45592 mod_feedback - unwanted linebreak after import or duplicating a feedback 2014-05-29 17:16:10 +02:00
Mark Nelson f68fee244a MDL-42462 mod_feedback: added $OUTPUT to list of global variables used to avoid error 2014-04-09 15:37:21 +08:00
Michael Milette cba011942c MDL-42462 - Feedback - Fix for WCAG 2.0 issue with Informational and Error Content Displayed in red
1) The same code used in other Moodle forms is now used in Feedback to display the "There are required fields in this form marked (*/Required field)" message at the top of the screen and each of the asterisks next to required fields.

2) Feedback specific styles (missingrequire, feeback_required_mark), which were used to highlight required and error fields, have been eliminated. These colours are now controlled by the common Moodle styles (mform1, mform, fdescription, required, req and error) that are used throughout the rest of Moodle for a more uniform appearance.

3) Field level error reporting now displays a message instead of just highlighting the field in a similar way that other Moodle forms do.

Affected files:

- /mod/feedback/styles.css
- /mod/feedback/complete.php
- /mod/feedback/complete_guest.php
- /mod/feedback/edit.php
- /mod/feedback/print.php
- /mod/feedback/item/captcha/lib.php
- /mod/feedback/item/info/lib.php
- /mod/feedback/item/multichoice/lib.php
- /mod/feedback/item/multichoicerated/lib.php
- /mod/feedback/item/numeric/lib.php
- /mod/feedback/item/textarea/lib.php
- /mod/feedback/item/textfield/lib.php
- /mod/feedback/lang/en/feedback.php

Signed-off-by: Michael Milette <michael.milette@instruxmedia.com>
2014-04-03 09:25:37 -04:00
Marina Glancy 7480dbc5f2 Merge branch 'MDL-42505-Feedback-Inappropriate-use-of-fieldset-tags-around-cancel-button' of git://github.com/michael-milette/moodle 2014-02-11 14:13:39 +08:00
Michael Milette ca5849e5dc MDL-42505 - Feedback plugin: Inappropriate use of fieldset tags around form and cancel button
Changes:
* Removed the fieldset HTML tags around the Cancel button at the bottom of the form.
* Removed the fieldset HTML tags around the whole form.
* Added missing fieldset tags around groups of radio buttons and checkboxes.
* Removed unordered list wrapping dropdown lists.
* Removed duplicate label for dropdown lists.

Modified Files:
* mod/feedback/complete.php
* mod/feedback/complete_guest.php
* mod/feedback/item/multichoice/lib.php
* mod/feedback/item/multichoicerated/lib.php

Signed-off-by: Michael Milette <michael.milette@instruxmedia.com>
2014-01-28 09:43:56 -05:00
Tony Butler 802f85076a MDL-43632 mod_feedback: Use SSL for reCAPTCHA API request if Moodle is using it 2014-01-10 10:40:23 +00:00
Michael Milette a059b434f7 MDL-42310 feedback mod - Enable filtering of multichoice and multichoice rated controls
Conflicts:
	mod/feedback/item/multichoice/lib.php
	mod/feedback/item/multichoicerated/lib.php

Signed-off-by: Michael Milette <michael.milette@instruxmedia.com>
2014-01-03 10:24:49 +08:00
Andreas Grabs 73bbdce8c6 MDL-42521 mod_feedback - Feedback does not show line graphs in Clean theme 2013-11-03 19:11:27 +01:00
Andreas Grabs bb4191ff4d MDL-42210 mod_feedback - convert tabs to space 2013-10-20 10:22:56 +02:00
Michael Milette 690266bcf7 MDL-42210-Feedback-Input-Labels
Adds labels to the input fields in the Feedback module including: multichoice, multichoicerated, numeric, textarea and textfield.
2013-10-20 10:22:54 +02:00
Ankit Agarwal 0601e0eef6 MDL-40402 libraries: Replace get_system_context() with context_system::instance() in core 2013-07-04 15:41:06 +08:00
Frederic Massart 4a02b4312a MDL-39435 feedback: Fix missing calls to setType 2013-05-01 10:36:23 +08:00
Andreas Grabs 25d37fe24c MDL-37800 mod_feedback - item "information" does not appear correctly 2013-02-01 11:44:52 +01:00
Sam Hemelryk f44e7d0a77 Merge branch 'MDL-36357' of git://github.com/danpoltawski/moodle
Conflicts:
	user/view.php
2013-01-09 09:34:22 +13:00
Kevin Wiliarty a6a33636eb MDL-35221 mod_feedback: replace checkbox with advcheckbox for all requirable feedback question types 2012-11-29 11:30:19 -05:00
Dan Poltawski 0e35ba6ffc MDL-36357 cleanup - remove double semicolons 2012-11-15 09:51:26 +08:00
Andreas Grabs 9b90584f43 MDL-34952 - change get_info() to public access 2012-08-24 21:56:45 +02:00
Aparup Banerjee 0367f6b1aa Merge branch 'MDL-34564_accessibility' of git://github.com/rwijaya/moodle 2012-08-07 14:57:34 +08:00
Andreas Grabs 94848b0748 MDL-34658 - Saving failed because missing or false values 2012-08-03 12:01:45 +02:00
Rossiani Wijaya f203506463 MDL-34564 accessibility compliance for feedback module: Add forform input text and select tag 2012-08-03 11:53:55 +08:00
David Monllao 2c979976e1 MDL-34464 mod_feedback Replace all instances of get_context_instance() with respective context_XXXX class in mod/feedback 2012-07-27 09:13:57 +08:00
Andreas Grabs f65c82636a MDL-33932_master - added array_unique() 2012-06-25 21:45:33 +02:00
Sam Hemelryk 5f17311f52 MDL-27675 mod_feedback: Fixed up white space 2012-06-21 11:40:38 +12:00
Sam Hemelryk d2448b8bd2 Merge branch 'MDL-27675_master' of git://github.com/grabs/moodle 2012-06-21 11:25:07 +12:00
Andreas Grabs e7fc2ff42e MDL-27675 - Feedback module abuses data_submitted 2012-06-06 23:17:35 +02:00
Sam Hemelryk 378eb6f6a2 Revert "Merge branch 'MDL-27675_master_wip' of git://github.com/grabs/moodle"
This reverts commit a09a9be812, reversing
changes made to 08e0aaa173.
2012-05-30 16:34:11 +12:00
Sam Hemelryk 064cac7866 MDL-27675 mod_feedback: Tidy up of phpdocs and scope within feedback mod 2012-05-28 13:38:36 +12:00
Andreas Grabs 9a2c4dbd00 MDL-27675 - Feedback module abuses data_submitted 2012-05-28 00:40:04 +02:00
Petr Skoda 411fd747cf MDL-32735 fix multiple E_STRICT feedback issues 2012-05-06 12:02:54 +02:00
Andreas Grabs bf4fb3b317 MDL-32316 feedback: fix tem type label does honor trusted text 2012-04-10 00:26:08 +02:00
Andrew Robert Nicols 536328fb0a MDL-32065 Allow feedback images to be themed 2012-03-15 11:48:21 +00:00
Andreas Grabs 9c5bc7a580 MDL-29804 - Clean up Feedback modules coding style 2011-10-28 00:30:42 +02:00
Andreas Grabs 7b1126fd20 MDL-19488 - allow the creation of a "Public" feedback 2011-10-13 11:10:15 +02:00
Andreas Grabs af26e3453a MDL-29621 - XHTML not welformed when creating Feedback questions 2011-10-03 18:40:16 +02:00
Aparup Banerjee 7eae2c5ae2 Merge branch MDL-29187-master of git://github.com/samhemelryk/moodle
- resolved conflict.
2011-09-13 13:52:31 +08:00
Sam Hemelryk 63390481c4 MDL-29187 multilang Reviewed the uses of category name and ensured things are being formatted correctly 2011-09-08 09:37:07 +12:00
Sam Hemelryk 8ebbb06adf MDL-29189 mutlilang Reviewed the uses of course shortname and ensured things are being formatted consistently 2011-09-08 09:30:27 +12:00
Rajesh Taneja e9de1cf49c MDL-27896 context - Fixed editor context to observe filter status 2011-08-12 11:33:21 +08:00
Andreas Grabs b7030c3def MDL-28014 - unpropitious use of bcmod() 2011-06-23 21:22:38 +02:00
Andreas Grabs 439ae873af MDL-27422 The excel export fails in some conditions. 2011-05-09 17:27:06 +08:00
Sam Hemelryk 912d099cc9 Merge branch 'MDL-25637' 2011-01-24 16:20:51 +08:00
Sam Hemelryk 80c1289773 MDL-25637 Fixed whitespace 2011-01-24 16:20:30 +08:00
Aparup Banerjee 2b9ce62e23 performance MDL-25637 converted tabs to spaces 2011-01-24 15:49:18 +08:00
Aparup Banerjee b692e4aa29 Performance MDL-25637 moved static count/sizeof functions out of for loop conditions 2011-01-24 14:51:21 +08:00
Aparup Banerjee f179cdb73e performance MDL-25637 some of more similar performance tweaks to come 2011-01-24 14:51:21 +08:00
Petr Skoda 99d19c13ae MDL-25855 some more missing filelib includes 2011-01-23 18:34:41 +01:00
Sam Hemelryk 367a75fae4 themes lib MDL-24895 Multiple fixes to better handle overflow.
Major tasks undertaken in this patch:
* New format_text argument, overflowdiv.
* New page layout Report.
* Review of all format_text calls.
* Added support for the report layout to all themes.
* Changed forum post display from tables to divs.
2010-11-05 02:53:47 +00:00
Andreas Grabs bf1b9ef70b MDL-24357 - Information on Course in Feedback Module Prints Incorrectly in Show Responses Tab 2010-09-23 22:24:18 +00:00
Petr Skoda 39790bd805 MDL-24321 switching to stdClass in /mod/ 2010-09-21 08:37:36 +00:00