Commit Graph

178 Commits

Author SHA1 Message Date
Mark Nelson 5869dbfc4c MDL-40285 mod_assign: added extra group submissions behat scenario
Thanks a lot to Jody Steele for providing the basis for the scenario.
2015-01-27 00:35:14 -08:00
Eloy Lafuente (stronk7) e048e9f1ab Merge branch 'M27_MDL-48574_workflow_state_updated_batch_single' of https://github.com/Dave-B/moodle into MOODLE_27_STABLE 2015-01-14 00:14:57 +01:00
David Balch e119e084ec MDL-48574 assign: Test workflow_state_updated fired on batch and single. 2015-01-09 16:48:01 +00:00
Mark Nelson 91484edf1b MDL-46498 mod_assign: fixed failing behat test due to GS 2015-01-07 13:30:20 +08:00
Mark Nelson 7eeca30cef MDL-46498 mod_assign: added behat tests 2014-12-26 17:51:10 -08:00
Dan Poltawski 534fae49b1 Merge branch 'MDL-46442-27' of git://github.com/zbdd/moodle into MOODLE_27_STABLE 2014-12-16 13:54:15 +00:00
Zachary Durber 6edc717d0d MDL-47694 mod_assign: Grades require a grade to show as graded
Special thanks to Howard Miller.
2014-12-16 11:20:26 +01:00
Dan Poltawski 4d76973693 Merge branch 'MDL-38128_27' of https://github.com/dmonllao/moodle into MOODLE_27_STABLE 2014-12-15 16:10:20 +00:00
Dan Poltawski c363aaee5d Merge branch 'MDL-45324_27' of git://github.com/jonof/moodle into MOODLE_27_STABLE 2014-12-15 14:59:39 +00:00
David Monllao bc4a8d86f3 MDL-38128 mod_assign: Counts and groups unit tests 2014-12-12 14:04:30 +08:00
Zachary Durber b43cd17b0d MDL-46442 mod_assign: Notify users when grades are changed 2014-12-11 13:27:43 +08:00
Jonathon Fowler 7b9a54432a MDL-45324 assign: notify when workflow is Off, or if state is Released
When marking workflow is enabled, students will be notified only when
the workflow state transitions to 'Released'. Until that happens,
sending of messages will be held and the 'Notify students' grading
form option will be locked.

Additionally, the batch set marking workflow state facility gains
the 'Notify students' option.

Credit to Steve Upton and David Balch for the basis of this patch.
2014-12-10 22:28:07 +10:00
Matt Petro ad2cacf152 MDL-48235 mod_assign: Fix reopen until pass behavior 2014-12-09 10:53:01 -05:00
Damyon Wiese 6bee9ff6ab MDL-47975 assign: Stop gap fix for random time fails. 2014-10-31 13:01:53 +08:00
Damyon Wiese eceb11d200 MDL-47815 assign: Fix random unit test fails
This test was failing when it was run really slowly (looking at you oracle).
2014-10-22 17:01:53 +08:00
Marina Glancy 12a88823f0 MDL-47187 assign: fixed timing unittest failure 2014-09-10 11:57:02 +08:00
Damyon Wiese 4939d0d71a MDL-46485 Assign: New unit test to show error with group submission 2014-07-25 15:20:36 +08:00
Dan Poltawski a7e348e937 Merge branch 'MDL-37509-27' of git://github.com/damyon/moodle into MOODLE_27_STABLE 2014-07-22 15:56:58 +01:00
Damyon Wiese 05cc5bf052 MDL-37509 Assign: Do not put description in calendar before it should be shown to students 2014-07-21 15:58:08 +08:00
Damien Bezborodov d8b6437fa9 MDL-42179 mod_assign: Time remaining issue for group assignment 2014-07-14 13:52:41 +09:30
Damyon Wiese 99e0bb23bf MDL-46044 Assign: Move common setup to setUp method (share it for all of lib_test.php) 2014-06-27 14:18:10 +08:00
Damyon Wiese 53fb01aef0 MDL-46044 Assign: Update unit test to test multiple attempts on overview page 2014-06-27 14:17:44 +08:00
Eloy Lafuente (stronk7) d81917322f Merge branch 'MDL-45870-27' of git://github.com/FMCorz/moodle into MOODLE_27_STABLE 2014-06-17 00:51:33 +02:00
Jonathon Fowler 5807b224d9 MDL-42531 assign: refactor batch operations to use forms properly
Avoids a lot of ugly optional_param() use. Also fixes the
non-functional cancel buttons.
2014-06-16 16:43:54 +08:00
Frederic Massart 0085d95576 MDL-45870 mod_assign: Behat test covering some outcome usage 2014-06-11 10:34:44 +08:00
David Monllao e0cd7e44db MDL-45192 behat: Replacing specific-selector steps by a generic one
Having a I click on we can use all our selectors rather
than having multiple steps for the same purpose. This
step allow us to manage JS native dialogues without
having to fail a scenario.

Credit for Mohamed Alsharaf.
2014-05-26 13:57:23 +12:00
Mohamed Alsharaf 184cdf0d52 MDL-45192 assign: added behat script & new definitions to handle alert dialog
The behat script is to test the batch action to lock and unlock submissions.
The new definitions are to prevent the "unexpected alert open" error in Selenium.
2014-05-26 13:57:18 +12:00
John Okely 6d90ef2b4a MDL-45296 mod_assign: Revert changes to lock_submission and unlock_submission events 2014-05-09 09:58:55 +08:00
Eloy Lafuente (stronk7) 2fe085b284 MDL-45296 tests: ensure all submissions exist
The changes performed with the change from
create_from_user() to create_from_submission()
in practice enforce a new restriction about
submissions having to exist in order to fire
their lock/unlock events.

This did not exist before the change and, also,
it seems that the assign api itself, submission->lock() ...
also accepts non existing submissions.

So I was not 100% sure about how to fix these events:

1) enforcing submission to exist.
2) firing them only if the submission exist.

I've gone with 1) for now, making tests to pass. But will
raise the question in the Tracker, just in case we have
to move to the 2) approach for any reason.
2014-05-08 20:03:34 +02:00
Damyon Wiese 0cd720fe51 MDL-44606 assign: disable sesskey protection for unit test. 2014-05-07 14:06:08 +08:00
Marina Glancy 3f0a5f287a Merge branch 'MDL-45257-master-2nd' of git://github.com/FMCorz/moodle 2014-04-30 10:05:11 +08:00
David Monllao d2e6b3b26b MDL-44614 behat: Added missing @_file_upload 2014-04-29 09:55:47 +07:00
Frederic Massart abf3a51e29 MDL-45257 mod_assign: Removing wonky feedback_updated event 2014-04-28 15:13:55 +08:00
Marina Glancy f6db769eb2 Merge branch 'MDL-44614_master' of git://github.com/dmonllao/moodle 2014-04-28 13:03:39 +08:00
David Monllao 23102c3e2e MDL-44614 behat: Automate MDLQA-61
In an Offline activity assignment, a teacher can
grade and give comments on an assignment completed
offline.
2014-04-28 10:01:01 +07:00
David Monllao 6f9f05a06e MDL-44614 behat: Automate MDLQA-60
A teacher can provide feedback
comments and files for an assignment.
2014-04-28 10:00:41 +07:00
David Monllao 2353a68fa8 MDL-45164 behat: Add a wait to avoid random failures
It may fail in fast systems as the JS animation
to remove the delete comment may be slower than
the following steps where we check that the element
is not there anymore.
2014-04-27 07:44:15 +07:00
Marina Glancy 0b10dfce9d Merge branch 'w16_MDL-41101_m27_assign' of git://github.com/skodak/moodle 2014-04-17 11:20:51 +08:00
Marina Glancy c5b027629f Merge branch 'MDL-44617_master' of git://github.com/dmonllao/moodle 2014-04-17 11:03:25 +08:00
Damyon Wiese 7c9b2aafeb MDL-35373 mod_assign: Add a behat test for word count limit. 2014-04-17 10:27:07 +08:00
Petr Škoda bf5b441327 MDL-41101 move assign property to the assign event base class 2014-04-17 09:51:13 +08:00
Mark Nelson b7656ff069 MDL-41101 mod_assign: replaced 'save grading feedback' add_to_log call with an event 2014-04-17 09:51:11 +08:00
Mark Nelson 9147c4e07f MDL-41101 mod_assign: replaced 'grade submission' add_to_log call with an event 2014-04-17 09:51:11 +08:00
Mark Nelson 81f92c220b MDL-41101 mod_assign: replaced 'view batch set marker allocation' add_to_log call with an event 2014-04-17 09:51:11 +08:00
Mark Nelson eef4d5946a MDL-41101 mod_assign: replaced 'view batch set marking workflow state' add_to_log call with an event 2014-04-17 09:51:11 +08:00
Mark Nelson cf2d7bfb49 MDL-41101 mod_assign: replaced 'view' add_to_log call for the submission status page with an event 2014-04-17 09:51:10 +08:00
Mark Nelson 47349e4eb0 MDL-41101 mod_assign: replaced 'view confirm submit assignment form' add_to_log call with an event 2014-04-17 09:51:10 +08:00
Mark Nelson c24aaa389a MDL-41101 mod_assign: replaced 'submission statement accepted' add_to_log call with an event 2014-04-17 09:51:10 +08:00
Mark Nelson b06decdd59 MDL-41101 mod_assign: replaced 'view' add_to_log call for the reveal identities confirmation page with an event 2014-04-17 09:51:09 +08:00
Mark Nelson e65221c27b MDL-41101 mod_assign: replaced 'view submit assignment form' add_to_log call with an event 2014-04-17 09:51:09 +08:00