Commit Graph

66 Commits

Author SHA1 Message Date
Eric Merrill ab391cddf0 MDL-48655 gradebook: Don't treat a scale with a gradepass of 0 as passed 2014-12-18 16:18:40 -05:00
Damyon Wiese 78c55e13a2 MDL-46997 Grades: Fix aggregation when hiding is excluded and items have nested dependencies
Includes a unit test for the dependency flattening function.
2014-09-09 14:02:13 +08:00
Damyon Wiese 5e33ee65e5 MDL-35984 grade: Recalculate min/max for sum of grades when hidden grades are involved. 2014-08-11 14:22:27 +08:00
sam marshall e01efa2cfd MDL-44070 Conditional availability enhancements (3): conditions
Includes all the conditions that were in previous Moodle versions:

* Date
* Grade
* Completion (of another activity)
* User profile field

Also includes conditions that are used to reimplement
groupmembersonly:

* Grouping
* Group

For each condition, the component plus unit tests are included.

PLEASE NOTE: The code to actually check each condition is reused
from previous Moodle versions and has not been modified except to
pass codechecker. This is intentional, to reduce the risk of the
change and maximise the chance that behaviour is preserved. Some
of this code might not be very good and might need updating but
that can happen separately.

AMOS BEGIN
 CPY [contains,core_condition],[op_contains,availability_profile]
 CPY [doesnotcontain,core_condition],[op_doesnotcontain,availability_profile]
 CPY [endswith,core_condition],[op_endswith,availability_profile]
 CPY [isempty,core_condition],[op_isempty,availability_profile]
 CPY [isequalto,core_condition],[op_isequalto,availability_profile]
 CPY [isnotempty,core_condition],[op_isnotempty,availability_profile]
 CPY [startswith,core_condition],[op_startswith,availability_profile]
 CPY [completion_fail,core_condition],[option_fail,availability_completion]
 CPY [completion_pass,core_condition],[option_pass,availability_completion]
 CPY [completion_complete,core_condition],[option_complete,availability_completion]
 CPY [completion_incomplete,core_condition],[option_incomplete,availability_completion]
AMOS END
2014-04-07 20:11:37 +01:00
sam marshall ddf368a213 MDL-44141 Completion: System updates data during restore
The completion system has code which is supposed to prevent it
updating completion status while grades are being restored. This
code was a nasty hack and had not worked for some time. As a result
completion dates were restored incorrectly.

This commit implements a 'proper' way to find out if a restore is
currently running, replacing the previous hack.
2014-03-18 13:31:34 +00:00
Marina Glancy 9b5e2461d5 MDL-28463 grades: use get_course() method 2013-10-29 11:33:55 +11:00
Marina Glancy b85b9b7c29 MDL-28463 grades: inform conditionlib that grades changed 2013-10-29 11:33:21 +11:00
Petr Skoda f20edd5208 MDL-32094 fix various E_STRICT compatibility problems 2012-03-18 18:37:24 +01:00
Andrew Davis a153c9f2fe MDL-30999 grade: updated Grade API phpdocs 2012-02-14 14:04:19 +07:00
sam marshall ad275cb4ad MDL-28643 Fix debugging message when deleting activity with grade completion 2011-08-10 11:02:56 +01:00
Eloy Lafuente (stronk7) 1b42e67747 MDL-25708 recordsets - fix lib/grade/xxx stuff 2011-01-25 19:59:00 +01:00
Petr Skoda 22a9b6d873 fixed phpdocs and marked methods as static 2010-09-18 10:43:50 +00:00
Petr Skoda 7ad5a62727 MDL-21249 improved php docs and adding direct access prevention in editors 2010-07-25 13:56:54 +00:00
Petr Skoda f7d515b6d3 fixed silly comment typos 2010-05-21 18:57:05 +00:00
Andrew Davis 61541a5a46 gradebook MDL-21218 Improved the hiding/displaying of category and course totals when they contain hidden items 2010-02-08 06:27:04 +00:00
Petr Skoda 4a0e2e632f MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 11:42:23 +00:00
Sam Hemelryk 26f0525fa5 NOBUG: Testing CVS mailout for Jordan 2009-10-30 06:31:17 +00:00
skodak a9e38ac8a7 MDL-19008 extra credis should not be dropped when drop low or keep high specified (including unit tests) 2009-04-29 13:42:03 +00:00
nicolasconnault 653a86489e MDL-18083 Committing gradebook improvements to head 2009-04-16 07:16:44 +00:00
skodak cb551e3625 MDL-18550 fixed DML typo and bad coding style - yes sam, whitespace is part of the official coding style! thanks nigel daley for spotting of the typo 2009-03-15 13:29:40 +00:00
sam_marshall 82bd6a5ea9 MDL-15499: Conditional availability of activities 2008-12-17 16:37:35 +00:00
sam_marshall 49f6e5f476 MDL-15498: Fixes to problems Petr identified with completion system checkin 2008-07-28 15:58:50 +00:00
sam_marshall 4e781c7b50 MDL-15498: Completion system 2008-07-28 12:31:29 +00:00
skodak 9718765e92 MDL-14679 finished gradelib conversion 2008-05-30 17:43:00 +00:00
nicolasconnault 5b0af8c5e3 MDL-14967 More upgrades 2008-05-26 05:06:01 +00:00
nicolasconnault da3801e84b MDL-14967 Upgraded gradebook code and unit tests. 4 failing tests in grade_item to fix. 2008-05-23 14:52:50 +00:00
dongsheng 2f137aa130 "MDL-14129, fix print_error" 2008-05-20 02:53:46 +00:00
dongsheng 5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
skodak c55c9d73df MDL-13899 feedback itself is a type of grading - date graded is now affected by feedback too; merged from MOODLE_19_STABLE 2008-03-18 23:21:23 +00:00
skodak cf12f6c5a9 MDL-13899 feedback itself is a type of grading - date graded is now affected by feedback too; merged from MOODLE_19_STABLE 2008-03-18 22:54:56 +00:00
skodak 25bcd90821 MDL-13845 rewritten rounding in grades classes again - rounding done also before storage into db so that we can compare the values properly and skip db updates if possible + some more optimisations; merged from MOODLE_19_STABLE 2008-03-12 19:45:17 +00:00
nicolasconnault e64779883b MDL-12356 Patched grade_grade->is_passed() method so that it returns null when the gradepass value is null or equal to grademin, or when the finalgrade is null. Merging from MOODLE_19_STABLE 2008-03-07 14:09:43 +00:00
nicolasconnault 43ea3f3ca6 MDL-12182 Fixing unit tests for gradebook. Mainly a change in set_locked() arguments. Merging from MOODLE_19_STABLE 2008-03-06 13:51:55 +00:00
skodak 2e0d37fe41 MDL-12942 extra credit implemented in sum aggregation type; fixed sum aggregation; fixed division by zero in item grade min==max; merged from MOODLE_19_STABLE 2008-02-18 19:10:44 +00:00
nicolasconnault 66b61ac680 MDL-12356 CSS classes implemented 2007-11-28 05:16:09 +00:00
nicolasconnault f3ac8eb40c MDL-12182 Reverting to pre-upgrade in order to prepare a patch instead 2007-11-22 05:42:46 +00:00
nicolasconnault dea2f0d945 MDL-12182 Only testgradeitem.php isn't yet completed. 2007-11-15 06:44:26 +00:00
nicolasconnault b7cf8eac52 Fixing a few bugs identified by Petr and attacking grade_item unit tests 2007-11-13 19:12:37 +00:00
nicolasconnault 9a68cffcbb Restoring some of the static calls which were converted unnecessarily 2007-11-13 13:44:27 +00:00
nicolasconnault aaefeda438 More fine-tuning of gradebook classes 2007-11-13 10:31:08 +00:00
nicolasconnault 4fc9ec1ec0 Managed to remove static calls from the core gradebook classes without removing support for such calls in gradebook interface code. I used a singleton pattern for this (get_instance in grade_object). 2007-11-13 07:36:00 +00:00
nicolasconnault 1f0e492171 Unit test refactoring using mock objects. NOT FINISHED: testgradecategory and testgradeitem are incomplete. The other tests work great however, and no longer a need for DB data 2007-11-07 17:59:33 +00:00
skodak ced5ee5921 MDL-11966 implemented dategraded and datesubmitted, tweaked altering of grades depending in hidden grades
MDL-11974 improved gradebook CSS
2007-11-01 08:25:05 +00:00
skodak 597f50e616 MDL-11973 Improved showing of hidden items in ouuser and user report 2007-10-30 21:25:50 +00:00
skodak 0f392ff4f0 MDL-11957 improving and cleanup in grade overriding 2007-10-30 11:40:50 +00:00
nicolasconnault 1994d890c9 Fixing unit test failures 2007-10-27 10:13:25 +00:00
skodak 4c8893ed88 MDL-11718 fixed altered aggregation of overridden and locked grades + some speedup and corrections 2007-10-21 13:22:07 +00:00
skodak 78358cd6a1 MDL-11718 fixed incorrect bounds when altering aggregates for hidden grades 2007-10-20 15:48:46 +00:00
skodak 89a5f82768 MDL-11278 improved forced category settings - refactoring + regrading forced + new setting to hide forced settings in UI 2007-10-20 15:00:31 +00:00
skodak d297269d79 2007-10-19 08:51:52 +00:00