73841c3908
MDL-48914 admin: check maxuserperpage in existingroleholders->find_users
2015-01-23 16:01:46 +00:00
f051bed3bc
MDL-48532 core_roles: Set correct heading on user roles page
2014-12-09 14:21:08 +13:00
25a487b90a
MDL-47426 assign local roles: rewrite query for better performance.
...
This is an extremely dangerous query, because it includes the user
table twice, along-side two other potentially large tables,
role_assignments and user_enrolments.
The solution is to rewrite the query so that:
1. The subquery is JOINed, not WHERE ... INed. Typically query
optimisers handle the JOIN case better.
2. Before the join was role-assignments <-> users <-> subquery.
That is, everything was linked to u.id.
Now the linking is role-assignments <-> subquery <-> users,
so the SELECT DISTINT eu1_u.id FROM {enrolled users} is central.
That seems to send a strong hint to the query optimiser about
a good order to execute the query.
2014-10-02 17:10:57 +01:00
37e7d91b8c
Merge branch 'MDL-45596-27' of git://github.com/FMCorz/moodle into MOODLE_27_STABLE
2014-07-08 10:50:55 +01:00
d019ffd21f
MDL-45596 roles: Escape filter value before using it in form field
2014-07-04 11:49:42 +08:00
5eb386fd09
MDL-45833 event: Removing courseid as the context is higher than course context
2014-06-27 11:25:07 +08:00
db77228155
MDL-45623: Fix assigned users count on role delete confirmation page
2014-05-26 10:00:51 +12:00
79b146cb5c
MDL-44323 admin: use correct css class for warning
...
The notifyproblem notification is consistent with the rest of
the warnings we report.
Conflicts:
theme/bootstrapbase/style/moodle.css
2014-05-20 15:48:48 +12:00
b6df9f8f55
Merge branch 'wip-mdl-42560' of git://github.com/rajeshtaneja/moodle
2013-10-29 13:09:23 +08:00
045d913d11
MDL-42560 Events: Removed use of role->name
...
role->name is usually empty or localized, so should not be used in events
2013-10-28 11:06:47 +08:00
d5814f4e22
MDL-41811 simplify the admin tree detection logic and fix navigation in multiple areas
2013-10-21 14:17:55 +08:00
b92adf24a4
MDL-41811 navigation: Fixed navigation issues on pages
...
Few admin pages don't add navigation node and hence they should
not show site admin
2013-10-21 14:17:54 +08:00
e9091a28f5
Merge branch 'wip-MDL-42089-master' of git://github.com/abgreeve/moodle
2013-10-09 10:54:24 +08:00
5dc361e16e
MDL-31830 core_course: new course category management interface
...
* Implemented a new course and category management page.
* Deprecated the old management interface.
* Unit tests to cover the new API and core functions.
* Behat tests to cover the new interface.
2013-10-07 10:21:41 +13:00
4d83abd052
MDL-42089 - Administration: Update to sql to include alternate name fields.
2013-10-03 10:34:07 +08:00
0aa535bf1d
MDL-20045 add support for custom context levels
2013-08-31 11:47:44 +02:00
74df2951d1
Revert "MDL-39876 Change get_record('course') calls to get_course"
...
This reverts commit ab7632b74c
2013-08-21 13:42:30 +08:00
ab7632b74c
MDL-39876 Change get_record('course') calls to get_course
2013-08-15 11:31:20 +01:00
35e4eb42c0
MDL-40044 Roles: Updated role_assigned and role_unassigned event to remove add_to_log
2013-08-09 18:02:02 +08:00
1613ffa55f
MDL-40044 Roles: Added role_allow_*_updated events to replace add_to_log on role allow page
...
Added events:
1. role_allow_assign_updated
2. role_allow_override_updated
3. role_allow_switch_updated
2013-08-09 17:59:54 +08:00
82ddcad0a3
MDL-40044 Roles: Added role_capabilites_updated event and replaced related add_to_log
2013-08-09 17:59:54 +08:00
a7524e354b
MDL-40044 Roles: Added role_deleted event and replaced related add_to_log
2013-08-09 17:59:54 +08:00
2f1e464a88
MDL-40438 migrate all collatorlib:: and textlib:: uses
2013-08-06 21:04:35 +02:00
a439b2f9b4
MDL-40465 libraries: Deprecate fetch_context_capabilities()
2013-07-11 14:33:25 +08:00
6c89d4e1c0
MDL-40431 libraries: deprecated get_context_url()
2013-07-11 13:23:45 +08:00
329846f198
MDL-40430 - Libraries: Deprecate print_context_name().
2013-07-09 16:11:55 +08:00
7f5b51c4e6
MDL-40404 Libraries: Deprecated get_parent_contextid()
2013-07-09 14:33:21 +08:00
1415127ebc
MDL-40337 fix some more deprecated calls in role code
2013-06-27 22:41:14 +02:00
5089cca0b4
MDL-40337 use full frankenstyle in get_string() calls
2013-06-27 22:17:46 +02:00
07364397cd
MDL-40337 fix remaining code checker troubles in admin/roles/*
2013-06-27 22:17:45 +02:00
282ed3e5d9
MDL-40337 cleanup users roles code
2013-06-27 22:17:45 +02:00
72de139a6e
MDL-40337 cleanup role permissions code
2013-06-27 22:17:45 +02:00
d7797b7924
MDL-40337 cleanup role override code
2013-06-27 22:17:45 +02:00
06a0a2955e
MDL-40337 cleanup role manage UI
2013-06-27 22:17:45 +02:00
bb061951a0
MDL-40337 cleanup role definition code
2013-06-27 22:17:45 +02:00
aac13d6728
MDL-40337 cleanup role assign pages
2013-06-27 22:17:45 +02:00
67ab75e521
MDL-40337 cleanup role allow pages
2013-06-27 22:17:45 +02:00
d6c4544d63
MDL-40337 cleanup admin select UI
2013-06-27 22:17:44 +02:00
bc7b53fb49
MDL-40337 use class loader for admin/roles/*
2013-06-27 22:17:44 +02:00
4dd680c74e
MDL-17081 allow role reset to self
...
The use case is importing of incomplete XML preset - keep current + preset changes. This also discards any pending changes.
2013-06-25 15:15:46 +02:00
8c6b980803
MDL-17081 fix invalid role XML schema
2013-06-25 10:18:22 +02:00
fcd75b6e6d
MDL-17081 store also CAP_INHERIT in role export files
2013-06-25 00:24:55 +02:00
5e72efd498
MDL-17081 add role export/import
...
This includes improved role creation, allowed roles are editable and other improvements.
2013-06-24 12:40:59 +02:00
a5f82c5b21
MDL-38309 Substitute usage of print_tabs() with renderable tabtree
2013-04-15 12:13:13 +10:00
9a51c3d95c
MDL-36395: Converted hard-coded MAX_USER_PER_PAGE to config setting
...
course, cohort, enrol, role, groups and forum used to use hard-coded
MAX_USERS_PER_PAGE=100 for rendering user list. This has been converted
to $CFG->maxusersperpage.
2013-03-12 17:14:53 +08:00
502e785311
Merge branch 'w04_MDL-37638_m25_rolecloning' of git://github.com/skodak/moodle
2013-01-28 18:00:07 +13:00
682a1c0108
Merge branch 'w04_MDL-37728_m25_roledef' of git://github.com/skodak/moodle
2013-01-28 17:25:51 +13:00
ba4b17dc55
MDL-37728 show role risks
2013-01-27 14:55:06 +01:00
c7e2e4d5d1
MDL-37728 list only relevant capabilities when reviewing role permissions
2013-01-27 14:29:27 +01:00
3b00599bb6
MDL-37728 show allow matrix info in role overview
2013-01-27 14:14:32 +01:00
Rod Norfor