Commit Graph

380 Commits

Author SHA1 Message Date
Eric Merrill 7fc6677853 MDL-74299 question: Don't use a strict comparison for DB objects 2022-03-23 19:20:37 -04:00
Cameron Ball 83b7836068 MDL-54724 qtype_multianswer: Better handle corrupted questions
When questions are deleted, we now check if the parent is in use before deletion.

Prior to this, it would be possible for multianswer questions to reference
questions that have been deleted. This results in fatal errors when the quiz
is viewed.

This patch uses a dummy 'subquestion_replacement' to handle this case and
display some information to the end user about what has happened so that
they may take action to repair the corrupted question.

As a result of the bug described above, the sequence column of
mdl_question_multianswer can contiain references to questions that no
longer exist, and these IDs can make their way in to backups.

When this happens, the backups cannot be restored. To avoid this,
this patch skips trying to restore those questions that reference
question IDs that no longer exist (as there is no way to recover them).
2022-03-02 18:46:21 +08:00
Luca Bösch 003d17d98b MDL-60331 questions: prevent double escaping question categories. 2021-04-28 17:16:31 +02:00
Tim Hunt 5fbb14524d MDL-69077 questions: question tag capabilties are relevant 2020-06-17 13:06:57 +01:00
Martin Hanusch 08fe534986 MDL-63284 question: Moving questions with tags disabled bug fix 2020-05-29 16:42:04 +02:00
Adrian Greeve b2978c1787 Merge branch 'MDL-68757' of https://github.com/timhunt/moodle 2020-05-26 10:33:03 +08:00
Victor Deniz Falcon a735d4d1d4 Merge branch 'MDL-68252' of https://github.com/timhunt/moodle 2020-05-26 00:55:02 +01:00
Tim Hunt 4a45b7112c MDL-68757 questions: don't do output in low-level functions 2020-05-18 20:54:27 +01:00
Tim Hunt 1d47cb2168 MDL-68615 questions: fix fiendish default idnumber edge case 2020-05-05 16:19:54 +01:00
Tim Hunt fa7431ce50 MDL-68252 question tags: fix tag editing for missingtype questions 2020-04-24 11:26:12 +01:00
Tim Hunt 7459856d26 MDL-68300 questions: un-break duplicating questions without idnumbers
This was a regression caused by MDL-67934
2020-03-31 11:00:39 +01:00
Jake Dallimore 9b8fc9be6d Merge branch 'MDL-67934' of https://github.com/timhunt/moodle 2020-03-25 08:28:27 +08:00
Tim Hunt f2393804bf MDL-67934 questions: give a sensible default idnumber when duplicating 2020-03-12 18:07:11 +00:00
Tim Hunt 1b6b554118 MDL-67981 questions: avoid errors deleting contextless questions 2020-03-06 17:57:11 +00:00
Eloy Lafuente (stronk7) 2b97ab8adb Merge branch 'MDL-67947' of https://github.com/timhunt/moodle 2020-02-19 17:48:14 +01:00
Tim Hunt 887daf932c MDL-67947 questions: questions_in_use should ask all components
Previously it was only checking mods.
2020-02-19 11:55:04 +00:00
Sara Arjona 855d4db87a Merge branch 'bugfix-MDL-67142' of https://github.com/AngadSethi/moodle 2020-02-11 10:18:49 +01:00
Angad Sethi 86127e774f MDL-67142 quiz: fixed error when deleting saved questions long-name-quiz
An error was showing up while deleting questions
(in the question_save_from_deletion method) which had been saved
and which belonged to a quiz with a super long name, not exceeding 255
characters, as the 'name' field in 'question_categories' table had a
max size of 255 characters. The shorten_text function was used to
shorten the string to 255 characters and a unit test was added with
the name test_question_save_from_deletion_quiz_with_long_name to test
the patch.
2020-02-08 19:40:44 +05:30
Tim Hunt 1aacbb72d3 MDL-67832 quiz: fix lots of PHPdoc in attemptlib.php 2020-01-31 19:09:03 +00:00
Eloy Lafuente (stronk7) ee439d017e MDL-67115 core: php74 params order for implode()/join()
Passing parameters to implode() in reverse order is deprecated, use
implode($glue, $parts) instead of implode($parts, $glue).

This commit corresponds to phpunit and manual detections, core files.
2020-01-19 18:47:07 +01:00
Shamim Rezaie 35ca1475b5 MDL-67151 core_question: Support scientific format at question preview 2019-12-03 16:52:22 +11:00
Tim Hunt a3f42f998c MDL-66553 question bank: show idnumbers in category drop-down 2019-10-11 13:59:26 +01:00
Tim Hunt d30c6cdc17 MDL-66553 question bank: fix lots of phpdoc and other warnings 2019-10-09 13:26:12 +01:00
Jun Pataleta cbd8641a8a MDL-65994 question: Convert checkboxes to checkbox-toggleall element 2019-07-19 10:29:18 +08:00
Adrian Greeve eee677c024 Merge branch 'MDL-53140-master' of git://github.com/rezaies/moodle 2019-05-01 10:30:22 +08:00
Shamim Rezaie 197e074eba MDL-53140 question: Support localised floats when previewing a question 2019-05-01 12:10:32 +10:00
VinhLe 4ca60a5660 MDL-36088 questions: Add new events 2019-04-29 11:16:19 +07:00
Stephen Bourget 93e435b909 MDL-36088 questions: Add new events 2019-04-29 11:15:36 +07:00
Simey Lameze 9bec0e7e74 MDL-65207 core: replace typos by actually 2019-04-01 08:49:18 +08:00
Shamim Rezaie 8e93e515ed MDL-63809 question: handling bad questions in question_has_capability_on 2018-12-18 15:05:37 +11:00
Tim Hunt 616442a2fa MDL-63738 question bank: a link to download a single question 2018-10-29 10:38:24 +00:00
John Beedell 6189fda47f MDL-62708 question: Add idnumbers to question and question category 2018-09-21 12:26:24 +01:00
Andrew Nicols e36019c2f3 Merge branch 'wip-MDL-62742-master' of git://github.com/marinaglancy/moodle 2018-08-29 08:31:08 +08:00
Marina Glancy 442f12f81a MDL-62742 core: rename coursecat->core_course_category
Also rename course_in_list -> core_course_list_element
Deprecate class coursecat_sortable_records
2018-08-28 11:36:23 +02:00
John Beedell d0a60444a1 MDL-63165 Question: xml import of question categories 2018-08-24 15:20:18 +01:00
Shamim Rezaie 94fe904ed6 MDL-62897 Questions: Fix multi top cats in question_save_from_deletion 2018-07-23 14:37:40 +10:00
Andrew Nicols cc98914e85 MDL-61407 question: Allow formatters to ignore caps 2018-05-02 19:13:30 +08:00
Simey Lameze 02b1868c32 MDL-61364 core: fix cibot coding issues 2018-03-28 10:18:33 +08:00
Simey Lameze e7329cd026 MDL-61364 question: refactor question_has_capability_on 2018-03-27 16:14:44 +08:00
Eloy Lafuente (stronk7) 4dca6ab54d Merge branch 'MDL-61589-master' of git://github.com/rezaies/moodle 2018-03-21 00:21:24 +01:00
Eloy Lafuente (stronk7) 9a79102a4c Merge branch 'MDL-61410-master' of git://github.com/lameze/moodle 2018-03-20 23:53:28 +01:00
Shamim Rezaie ae9f5a04b1 MDL-61615 Questions: Only move question categories if there is any 2018-03-20 17:30:21 +11:00
Simey Lameze 6307622b28 MDL-61410 question: move tag sorting logic to a new function 2018-03-19 11:45:55 +08:00
Shamim Rezaie c185e4fe21 MDL-61589 Questions: Top question category naming improvement
Display the context name next to the top question category name.
2018-03-15 18:47:25 +11:00
Shamim Rezaie bd94e16e95 MDL-61615 Questions: Fix multiple top cats when deleting a course cat
Prevent having multiple top question categories when deleting a course category.
This commit also fix the problem of question files' contexts not being updated when moving them.
2018-03-13 18:31:01 +11:00
Ryan Wyllie 68beb75851 MDL-61363 question: update tags on question context change 2018-03-07 10:31:47 +08:00
Ryan Wyllie 081eb156c5 MDL-61363 question: add course context tagging 2018-03-07 10:31:47 +08:00
Simey Lameze 1451c07e05 MDL-61444 question: make question_has_capability_on support new caps 2018-02-19 14:21:49 +08:00
Shamim Rezaie 3b8f3198de MDL-61132 Quiz: "Random" question from "Top" categories
* Support for adding ranodm questions from "Top" categories
2018-02-05 11:58:57 +11:00
Shamim Rezaie bb06397130 MDL-61132 Questions: Add "Top" categories by default when don't exist
Create "Top" categories along with the default categories when they don't exist
2018-02-05 11:53:36 +11:00