a8e577debb
MDL-37374 questions: fix property_exists calls.
2013-01-16 11:13:53 +00:00
8d54191d7a
MDL-37374 questions: use property_exists rather than isset
...
$a->field = null; isset($a->field) returns false, which is typical PHP.
I also improve the error handling a bit.
2013-01-11 13:15:51 +00:00
f44e7d0a77
Merge branch 'MDL-36357' of git://github.com/danpoltawski/moodle
...
Conflicts:
user/view.php
2013-01-09 09:34:22 +13:00
d55399a098
MDL-28183 fix for problem during integration
...
Conflicts:
question/type/multianswer/question.php
2013-01-08 12:03:48 +01:00
4c345a1ed4
Merge branch 'MDL-36955' of git://github.com/jmvedrine/moodle
2013-01-08 12:20:54 +08:00
9519d41142
MDL-28183 - fix trailing whitespace
2013-01-08 12:18:49 +08:00
b5b418b2a7
Merge branch 'MDL-28183' of git://github.com/jmvedrine/moodle
2013-01-08 12:17:51 +08:00
c2f056a925
MDL-36955 Multianswer grading penalties do not address subparts
2012-12-30 11:59:34 +01:00
e9af609176
MDL-28183 add num parts correct and clear wrong to multianswer
2012-12-30 11:55:21 +01:00
5a449045c2
MDL-37157: Normalize short answers before comparison
...
This ensures that ambiguous Unicode representations can be compared sanely.
Also add some tests to ensure it keeps working.
Thanks to Tim Hunt for the syntax check.
2012-12-18 18:44:15 +01:00
6b9dfe731e
MDL-37032 upgrade: define all the 2.4.0 points
2012-12-11 13:11:11 +01:00
5d44e45264
Merge branch 'MDL-36025-negative-zero' of git://github.com/mpetrowi/moodle
2012-12-11 11:06:28 +08:00
9a8b79864a
Merge branch 'MDL-36916' of git://github.com/timhunt/moodle
2012-12-11 15:42:13 +13:00
6b290a491c
MDL-36732 Cloze qtype: review marks should not depend on feedback.
...
The various review options should be independent.
2012-11-30 15:58:12 +00:00
663dbbc2e6
MDL-36933 Bump everything to 2012112900
...
(versions, requires and dependencies)
2012-11-30 03:30:09 +01:00
6e4a2acf93
MDL-36916 quiz/questions: simplify code after MDL-36638.
2012-11-29 09:28:36 +00:00
c384744304
MDL-36638 usability: Core changes for new quiz/question icons
2012-11-29 12:41:29 +08:00
5f137dcbe2
MDL-36760 formslib: fix frozen elements with [] in name.
...
This was a regression caused by MDL-30845 or, to be precise, the related
issue MDL-32785.
Form elements with names like multipier[0] require special handling,
such as is present in HTML_QuickForm_element::_prepareValue. I have
added equivalent handling to MoodleQuickForm::exportValues. I am afraid
that I could not think of a way to do this reliably without duplicating
code.
2012-11-23 10:53:14 +00:00
91b0d0b75a
Merge branch 'MDL-36571' of git://github.com/timhunt/moodle
2012-11-20 14:59:34 +08:00
acb9f7f47d
MDL-36683 qtype match restore: better subq indentification.
...
This is very similar to what MDL-30018 did for question_answers.
2012-11-19 17:46:25 +00:00
8a7d763c77
MDL-36571 qtype multichoice: don't corrupt unicode characters.
...
It seems that \s includes non-breaking space, and the typical one-byte
representation of that is the same as some parts of multibyte unicode
characters. Therefore, you need to include the u modifer on the regular
expressions.
Also, remove any number of <br /> at the end of the answer.
Thanks to Joseph Rézeau and Jean-Michel Vedrine for working out what the
problem was, and how to fix it.
2012-11-19 17:21:00 +00:00
0e35ba6ffc
MDL-36357 cleanup - remove double semicolons
2012-11-15 09:51:26 +08:00
a538cf839e
MDL-36025 qtype calculated: Fix handling of "-0"
2012-11-02 11:07:02 -04:00
41b4e5ec7f
Merge branch 'MDL-36076' of git://github.com/timhunt/moodle
2012-10-30 12:59:23 +13:00
506263cfee
Merge branch 'WIP-MDL-36033-master' of git://github.com/nadavkav/moodle
2012-10-29 14:59:45 +08:00
15dd772736
MDL-34399 questions cleanup: straighten out strange links to question objects.
2012-10-26 11:58:14 +08:00
f12117250d
MDL-36033 - Left align Numeric value fields in Calculated and Numeric question, when in RTL mode
2012-10-19 10:24:03 +02:00
16c7457f57
MDL-36076 qtype multichoice: validation fails on '0' answer.
2012-10-17 13:54:45 +08:00
76b4a3d118
MDL-30845 formslib: Removing persistant true as its not needed anymore
2012-10-15 14:01:47 +08:00
588d1b595a
MDL-35858 question: Fixed display of feedback in cloze questions
2012-10-09 10:28:21 +08:00
ed27ce0163
Merge branch 'MDL-34570-master' of git://github.com/FMCorz/moodle
2012-10-02 13:56:48 +08:00
c3cdf1e4cb
MDL-34570 Accessibility: Adding labels on text inputs and selects to questions
2012-09-28 11:40:40 +08:00
83690170be
MDL-34570 accessibility compliance for question: edit string label
2012-09-28 11:40:40 +08:00
b2a79cc1e8
MDL-35370 cloze qtype: distinguish wrong & unanswered subqs
...
This affects the subquestions that appear as an embedded text input box.
There are three cases:
1. Input for subq left blank
2. Input for subq was wrong, and matched by a * wildcard.
3. Input for subq was wrong, and did not match any answer.
2. and 3. should look identical, apart from any feedback in case 2.
1. is different. The state should be displayed as "Not answered" even
though the mark for this part is still shown as 0.
There are some new unit tests for these cases.
Also, we slighly improve handling of , for decimal point in multianswer,
although there are still issues.
While working on this, I made some minor clean-ups in shortanswer and
numerical qtypes.
2012-09-27 12:43:21 +01:00
8e8a397b16
MDL-35343 JavaScript visible in multichoice choice feedback.
...
Also, Match correct answer, and calculated multi and multianswer
feedback.
2012-09-10 13:06:47 +01:00
a39c97ca4a
Merge branch 'MDL-33306' of git://github.com/timhunt/moodle
2012-09-04 00:30:35 +02:00
89269fc2c8
MDL-33306 qtype multichoice: fix display of right answer.
...
Also, fix higlighing of last edited question in the qeustion bank, when
it co-incides with a grey row.
2012-08-29 17:47:48 +01:00
23d82edc91
Merge branch 'MDL-31837' of git://github.com/timhunt/moodle
2012-08-28 17:03:55 +08:00
a4290d5803
Merge branch 'MDL-32464' of git://github.com/timhunt/moodle
2012-08-28 16:53:41 +08:00
9455f48280
Merge branch 'MDL-34549-master' of git://github.com/ankitagarwal/moodle
2012-08-28 11:45:11 +08:00
af08f5d0af
Merge branch 'MDL-34430' of git://github.com/timhunt/moodle
2012-08-27 18:50:29 +02:00
d683fcdf98
Merge branch 'MDL-34993' of git://github.com/timhunt/moodle
2012-08-27 18:35:23 +02:00
4299f5f6a8
Merge branch 'MDL-35026' of git://github.com/timhunt/moodle
2012-08-27 17:53:59 +02:00
7f7cda07f2
Merge branch 'MDL-35003' of git://github.com/timhunt/moodle
2012-08-27 17:50:55 +02:00
aa9d6e4300
MDL-32464 qformat multianswer: fix missing include.
...
Also, add a sample file that can be used for testing, and add a unit
test to verify this is working.
2012-08-24 16:56:18 +01:00
5fbe2118bc
MDL-34549 libraries: Changing strictness of context::instance_by_id() when required
2012-08-24 11:30:35 +08:00
d197ea4300
MDL-34549 libraries: Replace get_context_instance_by_id() by context::instance_by_id()
2012-08-24 11:30:10 +08:00
ca9385682f
MDL-34430 qtype essay: upgrade from MDL-31393 needs a progress bar.
2012-08-23 20:08:30 +01:00
e7a6779efb
MDL-35026 qtype multianswer: misnamed string.
...
AMOS BEGIN
MOV [questionnadded,qtype_multianswer],[questionsadded,qtype_multianswer]
AMOS END
2012-08-23 19:28:53 +01:00
2b3f70dbad
MDL-35023 qtype calculated: fix strict syntax problem.
2012-08-23 19:28:38 +01:00
Tim Hunt