These changes are motivated by feedback from Tim Hunt (17 October 2011
in the developers chat room). The combination of using an interface, but
then putting all the useful information in public fields, was not good
design of this library. So I am merging the plugin_information interface
and the plugintype_base class into a new abstract class plugininfo_base.
This new class defines the basic API of all information holding
subclasses. This does not change the code, just puts the documentation
closer to the methods they are actually implemented.
Conflicts:
question/type/upgrade.txt
There were already one just added upgrade.txt file so this ended
conflicting. Reviewed the contents, I've deleted the less detailed
note about pluginname, leaving the longer description added by Tim.
Ciao :-)
AMOS BEGIN
MOV [pluginpagetype,coursereport_stats],[pluginpagetype,report_stats]
MOV [stats:view,coursereport_stats],[stats:view,report_stats]
AMOS END
AMOS BEGIN
CPY [log:viewlive,coursereport_log,[loglive:view,report_loglive]
MOV [livelogs,core],[livelogs,report_loglive]
CPY [loglive,coursereport_log],[pluginname,report_loglive]
AMOS END
AMOS BEGIN
MOV [participation:view,coursereport_participation],[participation:view,report_participation]
MOV [pluginpagetype,coursereport_participation],[pluginpagetype,report_participation]
MOV [pluginname,coursereport_participation],[pluginname,report_participation]
AMOS END
AMOS BEGIN
MOV [pluginname,coursereport_progress],[pluginname,report_progress]
MOV [pluginpagetype,coursereport_progress],[pluginpagetype,report_progress]
MOV [progress:view,coursereport_progress],[progress:view,report_progress]
AMOS END
AMOS BEGIN
MOV [outline:view,coursereport_outline],[outline:view,report_outline]
MOV [pluginpagetype,coursereport_outline],[pluginpagetype,report_outline]
MOV [pluginname,coursereport_outline],[pluginname,report_outline]
AMOS END
It can be easily included in official distribution again if somebody fixes it because there are no stored data, capabilities or versions. This will finally allow us to drop the outdate Smarty library form distribution package.
David Mudrak