Commit Graph

80 Commits

Author SHA1 Message Date
dongsheng 5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
danmarsden 55963a3a29 MDL-13892 partial fix - check var first before using! 2008-03-11 19:01:34 +00:00
danmarsden a5f35b9f5b MDL-13812 choice options not shown when limit enabled. 2008-03-06 19:56:29 +00:00
moodler 5d9d5227ad Merged MDL-13478 Cleaned up some variables 2008-03-03 05:24:55 +00:00
moodler c2a4d0169b Merged MDL-13753 to add percentages 2008-03-03 05:12:22 +00:00
moodler a61e418846 MDL-13478 Fixing a botched merge 2008-03-03 04:42:01 +00:00
moodler 7b360f33af MDL-13478 Merged from 1.9 2008-03-03 04:36:32 +00:00
danmarsden eabb4dd694 MDL-13478 performance fixes. 2008-02-29 11:53:38 +00:00
danmarsden 47ab6f83bb MDL-13478 choice results using too much memory. - improves performance when not showing the unanswered column. - also tidies up a few checks which aren't needed. 2008-02-18 19:52:33 +00:00
danmarsden 9d265d3747 MDL-6373 add MyMoodle support for Choice module. - thanks to Stephen Bourget for partial code. 2008-02-04 22:13:01 +00:00
danmarsden 3c56a7cc93 fix for MDL-7128 - hide save button when options are all full. and tidy up of old is_guest call 2008-01-18 00:32:31 +00:00
danmarsden 06d5e7f08b MDL-12331 prevent hidden role assignments from being shown in the unanswered column of the choice, but still allow them to be shown if they have selected a choice. 2008-01-17 23:02:57 +00:00
danmarsden ba85f6cebc MDL-12890 - patch that allows doanything users to submit a choice, but not shown in the unanswered column. 2008-01-16 18:50:20 +00:00
poltawski 5c88048813 MDL-12890 - differing values for number of choice responses link to what is
displayed
merged from MOODLE_19_STABLE
2008-01-10 14:08:19 +00:00
tjhunt 89d7d96279 MDL-12546 - The choice module was calling get_users_by_capability, which hammers the database and returns lots of data, inside a loop over users - and it was calling it with identical parameters each time. Ouch!
Actually, since the fix for MDL-12331, which changed the get_users_by_capability call at the top of this function, the check it was doing is entirely redundant anyway, so I removed it.

Merged from MOODLE_19_STABLE.
2007-12-11 18:49:56 +00:00
skodak 0b5a80a1a5 MDL-7028 rewritten course reset + forum role_unassign cleanup fixes; merged from MOODLE_19_STABLE 2007-11-29 14:43:04 +00:00
toyomoyo fb656c9f40 MDL-12331, hidden teacher should not be displayed in choice results 2007-11-26 06:01:26 +00:00
danmarsden 770778a502 missed one line.
Fix for MDL-10085  and MDL-8118 Problem with number of Responses in choice wrong, and displayed users incorrect on results.
2007-10-29 00:21:53 +00:00
danmarsden 97b294f8c4 Fix for MDL-10085 and MDL-8118 Problem with number of Responses in choice wrong, and displayed users incorrect on results. 2007-10-28 23:25:54 +00:00
danmarsden 41daad7675 MDL-11397 bug with IE 6 not displaying anonymous results correctly.
- also fix for XHTML Strict.
2007-10-24 21:27:26 +00:00
danmarsden 19e559e4bc Fix for MDL-9666 totals don't appear when full names are shown. 2007-10-22 21:49:58 +00:00
mattc-catalyst 6d5b7706da MDL-10888: groupings - mod/choice - updated to support groupings 2007-08-27 21:52:35 +00:00
skodak 2c386f82e5 MDL-10383 - deprecated get_groups(), user_group() and ismember() 2007-08-15 20:21:01 +00:00
moodler 2b85d965a5 Merged 1.8 fix for groups in choice activity 2007-08-09 06:27:22 +00:00
Martin Langhoff 08103c9364 cvsimport fixups 2007-07-07 14:18:30 +12:00
danmarsden 243ac1feb4 MDL-8394 Allow students to remove their choice when they are allowed to update their choice. 2007-05-03 00:04:53 +00:00
skodak aa4836f438 MDL-9568 Choice does not count correct; merged from MOODLE_18_STABLE 2007-04-24 20:09:01 +00:00
toyomoyo 95aa949b72 MDL-7861, xhtml strict fixes for choice 2007-01-09 03:14:34 +00:00
toyomoyo d71bc1ab61 MDL-7861, fixing xhtml strict problems 2007-01-09 01:38:24 +00:00
skodak 7150226896 MDL-7861 xhtml strict fixes - fixed all <br> in our code 2007-01-04 23:38:17 +00:00
toyomoyo 3402a6f345 MDL-7861, broken xhtml 2006-12-21 07:50:19 +00:00
toyomoyo 077f381461 accessiblity, associating <th> with respective row or col 2006-12-13 08:24:23 +00:00
jamiesensei a2e67a9a47 fix for error preventing adding of more choices in chat upate form 2006-12-05 13:32:32 +00:00
jamiesensei ebd3c7ac94 added repeat_elements method to moodleform and used method for choice form 2006-11-24 12:20:26 +00:00
toyomoyo 33a893aa2b merged, adding missing fields 2006-11-15 06:28:37 +00:00
toyomoyo e1658dad73 merged, replacing deprecated functions 2006-11-15 06:23:28 +00:00
danmarsden ff8d654f00 Fix for MDL-6550 - patch from Graeme Byrne thanks! :-)
+ remove a bit of unneeded space! :-)
2006-10-16 00:01:13 +00:00
toyomoyo 39b3e7dedf adding capaility, fixing indenting and logic (could have broken things) 2006-09-11 07:17:10 +00:00
toyomoyo f9a59efa64 adding some capabilities 2006-08-29 08:43:59 +00:00
moodler 0468976c9a SWEEPING CLEANUP
The API was changed slightly so that has_capability now takes the
whole $context object (we almost always have it anyway)

The $kill thing was removed.   If you want to assert a capability
then use:

    require_capability('capname', $context);

with optional variables to modify the error message

Misc bugs here and there also removed and code tidied
2006-08-14 05:55:40 +00:00
moodler dabfd0ed85 Removed tabs 2006-08-09 13:45:49 +00:00
moodler bbbf2d4015 ROLES AND PERMISSIONS - FIRST CHECK-IN
=======================================

WARNING:  DEV IS CURRENTLY VERY UNSTABLE.

This is a mega-checkin of the new Roles system.   A lot of changes have
been made in core and modules.

Currently there are a lot of rough edges and known problems.  We are
working hard on these .. .the reason for getting this into HEAD at this
stage is enable us to move faster (our branch was diverging from HEAD
too much).

Please keep an eye on http://docs.moodle.org/en/Roles for current status
and information for developers on how to use the new Roles system.
2006-08-08 05:13:06 +00:00
danmarsden 1e0c4d67fd Fix for Bug 6119 - gives error when choice full, and user submits a choice they have already selected 2006-07-23 22:14:31 +00:00
danmarsden 22d56e8015 need to check vars aren't empty b4 using them! - another one! 2006-04-12 21:15:10 +00:00
danmarsden 6c5a77bbb7 couple of bugs when no data returned. 2006-04-06 20:42:35 +00:00
danmarsden 3e11b9f44a missed one. 2006-04-04 23:36:13 +00:00
danmarsden acaf7b86e3 Bug Fixes for:
Bug 5042
Bug 4600
Bug 4021
Bad code - need to check vars aren't empty b4 using them!
2006-04-04 23:03:15 +00:00
danmarsden 90ca2ce87d fixed bug with limits not limiting for only enrolled students - limit was counting non-enrolled students as well. - also removed checkboxes to delete response from not-answered column. 2006-02-23 21:20:44 +00:00
danmarsden 348630d87e moving duplicated code into Lib.php as functions & clean up the code a bit. - also now include users group info in text/excel downloads. - preparation for new choice block! 2006-02-23 01:20:24 +00:00
danmarsden c100a341a6 Bug 3768 - Release is now a reserved word in MySql 5 2006-02-08 23:46:21 +00:00