Commit Graph

87 Commits

Author SHA1 Message Date
tjhunt 95e5c19295 Remove CVS confilt markers. 2007-02-28 15:11:54 +00:00
nicolasconnault 7c08ef3653 Fixed MDL-8582
Not sure if the hotpot module is converting ampersands correctly. $heading and $title are set up differently than in other modules: instead of outputting $course->title, a temporary $title variable is created and assigned that value. That made it difficult for me to decide whether it was already formatted elsewhere or not.

Also I didn't format_string() any of the variables included in $navigation rings, because I assume these strings get processed by print_navigation(), which includes format_string().
2007-02-28 05:36:13 +00:00
thepurpleblob c09f474dd0 MDL-8450 Added support for including question categories in a quiz export. 2007-02-07 10:14:22 +00:00
tjhunt a95cd8a650 Get the alt text for the question type icon in a better way. 2007-01-30 11:09:32 +00:00
tjhunt 47cdbd1f64 Question session state logic improvement - if students have not yet entered an answer, don't do an EVENT_SAVE. 2007-01-11 12:18:10 +00:00
skodak 0d905d9f34 MDL-7861 new class .icon and .iconsmall 2007-01-08 09:14:05 +00:00
jamiesensei 375ed78a93 fixed the MoodleQuickForm_questioncategory, question_category_options function wasn't committed so I've implemented it from question_category_select_menu code. 2007-01-07 13:54:36 +00:00
jamiesensei 271ffe3f25 various formslib work including bug fixes for MDL-8039 id attribute collision between forms and page ids. Also added editor helpbutton. This is a fix for MDL-6941 need the ability to associate several helptopics with htmleditor. Also started on converting forms for question types to formslib. 2007-01-07 12:46:47 +00:00
moodler 7cd2f598aa More XHTML strict - removed image borders and height/width 2007-01-05 12:58:22 +00:00
thepurpleblob dd0730c2dd Added some cleaning to the category path for some safety. 2007-01-05 10:16:12 +00:00
vyshane bc75cc5210 Added 2 new functions: question_get_feedback_image() and question_get_feedback_class(). 2006-12-18 06:07:44 +00:00
thepurpleblob f5c154078a Merged from STABLE. Addition function to find or create category path.
MDL-4163
2006-11-29 13:29:00 +00:00
tjhunt 84bf852c1b MDL-7428 - Quiz regrade removes student answers from essay questions that have been graded. Merged from MOODLE_16_STABLE. 2006-11-15 17:32:49 +00:00
tjhunt f9c92efef3 MDL-7531 Fix SQL that does not work in Oracle. Thanks to Mark Hetherington for the fix. Merged from MOODLE_17_STABLE. 2006-11-14 15:41:20 +00:00
tjhunt 95ac8a4039 MDL-6315 - Manually grading a question 0 marks was not being registered. I took the opportunity to clean up the logic in this function a bit. Merged from MOODLE_16_STABLE. 2006-10-17 23:23:18 +00:00
skodak 57f1b91497 fixed some incorrect strtolower() calls that were breaking non ascii languages MDL-6135 2006-10-07 20:47:54 +00:00
tjhunt 13835c77b6 MDL-6731 Can't save manual comment on a quiz question. I had missed one instance of the comment -> manualcomment column rename. 2006-10-06 17:22:08 +00:00
tjhunt b20ea66988 Hopefully improve performance on site with lots of question categories Merged from MOODLE_16_STABLE. 2006-10-06 16:48:54 +00:00
tjhunt 1da5a36294 More capability name typos. 2006-09-20 08:01:59 +00:00
toyomoyo 9ce384ba1e relacing deprecated functions with capability checks 2006-09-19 14:16:40 +00:00
tjhunt 3e3e5a4030 Renamed column question_sessions->comment at Eloy's request since comment is a DB reserved word.
I have not been able to test this fully, because I cannot assign roles (e.g. Student and Teacher) in 1.7dev at the moment to test a student answering an essay question then a teacher grading it. However, I have tested as much as possible as admin and cannot get any errors.
2006-08-24 16:44:15 +00:00
tjhunt 3ebdddf70f MDL-4816 Fix silly error in my commit for this bug. 2006-08-24 11:37:10 +00:00
tjhunt c82f76d050 MDL-4816 Short answer question type considers '100' and '100.' to be the same Actually, this may have affected other question types too. 2006-08-23 21:17:23 +00:00
tjhunt ef82286874 Bug #6293 - Cannot regrade a question when a teacher has added a comment with a ' - Merged from MOODLE_16_STABLE. Stupid, wreched, datalib. Why can't datalib take care of addslashes, so the whole of the rest of the code can forget about it? That is how a database abstraction layer should work. I know, it is pointless to moan about it, but it has just cost me 3 hours, so I feel I have earned the right to moan. 2006-08-18 22:34:54 +00:00
tjhunt 865b753486 Code cleanup. Merged from MOODLE_16_STABLE. 2006-08-18 22:26:04 +00:00
tjhunt 1780811d55 Added todo. 2006-08-18 08:14:47 +00:00
tjhunt 1d723a169a Bug #6267 - questionlib.php delete_question infinite loop with rantom questions. Thanks to mbockol at carleton dot edu. Merged from MOODLE_16_STABLE. 2006-08-16 16:17:18 +00:00
tjhunt a21567892f Refactor how question types register themselves with the question bank. This change makes it easier for 3rd party question types to control their destiny, but is also backwards compatible, in that old 3rd party plugins will still work. See http://moodle.org/mod/forum/discuss.php?d=51796 for more details. 2006-08-15 21:25:38 +00:00
tjhunt 1b8a7434e2 Bug 6239 - Allow questions to have some teacher-supplied commentary.
While implementing this, I removed the ~100 lines of very similar code from the top of each question type's editquestion.html template, and moved this to a the function print_question_form_start() in the base class, which uses the template question/type/editquestionstart.html. This is described in more detail here: http://moodle.org/mod/forum/discuss.php?d=51590, and is why this patch makes the codebase 523 lines smaller.
2006-08-11 14:59:18 +00:00
tjhunt 93eb0ea339 Fix comment. 2006-08-10 21:33:53 +00:00
tjhunt 5a14d563b9 Bug #5972 - Some question types mark a blank answer inconsistently.
Also, cleaned up the marking code for numerical and short answer questions, partly by making the base-class method more useful.

Rewrote the way the way short answer questions do wildcard matching to be more robust, Unicode safe, and generally not suck.

This is a big change, so I am pleased to report I tested it using my new Selinium  test suite. See: http://moodle.org/mod/forum/discuss.php?d=51161
2006-08-04 16:53:43 +00:00
tjhunt bdfad57b83 Added information to a comment. 2006-07-28 10:55:37 +00:00
tjhunt d7444d442f Bug #6033 - missing string for unknown questiontype. Also tidied up some messy code. Merged from MOODLE_16_STABLE. 2006-07-18 15:34:24 +00:00
tjhunt 062a7522c2 Bug 6111 - Rewrite the code for making an indented list of question categories, becase the existing code was so horrible. Merged from MOODLE_16_STABLE. 2006-07-14 15:36:29 +00:00
tjhunt ec23db087c Bug 6031 - missing parameter for warningmissingtype in libquestionlib.php. Merged from MOODLE_16_STABLE. 2006-07-06 11:09:24 +00:00
tjhunt 82b5d7cd8e Bug #5922 - comment from manualgraded questions lost during regrade. Thanks to Jean-Michel Vedrine for the fix. Merged from MOODLE_16_STABLE. 2006-06-28 11:45:11 +00:00
tjhunt 5e60643e1b Bug 5889 - Regrading a quiz wipes student answers. Thanks to Jean-Michel Vedrine for the fix. Merged from MOODLE_16_STABLE. 2006-06-26 11:23:32 +00:00
danstowell 87075ec1cd Fixed typo which caused images in questions to fail to display if NOT using slasharguments 2006-06-23 15:06:23 +00:00
gustav_delius 36be25f6e5 Introduce question_attempts table, closing bug 5468
Fixed incorrect check for whether to update state or insert new one in save_question_session()
Deal with manually graded states correctly during regrading
Increase state sequence number during manual grading
Supplied missing userid to quiz_save_best_grade() during manual grading
2006-05-13 16:57:17 +00:00
thepurpleblob 6cb4910c58 Merged from STABLE 2006-05-08 10:39:14 +00:00
thepurpleblob 9c802dff19 Bunch of category functions moved to question/editlib.php 2006-05-02 12:26:36 +00:00
thepurpleblob 947217d725 Small clean up, and fix a link to a required file for robustness. 2006-05-02 09:04:38 +00:00
gustav_delius 2b44d03f81 Error message for when a questiontype is missing is prepended to question text. 2006-04-30 17:33:00 +00:00
gustav_delius 2e9b6d157c Fixed bug 5192 2006-04-30 16:15:04 +00:00
gustav_delius ca56222d50 Fixed and simplified the logic in the response processing. Remove the walking through previous graded states. 2006-04-30 11:45:14 +00:00
gustav_delius c4c11af898 Now that the shuffling within a question can be controlled also at question level the default at the module level needs to be set to true, otherwise people can not test the question setting. 2006-04-30 08:11:49 +00:00
skodak 6cf4cbbdf9 added FIX ME notice for inclusion of format.php 2006-04-22 17:21:21 +00:00
thepurpleblob 2784b98278 Don't compare floats for equality! Bug #5176 2006-04-13 10:29:20 +00:00
gustav_delius da1cc5a44e Fixed problem with slashes, bug 5177 2006-04-13 00:37:14 +00:00
gustav_delius cbe20043b5 Whenever a question is edited the version field is set to question_hash(), see bug 2958. 2006-04-10 22:10:32 +00:00