Commit Graph

36 Commits

Author SHA1 Message Date
David Mudrak a8b309a37d MDL-22507 workshop rendering of messages and allocation process fixed 2010-10-20 13:13:01 +00:00
David Mudrak 65601f04a3 MDL-21249 workshop and its subplugins: fixing phpdocs @package and @subpackage 2010-09-30 14:44:33 +00:00
Petr Skoda 5924db724d fixed a few spelling problems and standardised stdClass 2010-09-18 14:18:39 +00:00
David Mudrak 346af1a431 MDL-24091 workshop: deleting subplugins data together with the workshop instance 2010-09-17 13:24:52 +00:00
David Mudrak 67ae13d9ad NOBUG workshop: add_allocation() parameters order changed 2010-06-08 23:10:06 +00:00
David Mudrak 30c8dd34f7 MDL-15252 Re-committing all English strings exported from AMOS
From now on, all English strings use the new syntax. They are not
eval()'ed any more and the only valid placeholders are {$a} and
{$a->foobar}. No extra quotes escaping, dollar sign escaping and putting
double percent signs.

The modified files were exported from AMOS database repository in the
new syntax and were re-ordered by stringid. Standard GNU/GPL and PHPdoc
blocks are added. Where there was no copyright note so far, I added the
default one with Martin Dougiamas as the copyright holder.

Live long and prosper.
2010-04-10 14:01:45 +00:00
Petr Skoda 3a915b0667 MDL-21693 Dropping _utf8 suffix from language codes and folder names; enabling new string managers - please note the transition is not yet fully complete because we need to wait for git to recognize the renames in cvs 2010-04-10 07:24:56 +00:00
Petr Skoda b9bc201962 MDL-21233 escaped parameter is far more importatnt than the overrideparams in out() method - especially all JS urls should be converted to out(false); also it is possible to create new url with overrided parameters in constructor which might be actually work around the double encoding problems in the url (we should never use the out() in moodle_url constructor itself!) 2010-01-17 09:50:55 +00:00
Petr Skoda 340d461269 MDL-21233 simplifying moodle_url->out() api 2010-01-17 09:18:11 +00:00
David Mudrak 7a789aa8cc workshop coding style - use stdclass instead of stdClass 2010-01-04 18:30:57 +00:00
David Mudrak 6adbcb8015 workshop in reply to MDL-20204 - new output API 2010-01-04 18:26:56 +00:00
David Mudrak d864fdfb14 Fixed deprecated call by reference 2010-01-04 18:25:52 +00:00
David Mudrak f6e8b31802 workshop: general cleanup
Moving stuff from lib.php into static methods in localib.php. Removing
things from workshop core that were implemented in a subplugin. Dropping
stuff related to features not to be implemented in 2.0.
2010-01-04 18:22:10 +00:00
David Mudrak 4efd7b5d5f Improved the workshop constructor to support unit testing
Thanks to Tim Hunt for the hint.
2010-01-04 18:12:32 +00:00
David Mudrak d895c6aaf5 Improved context handling
Getting a context from instance is very cheap and I can actually do it
just once when constructing the workshop API class. In the future, I
will get rid of all $PAGE->context which is actually meant for things
like blocks etc.
2010-01-04 18:11:35 +00:00
David Mudrak 6cc363f4bf Fixed a bug caused by incorrect comparison of float values 2010-01-04 18:09:28 +00:00
David Mudrak 29dc43e7e4 MDL-20058 first prototype of the grading report renderer 2010-01-04 18:08:27 +00:00
David Mudrak 00aca3c14c A lot of work here and there
DB columns userid renamed to authorid or reviewerid to make the value
clear. Improved manual allocation UI. Raw grades are stored as numeric
values from 0.00000 to 100.00000 (instead of the current 0 to 1) to be
more precise. Started to work on the Grading report (it est the overall
report of all grades form submission and grades for assessments).
2010-01-04 18:08:13 +00:00
David Mudrak 87a5368df1 Scalability issues
Did not display properly with dozens of users
2010-01-04 18:07:28 +00:00
David Mudrak f05c168d2e MDL-20236 overall codebase architecture cleanup and fixing regression
See the issue description for more details
2010-01-04 18:05:48 +00:00
David Mudrak 3dc78e5b04 Refactoring some critical parts
Critical issue fixed here: after recent refactorings, I called
get_users_with_capability() inside the loop in another loop! (oops :-)
This was used in my very first code using the renderers. I have learnt
I should follow the core approach (as suggested by Tim) to prepare a
data object and pass it to the renderer. The fact the renderer called
a workshop method indicated something was really wrong...

WIP
2010-01-04 18:02:05 +00:00
David Mudrak 3189fb2d42 Uses tabs for all actions, removed temporary links 2010-01-04 18:01:15 +00:00
David Mudrak b761e6d9c6 Mostly working on the view.php UI plus some changes 2010-01-04 18:00:54 +00:00
David Mudrak ed597c7756 MDL-20192 Allocators and grading strategies are proper subplugins now 2010-01-04 17:59:34 +00:00
David Mudrak 8d54587610 Puttting a TODO note - return to this code once working on the Scheduled allocation 2010-01-04 17:55:23 +00:00
David Mudrak 65ba104c5d Reverting Petr's suggestion - using stdClass instead of object again
I do not agree with using object() class for no real reason.
2010-01-04 17:55:02 +00:00
David Mudrak 9bb4a4a0d5 Petr's review: Removing assignments by reference where not needed 2010-01-04 17:53:20 +00:00
David Mudrak 4443519f57 Petr's review: use object instead of stdClass 2010-01-04 17:52:59 +00:00
David Mudrak 74e28b263a Petr's review: Removing assignment by reference 2010-01-04 17:52:45 +00:00
David Mudrak a39d7d87aa A lot of changes here and there 2010-01-04 17:49:01 +00:00
David Mudrak b8ead2e6a4 Uses workshop renderer to display assessment page
Some small refactoring like using single function to group users done.
2010-01-04 17:48:33 +00:00
David Mudrak a7c5b9185a Extending workshop class constructor
Every action script in 99% starts with fetching course, course module,
and module instance record. Workshop class will keep the reference to
the course record in courserecord public member variable (do not confuse
with course integer property).
2010-01-04 17:47:43 +00:00
David Mudrak da92436b2d MDL-19870 Random allocation - work in progress
Random allocation implemented. More testing needed.
2010-01-04 17:47:32 +00:00
David Mudrak 32e3858578 Fix: do not remove allocation if it should be kept 2010-01-04 17:47:22 +00:00
David Mudrak 53fad4b90c MDL-19870 Initial work on random allocator
Initial sketches of random allocator. Refactoring of the rest of the
module here and there. Also, this commit removes trailing whitespace and
running empty lines.
2010-01-04 17:47:09 +00:00
David Mudrak 6e3099730e MDL-19717 First drafts of allocation support 2010-01-04 17:46:05 +00:00