Tim Hunt
ef37c13e29
MDL-42309 typo: fix reponse -> response throughout Moodle.
2013-10-15 13:50:05 +11:00
Tim Hunt
cf2fb7579b
MDL-42232 Multiple choice question choice alignment issue
...
The problem was with the alignment of:
* tables inside the choices.
* Lists inside the choices.
* The specific feedback, when it spanned mulitple lines.
The problem was introduced by MDL-39420.
2013-10-11 14:26:34 +01:00
Tim Hunt
b014bb8b4c
MDL-38203 multianswer qtype: feedback pop-up should be constrained.
...
So that, when there is a lot of feedback, it is all visible.
2013-08-15 14:16:32 +01:00
Dan Poltawski
d835ad6935
MDL-39507 qtype_essay: hacky fix for unit tests
...
This is just to get the tests passing for integration purposes. Tim
may want to do a robust fix and revert this.
2013-08-13 10:47:46 +08:00
Tim Hunt
06a42cff90
MDL-39507 questions: fix pluginfile URLs before format_text.
...
This commit build's on Jean-Michel's work, tidying up a few lose ends.
2013-08-12 13:13:54 +01:00
Jean-Michel Vedrine
cda91161df
MDL-39507 questions: fix pluginfile URLs before format_text.
2013-08-12 10:36:40 +01:00
Damyon Wiese
4dcd073864
Merge branch 'MDL-39420_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-07-09 22:44:21 +08:00
Tim Hunt
4cc817aa33
MDL-39420 multichoice: fix layout of multi-line choices.
2013-07-09 11:57:07 +01:00
Damyon Wiese
d3dc9a334c
Merge branch 'MDL-40499_24' of git://github.com/jmvedrine/moodle into MOODLE_24_STABLE
2013-07-09 13:27:05 +08:00
Jean-Michel Vedrine
a16ec93666
MDL-40499 Edit question from 1.9 backup breaks if images in subdirs
2013-07-04 15:07:46 +02:00
Tim Hunt
ca6904b6c9
MDL-40434 calculatedmulti multiple-response questions not randomised
2013-07-02 08:24:01 +01:00
Kyle Temkin
b64526c715
MDL-40264 fix essay handling of zero-string response
...
Fixes an inappropriate behavior of the is_complete_response() function
for the Essay question type, which caused the string "0" to be
inappropriately marked as an incomplete response.
Also adds a set of unit tests for the Essay question type's
is_complete_response.
2013-06-21 03:28:59 -04:00
Tim Hunt
c0f5255cb9
MDL-39945 qtype multichoice was not comparing blank responses correctly.
2013-05-30 19:47:58 +01:00
Tim Hunt
18d5870e8b
MDL-39728 List all the classes in question/type/questionbase.php
...
This should make it easier for people to understand the type hierarchy.
2013-05-18 09:25:17 +01:00
Eloy Lafuente (stronk7)
ec00601863
Merge branch 'MDL-38487_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-05-09 00:54:54 +02:00
Tim Hunt
d8da3c0f5b
MDL-39446 calculated qtype: make answer formula input bigger
...
This makes it easier for teachers editing questions.
2013-05-02 15:47:54 +01:00
Tim Hunt
c1288cd726
MDL-38487 qtype match restore: problem with blank ids.
...
As it happens, this field is useless, and has been removed from the DB
in 2.5. Therefore, we only need a work-around for stable branches.
2013-05-02 15:46:58 +01:00
Damyon Wiese
49b18efa4e
Merge branch 'MDL-39342_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-04-29 15:36:09 +08:00
Tim Hunt
9a3d0206da
MDL-37845 multichoice qtype: Fix some display issues.
...
1. Better handling of multi-line choices in the correct answer display.
2. Remove dangerous CSS that is no longer needed.
2013-04-25 17:21:11 +01:00
Jason Platts
261aae298b
MDL-39342 stop users entering too long matching answers.
...
Since they lead to an ugly DB error.
2013-04-25 12:00:09 +01:00
Eloy Lafuente (stronk7)
82f27d5bbd
Merge branch 'MDL-38363_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-03-19 21:07:08 +01:00
Eloy Lafuente (stronk7)
bc353318b2
Merge branch 'MDL-38355_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-03-19 21:01:10 +01:00
Eloy Lafuente (stronk7)
59faf92e1f
Merge branch 'MDL-38542_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-03-19 16:49:23 +01:00
Eloy Lafuente (stronk7)
332e3c0153
Merge branch 'MDL-38444_24' of https://github.com/ppichet/moodle into MOODLE_24_STABLE
2013-03-19 16:35:30 +01:00
Tim Hunt
708c1b7fc8
MDL-38542 shortanswer qtype: was broken for responses of '0'.
...
This was a regression caused by MDL-37157 & MDL-37746.
2013-03-19 13:55:41 +00:00
ppichet
1e9f48c9bc
MDL-38444 Saving datasets from edit_calculatedsimple_form.php
...
Bypassing the 3 steps savequestion() of calculated.
2013-03-17 00:45:00 -04:00
Tim Hunt
7b62eec877
MDL-38363 qtype_calculated. Fix warnings.
2013-03-15 11:23:33 +00:00
Tim Hunt
16442e5cfd
MDL-38355 qtype_multianswer: input boxes too big in Russian.
...
... and any other language where the characters take multiple
bytes in UTF-8.
This fix was worked out by Dušan Ristić. I am just committing it.
2013-03-14 22:26:40 +00:00
Tim Hunt
3d8c5cb044
MDL-38397 question editing: only validate default mark if present.
...
Most qtypes have that field, but not all. multianswer is an example in core.
Also some contrib qtypes.
2013-03-14 22:13:44 +00:00
Jean-Michel Vedrine
c16e466de2
MDL-33424 Images missing when restoring a 1.9 backup
2013-03-09 13:41:03 +01:00
Eloy Lafuente (stronk7)
add7b5a250
Merge branch 'MDL-38119_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-03-05 16:45:42 +01:00
Tim Hunt
a78c180efa
MDL-38279 questions: must have default mark positive.
2013-03-01 15:22:05 +00:00
Tim Hunt
627f31b52c
MDL-37847 / MDL-38119 question engine: document API change.
2013-02-28 18:26:46 +00:00
Tim Hunt
2de3659810
MDL-37896 qtype_essay: correct PARAM_CLEANHTML -> PARAM_RAW.
...
It turns out that you should almost never use PARAM_CLEANHTML.
2013-02-08 12:49:58 +00:00
Eloy Lafuente (stronk7)
65828d8652
Merge branch 'MDL-37847_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-02-04 22:56:03 +01:00
Tim Hunt
b7f894a403
MDL-37847 plain text essays were screwing up HTML special chars.
...
This was incorrect use of PARAM_CLEANHTML for these inputs.
This fix also adds some unit tests to try to verify that this does not
break again in future.
2013-02-04 12:55:31 +00:00
Tim Hunt
3f7a6d5331
MDL-37746 qtype_shortanser: avoid normalizer_normalize dangers.
...
When an error occurs, normalizer_normalize just silently returns null,
which is dangerous. Here, we wrap it in a safe helper function.
2013-01-31 11:33:12 +00:00
ppichet
92a7501ac6
MDL-29691 Improve numerical format in multianswer
...
Allow the use of , as decsep in multianswer numerical subquestions
2013-01-29 16:30:27 +08:00
Tim Hunt
2b18a45e61
MDL-28512 qtype essay: clean up properly when a question is deleted.
2013-01-18 11:51:47 +00:00
Tim Hunt
db1f584cc2
MDL-37374 questions: fix property_exists calls.
2013-01-16 11:20:58 +00:00
Tim Hunt
4dcede552e
MDL-37374 questions: use property_exists rather than isset
...
$a->field = null; isset($a->field) returns false, which is typical PHP.
I also improve the error handling a bit.
2013-01-11 13:04:31 +00:00
Jean-Michel Vedrine
0a32dca4bb
MDL-28183 fix for problem during integration
...
Conflicts:
question/type/multianswer/question.php
2013-01-08 12:05:45 +01:00
Dan Poltawski
c33a96f676
MDL-28183 - fix trailing whitespace
2013-01-08 12:18:31 +08:00
Dan Poltawski
9910a5d7eb
Merge branch 'MDL-28183_24' of git://github.com/jmvedrine/moodle into MOODLE_24_STABLE
2013-01-08 12:17:58 +08:00
Didier Raboud
f4537d5676
MDL-37157: Normalize short answers before comparison
...
This ensures that ambiguous Unicode representations can be compared sanely.
Also add some tests to ensure it keeps working.
Thanks to Tim Hunt for the syntax check.
2013-01-07 14:00:13 +08:00
Jean-Michel Vedrine
a7eec81ec6
MDL-28183 add num parts correct and clear wrong to multianswer
2012-12-21 05:18:02 +01:00
Eloy Lafuente (stronk7)
e958133ca6
MDL-37032 upgrade: define all the 2.4.0 points
2012-12-11 13:12:03 +01:00
Matt Petro
95ae9d9e5e
MDL-36025 qtype calculated: Fix handling of "-0"
2012-12-11 11:07:24 +08:00
Sam Hemelryk
6ff1745873
Merge branch 'MDL-36916' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2012-12-11 15:42:08 +13:00
Tim Hunt
6812769f8f
MDL-36732 Cloze qtype: review marks should not depend on feedback.
...
The various review options should be independent.
2012-12-10 15:18:14 +08:00