Commit Graph

2336 Commits

Author SHA1 Message Date
Tim Hunt ef37c13e29 MDL-42309 typo: fix reponse -> response throughout Moodle. 2013-10-15 13:50:05 +11:00
Tim Hunt cf2fb7579b MDL-42232 Multiple choice question choice alignment issue
The problem was with the alignment of:
* tables inside the choices.
* Lists inside the choices.
* The specific feedback, when it spanned mulitple lines.

The problem was introduced by MDL-39420.
2013-10-11 14:26:34 +01:00
Adam Olley 7c95cf02af MDL-41600: qformat_blackboard_six Fix test_import_match fail w/ddmatch
With qtype_ddmatch installed, the unit tests for qformat_blackboard_six
fail as they generate ddmatch questions instead of match ones. This
patch checks for ddmatch and changes the test to expect that instead if
its installed.
2013-09-10 09:16:29 +09:30
Damyon Wiese 13ad8def1b Merge branch 'MDL-41348_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-09-03 16:10:13 +08:00
Tim Hunt 530e43776b MDL-41348 question code depends on filelib.
I think this used to work because mod/forum/lib.php used to be included
everywhere, and in turn included lib/formslib.php. We should declare the
dependencey explicitly.
2013-08-28 11:18:25 +01:00
Dan Poltawski 7d64b40db1 Merge branch 'MDL-41366_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-08-27 18:09:54 +08:00
Tim Hunt 67051eb403 MDL-41366 qbehaviour_informationitem fix name capitalisation. 2013-08-21 12:30:06 +01:00
Damyon Wiese 18c49b1420 Merge branch 'MDL-41036_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-08-20 13:02:26 +08:00
Tim Hunt b014bb8b4c MDL-38203 multianswer qtype: feedback pop-up should be constrained.
So that, when there is a lot of feedback, it is all visible.
2013-08-15 14:16:32 +01:00
Tim Hunt e859dfdfb8 MDL-41036 Question category info should use HTML editor
This is a minimal fix. All this code could do with a clean-up, but at
the moment, it works, so I am not going to touch it.
2013-08-15 11:58:05 +01:00
Dan Poltawski 5fa41023da Merge branch 'MDL-39507_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-08-14 21:58:14 +08:00
Tim Hunt 12cc56072a MDL-39507 Question HTML export: fix image handling.
Some code got committed to stable branches that relied on a new API that
was in master only. This fixes it to use the old API.
2013-08-14 11:04:10 +01:00
Dan Poltawski d835ad6935 MDL-39507 qtype_essay: hacky fix for unit tests
This is just to get the tests passing for integration purposes. Tim
may want to do a robust fix and revert this.
2013-08-13 10:47:46 +08:00
Dan Poltawski 2e91dfc66c Merge branch 'MDL-39507_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-08-13 09:53:31 +08:00
Sam Hemelryk 452ff25284 Merge branch 'MDL-41091_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-08-13 09:38:20 +12:00
Tim Hunt 06a42cff90 MDL-39507 questions: fix pluginfile URLs before format_text.
This commit build's on Jean-Michel's work, tidying up a few lose ends.
2013-08-12 13:13:54 +01:00
Jean-Michel Vedrine cda91161df MDL-39507 questions: fix pluginfile URLs before format_text. 2013-08-12 10:36:40 +01:00
Jean-Michel Vedrine 390cb87e76 MDL-30001 WEBCT Import does not work for 2.0 2013-08-11 08:06:13 +02:00
Tim Hunt 053617fcb6 MDL-41091 questions: fix get_all_submitted_qt_vars for unit testing. 2013-08-08 14:43:28 +01:00
Ruslan Kabalin 05342e935c MDL-31226: quiz: Fix message for attempts built on previous.
At the moment, when attempt is built on the last one, "not yet answered"
message is shown, which confuses many people. This patch modifies the state to
"complete" for attempt based on previous and modifies the output string.

Many thanks to Tim Hunt for guiding me through quiz infrastructure and some code
suggestions.
2013-08-02 17:01:50 +01:00
Damyon Wiese 4dcd073864 Merge branch 'MDL-39420_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-07-09 22:44:21 +08:00
Tim Hunt 4cc817aa33 MDL-39420 multichoice: fix layout of multi-line choices. 2013-07-09 11:57:07 +01:00
Damyon Wiese d3dc9a334c Merge branch 'MDL-40499_24' of git://github.com/jmvedrine/moodle into MOODLE_24_STABLE 2013-07-09 13:27:05 +08:00
Jean-Michel Vedrine a16ec93666 MDL-40499 Edit question from 1.9 backup breaks if images in subdirs 2013-07-04 15:07:46 +02:00
Tim Hunt ca6904b6c9 MDL-40434 calculatedmulti multiple-response questions not randomised 2013-07-02 08:24:01 +01:00
Kyle Temkin b64526c715 MDL-40264 fix essay handling of zero-string response
Fixes an inappropriate behavior of the is_complete_response() function
for the Essay question type, which caused the string "0" to be
inappropriately marked as an incomplete response.

Also adds a set of unit tests for the Essay question type's
is_complete_response.
2013-06-21 03:28:59 -04:00
Marina Glancy 351f4729e2 Merge branch 'MDL-39412_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-06-11 12:02:01 +10:00
Tim Hunt c0f5255cb9 MDL-39945 qtype multichoice was not comparing blank responses correctly. 2013-05-30 19:47:58 +01:00
Damyon Wiese 17bca7a2b9 MDL-39412 Prevent developer warnings on upgrade from 24 to master 2013-05-20 12:42:55 +01:00
Tim Hunt c22a0ad980 MDL-39412 disabling manual graded behaviour refinements
1. Change behaviour admin settings so you can only select enabled
behaviours.
2. During the upgrade, change admin settings that might be currently set
to manual graded, so that instead they are set to deferredfeedback (if
that is available. If not, we just take the first alphabetically.)
2013-05-20 12:42:15 +01:00
Tim Hunt 617947c0b7 MDL-39412 question behaviours: hide manual graded option
The ability to set all your quiz questions to require manual grading is
an interesting possibility, but practically almost useless.

If you set that accidentally, then you are badly stuck. There is no way
to fix it after the students have answered the quiz.

Therefore, we should set the config option to hide that option from the
UI. We do this for all Moodle sites as part of the upgrade, not just for
new installs.

If any admin wants to re-enable this, they can later.
2013-05-20 12:26:06 +01:00
Dan Poltawski 133defa353 Merge branch 'MDL-27748_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-05-20 15:47:34 +08:00
Tim Hunt 0377e4fbc9 MDL-27748 question: grade options should be localised.
question_bank::fraction_options should use format_float to display
decimal pionts correctly.
2013-05-19 23:45:48 +01:00
Tim Hunt 18d5870e8b MDL-39728 List all the classes in question/type/questionbase.php
This should make it easier for people to understand the type hierarchy.
2013-05-18 09:25:17 +01:00
Eloy Lafuente (stronk7) d5420db934 Merge branch 'MDL-29758_24' of git://github.com/jmvedrine/moodle into MOODLE_24_STABLE 2013-05-10 02:54:06 +02:00
Jean-Michel Vedrine da4bd770f2 MDL-29758 make Cloze question feedback display more informative
as it was in Moodle 1.9
2013-05-09 08:56:33 +02:00
Eloy Lafuente (stronk7) ec00601863 Merge branch 'MDL-38487_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-05-09 00:54:54 +02:00
Tim Hunt d8da3c0f5b MDL-39446 calculated qtype: make answer formula input bigger
This makes it easier for teachers editing questions.
2013-05-02 15:47:54 +01:00
Tim Hunt c1288cd726 MDL-38487 qtype match restore: problem with blank ids.
As it happens, this field is useless, and has been removed from the DB
in 2.5. Therefore, we only need a work-around for stable branches.
2013-05-02 15:46:58 +01:00
Damyon Wiese 49b18efa4e Merge branch 'MDL-39342_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-04-29 15:36:09 +08:00
Tim Hunt 9a3d0206da MDL-37845 multichoice qtype: Fix some display issues.
1. Better handling of multi-line choices in the correct answer display.
2. Remove dangerous CSS that is no longer needed.
2013-04-25 17:21:11 +01:00
Jason Platts 261aae298b MDL-39342 stop users entering too long matching answers.
Since they lead to an ugly DB error.
2013-04-25 12:00:09 +01:00
Dan Poltawski ce024436be Merge branch 'MDL-39283_24' of git://github.com/jmvedrine/moodle into MOODLE_24_STABLE 2013-04-24 14:35:09 +01:00
Dan Poltawski 2a4eeac067 Merge branch 'MDL-37784_24' of git://github.com/jmvedrine/moodle into MOODLE_24_STABLE 2013-04-23 13:00:39 +01:00
Jean-Michel Vedrine c8fbd8b0c3 MDL-39283 GIFT and XML question export broken for unsupported qtypes
Do no write any data to the export for unsupported qtypes
2013-04-23 09:52:47 +02:00
Jean-Michel Vedrine 37eadb417b MDL-37784 Adaptive no penalty display wrong penalty info
Adaptive Mode tells students they have been penalized even when set to no penalties
2013-04-23 08:39:48 +02:00
Jean-Michel Vedrine 3b44cab37b MDL-39172 Import of .dat files is broken in blackboard_six import format 2013-04-18 17:48:08 +02:00
Jean-Michel Vedrine 50a9a7d498 MDL-38880 Imported Cloze questions lose embedded images or other media 2013-04-11 16:29:34 +02:00
Jean-Michel Vedrine 720b0f5eb0 MDL-19072 XHTML export for match questions fix for distractors 2013-04-09 11:02:27 +02:00
Eloy Lafuente (stronk7) 8bcca79594 Merge branch 'MDL-38490_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-03-20 00:43:43 +01:00