Commit Graph

69 Commits

Author SHA1 Message Date
Dan Poltawski e3559db951 MDL-38765 quiz: fix incorrect comment 2013-08-27 13:59:24 +08:00
Dan Poltawski 4c37aadb32 Merge branch 'MDL-38765_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE 2013-08-27 13:53:09 +08:00
Tim Hunt f08bce9a54 MDL-40996 & MDL-41162 quiz: fix html_writer::div use in 2.4. 2013-08-22 08:26:01 +12:00
Tim Hunt 6dc4e89073 MDL-38765 quiz view: fix duplicate message.
The "No more attempts are allowed" message was being shown twice. I
checked back, and it has been like that since before the quiz was
converted to use a renderer. Still, it looks horrible, so changing it.
2013-08-21 10:24:32 +01:00
Tim Hunt 8fbb62c9bc MDL-41162 quiz view page: invalid HTML.
We were sometimes outputting nested p tags. Change the outer one to a
div.
2013-08-15 12:41:31 +01:00
Tim Hunt 1d2247bed6 MDL-40996 quiz show user pic should also show name.
This was a regression introduced by MDL-20636 two years ago!
2013-08-08 09:57:57 +01:00
Tim Hunt c004ced96b MDL-40318 quiz intro comprising just an impage was not shown
Also, ensure that we don't output an empty box if there are no access
messages.
2013-07-04 12:34:21 +01:00
Frederic Massart c384744304 MDL-36638 usability: Core changes for new quiz/question icons 2012-11-29 12:41:29 +08:00
Dan Poltawski 939a43e426 Merge branch 'MDL-35717-quiz-attempt-checkstate' of git://github.com/mpetrowi/moodle
Conflicts:
	mod/quiz/tests/generator/lib.php
2012-11-26 12:07:04 +08:00
Tim Hunt e498f21421 MDL-30884 quiz: ARIA attribute for the coutdown timer. 2012-11-20 13:18:02 +00:00
Matt Petro 8e771aed93 MDL-35717 quiz: fix overdue attempt processing 2012-11-16 21:32:09 -05:00
Tim Hunt d869de66a6 MDL-34733 quiz 'secure' mode: finish review link broken in previews
This fix a small API change in mod_quiz_renderer::finish_review_link.
At least the required change is an improvement, since it gives the
renderer more flexibility.
2012-08-21 12:08:57 +01:00
Dan Poltawski 648c1ad194 Merge branch 'MDL-34187' of git://github.com/timhunt/moodle 2012-07-16 15:57:21 +08:00
Tim Hunt 2cdcb90553 MDL-34164 quiz reports: only try to show graphs if GD is installed.
if (empty($CFG->gdversion)) { seems to be the common idiom for this.
I refactored the graph output into the renderer, to avoid having to
duplicate that test three times.
2012-07-14 09:20:04 +01:00
Tim Hunt ddda79ca5f MDL-34257 quiz 'secure' window: does not close automatically. 2012-07-13 18:02:20 +01:00
Tim Hunt 9e83f3d11d MDL-32788 quiz: clean up codechecker issues before the 2.3 release. 2012-05-04 15:12:23 +01:00
Tim Hunt 96e5168c7e MDL-32740 / MDL-3030 quiz summary: no Return to attempt for overdue. 2012-05-03 12:16:43 +01:00
Tim Hunt b39b5d77c3 MDL-3030 quiz overdue handling: show attempt state on the review page. 2012-04-27 15:07:30 +01:00
Tim Hunt 2b2b645842 MDL-3030 quiz overdue handling: display message on the summary page.
This change also includes a clean-up of how we display and initialise the countdown timer.
2012-04-27 15:07:29 +01:00
Tim Hunt 2de9be52aa MDL-3030 quiz overdue handling: show attempt state on the view page 2012-04-27 15:07:27 +01:00
Charles Fulton 33c8d37b6f MDL-11047 quiz: enable sequential navigation 2012-03-15 10:09:27 -07:00
Tim Hunt ee664a16f2 MDL-31205 quiz 'secure' window: scrollbars missing.
Embarrassing type in the arguments to openpopup
2012-01-20 17:28:26 +00:00
Tim Hunt d89eb938fd MDL-31019 quiz secure mode. Fix typo that breaks submit. 2012-01-09 17:09:11 +00:00
Tim Hunt 9d5687893a MDL-30145 Quiz intro not displayed on the password page 2011-11-04 22:57:17 +00:00
Tim Hunt 987c2d491e MDL-29627 quiz access refactor password check into a generic check page. 2011-10-13 11:13:20 +01:00
Tim Hunt 0eafc98852 MDL-29627 fix code-checker issues throughout the quiz code. 2011-10-13 11:13:16 +01:00
Tim Hunt d755b0f577 MDL-29627 quiz_access_manager move all output code to the renderer.
This achieves a massive clean-up. It simplifies comples code in a number
of places. It allows some methods and functions to be moved to a more
appropriate home (for example cannot_review_message to the quiz class).
It moves more logic out of the renderer.
2011-10-13 11:13:12 +01:00
Tim Hunt babfb615c9 MDL-28424 Reviewing a quiz in 'secure mode' gives a fatal error.
The problem was when output was being started in relation to when the fake block was added.

Took the opportunity to clean up the quiz renderer API a bit.
2011-09-21 16:37:21 +01:00
Aparup Banerjee a1b744594c Merge branch 'MDL-29144' of git://github.com/timhunt/moodle 2011-08-29 12:10:30 +08:00
M Kassaei f28ef47e8f MDL-29144 quiz navigation: Screen-readers speak question state twice 2011-08-26 19:10:08 +01:00
Tim Hunt 918776f47d MDL-29111 quiz was passing 0 to ->review_url when it should have been null. 2011-08-26 18:21:43 +01:00
Eloy Lafuente (stronk7) 2ed28439f6 Merge branch 'MDL-28976' of git://github.com/timhunt/moodle 2011-08-24 12:57:16 +02:00
Tim Hunt a47a46f136 MDL-28996 Quiz view page list of attempts table is sometimes missing a cell. 2011-08-18 19:26:30 +01:00
Tim Hunt 45e5fbe11e MDL-28976 quiz was passing 0 to ->attempt_url when it should have been null.
There was also one other incorrect call that is fixed in this commit.
2011-08-18 14:00:30 +01:00
Tim Hunt 4e5b9e498e MDL-28338 fix stupid '\n's in the quiz renderer 2011-07-27 19:22:24 +01:00
Tim Hunt 8c4deb8003 MDL-28377 Call to mod_quiz_renderer is screwed up. 2011-07-25 09:14:44 +01:00
Tim Hunt 6c7da46108 MDL-26165 quiz submit are-you-sure is potentially confusing. 2011-07-06 14:49:38 +01:00
Tim Hunt da72991636 MDL-27979 Should be an edit link for each question when previewing or reviewing a quiz. 2011-06-22 21:07:40 +01:00
Eloy Lafuente (stronk7) aed0dbe70a Merge branch 'MDL-27942' of git://github.com/timhunt/moodle 2011-06-20 17:05:54 +02:00
Tim Hunt e28bbd8919 MDL-27942 Use picture not displayed during quiz attempts. 2011-06-20 10:26:01 +01:00
Sam Hemelryk 3fc7c06b99 Merge branch 'quiz_feedback_for_grade' of git://github.com/stronk7/moodle 2011-06-20 13:02:02 +08:00
Eloy Lafuente (stronk7) 1b327dec8a MDL-27932 quiz - fix some calls to quiz_feedback_for_grade() 2011-06-20 01:46:29 +02:00
Tim Hunt 3a5da40b4c MDL-27902 quiz reviewquestion.php page needs to be converted to use the renderer. 2011-06-17 15:27:41 +01:00
Tim Hunt adf7fe2148 MDL-27747 Missing information and errors on the quiz view page. #720 2011-06-07 16:05:17 +01:00
Tim Hunt 97cdc1de72 MDL-27747 quiz summary, add a CSS class to the table rows based on question state.
The standard themes do not use this for anything, but it makes it easier for themers to do cool stuff.
Also improve the API for getting the question state class.
2011-06-07 15:11:04 +01:00
Tim Hunt 2178cd3a12 MDL-20636 Dean's refactoring had broken the quiz summary page. 2011-05-19 17:52:52 +01:00
Tim Hunt a2ac234956 MDL-20636 Merge remote-tracking branch 'moodle/master' into upgrade
Conflicts:
	lib/filestorage/file_storage.php
	mod/quiz/attemptlib.php
	mod/quiz/lib.php
	mod/quiz/mod_form.php
	mod/quiz/report/overview/overview_table.php
	mod/quiz/report/overview/report.php
	mod/quiz/report/responses/report.php
	mod/quiz/report/responses/responses_table.php
	mod/quiz/report/statistics/db/install.xml
	mod/quiz/report/statistics/qstats.php
	mod/quiz/report/statistics/report.php
	mod/quiz/report/statistics/statistics_question_table.php
	mod/quiz/report/statistics/statistics_table.php
	mod/quiz/report/statistics/version.php
	mod/quiz/review.php
	mod/quiz/reviewquestion.php
	mod/quiz/startattempt.php
	mod/quiz/styles.css
	mod/quiz/view.php
	question/type/essay/questiontype.php
	question/type/match/backup/moodle2/backup_qtype_match_plugin.class.php
	question/type/match/backup/moodle2/restore_qtype_match_plugin.class.php
	question/type/numerical/display.html
	question/type/numerical/questiontype.php
	question/type/questiontype.php
	question/type/random/questiontype.php
	question/type/shortanswer/questiontype.php
	theme/base/style/question.css
2011-05-11 20:29:49 +01:00
Dean Lennard 0de4393945 MDL-20636 moved header creation into seperate funciton 2011-05-11 15:04:19 +01:00
Dean Lennard 8e8bd3f967 MDL-20636 Changed renderer function scopes so they can be overridden. 2011-05-11 15:04:13 +01:00
Dean Lennard 2c3e2b53e6 MDL-20636 Added phpDoc comments 2011-05-11 15:04:07 +01:00