Commit Graph

62 Commits

Author SHA1 Message Date
Damyon Wiese dc633a24b9 MDL-40759 fontawesome: lang strings comments 2017-03-21 11:13:43 +08:00
Damyon Wiese b9b409cfc3 MDL-40759 icons: Peer review fixes (all minor) 2017-03-17 15:52:46 +08:00
Damyon Wiese 8857c715d1 MDL-40759 icons: Behat fixes for font-awesome 2017-03-17 15:52:18 +08:00
Damyon Wiese 663640f5b3 MDL-40759 icons: convert uses of pix_url to pix_icon
Also change filepicker to use scaled svgs instead of sets of custom pngs. The svgs are taken from font-awesome.
2017-03-17 15:52:17 +08:00
Jake Dallimore 86f1d1bb86 MDL-35980 comment: add comment info to delete button for screen readers
For each delete button in the comments widget, make the spoken text a
string containing the name of the poster and the datetime.
2017-02-24 08:15:40 +08:00
Jake Dallimore bb80768558 MDL-35978 comments: fix for comments block which has no toggler 2017-01-31 11:24:42 +08:00
Jake Dallimore af65270e87 MDL-35978 comments: expandable comments announce change when toggled
Added role and aria-expanded attributes to the toggler link and added
a key handler for the space and enter keys.
2017-01-27 13:03:53 +08:00
Simey Lameze 1f8d39893f MDL-57125 comment: prevent js execution if there are no comments 2016-12-12 11:34:42 +08:00
David Mudrák 3e4f5e6591 MDL-47773 comment: Indicate comment being saved via AJAX
This should be considered as quick & dirty usability fix as the whole JS
should ideally be rewritten and this behaviour should use CSS classes.
2015-03-31 13:59:59 +02:00
Jetha Chan 71688853e0 MDL-23912 core_comment: update count after deletion 2014-11-25 12:29:07 +13:00
Damyon Wiese 31d861d19b MDL-35981 comments: Fix for keyboard control of "add a comment" 2013-08-05 09:49:38 +08:00
Damyon Wiese fe1c01e751 MDL-35981 comments: Add comment about keycodes for space and enter. 2013-08-02 11:42:45 +08:00
Damyon Wiese ba29e212cd MDL-35981 comments: Make delete comment keyboard accessible. 2013-08-02 11:42:44 +08:00
Andrew Robert Nicols 98e1ff5f9f MDL-37173 Stop attempting to set User-Agent from core JS
This leads to some browsers throwing warnings that it is unsafe to set the
User-Agent. It doesn't help us in any way particularly either.
2013-01-08 09:55:44 +00:00
Jason Fowler b815ccd319 MDL-35979 - Commenting - Adding an empty alt attribute to the javascript generated delete icon for comments 2012-12-05 10:00:38 +08:00
Eloy Lafuente (stronk7) 9986cd9013 NOBUG: Trivial whitespace fix to quickly fix ongoing CI status. 2012-11-07 11:49:56 +01:00
Nadav Kavalerchik 9fe40de660 MDL-35481 - Invert "search option" listbox "open" arrow, when in RTL mode (page: manual user course registration ) and Personal Blog page 2012-09-22 21:05:14 +03:00
Petr Škoda 3993f027db MDL-34741 use 2in3 in comments 2012-08-11 20:40:10 +02:00
Andrew Robert Nicols 088258c160 MDL-33186 Ensure that the comment textarea exists before toggling it 2012-05-22 11:24:24 +01:00
Rajesh Taneja 2d8732d199 MDL-30375 Blocks: Comments block will show blank textbox rather then hiding and 'add a comment' will be visible if it's empty 2011-11-23 10:32:14 +08:00
Dongsheng Cai c1951ea953 MDL-26854 COMMENT
1. added pluginname_comment_validate callback to comments api
2. change permission callback defaults to false
3. Tidied up serveal areas of comments and implemented callback to
ignore system permissions for view (credits to Sam Hemelryk)

AMOS BEGIN
    MOV [modulerejectcomment,error],[callbackrejectcomment,error]
AMOS END
2011-05-04 17:23:46 +08:00
Sam Hemelryk 99f2cd5435 comment MDL-27024 Removed last check within comment.js for block_comment env 2011-04-11 10:31:13 +08:00
Dongsheng Cai 7cb854fe60 MDL-25331, fixed comment javascript 2010-11-22 02:20:05 +00:00
Dongsheng Cai 034699d20a MDL-24657, fixed xhtml in comment 2010-10-14 03:21:31 +00:00
Dongsheng Cai df796bf0ec MDL-24540, fixed comments UI for not logged in users 2010-10-07 08:18:56 +00:00
Petr Skoda 7e3b826516 fixed unterminated JS statements 2010-09-17 11:56:18 +00:00
Dongsheng Cai 4ef81b6cd8 "MDL-23917, fixed arrows in comments" 2010-08-27 10:02:02 +00:00
Dongsheng Cai 9e9dd1a356 "NOBUG, change loading image, comment api" 2010-08-27 07:21:54 +00:00
Dongsheng Cai 7ade777c54 "MDL-23917, added component parameter to comment api" 2010-08-25 06:24:17 +00:00
Dongsheng Cai d37e440a7b "MDL-23917, fixed js error in comment block" 2010-08-25 06:05:02 +00:00
Dongsheng Cai 6b9be73729 "MDL-23915 fixed js error in comment" 2010-08-25 03:28:34 +00:00
Dongsheng Cai 4df53d1a23 MDL-23108, fixed fullname in nonjs comment block 2010-07-12 08:49:11 +00:00
Dongsheng Cai e13187157a "MDL-19118, fixed a javascript error" 2010-05-04 07:02:15 +00:00
Dongsheng Cai 63eee7b4b7 "MDL-19118, tweak comment ui" 2010-05-03 16:35:31 +00:00
Dongsheng Cai 7deb5107da MDL-19118, now comments overlay works without yui3 hacks 2010-04-12 06:19:47 +00:00
Dongsheng Cai b45fde0572 MDL-19118, fixed css selector, comments api 2010-04-08 05:40:11 +00:00
Dongsheng Cai 535b4a51c1 MDL-21941, change language strings for comments api 2010-04-08 01:53:48 +00:00
Dongsheng Cai 1150c1bdba MDL-21944, remve ### link target 2010-04-07 09:09:32 +00:00
Dongsheng Cai 4b201bc6f5 MDL-19118, comments api improvement 2010-04-07 06:42:17 +00:00
Dongsheng Cai 34e20eb422 "MDL-19118, improve comments management" 2010-03-31 09:53:05 +00:00
Dongsheng Cai 5aaa76eaef "MDL-21943, remove hardcoded css" 2010-03-30 09:18:34 +00:00
Dongsheng Cai 2057b5ef50 "MDL-21959, comments api, fixed javascript events" 2010-03-30 03:59:58 +00:00
Dongsheng Cai 3e34183a97 "MDL-19118, improve comments pagination" 2010-03-18 09:57:32 +00:00
Dongsheng Cai 7695110029 "MDL-19118, improve comments block" 2010-03-18 09:42:30 +00:00
Petr Skoda 2b728cb5e1 MDL-21420 finally moving old global mstr to new M.str. 2010-02-07 09:43:07 +00:00
Petr Skoda bdf693894f MDL-21400 fixed regression in chrome, safary etc. - it is not allowed to use reserved "delete" keyword as method name, fixed comment 2010-02-03 14:43:13 +00:00
Petr Skoda 38673bfe7e MDL-21400 fixed regression in chrome, safary etc. - it is not allowed to use reserved "delete" keyword as method name 2010-02-03 14:41:43 +00:00
Petr Skoda 4c508047eb MDL-21400 converting forms stuff to new M namespace and using standardised JS module coding style, fixed some regressions - for now works in FF only 2010-02-03 14:36:53 +00:00
Petr Skoda 384ab39a62 MDL-21503 eliminating global Y 2010-02-03 09:32:02 +00:00
Petr Skoda 3b01539ccc MDL-21400 global Y revisited, I really think it is better to pass it around properly, this could help a lot in future if we have multiple versions of YUI installed; reverted js_function_call() and added new js_init_call() instead which should be hopefully easier to use and in theory could replace all other $PAGE->requires->js_*; finished implemenetation of js_module() 2010-01-23 17:08:18 +00:00