Commit Graph

37 Commits

Author SHA1 Message Date
Mark Nelson e4d9eff640 MDL-61224 core_role: prevent short name from exceeding 100 chars 2018-01-16 18:14:42 +08:00
Andrew Hancox 64cd459648 MDL-50666 core: Rename allow_ACTION to core_role_set_ACTION_allowed 2017-12-19 13:53:23 +13:00
Andrew Hancox a63cd3e2ca MDL-50666 core: Add function get_viewable_roles to set role visibility 2017-12-19 13:53:23 +13:00
Andrew Nicols 5ded18d5a8 MDL-60031 admin: Move risk longtext to pix title 2017-09-06 10:23:48 +08:00
Damyon Wiese 663640f5b3 MDL-40759 icons: convert uses of pix_url to pix_icon
Also change filepicker to use scaled svgs instead of sets of custom pngs. The svgs are taken from font-awesome.
2017-03-17 15:52:17 +08:00
Jes Ackland-Snow e985a29cdf MDL-56581 Roles: Permissions override screen not inherited styling 2016-12-20 12:09:01 +00:00
Damyon Wiese 2f3f8e45da MDL-56657 admin: Style all admin/role pages for boost 2016-11-14 15:11:15 +08:00
Simey Lameze 2e1c739a28 MDL-56652 core_roles: Add BS4 styling to define roles form 2016-11-10 16:46:54 +08:00
Damyon Wiese a2d9a89f5a MDL-56149 permissions: Alignment of icons should not wrap
/admin/roles/permissions.php?contextid=2 the icons should not wrap.
2016-10-31 16:24:11 +08:00
Cameron Ball bb30944f49 MDL-54010 roles: Specify encoding for escaped export data 2016-05-26 10:31:28 +08:00
Nigel Cunningham d50a9a9d30 MDL-54010 roles: Fix missing HTMLspecialchars in role export code.
Role name and description fields are currently not escaped when
exporting a role. This results in an unusable file when characters
such as ampersands are used in a name or description. Fix this by
using htmlspecialchars on both fields.

Signed-off-by: Nigel Cunningham <nigelc@catalyst-au.net>
2016-05-26 10:31:28 +08:00
Simey Lameze 73ea963215 MDL-53010 core_role: add missing coursecatlib include 2016-02-29 14:25:45 +08:00
Rajesh Taneja 660b0f0eed MDL-50484 core_lib: No need to cache action_icons
action_icons should not be cached as they
have a unique id and if cache is used then
all icons will have same id.
Other solution is to replace id with some static
but it's not worth a cache for a page, so
removing cache
2016-02-19 14:00:04 +08:00
Dan Poltawski 8f2c99d610 MDL-52370 role: purge coursecontacts when role is edited
This is perhaps a bit more brutal purge than you'd like, but it only
affects coursecat role edits.
2015-12-01 13:14:14 +00:00
Marina Glancy 2ff1f05183 MDL-51357 roles: fix table layout after MDL-38763 2015-09-09 13:07:11 +08:00
Martin Mastny 2493568970 MDL-38763 core_role: AMD module for managing permissions 2015-09-01 07:31:58 +02:00
Marina Glancy 2bf60e22f7 MDL-50222 admin: do not use deprecated print_textarea() 2015-06-08 17:10:58 +08:00
Rod Norfor 2350e7f24d MDL-48914 admin: check maxuserperpage in existingroleholders->find_users 2015-01-23 16:02:27 +00:00
Tim Hunt 482ca72089 MDL-47426 assign local roles: rewrite query for better performance.
This is an extremely dangerous query, because it includes the user
table twice, along-side two other potentially large tables,
role_assignments and user_enrolments.

The solution is to rewrite the query so that:

1. The subquery is JOINed, not WHERE ... INed. Typically query
   optimisers handle the JOIN case better.

2. Before the join was role-assignments <-> users <-> subquery.
   That is, everything was linked to u.id.

   Now the linking is role-assignments <-> subquery <-> users,
   so the SELECT DISTINT eu1_u.id FROM {enrolled users} is central.
   That seems to send a strong hint to the query optimiser about
   a good order to execute the query.
2014-10-02 17:10:40 +01:00
Frederic Massart af2a1e4e33 MDL-45596 roles: Escape filter value before using it in form field 2014-07-04 11:49:11 +08:00
Petr Škoda 0aa535bf1d MDL-20045 add support for custom context levels 2013-08-31 11:47:44 +02:00
Petr Škoda 2f1e464a88 MDL-40438 migrate all collatorlib:: and textlib:: uses 2013-08-06 21:04:35 +02:00
Frederic Massart a439b2f9b4 MDL-40465 libraries: Deprecate fetch_context_capabilities() 2013-07-11 14:33:25 +08:00
Adrian Greeve 329846f198 MDL-40430 - Libraries: Deprecate print_context_name(). 2013-07-09 16:11:55 +08:00
Petr Škoda 1415127ebc MDL-40337 fix some more deprecated calls in role code 2013-06-27 22:41:14 +02:00
Petr Škoda 5089cca0b4 MDL-40337 use full frankenstyle in get_string() calls 2013-06-27 22:17:46 +02:00
Petr Škoda 07364397cd MDL-40337 fix remaining code checker troubles in admin/roles/* 2013-06-27 22:17:45 +02:00
Petr Škoda 72de139a6e MDL-40337 cleanup role permissions code 2013-06-27 22:17:45 +02:00
Petr Škoda d7797b7924 MDL-40337 cleanup role override code 2013-06-27 22:17:45 +02:00
Petr Škoda bb061951a0 MDL-40337 cleanup role definition code 2013-06-27 22:17:45 +02:00
Petr Škoda aac13d6728 MDL-40337 cleanup role assign pages 2013-06-27 22:17:45 +02:00
Petr Škoda 67ab75e521 MDL-40337 cleanup role allow pages 2013-06-27 22:17:45 +02:00
Petr Škoda d6c4544d63 MDL-40337 cleanup admin select UI 2013-06-27 22:17:44 +02:00
Petr Škoda bc7b53fb49 MDL-40337 use class loader for admin/roles/* 2013-06-27 22:17:44 +02:00
Petr Škoda 4dd680c74e MDL-17081 allow role reset to self
The use case is importing of incomplete XML preset - keep current + preset changes. This also discards any pending changes.
2013-06-25 15:15:46 +02:00
Petr Škoda fcd75b6e6d MDL-17081 store also CAP_INHERIT in role export files 2013-06-25 00:24:55 +02:00
Petr Škoda 5e72efd498 MDL-17081 add role export/import
This includes improved role creation, allowed roles are editable and other improvements.
2013-06-24 12:40:59 +02:00