Commit Graph

89847 Commits

Author SHA1 Message Date
Simey Lameze 15cd009097 MDL-61364 core_question: tests for question_has_capability_on exception 2018-03-28 08:54:11 +08:00
Andrew Nicols ca18d567d7 MDL-61364 question: Add unit tests for question_has_capability_on 2018-03-28 08:54:11 +08:00
Simey Lameze 13e2b19838 MDL-61364 core: remove param from question_has_capability_on calls 2018-03-28 08:53:41 +08:00
Rohith 0ef25faa73 MDL-61746 PARAM_CLEANHTML: Fix documentation typos 2018-03-27 23:40:11 +05:30
Simey Lameze 2cf7bde8e9 MDL-61364 question: adjust code and fix phpunit errors 2018-03-27 16:14:46 +08:00
Simey Lameze e7329cd026 MDL-61364 question: refactor question_has_capability_on 2018-03-27 16:14:44 +08:00
Adam Pawełczak 7ccb6bb3cc MDL-60762 tool_usertours: Respect $CFG->admin in manager.php 2018-03-27 15:18:03 +08:00
dinhloc f4695ec722 MDL-61033 quiz: Editing a quiz while a preview is open
Editing a quiz while a preview is open in another browser tab can leads to a cryptic error that is hard to recover from
2018-03-27 10:47:32 +07:00
David Monllao add8d846d9 MDL-53226 search_simpledb: Remove unnecessary object clone 2018-03-27 09:37:20 +08:00
Matteo Scaramuccia 1f8d943461 MDL-59596 ddl: Support MariaDB 10.2.4+ SQL_MODE new default value. 2018-03-26 23:12:36 +02:00
Matteo Scaramuccia f6b16e95a8 MDL-59596 ddl: Added has_breaking_change_sqlmode() 2018-03-26 23:12:36 +02:00
Kathrin Osswald ea91e4f97d MDL-61343 theme Boost: Harmonise the structure of flat navigation. 2018-03-26 09:46:56 +02:00
Jake Dallimore e315e84cf2 MDL-61691 core_plagiarism: fix namespace in privacy provider interface 2018-03-26 12:28:58 +08:00
Mihail Geshoski e91bc73f87 MDL-61257 reports: Report logs link to unavailable completion report 2018-03-26 12:22:00 +08:00
Nick Phillips 7d4f34cb0d MDL-55532 gradebook: fix grade export to include category names 2018-03-26 11:47:44 +08:00
Ryan Wyllie c53beb73e5 MDL-61364 question: unit tests for submit_tags_form 2018-03-26 11:27:47 +08:00
Simey Lameze e6890b1164 MDL-61364 question: add support for course tags on modal 2018-03-26 11:24:50 +08:00
Mihail Geshoski d609207c3e MDL-61724 resource: Unable to view or download file resource 2018-03-26 11:14:46 +08:00
Marina Glancy 1f0157e137 MDL-61328 tool_usertours: do not fix tour sortorder after step editing
otherwise it breaks when we try to modify the step sortorder
2018-03-26 09:52:14 +08:00
Shamim Rezaie 7c33ba471f MDL-61464 Questions: Add unit test for question tags backup and restore 2018-03-26 12:28:08 +11:00
Zig Tan ff70e84941 MDL-39060 backup: fix typo backup destroy() function 2018-03-26 09:25:55 +08:00
AMOS bot 9ef1dce6b9 Automatically generated installer lang files 2018-03-25 00:06:10 +00:00
David Mudrák 47ea60fd3e MDL-61741 enrol_paypal: Prevent some edge-case false errors
While testing the plugin in various scenarios, I've noticed that there
are two situations which the current code does not handle quite well:

* Detecting for existing txn_id record was likely to throw "found more
  than one record" debugging message. Fixed by explicitly ignoring
  multiple records.
* The incoming IPN verification message does not always contain the
  recipient's email in the "business" field. When a payment has to be
  claimed manually at PayPal (e.g. as a result of currencies mismatch
  and other settings), the email is coming only in the "receiver_email"
  field. This led to PHP notice and caused the script to fail falsely.
2018-03-23 19:50:26 +01:00
David Mudrák a38da470af MDL-61741 enrol_paypal: Fix the IPN verification endpoint URL
IPN protocol spec has different URL for sending the verification
request. Better to have it fixed even if the existing value still
seems to work - to avoid unexpected surprise in the future.

Source: https://developer.paypal.com/docs/classic/ipn/integration-guide/IPNImplementation/#specs
2018-03-23 19:16:30 +01:00
Arnaud Trouvé a15e507366 MDL-61248 admin: fix incorrectly initialized property 2018-03-23 16:25:36 +01:00
willem fa979cd4e1 MDL-61708 mod_lti: use fullnamedisplay to pass lis_person_name_full
Students 'firstname lastname' was passed to LTI Provider as 
lis_person_name_full. Now changed to use fullnamedisplay.
2018-03-23 13:07:36 +01:00
Martin Gauk db3da830c1 MDL-61733 atto_table: fix creating new table
If Atto is embedded in an HTML table (e.g. in the database activity
on the template pages), you could not create a new table.
2018-03-23 09:08:39 +00:00
Jun Pataleta d5458014b3 MDL-36941 core: Remove default for convhash field in upgrade.php 2018-03-23 14:14:49 +08:00
Jun Pataleta ba926805e2 Merge branch 'MDL-36941_master' of git://github.com/markn86/moodle 2018-03-23 12:55:49 +08:00
Mark Nelson 5aac33c785 MDL-36941 core_message: dont query DB unnecessarily checking read status 2018-03-23 12:30:31 +08:00
Mark Nelson 99248f6177 MDL-36941 core_message: fixed minor CiBoT complaints 2018-03-23 12:30:31 +08:00
Mark Nelson e159b53b5b MDL-36941 core_message: improved performance of helper::get_messages()
Improved the query to use the 'convhash' field as well as adding an index.

Also fixed issue where 'timeread' was hardcoded as 0.
2018-03-23 12:30:30 +08:00
Mark Nelson d0d1e97ab6 MDL-36941 core_message: added details to upgrade.txt 2018-03-23 12:30:30 +08:00
Mark Nelson 2ccbb8ed62 MDL-36941 core: added index to 'message_user_actions' table 2018-03-23 12:30:30 +08:00
Mark Nelson 74ad60bfbe MDL-36941 core_message: deprecated 'api::mark_all_read_for_user' 2018-03-23 12:30:30 +08:00
Mark Nelson 0d657cc9b7 MDL-36941 core: removed 'message_working' table 2018-03-23 12:30:29 +08:00
Mark Nelson 123631ad47 MDL-36941 message_popup: removed 'message_popup' table 2018-03-23 12:30:29 +08:00
Mark Nelson b2cd17e6a9 MDL-36941 core: added 'convhash' field to quickly get conversations 2018-03-23 12:30:28 +08:00
Mark Nelson 0d51ae7ef3 MDL-36941 core: final deprecation of functions
This was done earlier than the usual deprecation
process since we have changed the table structure.
It would take time to change the logic in these
functions, but as they have been deprecated for
some time it was decided to forego this effort.
2018-03-23 12:30:28 +08:00
Mark Nelson 3f3e453632 MDL-36941 message_popup: use new WS for marking notifications as read
Also changed the observer to listen for the notification_viewed event,
rather than the message_viewed event.
2018-03-23 12:30:28 +08:00
Mark Nelson 2b595d96f4 MDL-36941 core: added new mark notification as read webservice 2018-03-23 12:30:28 +08:00
Mark Nelson 376a79c242 MDL-36941 core: added events for notifications 2018-03-23 12:30:27 +08:00
Mark Nelson 548936a6c9 MDL-36941 core_message: mark notification/messages takes stdClass
This avoid unnecessary DB calls.
2018-03-23 12:30:27 +08:00
Mark Nelson 883ce42127 MDL-36941 core: convert existing api to use new table structure
Also deprecated the following functions -

1. message_move_userfrom_unread2read - It is not necessary
   for us to mark a message as read on user deletion.
2. message_get_blocked_users - Horrible logic used to
   determine if a user is blocked via reference on some
   randomly chosen 'isblocked' variable.
3. message_get_contacts - The same as above. This can be
   done in a much nicer way.
4. message_mark_message_read - We want two functions to do
   this to avoid confusing messages and notifications.
5. message_can_delete_message - This assumed the variable
   $message contained the 'useridto' property, which
   was present in the old table structure. We do not want
   future usages where a query is done on the new table
   and is simply passed as this won't contain this property.
6. message_delete_message - Same as above.
2018-03-23 12:30:27 +08:00
Shamim Rezaie 70ec79f1ba MDL-61464 Backup: Restore question tags into the correct context 2018-03-23 14:19:19 +11:00
Shamim Rezaie 06d7352a0a MDL-61464 Backup: Include contextid for questuin tags 2018-03-23 14:19:19 +11:00
Shamim Rezaie 6bbb7ed570 MDL-61464 Questions: Improved top level category handling in restore
Use question_get_top_category() instead of directly inserting into DB when
parent category is 0. This is to make sure we are not ending up with having
multiple top level question categories for a single context.
2018-03-23 14:19:19 +11:00
Mark Nelson 4cd439887a MDL-36941 core: alter events to use new table structure 2018-03-23 09:27:57 +08:00
Mark Nelson ee14412e21 MDL-36941 core_message: removed unit test that will always fail
We are changing how the API behaves so the old tables will never
be populated. This unit test is testing a deprecated function
which we will not be refactoring to use the new table structure.
2018-03-23 09:27:57 +08:00
Mark Nelson a63f98245c MDL-36941 core: added new messaging and notification tables 2018-03-23 09:27:56 +08:00