Commit Graph

3817 Commits

Author SHA1 Message Date
Dongsheng Cai d2b7803e5a MDL-30973 Files API, check and update DocBlock 2012-02-15 12:48:57 +08:00
Tim Hunt 03337d8bab MDL-47494 ddmarker: Add extra pluginname string to appease the plugins DB 2012-02-10 16:25:23 +00:00
Tim Hunt d8555d4a9f MDL-47494 ddmarker: Merge branch 'MOODLE_21_STABLE'
Conflicts:
	version.php
2012-02-10 16:22:23 +00:00
Tim Hunt 2a71bf53d2 MDL-47494 ddmarker: Clean up version.php and comments. 2012-02-10 16:20:14 +00:00
Tim Hunt eeb58297a6 MDL-47494 ddimageortext: Merge branch 'MOODLE_21_STABLE'
Conflicts:
	README.txt
	lang/en/qtype_ddimageortext.php
	version.php
2012-02-10 16:00:47 +00:00
Tim Hunt c109c9012e MDL-47494 ddimageortext: Fix version.php, and wrong qtype name in comments. 2012-02-10 15:52:42 +00:00
Michael Aherne 2af7d0d8d0 MDL-31495 Performance improvement in question engine upgrade SQL 2012-02-10 15:24:43 +00:00
Tim Hunt 90e64ecb4e MDL-47494 ddwtos: Merge branch 'MOODLE_21_STABLE'
Conflicts:
	lang/en/qtype_ddwtos.php
	version.php
2012-02-10 15:14:51 +00:00
Tim Hunt 12d0d76b90 MDL-47494 ddwtos: Update version.php 2012-02-10 15:13:02 +00:00
Tim Hunt 61809dfaaa MDL-47494 gapselect: Merge branch 'MOODLE_21_STABLE'
Conflicts:
	lang/en/qtype_gapselect.php
2012-02-10 14:46:42 +00:00
Tim Hunt 11f623878d MDL-47494 gapselect: Update version.php and readme. 2012-02-10 14:42:32 +00:00
Jamie Pratt 81b0d1a70f MDL-47494 ddimageortext: NOBUG adding an alt tag to drag and drop background image 2012-02-05 19:04:53 +07:00
Jamie Pratt 415893bb24 MDL-47494 ddmarker: Merge branch 'MOODLE_21_STABLE' 2012-02-05 18:44:23 +07:00
Jamie Pratt 612607d66c MDL-47494 ddmarker: NOBUG adding an alt tag to drag and drop background image 2012-02-05 18:43:31 +07:00
Jamie Pratt 8f042b5159 MDL-47494 ddwtos: Merge branch 'MOODLE_21_STABLE' 2012-02-05 14:12:19 +07:00
Jamie Pratt dce199af16 MDL-47494 ddwtos: NOBUG updating repo url in installation instructions 2012-02-05 14:10:43 +07:00
Jamie Pratt 266eade0cd MDL-47494 gapselect: Merge branch 'MOODLE_21_STABLE' 2012-02-05 12:57:56 +07:00
Jamie Pratt ce6bc6c673 MDL-47494 gapselect: NOBUG updating repo url in installation instructions 2012-02-05 12:57:05 +07:00
Jamie Pratt 6420d735b1 MDL-47494 ddmarker: Merge branch 'MOODLE_21_STABLE' 2012-02-05 12:56:06 +07:00
Jamie Pratt c710a1ebdb MDL-47494 ddmarker: NOBUG updating repo url in installation instructions 2012-02-05 12:51:40 +07:00
Jamie Pratt a9975ec074 MDL-47494 ddimageortext: NOBUG updating installations instruction with moodleou repo url 2012-02-05 12:38:16 +07:00
Jamie Pratt 5cf31e57d5 MDL-47494 ddimageortext: NOBUG updating installations instruction with moodleou repo url 2012-02-05 12:10:13 +07:00
Jamie Pratt 533a0aa2be MDL-47494 gapselect: Merge branch 'diff_2_2' changes for Moodle 2.2+
Conflicts:
	lang/en/qtype_gapselect.php
2012-02-04 18:27:11 +07:00
Jamie Pratt f37cb12ed0 MDL-47494 gapselect: NOBUG change to string identifiers 2012-02-04 18:20:46 +07:00
Jamie Pratt 801012aaaf MDL-47494 gapselect: NOBUG fixing unit tests related to change in default for hint format 2012-02-04 18:20:45 +07:00
Tim Hunt 7421dafa8f MDL-47494 ddmarker: Fix default text format when importing hints. 2012-02-03 19:18:13 +01:00
Tim Hunt 445143ef48 MDL-47494 ddmarker: Fix default text format when importing hints. 2012-02-03 19:14:11 +01:00
Jamie Pratt 3683ba61e7 MDL-47494 ddwtos: NOBUG change to string identifiers 2012-02-03 13:02:41 +07:00
Jamie Pratt 209d3e7ad5 MDL-47494 ddmarker: Merge branch 'MOODLE_21_STABLE' 2012-02-03 12:55:34 +07:00
Jamie Pratt bfd69fe659 MDL-47494 ddmarker: NOBUG updating README.txt installation instructions to include 2.1 branch 2012-02-03 12:54:22 +07:00
Eloy Lafuente (stronk7) ba353742ce Merge branch 'MDL-30854' of git://github.com/timhunt/moodle 2012-01-31 19:30:58 +01:00
Eloy Lafuente (stronk7) 7ce92ac1ad Merge branch 'MDL-30484' of git://github.com/timhunt/moodle 2012-01-31 17:16:04 +01:00
Jamie Pratt 9c6e2570be MDL-47494 ddmarker: NOBUG change to string identifiers 2012-01-31 18:00:59 +07:00
Jamie Pratt 77328c4143 MDL-47494 ddimageortext: NOBUG change to string identifiers 2012-01-31 18:00:04 +07:00
Jamie Pratt bb6427e31d MDL-47494 ddwtos: NOBUG change in dependency code for qtypes 2012-01-31 17:04:12 +07:00
Jamie Pratt 1f92921f6f MDL-47494 ddimageortext: NOBUG change in dependency code in qtypes 2012-01-31 16:59:04 +07:00
Jamie Pratt 4dafd7aa56 MDL-47494 ddmarker: NOBUG change in dependency code for qtypes 2012-01-31 16:43:00 +07:00
Jamie Pratt d82d9b649f MDL-47494 ddimageortext: Merge branch 'MOODLE_21_STABLE' of github.com:jamiepratt/moodle-qtype_ddimageortext into MOODLE_21_STABLE 2012-01-31 16:23:11 +07:00
Jamie Pratt 9a94582b0a MDL-47494 ddimageortext: NOBUG requires the gapselect question type to be installed 2012-01-31 16:15:31 +07:00
Tim Hunt 94815ccfa0 MDL-30484 question engine: don't lose response files when regrading.
The problem was mostly that, in the past, we did not worry if
question_attempt_step.id changed during regrade (because we deleted the
old step row and inserted a new one). However, now that steps can have
associated files, we can't be that slack, becuase the step id is used as
the file itemid.

So, now, we have to update the existing rows during a regrade. We do
this by having the question engine tell the question_engine_unit_of_work
that the step has first been deleted, and then added back. Then we make
the unit-of-work spot that delete + add = update.

This also means that during regrading, we have to pass around some extra
ids so that new steps know the id of the step they are replacing.

Naturally, this requires some quite trickly logic, so I finally got
around to writing unit tests for question_engine_unit_of_work, which is
a good thing.

Along the way I also got around to renaming
question_attempt->set_number_in_usage, which got missed out when
everthing else was renamed to slot ages ago.

Finally, while working on this code, I noticed and fixed some PHPdoc
comments.
2012-01-30 16:57:23 +00:00
Jamie Pratt 551fdcc830 MDL-47494 ddmarker: NOBUG fixing unit tests in testwalkthrough.php 2012-01-30 21:00:04 +07:00
Tim Hunt 72553162ba MDL-30854 quiz/question editing: fix create calc question & add on page.
This was one of those innocent seeming issues where, once you start
digging, you find a mess. In this case, the code that is now in
question_wizard_form::add_hidden_fields used to exist in four different
places, in four inconsistent versions. This is now all nicely
re-factored, and that solves the problem.

Along the way, I found and fixed some wrong string references in
qtype_random, and stripped out some unnecessary &s in function
declarations.
2012-01-30 12:32:12 +00:00
Aparup Banerjee fd174542e3 Merge branch 'MDL-31392' of git://github.com/timhunt/moodle 2012-01-30 14:24:31 +08:00
Jamie Pratt 389c6f5589 MDL-47494 ddmarker: NOBUG fixing testquestion.php unit tests 2012-01-29 17:23:01 +07:00
Jamie Pratt 317caf1150 MDL-47494 ddmarker: NOBUG fixing potential issue with use of core php array_intersect func 2012-01-29 15:14:02 +07:00
Jamie Pratt cf25df7a30 MDL-47494 ddmarker: NOBUG fixing obvious typo and redundant logic test. 2012-01-29 15:11:33 +07:00
Tim Hunt 6401b3c5bb MDL-31392 qeupgradehelper partial upgrade support broken since 2.2 2012-01-26 16:31:44 +00:00
Jamie Pratt 1cae63adf7 MDL-47494 ddmarker: NOBUG making polygon::is_point_in_shape more robust 2012-01-26 18:00:45 +07:00
Jamie Pratt 0aa089c778 MDL-47494 ddmarker: NOBUG return null for random_guess_score as it is incalculable
there are no shown drop zones and we don't know how many drag items have to be
dragged to the image. We could do the complicated calculation to find the area
of a polygon and compare it to the area of the image but it is an overly
complex a calculation I feel outside the scope of the current project.
2012-01-26 17:00:10 +07:00
Eloy Lafuente (stronk7) 2def471913 Merge branch 'MDL-30120' of git://github.com/timhunt/moodle 2012-01-25 00:47:10 +01:00