Commit Graph

20348 Commits

Author SHA1 Message Date
Marina Glancy 23e5104ae2 MDL-58666 course: add module name to cache
without it there will be an extra db read in get_array_of_activities() to retrieve it for each activity
2017-04-21 13:00:28 +08:00
Ryan Wyllie fa16d7fb8c MDL-58349 mod_assign: text wrap for comment search while grading 2017-04-21 04:58:14 +00:00
Jake Dallimore dd9c469ffc Merge branch 'MDL-58613-master-workshopfullname' of git://github.com/mudrd8mz/moodle 2017-04-21 10:26:00 +08:00
Marina Glancy aef1e7f500 MDL-57457 mod_book: Chapters are not userdata plus some improvements 2017-04-21 10:06:09 +08:00
Andrew Hancox 0e8c334eb5 MDL-57457 mod_book: Fix bug with edit form when tagging disabled 2017-04-21 10:06:08 +08:00
Andrew Hancox 4282634fcd MDL-57457 mod_book: performance improvement for tags backup/restore 2017-04-21 10:06:08 +08:00
Andrew Hancox 0178314682 MDL-57457 mod_book: Implement tagging 2017-04-21 10:06:08 +08:00
Jun Pataleta c1e917844c Merge branch 'MDL-58415-master' of git://github.com/jleyva/moodle 2017-04-20 16:11:31 +08:00
Juan Leyva d96d72955e MDL-58415 mod_lesson: Fix code styles and missing declaration
Found by the integrator review:
- Some incorrect code style declaration and phpdocs
- Missing $USER declaration
- Incorrect use of $lesson (should be $this)
2017-04-20 09:58:48 +02:00
Juan Leyva 9c543014a2 MDL-58415 mod_lesson: Add missing answer fields
There were a couple of fields missing when returning the complete
answer information required for offline usage.
2017-04-20 09:58:47 +02:00
Juan Leyva dd60892155 MDL-58415 mod_lesson: EOL var must be always numeric
Otherwise it will break the Web Service return description.
2017-04-20 09:58:47 +02:00
Juan Leyva f1cdd978aa MDL-58415 mod_lesson: Out of time should be a string
process_eol_page expects a string, right now we are passing a boolean.
We should convert it to the correct string when is set to true, that is
‘normal’
2017-04-20 09:58:46 +02:00
Juan Leyva a33c0e30eb MDL-58415 mod_lesson: Return always allowofflineattempts
We need this field always to be able to display if the lesson is
available or not for download
2017-04-20 09:58:46 +02:00
Juan Leyva 0fc1f24b12 MDL-58415 mod_lesson: Handle correctly review mode 2017-04-20 09:58:45 +02:00
Juan Leyva 0259109fb5 MDL-58415 mod_lesson: Avoid API http redirections
Deep in the lesson API there are some http redirections in special
pages like clusters.
We need to handle it via new parameters to avoid redirections.
2017-04-20 09:58:44 +02:00
Juan Leyva 16ca026c4b MDL-58415 mod_lesson: Force int type for calculated progress
Under some circumstances the value returned by the function needs
casting.
2017-04-20 09:58:44 +02:00
Andrew Nicols e44400ceca Merge branch 'MDL-58494-master' of git://github.com/ryanwyllie/moodle 2017-04-20 15:23:50 +08:00
David Monllao 626b05c09c Merge branch 'MDL-58349-master' of git://github.com/damyon/moodle 2017-04-20 15:17:59 +08:00
Dan Poltawski cdfcfb1f8c Merge branch 'MDL-58498-master' of git://github.com/ryanwyllie/moodle 2017-04-20 07:44:56 +01:00
David Monllao ba1ad89e7d Merge branch 'MDL-58278-master' of git://github.com/damyon/moodle 2017-04-20 14:05:39 +08:00
Ryan Wyllie 55e55a773f MDL-58494 mod_feedback: no action after feedback submitted
Don't provide an action in the action event callback if the user has
already submitted their feedback or if they don't have permission to
submit.
2017-04-20 05:51:32 +00:00
Andrew Nicols 6f9f15d1ad MDL-58515 2017-04-20 13:47:21 +08:00
Andrew Nicols 9517ea662d Merge branch 'MDL-58515-master' of https://github.com/lucisgit/moodle 2017-04-20 13:03:34 +08:00
David Monllao f60404b5ca MDL-57456 mod_glossary: Proper course access in behat test 2017-04-20 12:32:05 +08:00
Damyon Wiese f2a6b9cac9 MDL-58278 mod_assign: Ignore send notify with mw
When marking workflow is on and the grade is not released we never send notifications anyway.
Instead of preventing the grading form from submitting (validation error) we silently ignore it.
2017-04-20 11:43:34 +08:00
Jake Dallimore d8f9177462 Merge branch 'MDL-58412-master' of git://github.com/jleyva/moodle 2017-04-20 09:56:10 +08:00
Juan Leyva 78681d03b0 MDL-58431 mod_lesson: Fix error in random jumps on first visit
Random jumps to content pages were not working when they were set in
the first page.
This was caused because the page where the jump was, was not being
marked as visited before calculating the jump.
2017-04-19 17:47:21 +02:00
Juan Leyva bcd6249d53 MDL-58628 mod_quiz: Return missing fields in get_quizzes_by_courses
These fields must be returned always (even if the quiz is closed).
Those fields are required to display data to users that, for example,
finished a timed quiz.
2017-04-19 16:12:09 +02:00
David Mudrák 7fc7377082 MDL-58613 workshop: Provide all data to display user name
Additional fields such as middlename, alternatename and others were not
passed to the fullname(), causing a debugging message.
2017-04-19 13:43:21 +02:00
Juan Leyva cadae8dce6 MDL-58412 mod_feedback: Use constant for anonymous feedback
We were using hardcoded values instead the correct constant
FEEDBACK_ANONYMOUS_NO
2017-04-19 11:37:15 +02:00
Jun Pataleta f03d9b1946 Merge branch 'MDL-58642-master' of git://github.com/lameze/moodle 2017-04-19 16:20:21 +08:00
David Monllao a61fe737d4 MDL-57456 glossary: Refine patch changes 2017-04-19 15:44:45 +08:00
David Monllao c2118c8902 Merge branch 'wip-MDL-57456-master' of git://github.com/marinaglancy/moodle 2017-04-19 15:42:29 +08:00
Simey Lameze 5252d2835f MDL-58642 mod_glossary: add mapping for minus icon 2017-04-19 15:01:28 +08:00
Andrew Nicols 442908a100 Merge branch 'MDL-58138-master-v2' of git://github.com/snake/moodle 2017-04-19 11:53:40 +08:00
Jake Dallimore 273d310601 MDL-58138 completion: Fixes for a number of small issues. 2017-04-19 11:41:57 +08:00
David Monllao ac0553aa64 Merge branch 'MDL-54901' of git://github.com/stronk7/moodle 2017-04-19 11:30:03 +08:00
Marina Glancy 32b93ea7f8 MDL-58138 completion: changes after rebasing
The defaults for the completion have been changed in MDL-55611
2017-04-19 08:56:11 +08:00
Marina Glancy 61167c16d0 MDL-58460 mod_data: work with bulk completion API
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Jake Dallimore d233adbb77 MDL-58460 completion: add callbacks to mod_data for bulk completion
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Jake Dallimore 8db355c58f MDL-58138 tests: unit and behat tests covering bulk and default tabs
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Marina Glancy 7f53e8aa22 MDL-58267 completion: allow to set default activity completion
Part of MDL-58138 epic
2017-04-19 08:54:35 +08:00
Marina Glancy 06cdda468a MDL-58139 completion: bulk update completion
Part of MDL-58138 epic
2017-04-19 08:52:57 +08:00
Jake Dallimore b54bcddda4 MDL-58190 completion: callbacks to get completion rule descriptions
- Activities can have their custom completion rules added to cm_info
through the get_coursemodule_info callback.
- Descriptions of a modules active completion rules can be fetched using
the component callback mod_xxx_get_completion_active_rule_descriptions
which takes in a cm_info object and returns an array of strings.

Part of MDL-58138 epic
2017-04-19 08:52:57 +08:00
Dan Poltawski 9c1889810a Merge branch 'wip-MDL-58502-master' of git://github.com/marinaglancy/moodle 2017-04-18 19:48:35 +01:00
Dan Poltawski c4642d14a7 Merge branch 'MDL-58463-master' of git://github.com/junpataleta/moodle 2017-04-18 18:53:51 +01:00
David Mudrák b45193ca12 MDL-51932 workshop: Improve UX for teachers on switching workshop phases
The icon itself has been found insufficient, teachers did not realize it
was used to switch the phase. Its semantics is even less intuitive in
Boost when we do not show it on course outline any more.

So this patch starts to display the information that has been present
for assistive technologies only. As a side effect, I spotted there was a
bug that caused the id attribute "mod_workshop-userplancurrenttasks"
was used for all titles (not only the current one) so it did not
really serve the purpose well.
2017-04-18 18:00:59 +02:00
Dan Poltawski c7b7d67295 Merge branch 'MDL-58374-master-ltierrorlog' of git://github.com/mudrd8mz/moodle 2017-04-18 16:46:12 +01:00
Dan Poltawski 06fcba4bd9 Merge branch 'MDL-58603-master' of git://github.com/ankitagarwal/moodle 2017-04-18 16:45:09 +01:00
Ankit Agarwal 82db704eb0 MDL-58603 glossary: Fix fontawesome api name 2017-04-18 11:58:30 +05:30