Commit Graph

331 Commits

Author SHA1 Message Date
Christian Lawson-Perfect 7dcbe6a983 MDL-61355 SCORM: fix correct_response prefix check
The regexes to detect the optional prefixes at the start of some
interaction types are constructed to optionally match the prefix, so we
need to ensure that the matched group is really there when trying to
strip it from the given value in CRCheckValueNodes.

also remove "check for prefix" from CRcheckValueNodes

prefixes on correct responses patterns are removed in the section above
by CRremovePrefixes, so this block was redundant.
The `.pre` property for each correct_response is not used anywhere
else, so this removes their definitions too.
2018-07-12 10:44:30 +12:00
willem 9376f7d68e MDL-61709 mod_scorm: use student fullname when not in standards mode
Changed the scorm12standard setting for SCORM 1.2 in a more generic
'use SCORM Standards' setting. New setting is off by default.

The student name passed into the module is formatted as
$USER->lastname .', '. $USER->firstname and thus ignores the
fullnamedisplay. This is per SCORM1.2 standards. If setting
'use SCORM Standards' is disabled fullname will be used instead.
2018-04-07 09:14:22 +02:00
Andrew Nicols 7a2121d7f2 Merge branch 'wip-MDL-57785-master' of git://github.com/amygroshek/moodle 2017-01-31 12:19:13 +08:00
Amy Groshek c178ba7275 MDL-57785 scorm: Prevents SCORM nav refresh when nav not shown.
This improvement prevents refresh of SCORM 1.2 navigation menu
when the navigation menu is not displayed.
2017-01-27 09:11:16 -06:00
Dan Marsden e62e8545dc MDL-56808 scorm: remove some eval function that aren't needed. 2017-01-26 09:56:29 +13:00
David Monllao 9afc02742b Merge branch 'master_MDL-49557' of git://github.com/danmarsden/moodle 2017-01-04 11:34:00 +00:00
Dan Marsden e68cdceee3 MDL-49557 mod_scorm: optionally strip quotes. 2017-01-04 15:43:46 +13:00
Dan Poltawski 00e741af48 Merge branch 'master_MDL-49557' of git://github.com/danmarsden/moodle 2017-01-02 12:35:11 +00:00
Dan Marsden 63c2ea5038 MDL-52168 mod_scorm: Fix issue when scorm does not define org. 2016-12-28 10:54:49 +13:00
Dan Marsden 39eee56fa6 MDL-49557 mod_scorm: fix AICC pre-requisite handling. 2016-12-23 12:21:53 +13:00
Davo Smith 3bc7382d10 MDL-55057 mod_scorm: fix handling of SCO identifiers with apostrophes 2016-06-29 08:44:24 +01:00
Willem Roes 96f56b6e29 MDL-52646 mod_scorm: fix missing launch_data for SCORM 2004 2016-03-21 09:00:50 +01:00
Dan Marsden 3e28364257 MDL-50620 mod_scorm: Add Mastery score override setting
Thanks to Nathan Lewis for the initial patch
2016-02-10 09:20:25 +13:00
Dan Marsden 2e6c821d35 MDL-50972 mod_scorm: set autocommit as boolean
var currently passed as string so not evaluated correctly
2015-12-14 14:26:24 +13:00
Tony Levi 72af939f6e MDL-51757 mod_scorm: Remove duplicate function param
convert invalid break calls to exceptions for PHP 7
2015-11-25 14:06:02 +13:00
Dan Marsden ef88aa2938 MDL-46805 SCORM: AICC restricts allowed characters in the username 2015-03-31 10:38:16 +13:00
Dan Poltawski dab0d47632 Merge branch 'master_MDL-49303' of https://github.com/danmarsden/moodle 2015-03-02 16:57:52 +00:00
Dan Marsden 5e437bc0c0 MDL-49303 mod_scorm: Initialise student preferences on re-entry. 2015-02-26 20:36:48 +13:00
Dan Marsden a544661398 MDL-46408 mod_scorm: check param is set before using.
The default org is only set if it exists in the imsmanifest.xml
2015-02-20 14:41:07 +13:00
Ray Morris 9f56cc3794 MDL-47902 mod_scorm: Inappropriate default values for SCORM 1.3 variables 2014-10-27 15:06:42 -05:00
Ray Morris f893cb44e0 MDL-46669 mod_scorm: Extraneous quotes added to scorm API values 2014-08-18 16:20:42 +08:00
nobelium 15838edb63 MDL-45887 mod_scorm : Fixing variable names 2014-08-17 22:15:04 +12:00
nobelium 4cb25b3605 MDL-45887 mod_scorm : Fixing coding standard violations 2014-08-17 22:15:04 +12:00
Nobelium 6a6709ec51 MDL-37401 mod_scorm : autocommit for scorm 2014-08-09 22:06:54 +00:00
Nobelium bf4f65fbb6 MDL-46397 mod_scorm : binding cmi values with scoid 2014-07-28 05:37:21 +00:00
Eloy Lafuente (stronk7) c5e0735569 Merge branch 'MDL-35870' of git://github.com/nobelium/moodle 2014-07-15 18:30:29 +02:00
Nobelium 76c8fa4190 MDL-35870 mod_scorm : fix for debug.js.php not found error 2014-07-15 16:05:40 +00:00
Eloy Lafuente (stronk7) 714b25d07d MDL-35870 mod_scorm : whitespace fixes 2014-07-15 01:41:07 +02:00
Nobelium ad88d3ed2a MDL-35870 mod_scorm : Adding phpdocs for new functions
get_scorm_default in scorm_12lib.php
get_scorm_default in scorm_13lib.php
get_scorm_default in aicclib.php
scorm_isset in locallib.php
scorm_empty in locallib.php
2014-07-10 15:40:39 +00:00
Nobelium 3ad5eeedcf MDL-35870 mod_scorm : Removing loaddatamodel.php 2014-07-10 14:17:32 +00:00
Nobelium 7b9036be25 MDL-35870 mod_scorm : Initializing scorm API using js_init_call 2014-07-08 11:22:37 +00:00
Nobelium 93ca0d54c0 MDL-35870 mod_scorm : Prevents scorm API reload 2014-07-08 11:22:37 +00:00
Nobelium 139f32c218 MDL-35870 mod_scorm : Separating js and php files 2014-07-08 11:22:36 +00:00
Nobelium e3528983f2 MDL-41476 scorm settings- SCORM1.2 standard mode and CMIString length
Adding SCORM 1.2 standard mode checkbox in scorm admin panel. By default it will be enabled
(i.e: config name = `scorm12standard`, plugin name = `scorm`, value = `1`)
If `scorm12standard` is `1` CMIString256 is of length 256 and CMIString4096 is of length is 4096
if `scorm12standard` is `0` CMIString256 and CMIString4096 are of length is 64000
2014-04-07 14:07:48 +08:00
Dan Marsden e067e6f0ad MDL-44753 SCORM: make correct selection of first sco - also fixes MDL-44896 2014-04-02 20:50:21 +13:00
Dan Marsden 02bff1ad82 MDL-43541 SCORM: set first launchable sco correctly. 2014-02-17 19:56:40 +13:00
Dan Marsden 0d7eb69164 MDL-41695 SCORM: allow unlimited decimal places in CMIDecimal 2013-11-18 10:27:10 +13:00
Mayank Gupta df5c7086c8 MDL-39910 mod_scorm: rewrite SCORM code in YUI3, use responsive grids, add new nav setting; squashing commits 2013-09-20 22:45:36 +12:00
Dan Marsden b33e466550 MDL-41434 SCORM: add new sortorder field to allow better ordering of scos 2013-09-16 10:11:16 +12:00
Damyon Wiese 74df2951d1 Revert "MDL-39876 Change get_record('course') calls to get_course"
This reverts commit ab7632b74c.
2013-08-21 13:42:30 +08:00
Sam Hemelryk 6eee89bc8f Merge branch 'MDL-39876-master' of git://github.com/sammarshallou/moodle
Conflicts:
	course/lib.php
2013-08-21 12:08:46 +12:00
Matteo Scaramuccia 9d507f1d70 MDL-37393 SCORM: Fixed PHP Strict Standards errors with AICC packages 2013-08-16 09:28:41 +12:00
Dan Marsden d4978e044e MDL-37393 SCORM: Fix existing AICC scoes to use correct parent/child relationships
also fix bad version used by patch in MDL-39239
2013-08-16 09:28:40 +12:00
sam marshall ab7632b74c MDL-39876 Change get_record('course') calls to get_course 2013-08-15 11:31:20 +01:00
Mayank Gupta 0264b3eaac MDL-40773 mod_scorm: convert yui2 -> yui3 2013-08-09 13:10:39 +12:00
Ankit Agarwal d8d0b8b390 MDL-39363 scorm: Accept 0 as a valid score 2013-04-29 16:53:15 +08:00
Matteo Scaramuccia 5ecd13bc66 MDL-38678 SCORM: Runtime Environment (RTE) checks not required in case of SCO Assets 2013-04-11 22:44:29 +02:00
Dan Poltawski c39896e85d Revert "MDL-38678 SCORM: Runtime Environment (RTE) checks not required in case of SCO Assets"
This reverts commit fe104762c9.
2013-04-05 14:34:07 +08:00
Dan Poltawski 369496c31e Merge branch 'm25_MDL-38678_SCORM_RTE_not_required_for_SCO_Assets' of https://github.com/scara/moodle 2013-04-03 17:22:38 +08:00
Matteo Scaramuccia fd10686843 MDL-38745 SCORM: fixed appending 'API logging is on|off', once per launch 2013-03-28 22:28:06 +01:00