Commit Graph

101 Commits

Author SHA1 Message Date
Frédéric Massart 9f6296e5de MDL-61862 mod_feedback: Implement core_privacy API 2018-04-16 18:45:27 +08:00
Ryan Wyllie e236dc1446 MDL-60858 feedback: update behat tests for lang string change 2017-12-13 05:07:19 +00:00
Eloy Lafuente (stronk7) 7ec475e2d7 MDL-59159 upgrade: remove unused functions/settings from upgradelib
All these functions were used only by deleted upgrade steps
so it's safe to proceed with straight deletion, considering
them internal. Deletion has been documented in corresponding
upgrade.txt files:

- mod_feedback_upgrade_delete_duplicate_values()
- mod_feedback_upgrade_courseid()

These have been kept because they continue being used:

- @ install: make_competence_scale()
- @ restore: upgrade_course_letter_boundary()
2017-12-04 01:42:01 +01:00
Andrew Nicols 03561ea899 Merge branch 'MDL-60062-master-2' of git://github.com/ryanwyllie/moodle 2017-11-07 13:49:47 +08:00
Ryan Wyllie 478b1d194f MDL-60062 calendar: remove validate_event_timestart callback 2017-11-07 01:25:33 +00:00
Eloy Lafuente (stronk7) 796e48a58b MDL-60611 phpunit: remove deprecated stuff and other minor fixes
Thanks @scara for MDL-60611 phpunit: improved redis skipping reasons
2017-11-05 01:45:04 +01:00
Ryan Wyllie 83d4635d99 MDL-60063 feedback: add drag and drop of open close events 2017-10-17 03:54:24 +00:00
Ryan Wyllie f2c3818b39 MDL-60063 feedback: show feedback events on calendar for teacher 2017-10-17 03:54:23 +00:00
Andrew Nicols 77c5325f81 Merge branch 'MDL-9367-master' of git://github.com/ankitagarwal/moodle 2017-08-01 13:39:38 +08:00
Ankit Agarwal 0d14fcbc60 MDL-9367 restore: Roll only configuration dates
It was decided to roll only configuration dates and any date related to user content
such as 'timecreated' , 'timemodified' etc should not be rolled forward.
2017-08-01 10:46:37 +05:30
Mark Nielsen 197e2bca5b MDL-59602 behat: make use of new course nav steps 2017-07-21 13:50:47 -07:00
Eloy Lafuente (stronk7) 1d52027e57 MDL-59534 feedback: avoid some randomness with behat test failures 2017-07-13 20:08:33 +02:00
Eloy Lafuente (stronk7) da60573291 MDL-58772 behat: change step to 3.2 and up alternative 2017-05-05 00:14:31 +02:00
Dan Poltawski c201e4df40 Merge branch 'MDL-58772' of git://github.com/aolley/moodle 2017-05-03 16:50:29 +01:00
Adam Olley 0fb1335924 MDL-58772 mod_feedback: Dont overwrite anonymous entries
The feedback module lets you alternate between responses being anonymised and
not anonymised. When the module is in anonymous mode, its possible for a single
user to make multiple responses.

However when the activity is switched to non-anon mode, if a user leaves a
follow up feedback, one of their previously anonymous responses is used, so
their new response stays anonymous and their old anon response is lost.

This change lets them leave a new non-anonymised feedback entry and retains all
previous anonymous responses instead of incorrectly reusing one of their anon
ones at random.
2017-05-02 12:49:33 +09:30
Marina Glancy aa708b550e MDL-58665 mod_feedback: avoid extra db queries on dashboard 2017-05-01 12:57:19 +08:00
Andrew Nicols e44400ceca Merge branch 'MDL-58494-master' of git://github.com/ryanwyllie/moodle 2017-04-20 15:23:50 +08:00
Ryan Wyllie 55e55a773f MDL-58494 mod_feedback: no action after feedback submitted
Don't provide an action in the action event callback if the user has
already submitted their feedback or if they don't have permission to
submit.
2017-04-20 05:51:32 +00:00
Jake Dallimore d8f9177462 Merge branch 'MDL-58412-master' of git://github.com/jleyva/moodle 2017-04-20 09:56:10 +08:00
Juan Leyva cadae8dce6 MDL-58412 mod_feedback: Use constant for anonymous feedback
We were using hardcoded values instead the correct constant
FEEDBACK_ANONYMOUS_NO
2017-04-19 11:37:15 +02:00
Jake Dallimore 8db355c58f MDL-58138 tests: unit and behat tests covering bulk and default tabs
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Eloy Lafuente (stronk7) ad02561c15 Merge branch 'MDL-58453-master' of git://github.com/jleyva/moodle 2017-04-11 16:47:29 +02:00
Juan Leyva 7f700290b2 MDL-58453 mod_feedback: Add missing security checks
Some checks done in mod/feedback/show_nonrespondents.php were missing.
- Check for anonymous feedback
- Check for real courses (not site home)
2017-04-11 09:42:27 +01:00
David Monllao af938cf46e Merge branch 'wip-MDL-56370-master' of git://github.com/marinaglancy/moodle 2017-04-10 13:13:20 +02:00
Andrew Nicols b140b13c25 Merge branch 'MDL-58453-master' of git://github.com/jleyva/moodle 2017-04-10 11:23:37 +08:00
Marina Glancy 85b969f130 MDL-56370 mod_feedback: behat for repeat completion 2017-04-07 16:04:06 +08:00
Juan Leyva 94478c083d MDL-57813 mod_feedback: New WS mod_feedback_get_last_completed 2017-04-06 09:40:26 +02:00
Juan Leyva 682aea9b84 MDL-58453 mod_feedback: Refactor get_non_respondents WS
We should return more information like if the user started or not the
feedback and the total number of non respondents (to be able to
paginate).
2017-04-05 09:28:29 +02:00
Jun Pataleta 458315f857 Merge branch 'MDL-57821-master' of git://github.com/jleyva/moodle 2017-04-05 09:39:02 +08:00
Mark Nelson e1cd93ce20 MDL-58423 core_calendar: moved \core_calendar\event class
Part of MDL-55611 epic.
2017-04-04 11:01:49 +01:00
Juan Leyva a24289f12f MDL-57821 mod_feedback: New WS mod_feedback_get_responses_analysis 2017-04-04 12:01:23 +02:00
Andrew Nicols b375ec262d MDL-58363 mod_feedback: Remove calendar is_visible
Part of MDL-55611 epic.
2017-04-03 11:37:09 +08:00
Simey Lameze 07d1abe346 MDL-58265 mod_feedback: change custom step to link behat to course
Part of MDL-55611 epic.
2017-04-03 11:37:08 +08:00
Simey Lameze fdeeaff954 MDL-58265 core_test: replace I turn editing on steps
Also remove few more unnecessary steps that redirects behat to
site home page to actually get to the course.

Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Simey Lameze 93be3f730c MDL-58265 core_test: remove unnecessary steps
This commmit removes steps that take behat to site home page
to actually get to a course page.

Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Simey Lameze c987d1b2ef MDL-58265 core_test: replace all uses of I follow course steps
Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Simey Lameze 90e8330f1a MDL-57879 mod_feedback: add action events
Part of MDL-55611 epic.
2017-04-03 11:36:33 +08:00
Juan Leyva bb66bc4a89 MDL-57822 mod_feedback: New WS mod_feedback_get_non_respondents 2017-03-28 22:52:03 +02:00
Juan Leyva 52f57996f4 MDL-58230 mod_feedback: New WS mod_feedback_get_finished_responses 2017-03-28 22:50:36 +02:00
Juan Leyva ac9f0a6800 MDL-58229 mod_feedback: New WS get_unfinished_responses 2017-03-21 13:21:32 +01:00
Juan Leyva 82b2cd7d19 MDL-57820 mod_feedback: New WS mod_feedback_get_analysis 2017-03-21 13:12:35 +01:00
Juan Leyva 82a7a67869 MDL-57818 mod_feedback: New WS mod_feedback_process_page 2017-03-21 12:25:32 +01:00
Juan Leyva 74975948e5 MDL-57817 mod_feedback: New WS mod_feedback_get_page_items 2017-03-21 11:33:55 +01:00
Juan Leyva 951ddedf6f MDL-57816 mod_feedback: New WS mod_feedback_launch_feedback 2017-03-21 11:22:13 +01:00
Eloy Lafuente (stronk7) 592cdff297 Merge branch 'MDL-57815-master' of git://github.com/jleyva/moodle 2017-03-21 00:48:44 +01:00
Juan Leyva 10948ae133 MDL-57823 mod_feedback: Implement the check_updates callback
- added a mini version bump.
- fix some conflicts.
- fix phpdoc @version
2017-03-20 20:12:54 +01:00
Juan Leyva bb676b74fe MDL-57815 mod_feedback: New Web Service mod_feedback_get_items 2017-03-16 15:35:06 +01:00
Juan Leyva b315d721d9 MDL-57814 mod_feedback: New WS mod_feedback_get_current_completed_tmp 2017-03-15 15:31:38 +01:00
Juan Leyva 0f3c09979f MDL-57811 mod_feedback: New Web Service mod_feedback_view_feedback 2017-03-15 15:25:00 +01:00
Juan Leyva 3f62cbd33e MDL-57812 mod_feedback: New WS get_feedback_access_information 2017-03-15 15:23:24 +01:00