Commit Graph

82 Commits

Author SHA1 Message Date
Jake Dallimore 5a8791336a MDL-56881 mod_choice: add unit tests for choice_user_submit_response
Tests cover option limits and multiple option responses.
2018-07-09 11:02:50 +08:00
Mark Nelson 8e24041287 MDL-62428 core: fix incorrect early return in privacy providers 2018-05-14 13:06:29 +08:00
Juan Leyva 10b67ef9f1 MDL-60882 mod_choice: Avoid teacher delete all responses
Teachers should be able to delete all responses but when indicating the
response ids.
When the response ids are not passed, only their own responses should
be deleted (as the function documentation said).
2018-04-26 10:25:45 +02:00
Jake Dallimore f1c1db434a MDL-61475 mod_choice: Update core_privacy implementation 2018-03-14 09:36:03 +08:00
Jun Pataleta 138816b1b1 MDL-61475 mod_choice: Add implementation of Privacy API 2018-03-14 09:36:03 +08:00
Luca Bösch 91e2e5e7a2 MDL-58845 mod_choice: Fix behat related tests 2018-02-22 08:30:51 +08:00
Eloy Lafuente (stronk7) 8cd0679099 Merge branch 'MDL-2051-master-2' of git://github.com/junpataleta/moodle 2017-12-26 01:25:14 +01:00
Jun Pataleta 3af40cc62e MDL-58888 mod_choice: Verify sorting when testing multiple selections
* Improve test_choice_get_my_response() to verify the sorting of the
  responses returned by choice_get_my_response().
* Fix correct usage of choice_get_my_response().
2017-12-15 15:53:11 +13:00
Jun Pataleta 3cd76cbecc MDL-2051 mod_choice: Show info how choice results will be published 2017-12-13 14:36:03 +13:00
Ryan Wyllie 478b1d194f MDL-60062 calendar: remove validate_event_timestart callback 2017-11-07 01:25:33 +00:00
Ryan Wyllie 8c4b939cfe MDL-60058 choice: implement timestart range callback for calendar UI 2017-10-13 06:38:02 +00:00
Ryan Wyllie c35613ff28 MDL-59922 mod_choice: allow editing of open and close events 2017-09-19 08:21:53 +00:00
Ankit Agarwal 0d14fcbc60 MDL-9367 restore: Roll only configuration dates
It was decided to roll only configuration dates and any date related to user content
such as 'timecreated' , 'timemodified' etc should not be rolled forward.
2017-08-01 10:46:37 +05:30
Ryan Wyllie 71cd51b8ff MDL-58557 mod_choice: change action event callback logic 2017-04-26 02:11:18 +00:00
Jake Dallimore 8db355c58f MDL-58138 tests: unit and behat tests covering bulk and default tabs
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Mark Nelson e1cd93ce20 MDL-58423 core_calendar: moved \core_calendar\event class
Part of MDL-55611 epic.
2017-04-04 11:01:49 +01:00
Andrew Nicols dd2e7e6323 MDL-58363 mod_choice: Remove calendar is_visible
Part of MDL-55611 epic.
2017-04-03 11:37:08 +08:00
Simey Lameze fdeeaff954 MDL-58265 core_test: replace I turn editing on steps
Also remove few more unnecessary steps that redirects behat to
site home page to actually get to the course.

Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Simey Lameze c987d1b2ef MDL-58265 core_test: replace all uses of I follow course steps
Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Mark Nelson 213dcf5191 MDL-57732 mod_choice: added action events
Part of MDL-55611 epic.
2017-04-03 11:36:33 +08:00
Juan Leyva fa19c73350 MDL-57254 mod_choice: Add not open case in choice_can_view_results
If the choice is not available (not open yet), the function must return
false even is CHOICE_SHOWRESULTS_ALWAYS is set to true.
This was failing only in Web Services, in Web that function is not
reached (execution stops when the time open check is done).
2017-03-14 13:34:27 +01:00
Rajesh Taneja 57bee542ab MDL-56519 behat: Fixed lint errors 2017-01-03 09:12:54 +08:00
Marina Glancy e5287f9b3b MDL-56614 behat: navigate without navigation and admin blocks 2016-12-06 11:49:14 +08:00
Rajesh Taneja e4c98de168 MDL-56630 behat: Click on link in specificed block/region 2016-11-08 18:06:09 +08:00
Rajesh Taneja dc90838aaa MDL-56630 behat: Click on link in specificed block/region 2016-11-08 14:45:43 +08:00
Marina Glancy 8676e7c3e0 MDL-18592 mod_choice: Allow teachers to make choice for students
Capability to delete reponses becomes capability to delete or modify
responses.

This also resolves MDL-51659 (incorrect events answer_submitted and
answer_updated) by deprecating them and replacing with the answer_created
2016-08-08 14:16:57 +08:00
Andrew Nicols 8f33657dae Merge branch 'MDL-55140_m32v2' of https://github.com/sbourget/moodle 2016-08-02 08:48:36 +08:00
Stephen Bourget 2ff504c6b2 MDL-55140 mod_choice: Allow independent open and close dates 2016-07-27 07:18:54 -04:00
Dan Poltawski be5837d797 Merge branch 'MDL-54987-master-fixes' of https://github.com/lameze/moodle 2016-07-26 09:55:33 +01:00
Simey Lameze e747d65514 MDL-54987 mod_choice: Fix notices and behat failures 2016-07-26 16:24:35 +08:00
Rajesh Taneja 52f3e060e4 MDL-55091 phpunit: Following has been deprecated.
1. getMock()
2. setExpectedException()
3. checkForUnintentionallyCoveredCode renamed to beStrictAboutCoversAnnotation
4. beStrictAboutTestSize renamed to enforceTimeLimit
5. UnitTestCase class is now fully removed.
2016-07-26 10:11:30 +08:00
Eloy Lafuente (stronk7) 731f2989c9 MDL-53803 mod_choice: fix trailing whitespace 2016-07-12 18:05:32 +02:00
Stephen Bourget 025188da5f MDL-53803 mod_choice: remove orphaned answers when removing options 2016-07-06 17:08:50 -04:00
Dan Poltawski 1fe7dfd9f0 MDL-32135 mod_choice: fix behat tests 2016-06-30 09:24:59 +01:00
Stephen Bourget 7c2041b64d MDL-32135 mod_choice: update behat tests 2016-06-30 09:24:59 +01:00
Rajesh Taneja eb9ca848fa MDL-53381 behat: Replaced chained steps with api.
Behat 3.x doesn't support chained steps and hence
this is first step to get rid of chained steps in core.
2016-04-06 11:32:49 +08:00
Andrew Nicols 4ed942f41e MDL-53115 mod_choice: Remove unnecessary @javascript tags 2016-04-04 08:08:43 +08:00
Rajesh Taneja 07298309dc MDL-46891 behat: Move wait in behat_base so it can be used easily 2016-03-11 10:51:16 +08:00
Rajesh Taneja 42ad096fdb MDL-46891 Behat: Added support for behat 3 2016-03-11 10:51:15 +08:00
Mark Nelson da82688689 MDL-45740 mod_choice: fixed remaining issues 2016-02-01 18:49:22 +08:00
Stephen Bourget e62f6a01e4 MDL-45740 choice: add new events 2016-01-29 13:23:15 +08:00
Dan Poltawski 265ddbf30c MDL-51569 mod_choice: Fix use of hardcoded ids
(Previous approach of making up ids longer works now we are validating
them..)
2015-11-06 08:09:47 +00:00
John Okely 531bcb13f6 MDL-51569 mod_choice: Prevent users from updating choices with curl
And fix unit tests.
2015-11-06 14:52:26 +08:00
Damyon Wiese 0bca129775 MDL-51569 mod_choice: Validate the submitted optionid
Make sure any submitted choice options actually belong to the current choice
module.
2015-11-05 10:48:40 +00:00
Juan Leyva 3dd0ac559f MDL-51569 mod_choice: Check choice availability prior to do any action 2015-11-04 11:08:32 +00:00
Juan Leyva 4b93c3e342 MDL-51566 mod_choice: New WS mod_choice_delete_choice_responses 2015-10-07 13:58:51 +02:00
Juan Leyva f07a2bb09b MDL-50132 mod_choice: New WS mod_choice_get_choices_by_courses 2015-09-21 09:27:42 +02:00
David Monllao 742548e251 Merge branch 'wip-mdl-51101' of git://github.com/rajeshtaneja/moodle 2015-09-14 16:18:01 +08:00
Rajesh Taneja 1a5a476b03 MDL-51101 behat: Fixed wrong hover step usage
Hover step was being mis-used for checking activity completion
This is replaced with proper step which check for img element
2015-09-10 14:46:12 +08:00
Juan Leyva dffb87edf6 MDL-50944 mod_choice: Unit tests for external functions 2015-09-02 11:29:38 +02:00