Commit Graph

24767 Commits

Author SHA1 Message Date
David Mudrák d84c64b7d6 MDL-52873 forms: Generate unique id attributes for modgrade elements
The previous method of generating the id attribute of the elements
within the modgrade group did not take the name of the modgrade field
into account. So if there were multiple fields of the modgrade type
added into a form (not a common case yet still valid), elements created
within the group were assigned same id attributes.

The patch introduces a new method for generating the id attribute of
modgrade elements. The new method takes the name of the modgrade group
into account and returns the id in the format similar to the default one
returned by HTML_QuickForm_element::_generateId().

The patch changes the generated id attribute. Apart from the
block_activity_results' behat feature files, not other places seem to
rely on the exact value.
2016-01-22 14:24:53 +01:00
Simey Lameze 6759dc35fe MDL-35590 block_navigation: fix remaining issues 2016-01-22 18:48:04 +08:00
Rajesh Taneja 10ac8baf6e MDL-35590 behat: Fixed navigation steps to support aria attributes 2016-01-22 17:53:44 +08:00
David Monllao 2edb12ec30 MDL-52826 forms: Move global functions to self-contained 2016-01-22 15:43:08 +08:00
Rushikesh 32f2116b08 MDL-29817 Form : advcheckbox allows attributes even without group key 2016-01-21 22:37:43 +05:30
John Okely f889544657 MDL-35590 block_navigation: Add aria roles to navigation block tree 2016-01-21 10:18:22 +08:00
David Monllao c35cf9bfcd MDL-51702 blocks: Allow permission overrides in dashboard 2016-01-21 08:46:58 +08:00
Dan Poltawski b42adaab44 Merge branch 'MDL-52702-m' of https://github.com/micaherne/moodle 2016-01-20 14:37:17 +00:00
Eloy Lafuente (stronk7) 668aca1804 MDL-52383 Calendar: user prefs are varchar, look for varchars 2016-01-20 03:07:57 +01:00
Eloy Lafuente (stronk7) 4b2326faad Merge branch 'MDL-52383' 2016-01-20 01:26:22 +01:00
Eloy Lafuente (stronk7) d3220ca34f MDL-52383 Calendar: fix versions 2016-01-20 01:25:16 +01:00
David Mudrák 1ccd813264 MDL-52831 users: Do not delete Mr. and Mrs. Whitespace accounts
Due to imperfect validation of the user registration and profile forms,
we allowed for firstname and lastname be just a whitespace. On MySQL,
such a whitespace is not significant for VARCHAR comparison so these
otherwise valid accounts could be silently deleted.

The patch makes sure that at least one of the checked fields is a real
empty string before deleting such account.
2016-01-19 21:40:45 +01:00
Rajesh Taneja 31ed36f193 MDL-52721 behat: Exclude links in moodle while finding tests
Parallel run create links within moodle
so avoid searching for tests within links
2016-01-19 14:35:18 +00:00
Dan Poltawski 61c8abfb1e Merge branch 'MDL-51715_master_invalidweights' of https://github.com/colin-umn/moodle 2016-01-19 10:39:48 +00:00
Andrew Nicols 6c99c1e777 Merge branch 'MDL-48621_master' of git://github.com/dmonllao/moodle 2016-01-19 15:47:12 +08:00
David Monllao 923589d759 MDL-52825 atto: Ignore out of bounds event targets 2016-01-19 15:37:00 +08:00
David Monllao 20ff2fba25 MDL-48621 events: Adapting unit tests to debugging messages
- A new assertDebuggingCalledCount has been introduced, as multiple debugging messages
  may be called in some cases, for example when calling events_cron with queued events
  that need to be dispatched.
- events_update_definition has been moved out of setUp as debugging messages are only
  caught by our phpunit custom stuff when they are called inside tests.
2016-01-19 15:19:10 +08:00
David Monllao 32f8bbd8dc MDL-48621 events: Adding debugging messages
Debugging messages triggered once it is confirmed that the events 1 api handlers
are being used.
2016-01-19 15:12:15 +08:00
Andrew Nicols 441ffe514e Merge branch 'MDL-49291_master' of git://github.com/markn86/moodle 2016-01-19 08:04:59 +08:00
Andrew Nicols 223c4add23 Merge branch 'MDL-50268-master' of git://github.com/lameze/moodle 2016-01-19 07:56:41 +08:00
Dan Poltawski e34710c7fe Merge branch 'wip-mdl-52721' of https://github.com/rajeshtaneja/moodle 2016-01-18 14:39:46 +00:00
Dan Poltawski 0ff8d34f2f Merge branch 'MDL-52486-master' of git://github.com/cameron1729/moodle 2016-01-18 11:19:55 +00:00
Michael Aherne 5e43eea080 MDL-52702 plagiarism: Improvements to base plugin class 2016-01-18 09:39:54 +00:00
Rajesh Taneja 28dab6408c MDL-52799 unittest: Removed empty if statement 2016-01-18 15:47:07 +08:00
Andrew Nicols ae4cc740be Merge branch 'MDL-52608-master' of https://github.com/xow/moodle 2016-01-18 14:47:52 +08:00
Mark Nelson 806905b59b MDL-49291 core: final deprecation of sql_*_reader interfaces 2016-01-18 14:24:34 +08:00
Rajesh Taneja 1226f3ca33 MDL-52799 phpunit: Truncate records for brokedmysql not empty. 2016-01-18 14:10:18 +08:00
Simey Lameze 11d4bea28b MDL-50268 core: proper deprecation of get_file_url() method 2016-01-18 13:44:22 +08:00
Rajesh Taneja 60237c2ce2 MDL-52721 unittest: Exclude tests in vendor and node_modules 2016-01-18 10:25:02 +08:00
Brendan Heywood e9180351f9 MDL-52780 email: Added better script origin email header 2016-01-18 08:12:49 +11:00
Stephen Bourget a721339193 MDL-52383 Calendar: Allow users to set lookahead to 1 year 2016-01-15 13:14:56 -05:00
Dan Poltawski cfdb3d6fe7 Merge branch 'MDL-49290_master' of git://github.com/markn86/moodle 2016-01-13 15:21:01 +00:00
Dan Poltawski 67f6802712 MDL-50851 upgrade: dan *REALLY* *REALLY* sucks at integrating 2016-01-13 12:01:33 +00:00
Dan Poltawski 74a088bc82 Merge branch 'MDL-49662_master' of git://github.com/markn86/moodle 2016-01-13 11:40:49 +00:00
Dan Poltawski 51443a2130 MDL-49111 bennu: remove outdated readme note 2016-01-13 11:31:55 +00:00
Dan Poltawski 4cb85c4905 MDL-52210 upgrade: dan *REALLY* sucks at integrating 2016-01-13 09:09:22 +00:00
Dan Poltawski c3560ad652 MDL-52210 upgrade: dan sucks at integrating 2016-01-13 09:00:44 +00:00
Dan Poltawski 939d538c76 Merge branch 'MDL-52210-master-2' of git://github.com/cameron1729/moodle 2016-01-13 08:58:18 +00:00
Cameron Ball a73409d34e MDL-52210 webservices: Revise upgrade version number. 2016-01-13 13:48:06 +08:00
Andrew Nicols f731f9c6d9 Merge branch 'MDL-50829-master' of git://github.com/danpoltawski/moodle 2016-01-13 09:56:31 +08:00
Dan Poltawski 6f838471f9 Merge branch 'MDL-49111_master' of git://github.com/markn86/moodle 2016-01-12 17:01:51 +00:00
Dan Poltawski 5ea1de4d85 Merge branch 'MDL-49724_master' of git://github.com/markn86/moodle 2016-01-12 16:56:12 +00:00
Dan Poltawski d31c63fc0e Merge branch 'MDL-49784_master' of git://github.com/markn86/moodle 2016-01-12 16:56:06 +00:00
Dan Poltawski 6fc72ea59e Merge branch 'MDL-49824_master' of git://github.com/markn86/moodle 2016-01-12 16:56:01 +00:00
Dan Poltawski 04a03ff282 Merge branch 'wip-MDL-50851-master' of git://github.com/marinaglancy/moodle 2016-01-12 14:17:14 +00:00
Dan Poltawski b8ab80f07e Merge branch 'MDL-52210-master' of git://github.com/cameron1729/moodle 2016-01-12 13:36:13 +00:00
Dan Poltawski 73c2ae931d Merge branch 'MDL-52491-master' of git://github.com/jleyva/moodle 2016-01-12 11:35:25 +00:00
Dan Poltawski 7931245f95 Merge branch 'wip-mdl-52656' of https://github.com/rajeshtaneja/moodle 2016-01-12 10:39:46 +00:00
Andrew Nicols 0755d638d7 Merge branch 'MDL-52560-m' of https://github.com/micaherne/moodle 2016-01-12 09:31:08 +00:00
Andrew Nicols dc2aa7f947 Merge branch 'MDL-27840-master' of git://github.com/danpoltawski/moodle 2016-01-12 09:31:03 +00:00