Commit Graph

81 Commits

Author SHA1 Message Date
John Okely 1318aec36e MDL-59299 filepicker: Display what filetypes are accepted 2017-07-31 09:58:22 +08:00
David Mudrák 1661204a6c MDL-59544 forms: Implicit validation of the filemanager and filepicker
The patch adds an extra validation step against accepted file types.
Even if the repository checks are bypassed (as illustrated in the
Behat), the invalid file is still caught by the element's validation
rules.

It turns out there is no way to test the filepicker element easily via
Behat. Additionally, it provides the renaming features only with
disabled javascript. So the Behat tests are provided for the filemanager
only.

AMOS BEGIN
 CPY [err_wrongfileextension,mod_workshop],[err_wrongfileextension,core_form]
AMOS END
2017-07-14 20:38:54 +02:00
Damyon Wiese 344321e1ef MDL-55417 forms: Clean up form element template patch
Use a trait and a base mustache template for all form elements to reduce code
duplication and increase standardisation.

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Damyon Wiese 91bda4cd45 MDL-55417 forms: Render form elements with a template
This change allows form elements to be overridden with a mustache template.
The template can even listen for form validation errors and supply the JS to
change the look of the form element when there is/isn't a validation error.

Initial support is for all core form elements including:

text, select, selectyesno and checkboxes, groups, dateselector, datetimeselector,
autocomplete, modvisible, advcheckbox, button, duration, filemanager, filepicker, editor, static, grading,
warning, textarea, password, url, submit, questioncategory, recaptcha.

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Marina Glancy 1a0df5535e MDL-52081 forms: Use __construct() for constructors 2015-12-10 13:38:01 +08:00
Adrian Greeve b0c6dc1cac MDL-34465 - lib - Replacing get_context_instance with context_XXXX::instance (group 8) 2012-07-27 10:10:46 +08:00
Rajesh Taneja c277b502ab MDL-31294 Forms Library: Removed deprecated functions from forms library 2012-07-24 15:09:39 +08:00
Andrew Davis 703ffaea05 MDL-27156 repositories: altered a check as the !empty() test on $PAGE->course was always failing for some reason 2012-06-20 15:17:12 +07:00
Andrew Davis bc8da017b5 MDL-27156 repositories: altered filepicker.php so that users with the ability to ignore course file size restrictions are not incorrectly restricted 2012-06-20 11:27:31 +07:00
Andrew Davis 845c2ae110 MDL-27156 repositories: switched the file manager and the file picker over to using get_user_max_upload_file_size() 2012-06-14 09:19:26 +07:00
Marina Glancy 2d7c111734 MDL-33329 Filepicker form element can not link by reference. Also better handling of maxbytes 2012-05-24 16:14:02 +08:00
Dongsheng Cai 6723372514 MDL-28666 Extends repository to support references
1. Allow repository to create references to external contents
2. Extends files API to handle file references
3. Generic file caching
4. Backup/restore file references
5. Download external contents if repository uninstalled
6. Allow filepicker to display iframe
7. PHPUnit test suits
2012-05-21 11:57:51 +08:00
Sam Hemelryk 58b7d48f9a MDL-30974 forms: Last minute phpdoc fixes 2012-02-21 12:39:35 +13:00
Rajesh Taneja 6c1fd30484 MDL-30974 form: Checked and updated docblock for form library 2012-02-15 12:55:06 +08:00
Davo Smith f08fac7c89 MDL-29766 Add drag and drop upload to filemanager / filepicker elements 2012-01-09 17:27:32 +00:00
Rajesh Taneja 63d5c4ac85 MDL-25937 Forms Library: Filepicker will respect disable if 2011-10-03 16:26:21 +08:00
Rajesh Taneja c6aa3670d0 MDL-25937 Froms Library: Added server side validation for filepicker and filemanager 2011-09-29 09:39:44 +08:00
Eloy Lafuente (stronk7) ac4a2a8c08 MDL-29512 Revert "MDL-25937 Froms Library: Added server side validation for filepicker and filemanager"
This reverts commit f03a17bb09.
2011-09-25 17:13:40 +02:00
Eloy Lafuente (stronk7) f0e2317087 MDL-29512 Revert "MDL-25937 Forms Library: Added Javascript validation for filepicker and filemanager. Also fixed disbledif rule check for both"
This reverts commit 7dfe3c517b.
2011-09-25 17:10:27 +02:00
Rajesh Taneja 7dfe3c517b MDL-25937 Forms Library: Added Javascript validation for filepicker and filemanager. Also fixed disbledif rule check for both 2011-09-16 09:17:20 +08:00
Rajesh Taneja f03a17bb09 MDL-25937 Froms Library: Added server side validation for filepicker and filemanager 2011-09-16 09:17:19 +08:00
Jamie Pratt 5b5206e1cb MDL-28099 Fixed regression as outlined in tracker. 2011-06-30 14:34:10 +07:00
Jamie Pratt b1eca34453 MDL-28099 fixes issue with filepicker and element names with index not passing
value for draftitemid.
2011-06-29 18:39:15 +07:00
Aaron Wells 4b72f9eb78 MDL-26167 lib/form: Altering Javascript so that "disabledIf" will disable the "Choose" button for a filepicker 2011-04-15 09:59:46 +12:00
Dongsheng Cai 783f148609 MDL-24474, fixed warning message from filepicker element, fixed missing packageurl when adding new scorm instance 2010-10-21 04:46:05 +00:00
Petr Skoda 6ef1402e3d MDL-24650 xhtml strict fix in forms 2010-10-13 17:35:21 +00:00
Dongsheng Cai b817205bec MDL-24382, fixed display of file size limit in filepicker 2010-09-30 03:36:38 +00:00
Petr Skoda 6bdfef5da9 MDL-24321 switching to standard stdClass() 2010-09-21 08:54:01 +00:00
Dongsheng Cai 7126772325 "MDL-23786, added sesskey and added s() filter" 2010-08-13 06:53:28 +00:00
Dongsheng Cai 563d04175a MDL-23065, fix non js filepicker 2010-08-04 03:57:10 +00:00
Dongsheng Cai be85f7ab94 "MDL-23307, server file plugin display current course files by default" 2010-07-19 17:44:23 +00:00
Petr Skoda 64f93798d4 MDL-22950 adding new component column to the files table, unfortunately this change requires changes in all 2.0dev code, please review all custom code that was already upgraded to 2.0; fixing multiple problems and regressions in mod/assignment 2010-07-03 13:37:13 +00:00
Dongsheng Cai 7e0746709f "MDL-13766, added missing js init call" 2010-05-31 09:41:46 +00:00
Dongsheng Cai ce47962ed5 MDL-13766, added hidden elements to make label 'for' attribute happly 2010-05-31 05:57:35 +00:00
Dongsheng Cai bb496de7c2 MDL-13766, move file picker element to core renderer 2010-05-24 07:55:57 +00:00
Petr Skoda 842f291493 MDL-21400 fixed filepicker regression 2010-02-06 19:43:35 +00:00
Petr Skoda 4c508047eb MDL-21400 converting forms stuff to new M namespace and using standardised JS module coding style, fixed some regressions - for now works in FF only 2010-02-03 14:36:53 +00:00
Petr Skoda 5668690321 MDL-21403 hardcoded JS legacy code should not use new $PAGE->requires-> api, switching to html_writer instead 2010-01-26 10:22:58 +00:00
Petr Skoda 7b42e81a76 MDL-21170 migrated filepicker to new YUI3 loading, tested in editor only, the filemanager and picker elements still have some problems, sorry for that 2010-01-21 22:04:31 +00:00
Petr Skoda 9dec75dbcc MDL-21240 shortened urls now start with / everywhere 2010-01-18 20:57:32 +00:00
Dongsheng Cai 0c4edaa243 "MDL-21170, complete upload function, fixed missing itemid" 2010-01-18 05:28:42 +00:00
Dongsheng Cai 99eaca9d3d "MDL-21170, major update to filepicker, complete rewrote filepicker javascript code to use YUI3, need furthur polish" 2010-01-15 07:48:38 +00:00
Petr Skoda 4bcc51185c MDL-21217, MDL-21198 simplified/improved outputlib help icon related apis + several fixed regresions 2009-12-30 15:19:55 +00:00
Dongsheng Cai c2e2d8e3aa "MDL-20602, support FILE_INTERNAL and FILE_EXTERNAL in moodle form elements" 2009-11-02 07:18:38 +00:00
dongsheng 2289c0e43d "MDL-16697, fixed itemid in filepicker" 2009-09-11 03:24:51 +00:00
dongsheng 4ba3169d21 "MDL-16697, add savepath parameter to filepicker, fixed title click event in filepicker" 2009-09-09 04:59:58 +00:00
nicolasconnault 12f11f232a MDL-19799 Switched $_helpbutton to public members 2009-08-21 00:15:19 +00:00
dongsheng 7a0c240306 "MDL-16697, fixed parameters" 2009-08-16 03:46:15 +00:00
dongsheng dd07016297 "MDL-16697, rename callback functions" 2009-08-14 08:22:06 +00:00
dongsheng 2b20173965 "MDL-16697, update javascript parameters list" 2009-08-14 07:37:56 +00:00