Commit Graph

45 Commits

Author SHA1 Message Date
Bas Brands 1b21702511 MDL-62234 Theme boost: Improve atto dialogue styling 2018-06-13 11:34:41 +02:00
Neill Magill c3e1c98f04 MDL-52317 Atto: Large resized images may display scroll bars
When an image was added via Atto and it was set to resize automatically
if the alignment was set to Top, Middle or Bottom when it was made
smaller then a vertical scroll bar would be displayed.

This was caused by the interaction of the margin settings on the image
and the 100% width set via the img-responsive css class. The width of
an element only includes the content area and not any borders, padding
or margins.

This change stops atto hardcoding the styles for image alignment into
the images style tag, it instead adds a class that defines the alignment
the image should have.

This change has the benefit that themers will now be able to adjust
how atto image alignments work if they wish.

Images added before this patch will continue to have the issue
until they are edited by the plugin, at which time their legacy style
will be removed and the new alignment method will be added.

Thanks to Andrew Nicols who provided a refactor for the Alignment
and style detection code.
2016-09-30 08:48:33 +01:00
Dan Poltawski 3a0bc0fdc4 MDL-55244 js: build changes
There should be no changes to minified code
2016-07-25 07:58:05 +01:00
Dan Poltawski bc8b6dc652 MDL-55244 js: fix various lint warnings in yui
* Incorrect brace style
* Empty functions
* Multiple var statemnts
2016-07-25 07:53:05 +01:00
Dan Poltawski 5bb4f444de MDL-55244 js: fix problems with eslint --fix
eslint --fix '**/yui/src/**/*.js'
2016-07-25 07:53:05 +01:00
Panagiotis Nikoloutsopoulos c3c3c9f28a MDL-52550 atto: Added preventDefaults for events dragover and dragenter 2016-04-21 15:08:20 +08:00
Paul Nicholls ca50279d4e MDL-51854 atto_image: Allow other plugins to handle drop events
The drop handler should only return false if it has actually handled the
drop event (i.e. it was an image) - otherwise, Atto plugins loaded after
this one don't get an opportunity to handle other drop events.
2015-10-22 11:58:57 +13:00
Andrew Nicols 557f44d970 MDL-48620 JavaScript: Updated shifted files to comply with coding style 2015-01-23 14:51:24 +08:00
Daniel Thies eb8b2425a6 MDL-48062 atto_image: Add image select on single click 2014-12-18 18:26:28 -06:00
Paul Nicholls 1461aee88a MDL-43996 editor_atto: add image drag and drop capability
Adds the ability to drag and drop images directly into Atto, uploading the image and embedding it
correctly. Contains fixes from 1.0.2, as well as a policy change - images dragged and dropped into
Atto now have role=presentation by default.
2014-12-05 11:32:32 +08:00
uhunkler 6dccf359a0 MDL-46302 correct atto img float right
Correct the atto image "float right" margin CSS
2014-08-20 00:59:31 +02:00
Frederic Massart 91bc9570e1 MDL-46061 atto_image: Prevent error when image does not have a size 2014-06-19 16:00:22 +08:00
Andrew Nicols f366221309 MDL-45479 atto_image: Improve the preview area
This changes the preview area:
* to show the image at the requested size; and
* to fix the scaling issues.
2014-05-15 10:36:41 +08:00
Damyon Wiese c1660772b1 MDL-44972 Atto dialogues: Change M.core.dialogue attribute name to "focusOnShowSelector"
And some minor cleanups.
2014-05-05 16:27:36 +08:00
Damyon Wiese e5ddec38cd MDL-44972 Atto: Focus on the first input field in forms in dialogues. 2014-05-05 15:21:11 +08:00
Frederic Massart 8aa64bab43 MDL-45169 atto_image: Translatable string for 'size'
AMOS BEGIN
 CPY [size,core],[size,atto_image]
AMOS END
2014-04-23 14:43:28 +08:00
Damyon Wiese d3931a7d4d MDL-45034 Atto: Image dialogue improvements.
1. Fix Nan bugs in auto width / height
2. Allow percentages in auto width / height
3. Change dialogue title
4. Prevent preview image resizing from changing the height of the dialogue.
5. Change wording to "Auto size"
6. Auto adjust size when the "Auto size" checkbox is toggled.
7. Add img-responsive to images with the original aspect ratio.
8. If the width and height fields are left blank, revert them to the image size.
2014-04-15 16:43:27 +08:00
Damyon Wiese 7bbc64b88f MDL-44826 Atto: Set default image alignment to 'bottom' 2014-04-15 15:47:52 +08:00
Damyon Wiese d28af3d4aa MDL-44826 Atto: Image alignment options
If an image has custom alignment or margins - don't overwrite
them unless a new alignment option is chosen.
2014-04-15 12:23:31 +08:00
Damyon Wiese 2e8cbbb3ac MDL-44826 Atto: Remove most of the image alignment options
Just keep the simple ones and put some default padding on images.
2014-04-11 12:55:28 +08:00
Sam Hemelryk b983a5d869 Merge branch 'MDL-44765-master' of git://github.com/phalacee/moodle 2014-04-09 10:26:33 +12:00
Jason Fowler 9754ab92da MDL-44765 Atto: Fix the accessibility warning events for image dialogue 2014-04-07 07:59:45 +08:00
Damyon Wiese 8d1c017979 MDL-44949 Atto: JS error when picking an image from a repository 2014-04-04 12:03:01 +08:00
Eloy Lafuente (stronk7) e154e9d8cd Merge branch 'MDL-44000-master' of git://github.com/damyon/moodle
Conflicts:
	lib/editor/atto/plugins/image/yui/build/moodle-atto_image-button/moodle-atto_image-button-min.js
2014-04-02 00:27:30 +02:00
Damyon Wiese 43a737d1b5 MDL-43999 Atto : Make image dialogue open on double click of an image. 2014-04-01 15:22:12 +08:00
Andrew Davis 5491fd7f07 MDL-44763 editor_atto: removed unnecessary "preview" label 2014-04-01 10:57:16 +08:00
Damyon Wiese ffb8aff65c MDL-44000 Atto: Add option to constrain image size
(Keep aspect ratio)

Also some small improvements to the edit image dialogue.
2014-03-31 16:28:57 +08:00
Frederic Massart 6cb48e0424 MDL-44804 editor_atto: JS error when filepicker is disabled 2014-03-26 17:20:31 +08:00
Damyon Wiese da00661d1f MDL-44487 Atto: Restrict size of image preview in popup.
Instead of only restricting the width, we set a max-width and max-height in css.
We also make the dialog a bit wider so it looks better in clean.
2014-03-26 10:01:49 +08:00
Andrew Nicols 6246779510 MDL-44164 atto: Refactor the world 2014-03-26 10:01:48 +08:00
Damyon Wiese d321f68b3d MDL-44219 Atto: Convert selection logic to use Rangy JS Library
This removes alot of complex, hard to test, hard to debug code from the editor so
we can focus on the things we want to spend time on. Rangy seems a good choice for
browser support, stability and features.
2014-03-26 10:01:48 +08:00
Sam Hemelryk 67d3fe45bb MDL-44219 editor_atto: reinvent the event wheel for the atto editor 2014-03-26 10:01:48 +08:00
Sam Hemelryk c9292b18a3 MDL-44220 atto_image: added image alignment control 2014-03-26 10:01:44 +08:00
Sam Hemelryk a30a40cbf4 MDL-44221 editor_atto: convert plugins to use insert_html_at_focus_point 2014-03-26 10:01:44 +08:00
Damyon Wiese 3ee53a425f MDL-44092 Atto: Add selectionchanged event and listeners in the buttons.
This means the buttons can indicate the state of the text under the cursor.
2014-03-26 10:01:43 +08:00
Damyon Wiese 8095505e3c MDL-44126 Atto: List of minor fixes from review.
toolbar order (base it on tinymce)
change plain to paragraph
default for collapse plugin should be 5 groups
fix alignment of table dialogue form
insert newlines in html generated by table plugin
rename accessibility helper to screenreader helper
remove accessibility hint for images and media files
fix some broken plugin names
style table captions
remove verbose accessibility hints
2014-03-26 10:01:42 +08:00
Damyon Wiese b03d59821a MDL-43934 Atto: Rename shifter meta files to the correct name.
This could have caused yui to fetch extra files because the dependencies might not have been loaded.
2014-03-26 10:00:04 +08:00
Frederic Massart d19cf39edb MDL-44003 editor_atto: Identify the submit buttons in plugins 2014-03-26 09:59:36 +08:00
Damyon Wiese b269f635f6 MDL-43869 Atto: id escaping so Atto works with when there is : in the id.
(Quiz)
Also includes fixes for Atto when the repositories should not be displayed.
2014-03-26 09:59:34 +08:00
Damyon Wiese 55c0403c6c MDL-43853 Atto: Performance. Turbocharge the loader.
Rewrite the atto plugin loader so that:

A) We have a real settings.php page and can edit the toolbar.
B) All plugins are loaded at the same time (not serially)
C) All plugins share the YUI sandbox (more performance boost).

I had to change the loading API for this - but there are not non-core uses yet,
this is the best time to break it.
2014-03-26 09:59:34 +08:00
Damyon Wiese adca7326d8 MDL-43842: Import atto back into core 2014-03-26 09:59:34 +08:00
Damyon Wiese 775a32c9b8 MDL-42459 Atto: Bye bye - see you in the plugins db! 2013-10-22 12:01:56 +08:00
Damyon Wiese 103ba42d84 MDL-41993 Atto: Always clean/update the textarea when the content is changed 2013-10-09 11:08:06 +08:00
Jason Fowler 36973d707e MDL-41713 atto - implement new icons with matching UI 2013-09-20 14:20:05 +08:00
Damyon Wiese c90641facb MDL-41098 Atto Text editor: Add new text editor to core
This is an alternative to the TinyMCE text editor that is based on HTML5
content editable regions.

It has been designed to "gel" with Moodle and uses YUI for javascript,
Moodle standard dialogs and standard moodle buttons. It has also been designed
to work well on mobile devices and can collapse down to a narrow column if required.

Imported from the plugins database here:
https://moodle.org/plugins/view.php?plugin=editor_contenteditable

Original git repository here:
https://github.com/damyon/contenteditable
2013-08-26 22:16:43 +08:00