Commit Graph

1275 Commits

Author SHA1 Message Date
skodak 3ce50127b9 MDL-17502 accesslib: added warning if incorrect parameters supplied to has_all_capabilities() and fixed parameters in course lib code 2008-12-09 16:25:38 +00:00
tjhunt 18af228bf2 course categories: MDL-17502 followup. Fix notices. I'm sure I remember writing this code yesterday! 2008-12-09 09:27:25 +00:00
tjhunt 8a1b1c328d course categories: MDL-17502 when deleting a category and its contents, check moodle/course:delete capability.
* Note: this would never lead to problems with default role definions.
* Also ended up mostly rewriting delete_category_form to simplify the messages that are displayed.
* New helper function require_all_capabilities, a bit like require_any_capability.
2008-12-08 07:28:19 +00:00
tjhunt 77eddcd527 course request: MDL-9854 major cleanup to the course request code.
* Rewrite all the forms to use formslib and improve usability.
* Put the place where admins need to go to process approvals in the admin menu.
* Show the request course/pending requests button on the page for the category that requested courses get added to.
2008-12-05 08:56:54 +00:00
tjhunt 8ed5dd63ee course categories: Fix many bugs with category editing and permissions. Clean up code.
Bugs: MDL-17479, MDL-16426, MDL-16063, MDL-16013, MDL-15658, MDL-15556, MDL-15161, MDL-14925, MDL-13742, MDL-11557.

* Simplify category editing permissions to just moodle/category:manage and moodle/category:seehiddencategories.
* Enforce those correctly. (Note MDL 17502 is still outstanding.)
* Don't screw up category sort order when you just edit name or description.
* Niceties like where redirects go when you cancel or submit forms.
* Make sure a global course creator can see the site admin block.
* Don't allow a category to be made the child of one of its children!
* General code cleanup to bring key files more in line with best pracitice.

Apologies for the fact it is one big patch, rather than a series of smaller patches. However, categoryedit.php, category.php and index.php where in pretty bad shape and needed significant cleaning up. categoryedit.php, in particular, was almost completely rewritten.

Merged from MOODLE_19_STABLE.
2008-12-04 08:53:10 +00:00
skodak a2e4bf7f23 MDL-17463 - reparate capabilities for course and admin reports 2008-11-29 14:22:10 +00:00
tjhunt bef12c997a course settings: MDL-16327 when creating a course, the role renames were not saved. 2008-11-13 08:11:10 +00:00
tjhunt 7b553c8b58 course editing: MDL-17066 Assign roles icon next to activities when editing is on does not have a tool-tip 2008-10-30 03:00:20 +00:00
poltawski 38dc85bf1f MDL-16434 fix typo in class name "generalbox"
thanks to Joseph Rézeau
2008-10-09 10:51:57 +00:00
nicolasconnault ca255392e2 MDL-12198 Fixed ordering of sections, Merging from MOODLE_19_STABLE 2008-10-08 12:22:04 +00:00
stronk7 165d25cc35 Respect role names for logged students. MDL-16569 ; merged from 19_STABLE.
Credit goes to Otakar Šprdlík
2008-09-18 15:16:02 +00:00
stronk7 a682f0c2c3 XHTML-ize course categories list. MDL-16358 ; merged from 19_STABLE 2008-09-08 18:16:39 +00:00
skodak d857e8b627 MDL-16223, MDL-16222 - module context now available in xxx_add_instance() module method and $mform is passed as second parameter; $cm is updated/inserted before the activity insert/update hook; other related refactoring and cleanup; error string improvements 2008-08-27 16:33:50 +00:00
sam_marshall 5c168a031e MDL-15498: Completion system, help buttons aren't supposed to show when editing 2008-08-22 15:46:30 +00:00
sam_marshall f17a0360a2 MDL-15498: Completion system, added help button to explain the tickboxes 2008-08-22 11:51:24 +00:00
nicolasconnault 3440ec1234 MDL-12198 2008-08-08 05:25:54 +00:00
sam_marshall 7edc92457c MDL-15498: Completion fix: hide completion icons for guest/not logged in 2008-07-28 16:08:23 +00:00
sam_marshall 4e781c7b50 MDL-15498: Completion system 2008-07-28 12:31:29 +00:00
skodak 9009a99006 MDL-13353 Course page does not validate when a lable containing <p> tags is hidden; merged from MOODLE_19_STABLE 2008-07-26 11:36:35 +00:00
moodler 554606c76b MDL-15601 Merged basic checking to avoid some notices 2008-07-10 08:50:43 +00:00
skodak 2942a5cd34 MDL-9983, MDL-13998 core events related cleanup; merged from MOODLE_19_STABLE 2008-07-06 17:57:06 +00:00
skodak ff96219d2f MDL-15420 fixed commented out continue which was causing leaks of info about hidden activities ;-); merged from MOODLE_19_STABLE 2008-07-05 13:20:21 +00:00
scyrma 38fb819028 MDL-11992: adding course tagging patch, by John Beedell. This feature is not
active by default at this time. Related help files are not included in this
commit, as they are being revised (see issue 15385) and will be sent in soon.
2008-06-30 09:04:07 +00:00
skodak 0cbe81112a MDL-14580 rewritten course sorting algorithms 2008-06-16 14:25:53 +00:00
skodak dc5af91a86 MDL-15094 fixed regression 2008-06-04 23:45:31 +00:00
nicolasconnault 238c0dd9c1 MDL-14679 Fixed a typo from Petr, which caused fatal error in course lib 2008-06-04 06:38:03 +00:00
skodak 7e60297f54 MDL-14679 converted some sql_'s 2008-06-02 21:56:06 +00:00
skodak a5d424df7c MDL-14679 converted some get/set_field() 2008-06-02 21:39:23 +00:00
skodak 6bb0816313 MDL-14679 towards course conversion 2008-06-02 08:13:24 +00:00
skodak 7cac0c4b2b MDL-14679 fixed references to mod.html 2008-06-01 19:09:13 +00:00
skodak cb6fec1fa4 MDL-14679 converted some course related code 2008-06-01 19:05:07 +00:00
skodak 1c69b88529 MDL-14679 removed all instances of set_field_select() 2008-06-01 16:14:59 +00:00
skodak c3df090199 MDL-14679 datalib conversion completed 2008-05-30 16:47:21 +00:00
thepurpleblob 9d5a4b235e MDL-14832
Don't show a user name more than once. Only show them in the
most 'senior' role.

Merged from STABLE_19
2008-05-21 12:03:22 +00:00
skodak f33e1ed4ae MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs 2008-05-15 21:40:00 +00:00
skodak 59a7889975 MDL-14378 When deleting course category deal with everything that depends on its context; merged from MOODLE_19_STABLE 2008-05-13 22:04:06 +00:00
skodak e2b347e933 MDL-14378 When deleting course category deal with everything that depends on its context; merged from MOODLE_19_STABLE 2008-05-13 21:52:38 +00:00
tjhunt d4e5675c00 MDL-14797 - Error when moving a course to an empty category on Postgres 2008-05-12 10:44:44 +00:00
stronk7 bf221acaef Reverting to previous revision. MDL-14668 ; merged from 19_STABLE 2008-05-07 18:28:59 +00:00
dongsheng ba6018a902 "MDL-14129, fix print_error call under course/, see tracker" 2008-05-07 06:02:51 +00:00
dongsheng c1ec736afd "MDL-14668, fix course full name in activity reports, see tracker" 2008-05-07 02:59:36 +00:00
skodak 0f56c9da08 MDL-14621 fix warning when module code missing and editing course 2008-04-30 12:39:31 +00:00
skodak 7c3b032ec0 MDL-14621 modinfo ignores missing modules now properly 2008-04-30 12:33:18 +00:00
skodak 3a37b3f8d5 MDL-14621 fixed warning when module code missing 2008-04-30 12:24:54 +00:00
skodak 8634e00163 MDL-14475 initialised $assign 2008-04-25 14:03:44 +00:00
skodak 530db4cd17 MDL-14475 initialised $hideshow; backported from MOODLE_19_STABLE 2008-04-25 14:03:17 +00:00
dongsheng 8e48039682 MDL-14460, fix get_context_instance, merged from MOODLE_19_STABLE 2008-04-24 08:39:47 +00:00
scyrma c659559fd6 MDL-3381 - Prevent the un-necessary calls to ctype_alpha. 2008-04-24 06:40:26 +00:00
scyrma e12e0ee717 MDL-3381 - Reverse broken commit 2008-04-24 03:24:42 +00:00
scyrma bbbfc0579f MDL-3381 - Remove all remaining core calls to ctype_* functions in 1.9, and make ctype required for 2.0. (merge from 1.9) 2008-04-24 03:07:59 +00:00