Commit Graph

69 Commits

Author SHA1 Message Date
Damyon Wiese a60e8ba51e MDL-59365 enrol_manual: Rewrite the yui enrolment popup in amd
The add/roles thing was only converted to bootstrap 2/4 markup and the yui left in place.

The modal for adding users to a course was unsavable so I rewrote it with an mform in a popup, still calling
the same (barely) modified ajax script.

The webservice for searching cohorts was taken from admin/tool/lp and moved into /cohort. I added a generic "cohort"
mform element at the same time.

The webservice for searching for users was taken from the original ajax script.
2017-07-11 13:47:26 +01:00
Damyon Wiese 9c91a9593d MDL-57273 core: Remove magic setters and getters
Remove the magic getters and setters from persistent. They are deprecated only in the persistent
class for competencies.
2017-01-20 12:56:19 +08:00
Frederic Massart 4bc68a416e MDL-57273 core: Exporters support custom formatting parameters 2017-01-20 12:56:19 +08:00
Frederic Massart 81de839f37 MDL-53700 competency: Migrating external functions to core 2016-04-18 11:05:59 +08:00
Frederic Massart 922634d3e5 MDL-53700 competency: Migrating data generator to core 2016-04-18 11:05:59 +08:00
Frederic Massart 767f66c028 MDL-53700 competency: Migrating the competency API to core 2016-04-18 11:05:59 +08:00
Frederic Massart 67bc0eaf38 MDL-53700 competency: Migrate main classes to core 2016-04-18 11:05:59 +08:00
Frederic Massart a4e659c788 MDL-53700 competency: Migrate database tables to core 2016-04-18 11:05:58 +08:00
Frederic Massart b90e2205b4 MDL-53700 competency: Migrate capabilities to core 2016-04-18 10:59:01 +08:00
Frederic Massart 1f7699533c MDL-53645 tool_lp: Address FIXME comments 2016-04-18 10:59:01 +08:00
Damyon Wiese 9919b4af62 MDL-53452 tool_lp: Rename get_course_settings to get_by_courseid
In the course_competency_settings persistent.
2016-04-18 10:59:00 +08:00
Damyon Wiese 9785dd8174 MDL-53452 tool_lp: Change update_course_competency_settings param to stdClass
Allows for future settings to be added without changing the function signature.
2016-04-18 10:59:00 +08:00
Damyon Wiese fdd85edef9 MDL-53452 competencies: Update unit tests now we have removed suggest feature. 2016-04-18 10:58:59 +08:00
Damyon Wiese 7ba074873c MDL-53452 competencies: Add course and admin setting to push competency ratings outside a course 2016-04-18 10:58:59 +08:00
Serge Gauthier 44e8cba48e MDL-53483 tool_lp: Normalise the names of capabilities 2016-04-18 10:58:59 +08:00
Frederic Massart 96c2b8477f MDL-53453 cbe: PHP Docs and coding style adjustments 2016-04-18 10:58:57 +08:00
Frederic Massart 0fe5aac733 MDL-53282 tool_lp: Extend list_frameworks to support string search 2016-04-18 10:58:54 +08:00
Frederic Massart d17cbbfbad MDL-52691 tool_lp: Add note support to competency rating 2016-04-18 10:58:53 +08:00
Frederic Massart 47cddb9c1f MDL-52803 tool_lp: Save real estate by conditionally displaying comments
The comment area are exported when the user can read the comments.
The comment area is displayed when:
- The user can post, or
- The user can read, and there is something to read.
2016-04-18 10:58:52 +08:00
Frederic Massart 97244310c2 MDL-52827 tool_lp: Consider role overrides when searching users 2016-04-18 10:58:52 +08:00
Damyon Wiese 940235b762 MDL-52827 tool_lp: Fix SQL for filtering users by permission on user context 2016-04-18 10:58:52 +08:00
Frederic Massart 3c230247ce MDL-51035 tool_lp: Plans can be reviewed and commented on 2016-04-18 10:58:50 +08:00
Frederic Massart c008e92d22 MDL-51036 tool_lp: Implement a basic review process for competencies 2016-04-18 10:58:49 +08:00
Serge Gauthier 0d1a2e71f0 MDL-52463 tool_lp: Templates: Can not sync cohorts at category level 2016-04-18 10:58:49 +08:00
Frederic Massart f743bc1071 MDL-52677 tool_lp: Prevent false positive in search_users test 2016-04-18 10:58:49 +08:00
Frederic Massart 357d38628c MDL-52562 tool_lp: Deleting a plan removes related data 2016-04-18 10:58:49 +08:00
Damyon Wiese 65a67e238d MDL-51040 cbe: Fixes from peer review
No logic changes here - only small refactorings based on feedback from
peer review.
2016-04-18 10:58:48 +08:00
Damyon Wiese 02f9db888c MDL-51040 cbe: Competency API changes
Modify the list_user_competencies_in_course function to create the relations
if they do not exist.
Add new api function to grade a competency in a course.
Fix the permissions check for listing related competencies.
2016-04-18 10:58:47 +08:00
Damyon Wiese 0845a3a09a MDL-51648 cbe: Refactor the user_competency_summary exporter
Split it into a core exporter, and an extended one that adds information about the plan.
Also
* Remove userid from grade_competency_in_plan function (redundant)
* Improve the signature of list_evidence so it can handle completed plans (later)
* Rename read_user_competency_summary to data_for_user_competency_summary_in_plan
* Handle completed plans (list user_competency_plan as well as user_competency)
* Remove user_can_see_details_cap handling - if you can see the users plan you can see the user
* Pass final scaleconfiguration in the competency_summary_exporter
* Add docs comments to new templates
2016-04-18 10:58:47 +08:00
Damyon Wiese 3c659fc202 MDL-51648 cbe: Add a user competency plan summary page (allows grading) 2016-04-18 10:58:47 +08:00
Issam Taboubi 964afa98e7 MDL-52229 tool_lp: Handle hidden templates/frameworks 2016-04-18 10:58:46 +08:00
Frederic Massart 12888abaa8 MDL-52423 tool_lp: Page to view a plan and its information 2016-04-18 10:58:45 +08:00
Damyon Wiese 6880579736 MDL-52198 cbe: Move user summary to an exporter 2016-04-18 10:58:44 +08:00
Frederic Massart 80583e0dff MDL-52198 cbe: Add a user selector
For now this is only in tool_lp - for core we would wrap this with an mform element.
2016-04-18 10:58:44 +08:00
Issam Taboubi 14199b8561 MDL-51682 tool_lp: Fix persistent sortorder handling to prevent holes 2016-04-18 10:58:43 +08:00
Issam Taboubi 5b22462788 MDL-51953 tool_lp: Missing four services definitions 2016-04-18 10:58:43 +08:00
Issam Taboubi d805cc3745 MDL-52104 tool_lp: Improve UI for the change of states in plan 2016-04-18 10:58:43 +08:00
Frederic Massart 2388d46de7 MDL-52220 tool_lp: Create plan from template API 2016-04-18 10:58:43 +08:00
Frederic Massart 578e61c18a MDL-52119 tool_lp: Solidify the exporters to avoid developer mistakes 2016-04-18 10:58:42 +08:00
Damyon Wiese 8ec5f810f4 MDL-52119 cbe: Use generated structures for persistent classes 2016-04-18 10:58:42 +08:00
Damyon Wiese 0267097956 MDL-52064 cbe: Fixes for unit tests.
There were some real failures that the unit tests caught.
2016-04-18 10:58:42 +08:00
Damyon Wiese 86938d0613 MDL-52064 cbe: Clean many common errors in external functions
Fixes include format_text/format_string
New persistent_exporter class to export persistent objects for use in external apis.
Always validate_context
Always use validated params - not raw params
Do not use "xxformatted" properties.
2016-04-18 10:58:41 +08:00
Jean-Philippe Gaudreau 192569ed17 MDL-51805 tool_lp: Freeze learning plan when it is marked as completed
This includes:
* Copy user competencies to user_competency_plan when updating plan
  with status complete.
* User competencies in user_competency_plan are deleted when the plan
  is set back to draft or active.
* the api::list_plan_competencies method is now returning
  user_competency_plan objects if plan status is complete.
* external functions and renderer have been adapted to the new api
  methods.
* Remove fields status and reviewerid from user_competency_plan
2016-04-18 10:58:41 +08:00
Issam Taboubi 554b369b60 MDL-50328 tool_lp: Allow competencies to be assigned to a user plan 2016-04-18 10:58:40 +08:00
Frederic Massart 2ec1b70bcd MDL-51866 tool_lp: Framework scale cannot be changed once it is used 2016-04-18 10:58:40 +08:00
Frederic Massart 7f386a2e62 MDL-51034 tool_lp: Tests for list_plan_competencies 2016-04-18 10:58:40 +08:00
Frederic Massart 5159d6794b MDL-51965 tool_lp: Revisit capabilities to read/manage plans
Templates can no longer be linked to the plan via the plan editing
page because we will need to handle plan linking/unlinking directly.
2016-04-18 10:58:37 +08:00
Serge Gauthier 53084abb75 MDL-51645 tool_lp: Rename the plan capabilities 2016-04-18 10:58:36 +08:00
Serge Gauthier e9831af3c2 MDL-51233 tool_lp: Remove unused ID number from learning plan templates
Conflicts:
	admin/tool/lp/version.php
2016-04-18 10:58:36 +08:00
Frederic Massart bf61cd0cf3 MDL-51442 tool_lp: Validate the frameworks' scale ID 2016-04-18 10:58:36 +08:00