Commit Graph

183 Commits

Author SHA1 Message Date
Andrew Nicols c7c5d12353 MDL-59801 tool_lp: Behat fix for autocomplete
An earlier Behat fix made the use of autocomplete stricter on checking
an exact match instead of a substring, which in turn broke this use
which was searching for a partial match.
2017-09-01 08:24:51 +08:00
Damyon Wiese dda64b6f45 MDL-59548 behat: Helpers for autocomplete
Improve the helpers for autocomplete so that:
a) the set field for an auto complete will automatically close the suggestions list.
b) add a new helper to open the suggestions list
c) move the helper for clicking on an element in the suggestions list from tool_lp to core.
2017-07-17 11:10:15 +08:00
Damyon Wiese 394e73ff12 MDL-59365 behat: Autocomplete fixes
The suggestion list stays open for multi-selects now. We need to close it
explicitly.
2017-07-11 13:48:27 +01:00
Damyon Wiese a60e8ba51e MDL-59365 enrol_manual: Rewrite the yui enrolment popup in amd
The add/roles thing was only converted to bootstrap 2/4 markup and the yui left in place.

The modal for adding users to a course was unsavable so I rewrote it with an mform in a popup, still calling
the same (barely) modified ajax script.

The webservice for searching cohorts was taken from admin/tool/lp and moved into /cohort. I added a generic "cohort"
mform element at the same time.

The webservice for searching for users was taken from the original ajax script.
2017-07-11 13:47:26 +01:00
Dan Poltawski 34702e22e6 MDL-58625 behat: update tool_lp data generator 2017-04-18 12:51:13 +01:00
Damyon Wiese 8857c715d1 MDL-40759 icons: Behat fixes for font-awesome 2017-03-17 15:52:18 +08:00
Damyon Wiese 9c91a9593d MDL-57273 core: Remove magic setters and getters
Remove the magic getters and setters from persistent. They are deprecated only in the persistent
class for competencies.
2017-01-20 12:56:19 +08:00
Frederic Massart 4bc68a416e MDL-57273 core: Exporters support custom formatting parameters 2017-01-20 12:56:19 +08:00
Rajesh Taneja 57bee542ab MDL-56519 behat: Fixed lint errors 2017-01-03 09:12:54 +08:00
Marina Glancy e5287f9b3b MDL-56614 behat: navigate without navigation and admin blocks 2016-12-06 11:49:14 +08:00
Damyon Wiese c81a34774e MDL-56684 boost: Fix for competency behat tests with boost theme 2016-11-07 16:02:44 +08:00
Damyon Wiese ba5c5083c5 MDL-55074 theme_boost: Behat fixes for latest theme changes
Fix I edit profile steps
Apply fixed header in css
Remove transitions from menus for behat
Be more specific about some "I follow" steps
Navigation path changes
"Current course" node removed from nav tree
Adapt tests because there are no default blocks
Force some space between action menu items
2016-10-21 16:06:54 +08:00
Marina Glancy 134494e07a MDL-55418 behat: correct exception class name 2016-08-02 17:45:12 +08:00
David Monllao f74e3ace69 Merge branch 'MDL-53980-master-enfix' of git://github.com/mudrd8mz/moodle 2016-05-02 10:46:50 +08:00
David Mudrák c1d44340a5 MDL-53980 lang: Fix the reworded strings in Behat tests 2016-04-28 18:39:59 +02:00
Jun Pataleta 9031371211 MDL-53955 tool_lp: Remove the use of chained steps in tool_lp 2016-04-28 14:57:54 +08:00
David Monllao e7c979dff8 Merge branch 'MDL-53632-master' of git://github.com/FMCorz/moodle 2016-04-26 11:29:51 +08:00
Frederic Massart 4474c87401 MDL-53451 competency: Removing sneaky whitespaces 2016-04-19 12:21:36 +08:00
Frederic Massart 746da8ba60 MDL-53632 competency: Consistently use the terms frameworks, plans, ...
- Templates: 'Learning plan templates'
- Plans: 'Learning plans'
- Frameworks: 'Competency frameworks'

When the context, or sentence, is already stating that we are talking
about 'learning plans' or 'competencies', it may sound redundant to
repeat those terms, therefore we can simply refer to 'Templates',
'Plans', and 'Frameworks'.
2016-04-18 16:51:39 +08:00
Frederic Massart eeaef357f2 MDL-53451 tool_lp: Fix tests fails because block_lp already on dashboard 2016-04-18 13:49:16 +08:00
Frederic Massart 4aa6acb22a MDL-53700 competency: Migrating comment related APIs to core 2016-04-18 11:05:59 +08:00
Frederic Massart 5a1a685c28 MDL-53700 competency: Migrating events to core
Leaving comments behind for now as it's a tricky one.
2016-04-18 11:05:59 +08:00
Frederic Massart 81de839f37 MDL-53700 competency: Migrating external functions to core 2016-04-18 11:05:59 +08:00
Frederic Massart e0b9ba28a4 MDL-53700 competency: Migrating tests to core 2016-04-18 11:05:59 +08:00
Frederic Massart 922634d3e5 MDL-53700 competency: Migrating data generator to core 2016-04-18 11:05:59 +08:00
Frederic Massart 767f66c028 MDL-53700 competency: Migrating the competency API to core 2016-04-18 11:05:59 +08:00
Frederic Massart 72018c0a1c MDL-53700 competency: Migrating exporters to core 2016-04-18 11:05:59 +08:00
Frederic Massart 67bc0eaf38 MDL-53700 competency: Migrate main classes to core 2016-04-18 11:05:59 +08:00
Frederic Massart 42a7899f0d MDL-53700 competency: Migrate tasks to core 2016-04-18 11:05:58 +08:00
Frederic Massart a4e659c788 MDL-53700 competency: Migrate database tables to core 2016-04-18 11:05:58 +08:00
Frederic Massart b90e2205b4 MDL-53700 competency: Migrate capabilities to core 2016-04-18 10:59:01 +08:00
Frederic Massart 1f7699533c MDL-53645 tool_lp: Address FIXME comments 2016-04-18 10:59:01 +08:00
Jun Pataleta 4a4bda6d2d MDL-53567 tool_lp: Close menubar on click
This patch enables the closing of the menubar when a menu item is
clicked or when any other element outside the menubar is clicked.
2016-04-18 10:59:01 +08:00
Damyon Wiese 96f4d771bf MDL-52979 tool_lp: Fix user_competency_course summaries
Only show ratings from the course on course competency pages.
2016-04-18 10:59:01 +08:00
Damyon Wiese f1979b60a1 MDL-52743 tool_lp: Course competency statistics
Note - the statistics you see depends on whether you can recieve competency
ratings in the course. So students see their own progress as a %. Graders
see the least proficient competencies for the course.
2016-04-18 10:59:01 +08:00
Frederic Massart 4e89144ca7 MDL-53471 tool_lp: Hooking in to report when scale is being used 2016-04-18 10:59:00 +08:00
Issam Taboubi c11d30e2a8 MDL-53630 tool_lp: Rename Learning plans to Learning plan templates
* In site administration
* In category administration
2016-04-18 10:59:00 +08:00
Damyon Wiese 9919b4af62 MDL-53452 tool_lp: Rename get_course_settings to get_by_courseid
In the course_competency_settings persistent.
2016-04-18 10:59:00 +08:00
Damyon Wiese 9785dd8174 MDL-53452 tool_lp: Change update_course_competency_settings param to stdClass
Allows for future settings to be added without changing the function signature.
2016-04-18 10:59:00 +08:00
Damyon Wiese 644ff55b3a MDL-53452 competencies: Add unit test for course competency settings 2016-04-18 10:58:59 +08:00
Damyon Wiese fdd85edef9 MDL-53452 competencies: Update unit tests now we have removed suggest feature. 2016-04-18 10:58:59 +08:00
Damyon Wiese 7ba074873c MDL-53452 competencies: Add course and admin setting to push competency ratings outside a course 2016-04-18 10:58:59 +08:00
Serge Gauthier 65abd20d8c MDL_53523 tool_lp: Mark fields 'scale/scaleconfiguration' as required 2016-04-18 10:58:59 +08:00
Serge Gauthier 44e8cba48e MDL-53483 tool_lp: Normalise the names of capabilities 2016-04-18 10:58:59 +08:00
Frederic Massart 6f0c979f6e MDL-53550 tool_lp: Relax capability checks on cohorts
Cohorts seem to rely on the calling code doing the right capability
checks. In this case I applied the simple logic of checking if the
cohort is visible, and if it is not then checking the capability.

Methods using cohorts should apply relevant capability checks.
2016-04-18 10:58:59 +08:00
Frederic Massart 10bf349e70 MDL-53568 tool_lp: Fix getting proficiency of grade not in scaleconfig 2016-04-18 10:58:58 +08:00
Serge Gauthier 71cb304ad8 MDL-53186 tool_lp: Send competencies in review from evidence interface 2016-04-18 10:58:58 +08:00
Jun Pataleta e821c94799 MDL-53475 tool_lp: Redirect and show notification in destination
After creating a plan/competency/user evidence/plan template,
redirect the user to the plan/user evidence/plan template page.
After updating a plan/competency/user evidence/plan template,
redirect the user back to the previous page and display the notification
message instead of displaying a notification message and a continue button.
2016-04-18 10:58:58 +08:00
Frederic Massart 3b167714c5 MDL-53453 cbe: False negative when comment on a user competency 2016-04-18 10:58:57 +08:00
Frederic Massart 96c2b8477f MDL-53453 cbe: PHP Docs and coding style adjustments 2016-04-18 10:58:57 +08:00