Commit Graph

60 Commits

Author SHA1 Message Date
tjhunt 240363ac49 MDL-15654 Incorrect escaping of HTML in the history table on the review quiz attempt page. 2008-08-20 09:46:10 +00:00
tjhunt cda98581a5 Fix dangerous comment. (MDL-13536) 2008-02-19 17:14:13 +00:00
tjhunt df6447ef65 MDL-13110 - Manually grading random questions does not work. Fix thanks to Ken Burres. 2008-01-30 18:18:38 +00:00
tjhunt 048373691e MDL-10843 - Backporting lang string search changes from HEAD, so question type plugins can have their help file inside their lang folder. 2007-10-03 14:01:08 +00:00
tjhunt 4e557706d3 MDL-5327 - When making up a default question name from the question text, strip any HTML tags. 2007-09-27 06:53:59 +00:00
tjhunt aac5f17176 XHTML Strict in question state history table. 2007-09-20 15:09:45 +00:00
tjhunt dc1a8255ba MDL-11317 - Slashes displayed in incorrect responses for short answer questions. Fix by adding stripslashes in the appropriate place. 2007-09-18 12:15:10 +00:00
tjhunt 1c5d61d928 MDL-10799 - Question types do not accurately determine whether their state has changed or not. 2007-08-10 15:21:16 +00:00
tjhunt 0bb51a9c00 MDL-9432 - When restoring questions, links are not recoded. Merged from OU moodle. 2007-04-18 15:57:12 +00:00
tjhunt 12ff34e245 MDL-9303 - General Feedback not shown for essay questions on review screen. Merged from MOODLE_17_STABLE. 2007-04-11 19:04:59 +00:00
tjhunt 9e6f284ae6 Followup to MDL-8994 - validate the category id we got from the form. 2007-03-22 22:01:45 +00:00
tjhunt 66adefcbf6 MDL-8994 - Question category selector on the question type editing forms is ignored. 2007-03-22 00:10:32 +00:00
tjhunt fe4acc87a0 Improve string handling in the question type base class. 2007-03-21 17:12:38 +00:00
tjhunt 1043fa2dff MDL-6386/MDL-6462 - yet more special character issues with multianswer. I think I have got them all this time. Backported from HEAD. 2007-03-20 14:31:16 +00:00
pichetp 2076251d51 Give the question bank code sensible PHPdocumentor package names. 2007-03-19 21:31:22 +00:00
tjhunt 3b563f5893 MDL-8349 - responses not being filtered in history display. 2007-03-06 18:00:13 +00:00
vyshane fe0bcf738c Merged from 1.7. 2007-02-15 06:14:00 +00:00
tjhunt f07d1d3197 When editing some question types, the options get jumbled up. 2007-01-29 12:35:29 +00:00
jamiesensei 7b41a4a989 some more small changes to datasetdependent and calculated question type forms 2007-01-18 11:21:10 +00:00
jamiesensei 92186abc95 working on multipage form for calculated question type 2007-01-11 04:59:16 +00:00
vyshane 0fd5feef05 Xhtml fixes for MDL-7861. 2007-01-08 07:58:22 +00:00
jamiesensei 271ffe3f25 various formslib work including bug fixes for MDL-8039 id attribute collision between forms and page ids. Also added editor helpbutton. This is a fix for MDL-6941 need the ability to associate several helptopics with htmleditor. Also started on converting forms for question types to formslib. 2007-01-07 12:46:47 +00:00
ikawhero 96ed722ba3 Minor change so code works on all versions of PHP 2006-12-29 02:36:41 +00:00
tjhunt 36703ed725 MDL-8003 - part - Use formslib for question editing forms
This commit does two things:
1. Gives question types he opion to use formslib for their editing forms, instead of the old mechanism.
2. Converts the truefalse question type to formslib.
2006-12-22 15:39:40 +00:00
toyomoyo 077f381461 accessiblity, associating <th> with respective row or col 2006-12-13 08:24:23 +00:00
tjhunt bb080d2046 MDL-7896 - error from random question type in adaptive mode. Merged from MOODLE_17_STABLE. 2006-12-11 23:46:15 +00:00
tjhunt 2962ad61e4 Put back spaces in code that Martin Dougiamass stripped out of the lang strings without thinking about the consequences. Merged from MOODLE_17_STABLE. 2006-11-28 18:42:18 +00:00
tjhunt ee6c93555f MDL-5811 - Quiz editing outputs nasty junk before print_header sometimes. Second attempt at fixing. I forgot to mention the bug number in the previous commit to mod/quiz/edit.php. Merged from MOODLE_17_STABLE. 2006-10-31 12:06:52 +00:00
tjhunt 879caa5172 Make things a bit more robust. Sorry, I can't remember exactly what the problem was that this fixed any more. It has been sitting around for a couple of weeks and I had forgotten to commit it. 2006-10-16 15:23:54 +00:00
tjhunt ec6adca0f4 MDL-6761 Edit qestion link gone from question preview popup. It was checking the wrong capability. 2006-10-02 17:04:12 +00:00
tjhunt a4514d91de Renamed new commentary feature to 'general feedback'. 2006-09-19 13:35:42 +00:00
tjhunt 6459b8fc8d Give a bit more information to the subclasses. 2006-08-31 16:59:52 +00:00
tjhunt 695d225c6a Clarified comment. 2006-08-31 11:28:44 +00:00
tjhunt 32b0adfade Better comments 2006-08-29 08:57:47 +00:00
tjhunt 3e3e5a4030 Renamed column question_sessions->comment at Eloy's request since comment is a DB reserved word.
I have not been able to test this fully, because I cannot assign roles (e.g. Student and Teacher) in 1.7dev at the moment to test a student answering an essay question then a teacher grading it. However, I have tested as much as possible as admin and cannot get any errors.
2006-08-24 16:44:15 +00:00
tjhunt c82f76d050 MDL-4816 Short answer question type considers '100' and '100.' to be the same Actually, this may have affected other question types too. 2006-08-23 21:17:23 +00:00
tjhunt ac249da55e Clarified comment. 2006-08-23 21:04:04 +00:00
tjhunt 647bcd4129 Fix getting the context. It did not work during question preview from the question bank when there was no quiz in sight. 2006-08-23 18:37:38 +00:00
tjhunt d758f1e2eb Fix an obvious typo in the roles and permissions code. 2006-08-22 19:26:05 +00:00
tjhunt 20808266c8 Work round Eclipse warning. 2006-08-22 19:01:42 +00:00
toyomoyo 5cf38a57cd some quiz capabilities 2006-08-22 09:04:23 +00:00
tjhunt 8d2054411c Tweak to unbreak unit tests. 2006-08-17 17:30:56 +00:00
tjhunt a21567892f Refactor how question types register themselves with the question bank. This change makes it easier for 3rd party question types to control their destiny, but is also backwards compatible, in that old 3rd party plugins will still work. See http://moodle.org/mod/forum/discuss.php?d=51796 for more details. 2006-08-15 21:25:38 +00:00
tjhunt 1b8a7434e2 Bug 6239 - Allow questions to have some teacher-supplied commentary.
While implementing this, I removed the ~100 lines of very similar code from the top of each question type's editquestion.html template, and moved this to a the function print_question_form_start() in the base class, which uses the template question/type/editquestionstart.html. This is described in more detail here: http://moodle.org/mod/forum/discuss.php?d=51590, and is why this patch makes the codebase 523 lines smaller.
2006-08-11 14:59:18 +00:00
tjhunt 5a14d563b9 Bug #5972 - Some question types mark a blank answer inconsistently.
Also, cleaned up the marking code for numerical and short answer questions, partly by making the base-class method more useful.

Rewrote the way the way short answer questions do wildcard matching to be more robust, Unicode safe, and generally not suck.

This is a big change, so I am pleased to report I tested it using my new Selinium  test suite. See: http://moodle.org/mod/forum/discuss.php?d=51161
2006-08-04 16:53:43 +00:00
tjhunt 7baff8aa1a Fix for bug 5379: Item analysis report should not have a hard coded list of question types.
Please test this if you have a moodle install with some unusual question types. Thanks.

Merged from 1.6stable.
2006-05-31 15:58:39 +00:00
toyomoyo 3925a20afe fix for 5409 2006-05-03 08:05:58 +00:00
mjollnir_ d57cf4c132 question/type/qtype hide scores when requested by teacher
Changed question/type/questiontype.php such that when review.php
displays a state-by-state review of answers submitted,
scores are not displayed unless allowed by quiz options.

Credit: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2006-05-03 02:44:25 +00:00
gustav_delius ed28abca24 Don't throw a php error when there are no question answers in the default question type. 2006-04-30 17:13:44 +00:00
thepurpleblob 25ee4157c8 missing courseid parameter in "grades not not add up to 100%" check. 2006-04-13 08:45:11 +00:00