9db58d015f
MDL-15693 - print_question_icon does not cope with missing question types
2008-07-17 12:49:28 +00:00
698945eb18
MDL-14804 - question_list_instances is broken - It does not include the each modules lib file before doing function_exists($module->name.'_question_list_instances').
2008-05-12 17:29:50 +00:00
7f761c27eb
MDL-13189 - replace the $QTYPE_MENU global with a function call, so that we can set up the language strings later, after $COURSE is initialised. This ensures that the quesion names appear in the right language.
2008-02-28 12:53:05 +00:00
3fc8fbccd6
MDL-6315 - When processing a manul grading action, if both the comment and the score are blank - as might be the case on the 'Grade all' page of the manual grading when the teacher uses it to grade some, but not all of the students - then do not record the question as graded.
2007-09-19 10:55:31 +00:00
ffeb631f28
Fix whitespace.
2007-08-10 15:54:11 +00:00
a44ce185fa
MDL-10581 - Each attemtp builds on last & multi-page quizzes was casuing grading errors.
2007-08-10 15:22:15 +00:00
aa86e60148
Possible error passing course id from page to page resolved
2007-07-26 12:36:14 +00:00
fdfe84df84
OU bug 3463 - warnings when you start an attempt in 'each attempt builds on last' mode.
2007-07-17 15:28:04 +00:00
443768b8aa
MDL-9565 - Question preview links don't work in developer debug mode, and not XHTML strict. Merged from OU Moodle.
2007-04-24 16:59:23 +00:00
346a83d25f
Work round PHP4 being a stinking pile of crap.
2007-04-13 10:03:15 +00:00
e904a8315b
Reveted Nick's alleged typo fix.
Thank you very much for trying to fix my code, but your change is definitely wrong. get_context_instance needs to be passed a coursemoduleid, not a coursemodule object.
Why did you think there was a typo?
And neither of us had noticed that I had left some debug code in. Removing that.
2007-04-13 08:12:19 +00:00
3cba887fca
Fixed a typo introduced by Tim Hunt in revision 1.85.2.11. No hard feelings :-)
2007-04-13 01:24:31 +00:00
0ece80c088
MDL-9325 - mod/quiz:ignoretimelimits does not work.
This is a really horrific short-term fix to a problem not of my making.
2007-04-12 22:16:20 +00:00
b930d5a83b
MDL-9082 - moodle/question:manage does not let you create questions. Also:
* remove useless option from print_question_icon
* use the right module context in question_list
* a bit of XHTML strrrict in question_list
2007-04-11 22:56:50 +00:00
696b50fff2
Small code cleanup to fix an obscure warning. If you got an error in the middle of creating a quiz attempt, you could get an attempt with no states. Then that caused an error when the attempt was deleted. Merged from MOODLE_17_STABLE.
2007-03-30 10:17:20 +00:00
3849917982
Fix notice. Merged from MOODLE_17_STABLE.
2007-03-30 09:34:11 +00:00
fa62c456eb
MDL-6269, MDL-8958, MDL-8990 - Major fix to do with each attempt builds on last:
...
It used not to work with random questions, and there were problems with the computation of the grade, and regrading. Fix thanks to Paulo Matos, who not only fixed the bug and tested it, but was also incredibly patient waiting for me to have time to commit the changes to CVS.
Merged from MOODLE_17_STABLE.
2007-03-29 16:35:55 +00:00
cca01e1519
Add developer debugging to something that should not happen, and fix one instance of it. Backported from HEAD.
2007-03-29 16:06:13 +00:00
aff7b7bd00
MDL-8946 - Fix a regression that broke question export.
Also, partially clean up the way that question bank navigation tabs are printed, so the code is not duplicated in the quiz.
Some other miscellaneous code cleaning too.
2007-03-21 10:40:35 +00:00
196b6f3918
MDL-8764 - In menus, show question categories from this course first, then published categories from other courses.
2007-03-05 18:05:39 +00:00
7c1fb23156
MDL-6773 - eliminate duplicate code for getting a list of question categories.
2007-03-01 09:45:19 +00:00
95e5c19295
Remove CVS confilt markers.
2007-02-28 15:11:54 +00:00
7c08ef3653
Fixed MDL-8582
...
Not sure if the hotpot module is converting ampersands correctly. $heading and $title are set up differently than in other modules: instead of outputting $course->title, a temporary $title variable is created and assigned that value. That made it difficult for me to decide whether it was already formatted elsewhere or not.
Also I didn't format_string() any of the variables included in $navigation rings, because I assume these strings get processed by print_navigation(), which includes format_string().
2007-02-28 05:36:13 +00:00
c09f474dd0
MDL-8450
Added support for including question categories in a quiz export.
2007-02-07 10:14:22 +00:00
a95cd8a650
Get the alt text for the question type icon in a better way.
2007-01-30 11:09:32 +00:00
47cdbd1f64
Question session state logic improvement - if students have not yet entered an answer, don't do an EVENT_SAVE.
2007-01-11 12:18:10 +00:00
0d905d9f34
MDL-7861 new class .icon and .iconsmall
2007-01-08 09:14:05 +00:00
375ed78a93
fixed the MoodleQuickForm_questioncategory, question_category_options function wasn't committed so I've implemented it from question_category_select_menu code.
2007-01-07 13:54:36 +00:00
271ffe3f25
various formslib work including bug fixes for MDL-8039 id attribute collision between forms and page ids. Also added editor helpbutton. This is a fix for MDL-6941 need the ability to associate several helptopics with htmleditor. Also started on converting forms for question types to formslib.
2007-01-07 12:46:47 +00:00
7cd2f598aa
More XHTML strict - removed image borders and height/width
2007-01-05 12:58:22 +00:00
dd0730c2dd
Added some cleaning to the category path for some safety.
2007-01-05 10:16:12 +00:00
bc75cc5210
Added 2 new functions: question_get_feedback_image() and question_get_feedback_class().
2006-12-18 06:07:44 +00:00
f5c154078a
Merged from STABLE. Addition function to find or create category path.
...
MDL-4163
2006-11-29 13:29:00 +00:00
84bf852c1b
MDL-7428 - Quiz regrade removes student answers from essay questions that have been graded. Merged from MOODLE_16_STABLE.
2006-11-15 17:32:49 +00:00
f9c92efef3
MDL-7531 Fix SQL that does not work in Oracle. Thanks to Mark Hetherington for the fix. Merged from MOODLE_17_STABLE.
2006-11-14 15:41:20 +00:00
95ac8a4039
MDL-6315 - Manually grading a question 0 marks was not being registered. I took the opportunity to clean up the logic in this function a bit. Merged from MOODLE_16_STABLE.
2006-10-17 23:23:18 +00:00
57f1b91497
fixed some incorrect strtolower() calls that were breaking non ascii languages MDL-6135
2006-10-07 20:47:54 +00:00
13835c77b6
MDL-6731 Can't save manual comment on a quiz question. I had missed one instance of the comment -> manualcomment column rename.
2006-10-06 17:22:08 +00:00
b20ea66988
Hopefully improve performance on site with lots of question categories Merged from MOODLE_16_STABLE.
2006-10-06 16:48:54 +00:00
1da5a36294
More capability name typos.
2006-09-20 08:01:59 +00:00
9ce384ba1e
relacing deprecated functions with capability checks
2006-09-19 14:16:40 +00:00
3e3e5a4030
Renamed column question_sessions->comment at Eloy's request since comment is a DB reserved word.
...
I have not been able to test this fully, because I cannot assign roles (e.g. Student and Teacher) in 1.7dev at the moment to test a student answering an essay question then a teacher grading it. However, I have tested as much as possible as admin and cannot get any errors.
2006-08-24 16:44:15 +00:00
3ebdddf70f
MDL-4816 Fix silly error in my commit for this bug.
2006-08-24 11:37:10 +00:00
c82f76d050
MDL-4816 Short answer question type considers '100' and '100.' to be the same
Actually, this may have affected other question types too.
2006-08-23 21:17:23 +00:00
ef82286874
Bug #6293 - Cannot regrade a question when a teacher has added a comment with a ' - Merged from MOODLE_16_STABLE.
Stupid, wreched, datalib.
Why can't datalib take care of addslashes, so the whole of the rest of the code can forget about it? That is how a database abstraction layer should work.
I know, it is pointless to moan about it, but it has just cost me 3 hours, so I feel I have earned the right to moan.
2006-08-18 22:34:54 +00:00
865b753486
Code cleanup. Merged from MOODLE_16_STABLE.
2006-08-18 22:26:04 +00:00
1780811d55
Added todo.
2006-08-18 08:14:47 +00:00
1d723a169a
Bug #6267 - questionlib.php delete_question infinite loop with rantom questions. Thanks to mbockol at carleton dot edu. Merged from MOODLE_16_STABLE.
2006-08-16 16:17:18 +00:00
a21567892f
Refactor how question types register themselves with the question bank. This change makes it easier for 3rd party question types to control their destiny, but is also backwards compatible, in that old 3rd party plugins will still work.
See http://moodle.org/mod/forum/discuss.php?d=51796 for more details.
2006-08-15 21:25:38 +00:00
1b8a7434e2
Bug 6239 - Allow questions to have some teacher-supplied commentary.
...
While implementing this, I removed the ~100 lines of very similar code from the top of each question type's editquestion.html template, and moved this to a the function print_question_form_start() in the base class, which uses the template question/type/editquestionstart.html. This is described in more detail here: http://moodle.org/mod/forum/discuss.php?d=51590 , and is why this patch makes the codebase 523 lines smaller.
2006-08-11 14:59:18 +00:00
tjhunt