Commit Graph

314 Commits

Author SHA1 Message Date
David Mudrák 3f38b28079 MDL-84321 lang: Use the fixed strings in tests, too 2025-01-27 23:11:59 +01:00
Andrew Nicols bc75ef8bbc MDL-83468 phpunit: Fix various tests after phpunit 10 2025-01-20 16:47:55 +01:00
Amaia Anabitarte f87d36d750 MDL-82034 core_course: Fix Activity chooser opening issues on behat 2024-12-20 10:31:24 +01:00
Andrew Nicols c2414e5a45 MDL-81520 core: Fix test finality 2024-12-11 12:30:23 +08:00
Laurent David 5f4c55e16a MDL-82757 mod_data: Improve group access handling
* Improved handling of group access to ensure correct visibility of records.
2024-12-04 02:44:22 +00:00
Huong Nguyen 8da8b20ff9 Merge branch 'MDL-83643-main' of https://github.com/lameze/moodle 2024-11-28 09:19:52 +07:00
Andrew Nicols 4d961d28ff Merge branch 'MDL-83551-main' of https://github.com/lameze/moodle 2024-11-22 10:50:48 +07:00
Andrew Nicols a6acb015a3 MDL-81521 core: Update all possibly data providers to be static
Note: Some data providers could not be automatically be converted to
being static. These will be handled in a separate issue.
2024-11-15 12:50:55 +08:00
Simey Lameze b3d718147d MDL-83643 behat: make manual completion scenario names unique 2024-11-13 07:16:20 +08:00
Simey Lameze 9a3abb9148 MDL-83551 behat: make duplicated scenario names unique 2024-11-13 06:48:44 +08:00
Jun Pataleta 50d8a547c7 Merge branch 'MDL-76564' of https://github.com/paulholden/moodle 2024-10-31 11:21:43 +07:00
meirzamoodle 758f79a5af MDL-82988 general: Apply helper to get path to fixture 2024-10-27 13:46:48 +07:00
Paul Holden 8e2ad49afe MDL-76564 behat: final removal of deprecated pre-404 step definitions. 2024-09-30 19:42:54 +01:00
Simey Lameze 3ac7a2f6c5 MDL-63399 behat: update existing tests to use the better download steps
Co-authored-by: Tim Hunt <T.J.Hunt@open.ac.uk>
2024-09-06 12:14:07 +08:00
Huong Nguyen dca18ebca3 Merge branch 'MDL-81634-main' of https://github.com/andrewnicols/moodle 2024-08-20 09:30:44 +07:00
Paul Holden bad720a112 MDL-82669 editor: remove reliance on Atto editor in Behat scenarios. 2024-08-02 10:33:25 +01:00
Andrew Nicols 024e36be17 MDL-81634 core: Fix all implicitly defined nullables
Note: This does not impact third-party libraries.
2024-08-02 14:11:12 +08:00
Huong Nguyen 761df2bebc Merge branch 'MDL-82236-main' of https://github.com/andelacruz/moodle 2024-07-10 09:04:00 +07:00
Angelia Dela Cruz 5a93545c52 MDL-82236 mod_data: Behat to display DB activity entry rating 2024-07-09 14:39:23 +08:00
Angelia Dela Cruz 03f4c84684 MDL-81296 mod_data: Behat test for data activity readonly availability 2024-07-09 10:52:45 +08:00
Eloy Lafuente (stronk7) 674497a12c MDL-81523 phpunit: Add all missing setUp/tearDown parent calls
All setUp(), tearDown(), setUpBeforeClass() and tearDownAfterClass()
must, always, call to parent, to ensure that everything is properly
set and cleaned.

While in a lot of situations this is not needed (parents may not
have anything to run), with PHPUnit >= 10 this can become more
important because we are going to move the reset code from current
placement @ runBare() to setUp()/tearDown().

Note that all the changes performed in this commit have been detected
and fixed by moodle-cs (ParentSetUpTearDownSniffTest).
2024-06-14 16:04:57 +02:00
Eloy Lafuente (stronk7) 4f7631113c MDL-81522 phpunit: Add missing void return type to all tests #2
This commit includes more changes, all them also adding the :void
return type to unit tests missing them.

The difference is that all these changes, while also detected
perfectly by the moodle.PHPUnit.TestReturnType sniff, were not
auto-fixed (like the previous commit ones), because all them
do include some "return" statement and, for safety, we don't
fix them.

All the cases have been visually inspected and confirmed that
the existing "return" statements always belong to anon
functions within the test body and not the test own return statement.
2024-06-11 11:55:08 +02:00
Eloy Lafuente (stronk7) 01148a0816 MDL-81522 phpunit: Add missing void return type to all tests
While this change is not 100% required now, it's good habit
and we are checking for it since Moodle 4.4.

All the changes in this commit have been applied automatically
using the moodle.PHPUnit.TestReturnType sniff and are, exclusively
adding the ": void" return types when missing.
2024-06-11 11:55:07 +02:00
Laurent David 6a2c1823ff MDL-81875 mod_data: Revert database autolink removal
Autolinks are used in the database for text fields via
the auto-linking filter.
The revert is partial here because of changes made
in MDL-70384 to all field forms/templates

This reverts commit 42edaba5 from MDL-80949
2024-06-04 16:08:16 +02:00
Paul Holden 7594612fab MDL-81274 mod_data: observe current approved value on record import. 2024-04-22 12:48:51 +01:00
Laurent David ba9b291c03 MDL-81267 mod_data: Additional tests 2024-04-17 10:33:08 +02:00
Andrew Nicols 613f933442 Merge branch 'MDL-80820' of https://github.com/marinaglancy/moodle 2024-04-15 10:42:22 +08:00
Jun Pataleta 04ec43be5e MDL-70829 mod_data: Mark up decorative images properly
* Decorative images should have an empty alt text and there's no need
to set a presentation role.
* Accessibility Behat tests added to cover the changes
2024-04-12 10:42:10 +08:00
Marina Glancy 42c76b711a MDL-80820 lib/pear: phpdoc corrections 2024-04-08 10:13:39 +01:00
Marina Glancy ef1759da74 MDL-80820 various: fix incorrect phpdocs 2024-04-08 10:13:10 +01:00
Sara Arjona 42edaba56f MDL-80949 mod_data: Remove unused Allow autolink param for text field 2024-03-18 09:47:02 +01:00
Eloy Lafuente (stronk7) 361dfe8145 MDL-75952 general: Since php81, refection->setAccessible() is no-op
Refereces:
- https://wiki.php.net/rfc/make-reflection-setaccessible-no-op
- https://www.php.net/manual/en/reflectionproperty.setaccessible.php
- https://www.php.net/manual/en/reflectionmethod.setaccessible.php

As of PHP 8.1.0, calling this method has no effect; all methods are
invokable by default. So, let's remove all uses from core, they are
no-op.
2024-03-10 21:15:00 +01:00
Paul Holden bb6652699e Merge branch 'MDL-75794-main' of https://github.com/aanabit/moodle into main 2024-02-23 12:54:00 +00:00
Amaia Anabitarte 0c081f004a MDL-75794 mod_data: deprecate behat steps to generate entries and fields 2024-02-22 17:37:54 +01:00
Sara Arjona 15d399ec8c Merge branch 'MDL-80404-main' of https://github.com/andelacruz/moodle 2024-02-21 13:23:25 +01:00
Angelia Dela Cruz 6ea99c8897 MDL-80404 mod_data: Behat for url autolinking and opening in new window 2024-02-21 15:59:44 +08:00
Huong Nguyen 0d8c9ed4ae Merge branch 'MDL-78284-main' of https://github.com/sarjona/moodle 2024-02-21 09:49:41 +07:00
Sara Arjona 8cdd62ca88 MDL-78284 theme: Add new interactive content and update styles 2024-02-15 17:49:43 +01:00
Simey Lameze 7b7be30b4d MDL-80613 behat: convert manual completion steps to use generators 2024-02-15 17:52:38 +08:00
Angelia Dela Cruz 261a39d8e2 MDL-79768 fix: Fixed random failing Behat due to time difference 2023-10-26 18:09:16 +08:00
Angelia Dela Cruz 46f31447f2 MDL-79768 mod_data: Test for student can see upcoming data activity 2023-10-23 08:52:19 +08:00
Amaia Anabitarte b87b72195c MDL-78527 core_completion: Fixing tests 2023-09-12 15:43:49 +02:00
Andrew Nicols 2b19f23665 Merge branch 'MDL-78158-master' of https://github.com/andelacruz/moodle 2023-07-05 10:23:32 +08:00
Angelia Dela Cruz 09d654b3fe MDL-78158 behat: Behat cleanup and optimisation 2023-07-04 07:01:27 +08:00
Angelia Dela Cruz 9f101a30b2 MDL-78158 Behat: Use data generators to add blocks 2023-07-03 17:41:21 +08:00
Philipp Memmel fc13869f5a MDL-40084 mod_data: Rename and move entries ex-/importer classes
Also:
- Extend test coverage
- Small bug fixes
- Codestyle
2023-07-01 20:42:01 +02:00
Philipp Memmel cf2c91dae2 MDL-40084 mod_data: Add file import support
Co-authored-by: Stefan Hanauska <stefan.hanauska@csg-in.de>
2023-06-29 19:18:15 +02:00
Philipp Memmel 4003751163 MDL-40084 mod_data: Add file export support 2023-06-29 19:18:15 +02:00
Philipp Memmel 1296a2b868 MDL-40084 mod_data: Refactor importing data
Function data_import_csv has been deprecated.
2023-06-29 19:18:14 +02:00
Philipp Memmel bdf02ec088 MDL-40084 mod_data: Refactor exporting data
Functions data_export_csv, data_export_ods, data_get_exportdata have been deprecated.
2023-06-29 19:18:14 +02:00