Commit Graph

1945 Commits

Author SHA1 Message Date
David Monllao e689d68b54 Merge branch 'MDL-52954-master-behat-fixes' of git://github.com/damyon/moodle 2016-04-14 14:26:16 +08:00
Damyon Wiese 56fa860ead MDL-53772 externallib: Fix busted webservices context handling
Fix:
$PAGE->context must be reset when calling validate_context

Improve:
Provide wrapper for calling an external function

The wrapper correctly checks the function parameters and return type against
the description of the external function, and stores the PAGE and COURSE global
state variables, restoring them before the function returns.

Fix: buggy unit tests.

These tests are expecting debugging from a bug that was fixed, and calling web
service functions with no user or session.
2016-04-14 13:58:23 +08:00
Damyon Wiese 5267d632ff MDL-52954 assign: Fixes to webservices and context.
This patch gets the behat tests passing again - but only with MDL-53772 in the branch.
2016-04-13 21:23:50 +08:00
David Monllao 497cd6d48b Merge branch 'MDL-53181-master' of git://github.com/andrewnicols/moodle 2016-03-29 09:50:52 +08:00
Rajesh Taneja a8d9cb87ba MDL-49963 behat: fixed scenario and step definition
1. Participants are sorted by last access and they could
   be different on different db's. So sort them by last name
   before checking.
2. Use Give-When-Then steps.
2016-03-22 13:46:13 +08:00
Andrew Nicols d7dbef7366 MDL-53181 core: Add selectors to user menu items 2016-03-22 09:20:21 +08:00
David Monllao 2904f66421 Merge branch 'MDL-49963' of https://github.com/andrewhancox/moodle 2016-03-21 10:04:29 +08:00
Jun Pataleta 8e24a54e52 MDL-52433 user: Remove unnecessary capability check 2016-03-08 12:23:44 +01:00
Andrew Hancox 5b7c500a71 MDL-49963 core: Select all button on participant list works across pages 2016-03-07 11:08:12 +00:00
Andrew Nicols 372d6b923b MDL-30811 core: Replace use of continue_button with redirect 2016-02-29 09:05:58 +08:00
Rajesh Taneja 7b287e09e2 MDL-50484 core_grade: courseheader id should be unique
grader report show category with courseheader id
which gets replicated for all categories on page.
This will now be courseheader_categoryname.
2016-02-19 14:00:04 +08:00
Andrew Nicols 5ddf81cd27 MDL-51214 block_news_items: Rename to "Latest announcements" 2016-02-16 10:05:27 +08:00
Eloy Lafuente (stronk7) de0a98f8ef Merge branch 'MDL-52938-master' of git://github.com/marinaglancy/moodle 2016-02-09 00:30:02 +01:00
David Monllao 52ad3afadb Merge branch 'wip-MDL-51283-master' of git://github.com/marinaglancy/moodle 2016-02-02 17:40:39 +08:00
Marina Glancy 4be9c7ad99 MDL-51283 core_tag: Allow each tag area to set 'showstandard' 2016-02-02 17:31:17 +08:00
Marina Glancy e11d7380c2 MDL-51283 core_tag: change tagtype to isstandard
Change 'official' to 'standard' in UI
2016-02-02 17:31:14 +08:00
Marina Glancy e91a07f71b MDL-52938 mod_forum: check global setting to track forum posts 2016-02-02 10:54:22 +08:00
David Monllao b831527ce8 Merge branch 'MDL-52831-master-emptynames' of git://github.com/mudrd8mz/moodle 2016-02-01 11:28:40 +08:00
David Mudrák e9c27d1e0e MDL-52831 users: Automatically strip whitespace from name fields
This change prevents from registering and/or saving the profile of a
user with the whitespace instead of the required name.

Additionally, there is accessibility improvement for better error labels
in case of missing values (copied over from signup_form).
2016-01-19 21:40:45 +01:00
Andrew Nicols 64858d435c Merge branch 'MDL-52649-master' of git://github.com/junpataleta/moodle 2016-01-13 08:58:29 +08:00
Dan Poltawski 04a03ff282 Merge branch 'wip-MDL-50851-master' of git://github.com/marinaglancy/moodle 2016-01-12 14:17:14 +00:00
Andrew Nicols 8b9a15bbab Merge branch 'MDL-52610_master' of git://github.com/dmonllao/moodle 2016-01-12 09:31:07 +00:00
David Monllao 9ccc372917 MDL-52610 user: Honour allowaccountssameemail in create_users ws
Credit to Dmitriy Kuzevanov.
2016-01-12 13:54:48 +08:00
Jun Pataleta 9488b6f3a4 MDL-52649 user: Add check for potentially undefined variables 2016-01-12 08:56:17 +08:00
Marina Glancy c4e868d5f0 MDL-50851 user: use new tag API for interests 2016-01-10 15:25:47 +08:00
Dan Poltawski 7057c3efa9 MDL-38020 participants: Use consistent link for editing enrollments
Previously the role assignment url was used when a role was selected, but
this page doesn't enrol users into the course (its the old 1.9 way
before we had the enrollments table).
2015-12-30 14:53:26 +00:00
David Monllao 2f3ebc9bdb Merge branch 'MDL-51257-master' of git://github.com/cameron1729/moodle 2015-12-21 17:32:34 +08:00
Marina Glancy c4d0b752a2 MDL-51784 various: use __construct() for PHP7 compatibility 2015-12-11 12:48:24 +08:00
David Monllao 8573e526ff MDL-51698 user: Adapting behat test
Using the generic .breadcrumb-nav like in edit_tag.feature as the elements
on it are quite generic and there is no much chance of future conflicts.
2015-12-09 13:22:38 +08:00
Cameron Ball ea3aa9f9a0 MDL-51257 messages: Improve message form.
- Add sudmit button
- Add formchangechecker
- Update behat tests
2015-12-03 10:20:55 +08:00
John Okely 956caef6ad MDL-52260 user: Fix error when saving profile with locked field 2015-11-27 10:55:28 +08:00
David Monllao 6bcff8abf5 Merge branch 'MDL-47065-master' of git://github.com/danpoltawski/moodle 2015-11-16 15:25:42 +08:00
Dan Poltawski 00d70d79a4 MDL-47065 notes: prevent empty spaces added as note
(And updated behat test for this test case)
2015-11-12 09:56:56 +00:00
Dan Poltawski 142099e2a6 MDL-47065 notes: don't add blank notes
Previously the logic was wrong and was proceeding to add a note
when content was missing.

Also add behat coverage for adding notes to participants (this test is
not perfect, but better than zero coverage we had before).
2015-11-12 09:56:14 +00:00
Eloy Lafuente (stronk7) f509e2e0a2 Merge branch 'MDL-50781-master' of git://github.com/danpoltawski/moodle 2015-11-10 20:13:21 +01:00
Eloy Lafuente (stronk7) 2e144835bb MDL-52059 versions: bump all versions and requires near release
version = planned 2015111600 release version
requires= current 2015111000 rc3 version
2015-11-10 12:33:52 +01:00
Dan Poltawski 2f3e84c132 Merge branch 'MDL-51837-master' of git://github.com/junpataleta/moodle 2015-11-09 11:33:00 +00:00
Rajesh Taneja 7b4933db3a MDL-51685 unittest: Test functionality individually 2015-11-06 11:14:17 +01:00
Dani Palou 1f7273af6a MDL-51685 user: Support gravatar images in user_get_user_details 2015-11-04 08:40:19 +01:00
Dan Poltawski 24c3db91a4 MDL-50781 user: do not print useless table cell
Thanks to Maurício Severo da Silva for the patch
2015-11-03 10:51:49 +00:00
rajesh Taneja 4b274a10c2 MDL-51981 behat: No need for JS tag
This scenario crashes win-chrome and probably
other comninations. Looking at this, it seems
js tag is not needed, so removing js tag to make
it pass on all OS
2015-10-30 11:29:52 +08:00
Kevin Wiliarty b71890687a MDL-51834 auth,profile: locks custom fields based on auth settings 2015-10-22 23:39:49 -04:00
Jun Pataleta b47454f6b7 MDL-51837 user: Check if user email is set on validation
Add a check if the user's email is set before performing validation on
the user's email address. This is to prevent the warning messages to
be shown in the case of a pending email change which causes the user's
email field to be not included in the Edit profile form.
2015-10-19 16:50:01 -05:00
Andrew Nicols 3648d7963a Merge branch 'MDL-51427-master' of git://github.com/marinaglancy/moodle 2015-10-13 10:13:43 +08:00
Dan Poltawski 4a06e40908 Merge branch 'MDL-50142_master' of https://github.com/dmonllao/moodle 2015-10-07 12:19:13 +01:00
Ben Tindell f611319ed4 MDL-50142 user: context sensitive help
Added context sensitive help to
Edit Profile > Text Editor
2015-10-05 09:32:32 +08:00
Marina Glancy 810805da9e MDL-51636 core_tag: allow setting tags in generators 2015-10-04 22:25:37 +08:00
Eloy Lafuente (stronk7) c75b891ba7 Merge branch 'MDL-49821-master-master' of git://github.com/jleyva/moodle 2015-10-01 01:26:58 +02:00
David Monllao 161649644d Merge branch 'MDL-51415-master' of git://github.com/jleyva/moodle 2015-09-30 14:15:29 +08:00
David Monllao 07d370849b MDL-42639 user: user:viewalldetails enough to view some fields
The fields are:
- username
- idnumber
- institution
- department
2015-09-29 16:55:14 +08:00