Commit Graph

2493 Commits

Author SHA1 Message Date
Huong Nguyen c15cb5586c Merge branch 'MDL-79539-401' of https://github.com/meirzamoodle/moodle into MOODLE_401_STABLE 2023-10-04 10:56:09 +07:00
Andrew Nicols 2f6519d2de Merge branch 'MDL-78580_401_STABLE' of https://github.com/marxjohnson/moodle into MOODLE_401_STABLE 2023-10-03 11:23:54 +08:00
meirzamoodle 15c7909885 MDL-79539 core: handling negative input to get the upper value
Co-authored-by: Alain Corbière <alain.corbiere@univ-lemans.fr>
2023-10-02 20:57:08 +07:00
Sara Arjona 54d446ce43 MDL-77708 docs: Update references from docs.moodle.org/dev 2023-09-26 10:57:33 +02:00
Jake Dallimore 2a2edcde93 Merge branch 'MDL-79186-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-09-19 11:12:51 +08:00
Mark Johnson e6b80e155b MDL-78580 report_statistics: Prevent database deadlocks when viewing
If a quiz had a long job to calculate statstics running, this would
cause pages that may also attempt a recalculation (the statistics report
page or question bank) to load very slowly, and possibly result in a
database deadlock.

This change will firstly prevent the question bank page performing
analysis calculations at all, since these are not required for this
page, which will speed up loading and prevent deadlocks on this page.

Secondly, this adds a lock to the recalcuation process so that it cannot
run twice concurrently. This will present the user with a message to
indicate that it is waiting for a running calculation until it is
complete, and eventually it will timeout with a message and debugging.
2023-09-15 15:16:12 +01:00
Paul Holden 721b02a270 MDL-79186 task: fix evaluation of 'X/Y' cron field format.
The above syntax is defined as supported by the class, for example the
format '5/10' means:

"At every 10th <unit> from 5 through <max>."

It is analogous to '5-<max>/10'.
2023-09-11 09:22:26 +01:00
Jake Dallimore 35e8d7517f MDL-79181 core: update LinkedIn OAuth template to use OIDC
The old method (sign in with linkedin) is deprecated:
https://learn.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin

This replaces this with the new method:
https://learn.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin-v2

This is not entirely OIDC compliant, however. The well known
openid-configuration isn't present at the issuer root and the 'locale'
claim contains an object instead of a string. These are worked around.
2023-09-11 10:42:35 +08:00
Ilya Tregubov bc67d4491c Merge branch 'MDL-79139-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-08-28 15:40:51 +08:00
Andrew Nicols bf47757ef3 Merge branch 'MDL-78811-MOODLE-401' of https://github.com/aydevworks/moodle into MOODLE_401_STABLE 2023-08-25 00:02:49 +08:00
Paul Holden c5967dd7d0 MDL-79139 check: clarify default user role action text. 2023-08-23 13:35:44 +01:00
Jun Pataleta 88459bba94 MDL-78983 core: Preserve default behaviour of flipping question icon
Introduce a lang string `questioniconfollowlangdirection` that will
allow the current behaviour of displaying the question mark icon
in RTL languages in the same manner as the current language.
2023-08-11 16:11:05 +07:00
Jun Pataleta b504d19c12 MDL-78983 core: Fix question mark icon direction flipping
This fixes the changes made in MDL-75047:
* Change `thisicondirection` langconfig string to a more specific one
  like `questionicondirection`.
* Use existing direction string value `ltr` for the value of
  `questionicondirection`. Also add a comment to at least provide some
  form of documentation for it.
* Improve the logic for applying the horizontal flipping class for the
  question icon:
  - Check first if the icon is a question icon
  - Flip the icon if `questionicondirection` is set to `rtl`.
2023-08-11 11:48:10 +08:00
Huong Nguyen 00e6ac4ad8 Merge branch 'MDL-75047-MOODLE_401_STABLE' of https://github.com/SysBind/moodle into MOODLE_401_STABLE 2023-08-09 11:30:49 +07:00
Marcus Boon 3295c4bc1d MDL-78632 filetypes: Introduce yaml file type 2023-07-28 15:28:15 +10:00
Alex Yeung 356e1d8f31 MDL-78811 check: fix duplicate column contextid warning 2023-07-24 22:49:52 +01:00
Ilya Tregubov c057bc092d Merge branch 'MDL-67852_MOODLE_401_NEW' of https://github.com/aydevworks/moodle into MOODLE_401_STABLE 2023-07-11 11:12:16 +08:00
Alex Yeung 236f4654c0 MDL-67852 tool_dataprivacy: Fix security checks 2023-07-09 14:50:10 +01:00
Jun Pataleta 213223d162 MDL-77690 core: New activity_header method get_heading_level()
Add a new method for activity_header that determines the heading level
depending on whether the theme displays a heading for the activity
header (usually a h2 heading with the activity name).

E.g. in Boost, the activity name is already being displayed in a
heading. So page headings can be rendered as h2. However, on Classic,
the activity name is being displayed as a h2 heading. So headings need
to be adjusted for the activity pages.
2023-06-30 17:51:12 +08:00
Huong Nguyen 684889be8f MDL-78554 tiny_link: Add a TinyMCE link plugin
Backport of MDL-76520

Co-authored-by: Andrew Lyons <andrew@nicols.co.uk>
2023-06-26 15:45:56 +08:00
Andrew Nicols dedfbb7e63 Merge branch 'MDL-78461-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-06-15 11:23:27 +08:00
Paul Holden 43d715777a MDL-78461 core: fix base plugininfo class reference to root directory. 2023-06-13 14:05:31 +01:00
Paul Holden 05074c1ca3 MDL-74824 user: fix custom change password URL in login notification. 2023-06-11 17:41:09 +01:00
Andrew Nicols 7dc747ea99 Merge branch 'MDL-77264-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-06-08 11:32:46 +08:00
Stevani Andolo 69596a6bb2 MDL-78215 core: support checking if 0.0.0.0 is in subnet 2023-06-08 09:37:01 +08:00
Andrew Nicols 30e9810589 Merge branch 'MDL-78151-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-05-18 11:48:39 +08:00
Paul Holden 01ae473823 MDL-77264 grade: define fallback name of abstract export event. 2023-05-16 09:54:40 +01:00
Tim Hunt efe895f1bb MDL-75576 quiz/question statistics: don't expire by time
Previously, a set of calculated quiz statistics would only 'last' for
15 minutes. Then they would be considered invalid and not used.

Now, computed statistics are kept indefinitely. Instead, when a new
batch of values are computed for a particular set of settings, older numbers
for the same settings are deleted first. Therefore,
question_stats_cleanup_task is no more.
2023-05-15 10:04:34 +01:00
Paul Holden c228866a46 MDL-78151 core: account for timezone differences in intl extension.
Recent additions to timezones from the IANA TZDB are not necessarily
reflected in those used by the intl extension and/or ICU zones:

 * America/Ciudad_Juarez
 * America/Nuuk
 * Europe/Kyiv
 * Pacific/Kanton

Create mapping to allow these zones to be used without errors.
2023-05-10 17:12:33 +01:00
Andrew Nicols 50d1e69df6 MDL-75552 badges: move apiBase consumption to backpack
The apiBase in .well-known/badgeconnect.json was ignored and it was
causing some failures when connecting or sending badges to an
external backpack.
For OBv2.1, it has been changed to always use the apiBase defined
in the badgeconnect.json backpack provider.
2023-05-09 08:51:30 +02:00
Jake Dallimore 79fe493ab4 Merge branch 'MDL-77384-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-05-03 16:52:45 +08:00
Paul Holden 22b481f73c MDL-77384 check: clarify statistics check name. 2023-04-25 09:04:41 +01:00
Marina Glancy ccdaef7a68 MDL-78009 auth: require necessary files 2023-04-24 13:38:58 +01:00
Ilya Tregubov bb5bd2eed8 Merge branch 'MDL-77436-401' of https://github.com/meirzamoodle/moodle into MOODLE_401_STABLE 2023-04-20 16:23:19 +08:00
Ilya Tregubov dd553c1406 Merge branch 'MDL-77827-401' of https://github.com/HuongNV13/moodle into MOODLE_401_STABLE 2023-04-18 08:59:30 +08:00
Huong Nguyen 2f601f1e51 MDL-77827 events: Changed JSON comparison to be less strict 2023-04-14 12:29:32 +07:00
Jun Pataleta c99abd65ca MDL-77783 core: Validate sublugins.json
* Validate the decoded subplugins.json before processing it.
* Log errors if subplugins.json is invalid or if plugintypes is not
defined.
2023-03-29 09:29:57 +08:00
Meirza 110ec6a703 MDL-77436 auth_oauth2: Update profile fields based on data mapping.
After the user creation, the system must call an update function to update profile_fields_*.
We also provided two functions into user/profile/lib.php to get available from other areas.
We added PHP unit testing for new public functions and
the Behat tests for custom profile fields with locked and unlocked statuses.

Co-authored-by: Matt Porritt <matt.porritt@moodle.com>
2023-03-28 11:47:23 +07:00
Matt Porritt 714764d966 MDL-77436 auth_oauth2: Allow admin to choose profile fields for mapping
Update oauth2 to allow mapping of provider attributes against
user profile fields. Fields can also be locked to prevent
user changes.

Co-Authored-By: Michael Milette <michael.milette@tngconsulting.ca>
2023-03-28 11:46:51 +07:00
Jun Pataleta 69948eda10 MDL-77105 core: Method to determine whether a plugin has monolog icons 2023-03-27 13:36:38 +08:00
Mark Johnson 34c452afb4 MDL-72124 question: Fix system-level URLs in question events 2023-03-14 15:40:26 +00:00
Lars Bonczek d5ec540381 MDL-75659 core: Don't render component argument twice in mustache pix helper 2023-03-08 01:00:30 +00:00
Jun Pataleta 2c290f4bb8 Merge branch 'MDL-77430_401' of https://github.com/stronk7/moodle into MOODLE_401_STABLE 2023-03-01 23:59:28 +08:00
Andrew Nicols 3df3b9dfb2 Merge branch 'MDL-74585-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-03-01 10:51:45 +08:00
Eloy Lafuente (stronk7) be32856374 MDL-77430 plugininfo: php81 deprecation warnings on missing plugins
Whenever some plugin is missing from disk but installed, the plugins
page (and the upgrade) shows them as "missing from disk". Still, the
code tries to do things with their directory that, now, is null.

That was silently defaulting to '' in previous php versions, but
php81 emits a deprecated warning. So we have to check for them.
2023-02-28 11:41:04 +01:00
Andrew Nicols 3c262bb46f MDL-77248 mod_bigbluebuttonbn: Set dpa accepted when creating activities
This only applies when creating activities using the test data
generator.
2023-02-28 12:04:51 +08:00
Andrew Nicols 9d5e363b41 MDL-77248 core: Move pre_enable_plugin_actions callback to enable_plugin 2023-02-28 12:04:51 +08:00
Paul Holden 58d85f21da MDL-74585 core: pass string identifier/component to network keepalive.
Avoid passing potentially large amounts of data in the page AMD call,
allow the `core/network` module to load actual string content itself.
2023-02-22 16:20:34 +00:00
Andrew Nicols eed3f09aa0 Merge branch 'MDL-76878-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-02-16 10:43:56 +08:00
Miri Lipson a10f75360b MDL-75047 icons: Define the orientation of the question mark in right-to-left languages. 2023-01-23 17:26:45 +02:00