Commit Graph

117 Commits

Author SHA1 Message Date
tjhunt 3e10e4292d quiz editing: MDL-17454 first attemtp, and MDL-18554
This is a minimal fix for MDL-18554, I have just added a cancel button and made it work.

The more substantial part of this is MDL-17454, trying to make the quiz editing screen behave appropriately when shuffle questions is on. I am sure Olli will have opinions about this and want to change it further. Rought summary:
* When shufflequestions is off, never restrict manual paging, even if questionsperpage is set.
* When shuffle questions is on:
** Always display the quiz with the defined number of questions per page.
** Remove controls to add things except at the end of the quiz.
** Disable most of the order and paging tab, but still allow the question list to be reordered, in case that helps teachers track which questions they have added.
** Still allow questions to be reordered on the edit tab, but when moving the top question on a page up, reorder with the previous question, rather than moving to the previous page.
* Change the status bar, so that the yellow highlight is reserved for alert information. The more informative stuff is now plain, and moved to under the title. To my mind that associates it more closely with the quiz name. Also it moves Total of grades and Maximum grade closer together.
* JavaScript cleaned up. I learn more about YUI every day.
* Some PHP code clean ups that I forgot to commit separately before making substantive changes.
2009-03-17 09:51:34 +00:00
tjhunt f5831eeac0 quiz editing: coding style cleanup. 2009-03-06 04:06:48 +00:00
tjhunt 4299df1daf quiz editing: Refactor the editing actions to make functions in editlib.php for most of them.
In the process, do MDL-17456, move/delete questions by question id rather than position, for greater robustness.
2009-02-27 08:45:05 +00:00
tjhunt 944efb3e8b quiz editing: MDL-18376 Since there is no grading for description, we can show more question text. Thanks Olli. 2009-02-26 06:51:35 +00:00
tjhunt 8e84d9788c quiz editing: MDL-18173 tidy up wording and add cursor: help. 2009-02-25 07:27:02 +00:00
tjhunt cd120b2344 quiz editing / question bank: MDL-18355 Convert the add question drop-down to be a button that pops up a YUI dialogue.
That allows us to have a few sentences explanation of each question type, and is also easier to fit into a tight layout.

This commit should also fix MDL-18214 Layout screwed in Safari with long category names.
2009-02-25 07:14:03 +00:00
tjhunt 3cac440b76 quiz editing: MDL-18173 Make clear in the UI whether a random question selects from subcategories or not. 2009-02-24 05:16:23 +00:00
tjhunt 7b161e1290 quiz editing: MDL-17284 improve wording for delete -> remove all selected questions. 2009-02-13 07:11:55 +00:00
tjhunt 5bbdaed2a1 quiz editing: MDL-17455 fix non-unique first column in get records. Thanks Olli for spotting this. 2009-02-12 05:04:19 +00:00
tjhunt 4cc11ff992 quiz editing: MDL-17455 fix missing global. Oops. 2009-02-11 10:35:41 +00:00
tjhunt 2a874d65ce quiz editing: MDL-17455 refactor the editing code to use the locallib functions to print the icons.
Also, use the new method in the random question class to get the list of random questions reliably.
2009-02-11 10:08:07 +00:00
tjhunt ad041fad59 quiz editing: MDL-17296 final attempt to get the display of the open/closed state here to Olli's satisfaction ;-) 2009-02-11 08:12:19 +00:00
tjhunt ad65ff47d8 quiz: MDL-17873 small efficiency gains. 2009-02-11 07:52:26 +00:00
tjhunt b7a9dc5193 question bank: MDL-17992 and MDL-17397. Put back questiontext as a separate row option, and increase consistenscy between stand-alone qbank and the display in the quiz editing page. 2009-01-23 05:01:37 +00:00
tjhunt e4d1d5e010 question bank: MDL-17871 finish refactor of code into one class per column.
Needs tidying up, but basically there, so checking it in.
2009-01-22 09:19:37 +00:00
tjhunt 971c6fca06 question bank: MDL-17871 Kill most of the duplicated code between mod/quiz/editlib.php and question/editlib.php 2009-01-22 05:38:18 +00:00
tjhunt 5bd22790c4 question bank: MDL-17871 refactor the code that displays particular information about each question into classes.
More work in progress. Print column headers, and improve sorting. These classes are still not used.
2009-01-21 07:21:43 +00:00
tjhunt 5b5e5ab20c question bank: MDL-17302 refactor question bank display code into a class.
Step 2. Remove as many as possbile of the differences between the two classes. This is mostly whitespace and irrelevant code formatting issues, but there are also a few changes to the generated output, taking the best of both views.
2009-01-19 08:50:48 +00:00
tjhunt f4b879ddea question bank: MDL-17302 refactor question bank display code into a class.
Step 1. Just convert the existing functions quiz_question_showbank and question_showbank and friends into methods of a class and subclass.

More to come.
2009-01-19 05:30:01 +00:00
tjhunt 940b5fbb72 quiz editing: MDL-17296 further improve display of open and close dates on the editing page. 2009-01-12 07:24:03 +00:00
tjhunt d1be90991b quiz editing: XHTML strict 2009-01-09 05:26:26 +00:00
tjhunt e476804cdb quiz editing: MDL-17296 improve display of open and closde dates on the editing page. 2009-01-09 03:17:18 +00:00
tjhunt 477c217f5c MDL-17294 Eliminate some commented out code, and clean up the 'no questions in quiz' special case. 2009-01-05 05:26:08 +00:00
skodak 973d2660e6 MDL-16613 sesskey cleanup 2009-01-02 10:51:26 +00:00
skodak 81911e4d34 MDL-16613 sesskey cleanup 2009-01-02 10:36:27 +00:00
skodak d4a1fcaf11 MDL-16613 sesskey cleanup 2009-01-02 10:36:25 +00:00
pilpi dbd2b0fd45 quiz editing: MDL-17595 changed string from "question name" to "question" 2008-12-10 14:44:40 +00:00
pilpi d8875b3eae quiz editing: MDL-17590 added an id attribute for the grading input field to make labels work 2008-12-10 12:04:28 +00:00
skodak ecb45a9e40 MDL-17275 fixed DML syntax 2008-12-09 23:46:03 +00:00
tjhunt 4e6f553d43 quiz editing: MDL-15903 fix the code that updates $quiz->sumgrades,
so we only update the database when something changes, not on every page view.
2008-12-05 05:08:37 +00:00
pilpi 74c640b3a7 quiz editing: MDL-17409 converted string to use $a
created new string
2008-12-04 15:53:30 +00:00
pilpi 5af1b21ab2 quiz editing: MDL-17409 converted strings to use $a
converted concatenation to use $a instead for new (committed with the rest of Quiz UI redesign project) strings, created new strings for old strings that did not yet use $a
2008-12-04 15:13:22 +00:00
pilpi 3e6ad1d7a4 quiz editing: MDL-17409 removed ":" from source
removed ":" from source where they occured with new (committed with the rest of Quiz UI redesign project) strings and changed the strings accordingly
2008-12-04 13:28:20 +00:00
pilpi 588a58b8d9 quiz editing: MDL-17294 improved the error situation handling in process_randomquestion_formdata 2008-11-28 19:43:45 +00:00
pilpi 49a020c672 quiz editing: MDL-17294 removed unnecessary comments 2008-11-28 18:57:43 +00:00
pilpi 94da24dc76 quiz editing: MDL-17294 added a call to quiz_question_tostring() 2008-11-28 18:47:46 +00:00
pilpi 8c4d6dd2a2 quiz editing: MDL-17294 removed the $showbreaks parameter from quiz_print_question_list 2008-11-28 18:37:24 +00:00
pilpi c7c7f25a84 quiz editing: MDL-17294 changed quiz_process_randomquestion_formdata to always return (instead of sometimes redirecting) 2008-11-28 17:29:04 +00:00
pilpi 439d9cbe90 quiz editing: MDL-17452 customized the link tooltip to "Remove empty page" for the link for deleting an empty page 2008-11-28 16:33:48 +00:00
pilpi 8333ad82ae quiz editing: MDL-17398 Added "show category contents" as a tooltip for the link with the category name as its contents 2008-11-28 16:27:42 +00:00
pilpi 3814fb96fc quiz editing: MDL-17398 link to edit random question (configuration) in new UI 2008-11-28 15:43:10 +00:00
pilpi 7b2c3bde9e quiz editing: MDL-17451 CSS and whitespace fixes to truncate overlong question category name
Tested on opera 9.27, IE6, Firefox 3 on Ubuntu Linux 8.04
2008-11-28 15:16:40 +00:00
pilpi 9cdcf82665 quiz editing: MDL-17398 cleaned up random question display in the edit subtab
made the link in an empty random question more readable, added a link to show category contents after the list of sample questions of a random question
2008-11-28 14:07:06 +00:00
pilpi 9e5d7a8c5b quiz editing: MDL-17418 added back (removed comments around) random question preview link for also the random question printing function for the order and paging tab. 2008-11-26 16:24:46 +00:00
pilpi 101cad083a quiz editing: MDL-17294 added back (removed comments around) random question preview link 2008-11-26 13:16:49 +00:00
tjhunt 2e883810d3 quiz editing: MDL-17296 refactor print_timing_information to avoid duplicating code from mod/quiz/accessrules.php 2008-11-26 04:52:46 +00:00
tjhunt d7129a519f accessibility / lang strings: MDL-17359 remove > being used as an arrow - screen readers don't like it. 2008-11-25 13:15:53 +00:00
pilpi 414d5bfb7e quiz editing: MDL-17290 doc comments were updated 2008-11-22 15:28:46 +00:00
pilpi 3fd9edf010 quiz editing: MDL-17300 it is now possible to change question grades after there are quiz attempts 2008-11-22 13:45:45 +00:00
pilpi 8bccba71e6 quiz editing: MDL-17299 Moved function definitions from mod/quiz/edit.php to mod/quiz/editlib.php 2008-11-22 12:36:14 +00:00