Commit Graph

66 Commits

Author SHA1 Message Date
tjhunt 60ec12e055 MDL-14804 - question_list_instances is broken - It does not include the each modules lib file before doing function_exists($module->name.'_question_list_instances'). 2008-05-12 17:29:52 +00:00
tjhunt e7a84ec034 MDL-6269, MDL-8958, MDL-8990 - Major fix to do with each attempt builds on last:
It used not to work with random questions, and there were problems with the computation of the grade, and regrading. Fix thanks to Paulo Matos, who not only fixed the bug and tested it, but was also incredibly patient waiting for me to have time to commit the changes to CVS.

This commit also includes a backport of a small state logic changes to the 1.6 stable branch.

Backported from MOODLE_17_STABLE.
2007-03-30 16:05:14 +00:00
tjhunt 14a62bfcd5 MDL-7428 - Quiz regrade removes student answers from essay questions that have been graded. 2006-11-15 17:32:32 +00:00
tjhunt 32fd8433d9 Remove obsolete code. 2006-11-15 16:47:58 +00:00
tjhunt 24fcdd14c0 MDL-6315 - Manually grading a question 0 marks was not being registered. I took the opportunity to clean up the logic in this function a bit. 2006-10-17 23:19:15 +00:00
tjhunt e1088a97ec Hopefully improve performance on site with lots of question categories. 2006-10-06 16:45:16 +00:00
tjhunt 6ca5cf268b Reverting last change. I committed the wrong file. 2006-10-03 17:59:51 +00:00
tjhunt b9bdd0c7b6 MDL-5601 - restoring a course with a multianswer question sometimes causes an error() for a non-fatal contition. Change it to a notify, and everything seems to work. I don't really understand why, but this change does not make matters worse, so I am committing it. Thanks to Joseph Rezeau. 2006-10-03 17:56:51 +00:00
tjhunt 2b64c31597 Bug #6293 - Cannot regrade a question when a teacher has added a comment with a ' Stupid, wreched, datalib. Why can't datalib take care of addslashes, so the whole of the rest of the code can forget about it? That is how a database abstraction layer should work. I know, it is pointless to moan about it, but it has just cost me 3 hours, so I feel I have earned the right to moan. 2006-08-18 22:34:25 +00:00
tjhunt f7abe85cc0 Code cleanup. 2006-08-18 22:25:39 +00:00
tjhunt da4714358a Bug #6267 - questionlib.php delete_question infinite loop with rantom questions. Thanks to mbockol at carleton dot edu. 2006-08-16 16:16:42 +00:00
tjhunt 96ef5c792a Fixed typo which caused images in questions to fail to display if NOT using slasharguments. Merged from HEAD - original checkin was 1.49 to 1.50 by danstowell. 2006-07-18 15:37:17 +00:00
tjhunt e10e4fdd55 Bug #6033 - missing string for unknown questiontype. Also tidied up some messy code. 2006-07-18 15:27:50 +00:00
tjhunt d0f8a899f8 Bug 6111 - Rewrite the code for making an indented list of question categories, becase the existing code was so horrible. 2006-07-14 15:32:57 +00:00
tjhunt 52bf72770c Bug 6031 - missing parameter for warningmissingtype in libquestionlib.php 2006-07-06 11:09:03 +00:00
tjhunt 6d812d61a2 Bug #5922 - comment from manualgraded questions lost during regrade. Thanks to Jean-Michel Vedrine for the fix. 2006-06-28 11:40:56 +00:00
tjhunt 6aeb5a1f35 Bug 5889 - Regrading a quiz wipes student answers. Thanks to Jean-Michel Vedrine for the fix. 2006-06-26 11:21:08 +00:00
gustav_delius 07f8831194 Introduce question_attempts table, closing bug 5468
Fixed incorrect check for whether to update state or insert new one in save_question_session()
Deal with manually graded states correctly during regrading
Increase state sequence number during manual grading
Supplied missing userid to quiz_save_best_grade() during manual grading
2006-05-13 16:41:22 +00:00
thepurpleblob 3b438e0db9 Moved some of the category functions back here. Caused much
more grief than I anticipated.
2006-05-08 10:38:03 +00:00
thepurpleblob 9c802dff19 Bunch of category functions moved to question/editlib.php 2006-05-02 12:26:36 +00:00
thepurpleblob 947217d725 Small clean up, and fix a link to a required file for robustness. 2006-05-02 09:04:38 +00:00
gustav_delius 2b44d03f81 Error message for when a questiontype is missing is prepended to question text. 2006-04-30 17:33:00 +00:00
gustav_delius 2e9b6d157c Fixed bug 5192 2006-04-30 16:15:04 +00:00
gustav_delius ca56222d50 Fixed and simplified the logic in the response processing. Remove the walking through previous graded states. 2006-04-30 11:45:14 +00:00
gustav_delius c4c11af898 Now that the shuffling within a question can be controlled also at question level the default at the module level needs to be set to true, otherwise people can not test the question setting. 2006-04-30 08:11:49 +00:00
skodak 6cf4cbbdf9 added FIX ME notice for inclusion of format.php 2006-04-22 17:21:21 +00:00
thepurpleblob 2784b98278 Don't compare floats for equality! Bug #5176 2006-04-13 10:29:20 +00:00
gustav_delius da1cc5a44e Fixed problem with slashes, bug 5177 2006-04-13 00:37:14 +00:00
gustav_delius cbe20043b5 Whenever a question is edited the version field is set to question_hash(), see bug 2958. 2006-04-10 22:10:32 +00:00
gustav_delius 848d886edb Small change to question_print_comment_box() to allow multiple boxes on one page 2006-04-09 22:48:58 +00:00
gustav_delius 1d7e093418 Small fix so that unattempted questions would never be marked 2006-04-09 21:35:44 +00:00
gustav_delius 7c404f9b2b Fixed some small xhtml problems and removed a warning 2006-04-08 14:20:52 +00:00
gustav_delius 2a2aba273f submit button for teacher comment is now included in question_print_comment_box 2006-04-08 08:22:18 +00:00
gustav_delius b6e907a245 Manual grading 2006-04-07 16:00:29 +00:00
gustav_delius 755bddf118 Improvements to response history. Three small bug fixes. 2006-04-06 19:59:02 +00:00
gustav_delius 3a5a6f59a3 Introduce field for teacher comments, in preparation for manual grading 2006-04-06 16:42:00 +00:00
gustav_delius 0a5b58af89 Many bugfixes accummulated during CVS outage, more to come. 2006-04-05 05:53:18 +00:00
gustav_delius bc2feba364 Some preparation for manual grading 2006-03-27 17:38:30 +00:00
gustav_delius d23e3e11dd Moved the code for basing new attempts on previous attempts from questions to quiz and fixed the bug reported at http://moodle.org/mod/forum/discuss.php?d=42029#194212 in the process 2006-03-26 07:59:43 +00:00
gustav_delius 5cb9076a58 Removed warning when deleting questions with no states 2006-03-25 21:07:11 +00:00
gustav_delius 4eda4eecbd Added question type that is used if a question of unknown type is encountered.
Also removed some of the unnecessary calls to name()
2006-03-24 21:21:59 +00:00
gustav_delius ca252edb1d Setting title attribute on questiontype icons so that tooltips show the question type name 2006-03-24 20:02:42 +00:00
gustav_delius aaae75b04f Renaming question/questiontypes/ to question/types/ as requested by Martin 2006-03-24 19:54:13 +00:00
gustav_delius 643ec47d32 Renaming question/questiontypes/ to question/types/ as requested by Martin 2006-03-24 19:31:46 +00:00
gustav_delius 0429cd86c3 Deleting attempts properly now 2006-03-22 18:27:28 +00:00
gustav_delius 4dca7e51ca Some minor improvements in the handling of review options, the setting of timestamp, and improvements to the documentation 2006-03-22 17:22:36 +00:00
thepurpleblob 8511669cb9 Added function for matching/checking question grades on quiz import. 2006-03-22 16:27:46 +00:00
thepurpleblob e9de436630 Split out grade option list generation, so it can be used in import/export too. 2006-03-22 14:43:55 +00:00
gustav_delius 6040798269 Abolished the qtype integers. The question types are now indexed by their name as specified by their directory name. This will avoid a lot of confusion in future when we have plugable question types. 2006-03-21 23:08:36 +00:00
gustav_delius cf60a28a0b Fixed small problem in delete_question() 2006-03-21 15:33:30 +00:00