Commit Graph

83 Commits

Author SHA1 Message Date
Sam Hemelryk 8b05c5e2bd MDL-27962 Fixed typo in tablelib preventing columns from being collapsed 2011-06-23 13:33:28 +08:00
Tim Hunt d8a3b87c0e MDL-27340 tablelib.php fix a notice when is false. 2011-05-01 17:36:19 +01:00
Eloy Lafuente (stronk7) 11a6763546 MDL-26425 tablelib - fix tr class typo (detected @ MDL-27034) 2011-04-06 10:58:39 +02:00
Tim Hunt 71811083ba MDL-27035 table_sql forgets to set countparams. 2011-03-30 20:25:43 +01:00
Tim Hunt ba9164e575 MDL-26425 tablelib more cleanup, mostly to PHPdocs, following sam's comments. 2011-03-27 20:06:45 +01:00
Tim Hunt 76dc1e2527 MDL-26425 tablelib use html_writer when outputting rows and headers.
This includes refactoring to extract methods like sort_icon and show_hide_link which I think makes the code easier to read.

Note also the change to make_styles_string that makes it usable with html_writer. (Perhpas we need a css_writer classe ;-))
2011-03-27 20:06:44 +01:00
Tim Hunt 6f0d3480c7 MDL-26425 tablelib change print_initials_bar to remove duplication, and to use html_writer. 2011-03-27 20:06:44 +01:00
Tim Hunt b08fb128c8 MDL-26425 tablelib ability for table_sql to add a class to the row based on the data. 2011-03-27 20:06:43 +01:00
Tim Hunt abf72969a4 MDL-26425 tablelib change col_username to use html_writer and moodle_url. 2011-03-27 20:06:43 +01:00
Tim Hunt e81eed542c MDL-26425 tablelib better validation of the sort code, also some cleanup.
You may think that the extra validation is unnecessary, since the sort fields are already validated when the URL parameters are parsed, however that overlooks an important point. There may be other options that affect which columns are in the SQL, for example the quiz show individual question grades setting. These other options can cause a column that was in the table, and being sorted on, to disappear. Therefore, it is necessary to re-validate the sort columns when they are used, to make sure they are still present, otherwise you can get ORDER BY sql that refers to non-existant columns, which then causes DB errors.
2011-03-27 20:06:42 +01:00
Tim Hunt 59f392b3f0 MDL-26425 tablelib clean up setup and URL handling code.
Note that this change removes ->reseturl, This was supposed to be a way to reset all the session stuff relating to a table automatically in some situations, but from using Moodle and reading the code, I don't beleive it was working. The code was horrible and not easily fixible, and has been broken for years, so I just removed it.
2011-03-27 20:06:42 +01:00
Tim Hunt a49c17b424 MDL-26425 tablelib rename constructors to PHP5 __construct
and add depreacted functions with the old name so that legacy code does not break.
2011-03-27 20:05:55 +01:00
Tim Hunt 4b7079c100 MDL-26425 tablelib clean up constant definitions. 2011-03-27 19:55:10 +01:00
Tim Hunt 9683db71c9 MDL-26425 tablelib mass whitespace clean-up. 2011-03-27 19:55:10 +01:00
Sam Hemelryk 367a75fae4 themes lib MDL-24895 Multiple fixes to better handle overflow.
Major tasks undertaken in this patch:
* New format_text argument, overflowdiv.
* New page layout Report.
* Review of all format_text calls.
* Added support for the report layout to all themes.
* Changed forum post display from tables to divs.
2010-11-05 02:53:47 +00:00
Tim Hunt 6944b5e47e tablelib MDL-24327 CSV and TSV export was not right.
For example, cells containing \n or " were not handled properly.
2010-09-22 14:14:10 +00:00
Petr Skoda 365a594107 MDL-24321 switching to stdClass in /lib/ 2010-09-21 08:07:44 +00:00
Petr Skoda 230405214f fixed fatal dml conversion regression 2010-09-18 11:20:21 +00:00
Petr Skoda ee70439a64 MDL-24079 fixed recent and old regressions in tablelib, next commit is going to include fixes for usage of tablelib 2010-09-05 12:27:17 +00:00
Petr Skoda 20a79b4316 MDL-24079 fixed potential SQL injection in tablelib 2010-09-04 13:02:49 +00:00
Petr Skoda 78bfb562a0 MDL-21249 improved php docs and adding direct access prevention in core libs 2010-07-25 13:35:05 +00:00
Sam Hemelryk f4136193b7 mod-assignment MDL-22686 Implemented solution for overflow hidden of submission table 2010-07-20 05:19:22 +00:00
David Mudrak 6855dc3088 MDL-21695 Removing unused help files
tableexportformats.html removed as suggested by Helen.
2010-06-28 14:36:50 +00:00
Martin Dougiamas 03d9401e7d My Moodle MDL-19124 New version of My Moodle, User profiles and Course profiles, all with block support
Thanks very much to Remote Learner Canada, especially Hubert Chathi and Olav Jordan, for their work on the bulk of this code, and also Mike Churchward for supporting them.  I worked on it after that (actually simplified it by removing a feature temporarily: multiple pages) to bring it more to what I was imagining, and to provide a base to build on and get all the navigation perfect.

There's still work to do.  Some blocks don't quite work as expected, and some of the code still needs upgrading to bring it fully into line with 2.0.  We also could use a much better course overview block and better CSS styling of the profile pages.  But it's definitely more usable this it was, I think.
2010-05-04 13:04:35 +00:00
Petr Skoda 596509e431 MDL-21695 renaming ->help_icon() to old_help_icon() and going to introduce new help_icon() with new parameters and detailed debugging - hopefully this will help during the conversion to new help 2010-04-13 20:34:27 +00:00
Petr Skoda 61bb07c257 MDL-22050 removing moodle/langconfig duplicates
AMOS BEGIN
  MOV [alphabet,core],[alphabet,core_langconfig]
AMOS END
2010-04-10 17:30:00 +00:00
Tim Hunt 9baf267016 tablelib: MDL-22011 refactor flexible_table::get_sql_sort into several smaller methods.
Also, change assignemnt to use a separate static method, rather than overloading get_sql_sort.
2010-04-01 13:09:24 +00:00
Petr Skoda 929d7a8362 MDL-20204 converted paging_bar to new coding style + fixed regressions from recent commits 2010-02-17 16:59:41 +00:00
Rossiani Wijaya 4eb95309f5 MDL-18774 - fixed fullname format label. 2010-01-25 09:08:22 +00:00
Petr Skoda d776d59ee2 MDL-21235 fixed select method name 2010-01-16 18:29:51 +00:00
Petr Skoda 4b9210f31b MDL-21235 more conversion to new select 2010-01-16 18:25:51 +00:00
Petr Skoda 4bcc51185c MDL-21217, MDL-21198 simplified/improved outputlib help icon related apis + several fixed regresions 2009-12-30 15:19:55 +00:00
Petr Skoda b5d0cafc6f MDL-20787 final switch to new $OUTPUT->pix_url() - yay! 2009-12-16 21:50:45 +00:00
Petr Skoda 117bd74897 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 11:31:16 +00:00
nicolasconnault b28c784fd0 MDL-19799 Upgraded calls to print_paging_bar 2009-09-08 08:39:30 +00:00
skodak 92ebcabeb3 MDL-20169 fixed coding style, parameter type required 2009-08-27 19:14:45 +00:00
nicolasconnault aa9a686740 MDL-19799 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:20:12 +00:00
nicolasconnault 54b1669246 MDL-19799 Upgraded calls to choose_from_menu 2009-08-18 00:18:19 +00:00
nicolasconnault 25911860e3 MDL-19799 Converted calls to print_paging_bar 2009-08-07 01:38:36 +00:00
nicolasconnault 3c15938527 MDL-19799 Migrated calls to print_heading 2009-08-06 08:19:21 +00:00
tjhunt f2a1963c43 MDL-19690 - lots more $CFG->pixpath to $OUTPUT->old_icon_url 2009-07-02 11:09:15 +00:00
samhemelryk 72fb21b65b lib MDL-19236 Added boilerplates and copyrights 2009-05-26 05:18:52 +00:00
tjhunt eba40bfe7a tablelib: Fix typo. 2009-03-10 05:00:16 +00:00
tjhunt c7ecf78e5f tablelib: MDL-18372 Let people specify a CSS class name to add to the <tr> element. 2009-02-25 08:07:19 +00:00
jamiesensei ef27e74273 MDL-16869 "Exporting leaves <p> </p> in essay responses" added method to flexible_table class format_text that takes the same parameters as format_text the function in weblib. If the table is not in download mode then this formats the text as html. If it is then it strips the tags or does the right thing depending on the download type. Added methods to download classes to tell flexible_table class what should be done with html. 2008-10-14 15:00:26 +00:00
jamiesensei 869309b8d8 MDL-14202 "Replace Item Analysis Report with new improved 'Statistics' report." finished statistics report. This patch includes some changes to lib/tablelib.php so that it is possible to export the content of a table as part of a multi table export - with mutliple tables / multiple worksheets. 2008-09-11 12:48:08 +00:00
jamiesensei db16ac502a MDL-16126 "Altering the number of students shown can lead to students being inadvertently hidden" make sure that initials bar is shown if we are filtering by initials. 2008-08-29 06:03:02 +00:00
jamiesensei 43ec99aa74 MDL-15268 "Content for Quiz Statistics report table" further work on quiz statistics report. 2008-07-30 09:02:44 +00:00
jamiesensei 0fa4107dfc MDL-15719 "overview report slow for large data sets - count sql operation for table paging repeated twice whether or not it is necessary" 2008-07-20 12:21:59 +00:00
jamiesensei f36a330892 MDL-14187 "Improve tablelib - improve api and add functionality to download table contents in a variety of formats - XLS, ODS and CSV" initialize array. 2008-06-14 13:18:14 +00:00