Commit Graph

8 Commits

Author SHA1 Message Date
tjhunt 4659454ac6 manage roles: MDL-8313 fix bugs with safe overrides. 2008-11-18 08:08:18 +00:00
tjhunt bbdb7070ca manage roles: MDL-8313 Provide a basic mode for the manage roles page.
* New basic define roles mode, with just an Allow checkbox for each capability.
* Button to toggle this form to/from advanced mode.
* Also, a separate mode for viewing a role definition, rather than just showing disabled checkboxes.
* Now duplicating a role just takes to you a pre-populated add role form, so you can double-check things before saving the new role.
* Deleting a role is now logged.
* Role reordering code cleaned up.
* You can now no longer delete the last role that has admin permissions.
* This includes a general refactor of manage.php, which eliminates manage.html, and splits of define.php.
2008-11-18 07:10:00 +00:00
tjhunt e9abdd1b84 Fix typo. 2008-11-14 11:48:29 +00:00
tjhunt f4acee5d78 role manage ui: MDL-8313 First version of the basic/advanced role define page.
This is being separated from manage.php. This code is only partly working. It displays (most) of a role definition, but does not yet let you save changes. However, I wanted to commit it before going home on Friday night. Since this is new code, it won't break anything.
2008-11-14 11:46:01 +00:00
tjhunt a4df1cbbe5 role manage ui: MDL-8313 Refactoring and clean-up prior to basic/adv manage page. 2008-11-14 10:38:06 +00:00
tjhunt 8aee9bcc27 role override ui: MDL-8313 basic mode + toggle + usability improvements
* Basic mode just hides the prohobit column. Sadly that is all we can do.
* Button to toggle in and out of advanced mode, with user_perference.
* The permission you are selected is now on the page as a label, rather than just being in a tool-tip. (Not pretty, but helpful, I think. I may change my mind on this.)
* You can click anywhere in the table cell, rather than having to hit the radio button exactly.
* Brief instructions at the top of the page.
* Submit buttons both top and bottom of the page.
2008-11-14 05:46:27 +00:00
tjhunt c6505f1eaa role override ui: MDL-8313 refactor the page in preparation for making an non-advanced mode. 2008-11-14 03:28:15 +00:00
tjhunt 1e8e46879c roles interface: Code reorganisation and adding boilerplate comments.
I have collected code that used to be in lib/adminlib.php, lib/accesslib.php and user/selector/lib.php into a new admin/roles/lib.php file.

And I added standard GPL and Moodle comments to all the files in admin/roles.
2008-11-13 04:07:01 +00:00