Commit Graph

52 Commits

Author SHA1 Message Date
Petr Skoda f8311defeb MDL-31301 use static textlib methods 2012-03-03 11:46:13 +01:00
Petr Skoda 33dca15616 MDL-30613 use standard https checks 2011-12-09 21:28:04 +01:00
Chris Scribner 4c598b133f MDL-20534 lti: Updating privacy settings dynamically based on matched Launch URL. 2011-11-21 16:42:12 +01:00
Eloy Lafuente (stronk7) feeb52949f MDL-30328 some whitespace changes 2011-11-21 02:23:51 +01:00
Eloy Lafuente (stronk7) 27e5ce8b9f Merge branch 'MDL-30328' of git://github.com/scriby/moodle 2011-11-21 02:22:40 +01:00
Eloy Lafuente (stronk7) e5235e6eef Merge branch 'MDL-30326' of git://github.com/scriby/moodle 2011-11-21 02:03:51 +01:00
Eloy Lafuente (stronk7) 5f72d1025b MDL-30354 lti - whitespace fixes 2011-11-21 01:57:24 +01:00
Eloy Lafuente (stronk7) d167cc3397 Merge branch 'MDL-30354' of git://github.com/scriby/moodle 2011-11-21 01:48:52 +01:00
Chris Scribner 036e84c389 MDL-30354 lti - B27 - locallib changes 2011-11-18 12:38:41 -05:00
Chris Scribner 8f45215d1c MDL-20534 lti: B28 - Update attribution headers. 2011-11-17 16:29:50 -05:00
Charles Severance 6edcab7a1a MDL-20534
Undo change that Chris already did.
2011-11-17 10:35:07 -05:00
Charles Severance 461bde28d8 MDL-20534
Add the tool_consumer_info fields and fix parsing of custom parameters.
2011-11-17 10:34:58 -05:00
Chris Scribner 34eb05018f MDL-20534 lti: Some cleanup of locallib.php 2011-11-17 10:34:45 -05:00
Charles Severance ddcfda87d6 MDL-20534
I ran the software through the certification and caught a few nits:

The error return is 'failure' not 'error'
The spec says that it needs to return 'failure' for out of range or non-numeric grades
The result score needs a language tag, hard-coded as 'en'
Setting a grade multiplied by 100 but reading the grade did not divide by 100
All those are now fixed with this patch as well as this bit of cruft:

I removed the "extension service url" as it is not implemented in service.php

Feel free to review and adjust - probably the one place you might want to refactor
is that I put code to catch out-of-range-and non-numeric in
lti_parse_grade_replace_message and threw an exception on error and then caught
it in service.php and sent back the 'failure' message. Feel free to refactor a
bit if you see this done in a cleaner manner.
2011-11-17 10:34:23 -05:00
Chris Scribner 0297a3d4b7 MDL-20534 lti: Updating the tool consumer information strings to match newest spec version. 2011-11-17 10:34:07 -05:00
Chris Scribner 776e5cfa0f MDL-20534 lti: B8 - Switching from $ME to $FULLME to properly detect SSL requests. 2011-11-17 09:35:56 -05:00
Eloy Lafuente (stronk7) 5f1362550f MDL-20534 lti: reformat queries and fix some errors 2011-11-08 02:12:39 +01:00
Chris Scribner 5de15b83cc MDL-20534 lti: Replacing <<< strings with normal multi-line strings. 2011-11-07 01:05:42 -05:00
Eloy Lafuente (stronk7) fabd4fcf53 MDL-20534 lti: A4, add some todos towards unified Oauth 2011-11-06 22:05:11 -05:00
Eloy Lafuente (stronk7) ea04a9f989 MDL-20534 lti: A3, coding style + some scope, constructors 2011-11-06 22:02:26 -05:00
Chris Scribner e27cb316aa MDL-20534 lti: A3, whitespace fixes (Changes by stronk7) 2011-11-06 22:00:40 -05:00
Chris Scribner 61eb12d4df MDL-20534 lti: A3, copyright and DOS lf fixed 2011-11-06 21:51:06 -05:00
Chris Scribner d8d0412168 Updating SSL settings & configuration for the LTI plugin. 2011-11-06 20:42:03 -05:00
Chris Scribner 1d4f052e46 Update role checking to check course role if module is not available 2011-11-06 20:42:02 -05:00
Chris Scribner 16cac56633 Fixing the method used to get LTI roles 2011-11-06 20:42:02 -05:00
Chris Scribner feb30fd891 Only consider configured tools when receiving LTI web service calls 2011-11-06 20:42:01 -05:00
Chris Scribner 558be8fcef Adding a comment about the ext_submit button 2011-11-06 20:42:00 -05:00
Chris Scribner c4d80efeb6 More work on the tool return page to help the user get the tool configured. 2011-11-06 20:42:00 -05:00
Chris Scribner 9d57ad1737 Fix a bug introduced recently that broke launches (adding the return url after signing). Trim the launch URL to prevent signature errors. 2011-11-06 20:41:59 -05:00
Chris Scribner 3dd9ca2430 Some bug fixing & mostly done with help message when an unsigned request doesn't work. 2011-11-06 20:41:59 -05:00
Chris Scribner 020eea1be8 Updating web service verification method to work for LTI messages that don't send a source id.
Adding extension so other plugins can handle LTI web service calls.
2011-11-06 20:41:59 -05:00
Chris Scribner d66865d95b Fixing a coding error. 2011-11-06 20:41:58 -05:00
Chris Scribner 57d1dffd38 Implementing the return URL.
Still needs some help text when an error occurs.
2011-11-06 20:41:57 -05:00
Chris Scribner 3ff01b2fb7 Adding the lis_outcome_service_url to the launch 2011-11-06 20:41:56 -05:00
Chris Scribner 5e078d62c6 Refactoring some code to use constants and deleting old services 2011-11-06 20:41:56 -05:00
Chris Scribner f17f49595c If no launch URL is specified, launch to the base URL of the tool. 2011-11-06 20:41:55 -05:00
Chris Scribner 67ddf8472b Removing some unused code. 2011-11-06 20:41:55 -05:00
Chris Scribner cca9d3f769 Updating launch container for mobile devices 2011-11-06 20:41:54 -05:00
Chris Scribner f4f711d79b Updating LTI submission viewer 2011-11-06 20:41:54 -05:00
Chris Scribner 795dff011f Updates to get the plugin to work side-by-side with the basicLTI plugin 2011-11-06 20:41:53 -05:00
Chris Scribner 7023b65ef5 Favor course tools over global tools 2011-11-06 20:41:52 -05:00
Chris Scribner 16e8f13084 Improving the experience of instructor managed tool types 2011-11-06 20:41:52 -05:00
Chris Scribner 606ab1a13e A couple bugfixes related to instructor defined tools 2011-11-06 20:41:51 -05:00
Chris Scribner 6831c7cd4b LTI plugin updates. Finishing support of course level plugins. 2011-11-06 20:41:51 -05:00
Chris Scribner b69dc42951 Fixing a couple issues with grade receipt 2011-11-06 20:41:51 -05:00
Chris Scribner 996b0fd961 Updates to lti plugin & progress on instructor management of course tools. 2011-11-06 20:41:50 -05:00
Chris Scribner dbb0fec9fd Renaming global functions to include lti prefix 2011-11-06 20:41:50 -05:00
Chris Scribner b9b2e7bbf8 Adding oauth body code (from Chuck), implemented outcome services (only replaceResult tested) 2011-11-06 20:41:49 -05:00
Chris Scribner 879e97bd3b Extracting add/edit type functions for reuse 2011-11-06 20:41:48 -05:00
Chris Scribner a0eeacf9c7 Fixing issues with launching a tool which is not configured in the admin side, and improving utility methods for determing if a tool should be registered 2011-11-06 20:41:47 -05:00