Commit Graph

63 Commits

Author SHA1 Message Date
Petr Skoda cdbea7eed1 MDL-31607 use full course object for require_login() if already available
This eliminates 1 db query.
2012-04-22 17:41:47 +02:00
Rossiani Wijaya b4c0739547 MDL-20447 - add heading to the page and fix navbar content. 2010-05-28 04:28:05 +00:00
Petr Skoda a685593466 MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions 2010-01-16 15:39:56 +00:00
Petr Skoda 649cf95d0b MDL-21147 renamed find_renderer back to get_renderer() - there are no more collisions with those magic getters 2009-12-17 14:06:22 +00:00
Petr Skoda 56cbc53b76 MDL-21143 theme renderers related refactoring, it should detect more problems now, there is also a list of core renderer subtypes, hopefully the api changes are improvements 2009-12-17 13:45:54 +00:00
Petr Skoda 78946b9bdb MDL-20204 first batch of major theme changes, some regressions are still there, expect more changes and improvements soon; see tracker for details and list of subtasks 2009-12-16 18:00:58 +00:00
Sam Hemelryk 8f685009b3 forum MDL-21086 cleaned up boilderplates and php doc packages 2009-12-10 03:11:18 +00:00
Sam Hemelryk c23c90093e mod-forum MDL-17550 Converted subscribers.php to use the new user_selector control
At the same time I also converted weblib.php::check_theme_arrows to use UTF8 arrows rather than entities.
2009-12-10 02:11:28 +00:00
Sam Marshall f1035deb97 MDL-21009 Group selector must use absolute links in order to work with javascript off 2009-11-30 17:12:48 +00:00
Petr Skoda 441bef0f7a MDL-20901 fixed input validation 2009-11-21 15:26:54 +00:00
Petr Skoda 1adbd2c350 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 14:55:15 +00:00
samhemelryk cd4e6b1769 mod-forum MDL-19808 Added set_url calls, replaced deprecated functions 2009-09-24 06:41:04 +00:00
samhemelryk 15ca5e5e0d forum MDL-19808 Upgraded print_header and build_navigation calls to OUTPUT/PAGE equivilants 2009-09-04 05:50:21 +00:00
nicolasconnault 59e28d8f5d MDL-19808 upgraded calls to print_table, print_single_button, print_user_picture, print_container* and notice_yesno 2009-08-20 08:44:35 +00:00
nicolasconnault 9146b979fe MDL-19808 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:14:39 +00:00
nicolasconnault 396fb912ff MDL-19808 Converted all print_footer() calls 2009-08-06 14:14:09 +00:00
nicolasconnault f43f1834d3 MDL-19808 Migrated calls to print_heading 2009-08-06 08:23:02 +00:00
tjhunt 8d8d0bfaae forum subscriptions: MDL-14876 user of deprecated functions was breaking managing subscribers.
This was visible when, for example, unusual role definitions meant that someone could access a forum without being enrolled in a course.

Note that one of the places that was previously broken was front page forums. Since subscribers.php does not do paging at all, the fact that I have fixed this bug makes this page dangerous on large sites. A proper solution will have to wait until bug 17550 is fixed in HEAD.

This also fixes a minor problem introduced by MDL-12979.
2008-12-11 07:01:57 +00:00
skodak 294ce9870f MDL-15189 magic quotes finally removed 2008-06-09 16:53:30 +00:00
skodak c3df090199 MDL-14679 datalib conversion completed 2008-05-30 16:47:21 +00:00
dongsheng 3f4891b4ea "MDL-14129, fix print_error" 2008-05-29 02:22:37 +00:00
skodak 624a690b3d MDL-14679 first part of datalib conversion 2008-05-25 09:39:02 +00:00
dongsheng 5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
skodak 65bcf17b95 MDL-13450 and MDL-13303 - sorry for changing forum API so late, but it was needed; major perf improvement for forum; fixed printing of user pictures; merged from MOODLE_19_STABLE 2008-02-13 17:03:25 +00:00
tjhunt 38e179a4ed MDL-11741 - Convert core modules to take advantage of recent improvements to build_navigation.
This check-in removes about 400 lines of code. I hope I have not screwed anything up. I would be grateful if people could review this change, and keep an eye on the navigation bar in modules.

Any navigation bar bugs you find in the near future, feel free to file them in the tracker and assign them to me. Thanks.

If not to many problems are found, I think I would like to backport this to 1.9 stable, but I am not sure that is a good idea. Opinions to the General Developer Forum please. I am about to start a thread there.
2007-10-12 15:55:49 +00:00
Martin Langhoff 13534ef716 cvsimport fixups 2007-08-29 13:10:11 +12:00
mattc-catalyst 01e3838853 MDL-9473: Initialise navlinks array before use
Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-07-05 04:55:24 +00:00
mattc-catalyst 3b27b0fe21 MDL-9615: Correct incorrect use of term breadcrumbs
- $crumbs -> $navlinks


Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-07-05 04:40:48 +00:00
mattc-catalyst 70c6c0ad70 MDL-9474: Updated build_navigation() to use global $COURSE
- Removed $course parameter from build_navigation()
- Updated all calls to build_navigation()


Author: Matt Clarkson <mattc@catalyst.net.nz>
Committer: Matt Clarkson <mattc@catalyst.net.nz>
2007-04-23 21:11:10 +00:00
mattc-catalyst e3f58dfb4e Breadcrumbs: mod/forum changes
- Modified to use build_navigation() for breadcrumb generation.


Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-04-16 21:12:29 +00:00
moodler 0468976c9a SWEEPING CLEANUP
The API was changed slightly so that has_capability now takes the
whole $context object (we almost always have it anyway)

The $kill thing was removed.   If you want to assert a capability
then use:

    require_capability('capname', $context);

with optional variables to modify the error message

Misc bugs here and there also removed and code tidied
2006-08-14 05:55:40 +00:00
moodler bbbf2d4015 ROLES AND PERMISSIONS - FIRST CHECK-IN
=======================================

WARNING:  DEV IS CURRENTLY VERY UNSTABLE.

This is a mega-checkin of the new Roles system.   A lot of changes have
been made in core and modules.

Currently there are a lot of rough edges and known problems.  We are
working hard on these .. .the reason for getting this into HEAD at this
stage is enable us to move faster (our branch was diverging from HEAD
too much).

Please keep an eye on http://docs.moodle.org/en/Roles for current status
and information for developers on how to use the new Roles system.
2006-08-08 05:13:06 +00:00
skodak 23ca8954be removed isset_param() and fixed warning 2006-02-12 11:24:24 +00:00
moodler ea30fc5c0b Incorrect value being passed to header function.
Merged from stable. (SE)
2005-09-14 07:25:48 +00:00
thepurpleblob 70e3da07fd Changed all optional_variable() and require_variable() to equivalent
optional_param() and required_param() for greater security.
2005-06-10 19:54:41 +00:00
stronk7 3849dae80f Now the FIRST string working under CFG->filterall is done:
forum->name
(everything tested but email)

(I'm going to maintain a list of strings in Developers Wiki)
2005-03-26 01:57:40 +00:00
gustav_delius cd8d4471c8 Print course in footer 2005-03-17 15:12:07 +00:00
moodler b9dc937d01 Removed some redundant wrappers 2005-03-13 16:25:30 +00:00
gustav_delius ec81373f50 In order to ensure that when a teacher hides a resource or an activity that students really can't get at it, even if they know the direct links to its pages, I have given an optional third argument $cm to the functions require_login() and require_course_login(). Pages showing information about a particular course module now pass the course module object in this third argument. The login functions will then test if either the course module is visible or the user is a teacher. If neither is the case then the user is redirected to the course homepage after being shown a message "Sorry, this activity is currently hidden".
(While I was at it I also turned the autologinguests off for most module pages, except on the index.php pages and the view.php pages for those modules that allow guests)
2005-02-16 10:40:48 +00:00
moodler f1c1d2f166 Removing the THEME variable and adding in classes where appropriate 2005-02-10 10:41:22 +00:00
moodler d30867b0bf Removed some THEME stuff 2005-01-25 14:28:47 +00:00
urs_hunkler 680afe2e26 _ added the DIV framework for new CSS 2005-01-19 13:16:29 +00:00
gustav_delius 8f0cd6ef0f Resolved problems with previous replacement of
& to &amp; and fixed redirect() to entity encode the
inut where needed.
Julian Sedding
2004-09-21 11:41:58 +00:00
gustav_delius 41905731b7 fixed capitalization and quoting of attribute values 2004-09-12 16:24:41 +00:00
gustav_delius 90fcc576ea Removed notices by introducing new function print_header_simple() which works on site as well as in courses without extra logic. 2004-08-21 20:20:58 +00:00
gustav_delius 369fa1b01a Moved the raw SQL out of here and into the new search_user function in datalib.php. 2004-08-21 12:43:17 +00:00
gustav_delius f88803e06d Improved subscription editing interface according to discussion at http://moodle.org/mod/forum/discuss.php?d=11089#53612 2004-08-15 21:01:34 +00:00
gustav_delius 90e7063e45 Editing teacher can now subscribe users to a forum, see http://moodle.org/mod/forum/discuss.php?d=11089 2004-08-15 12:38:29 +00:00
gustav_delius f81be26aee Fixed bug 1443: In the case of a "Teacher Forum" the "Subscribe everyone to this forum" button now only subscribes teachers. 2004-05-23 20:46:29 +00:00
moodler d31262021a Minor tweaks I forgot to check in from a long time ago 2004-05-18 03:14:01 +00:00