Commit Graph

296 Commits

Author SHA1 Message Date
tjhunt b55797b8cc MDL-15452 - Put the OU quiz navigation improvements into the Moodle codebase. I was able to factor out some commonalities with review.php along the way. 2008-07-15 15:30:39 +00:00
jamiesensei 98f38217bb MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade" 2008-07-11 07:27:14 +00:00
scyrma 5a254a2938 MDL-14279: use get_file_url instead of checking $CFG->slashargument manually (merge from 1.9) 2008-07-10 09:55:11 +00:00
tjhunt 66d07f81a1 MDL-15538 - Rework attempt.php to use attemptlib.php - I had broken processing of submitted responses. Hopefully it is fixed again now. 2008-07-08 18:22:18 +00:00
tjhunt 78e7a3dd5d MDL-15452 - Put the OU quiz navigation improvements into the Moodle codebase - quite a lot of progress, sorry I am committing this as a big lump, but it took me a while to get the code back to a working state.
MDL-15537 - create oo attemptlib.php to hold shared code between attempt, summary and review.php
MDL-15541 - Refactor starting a new attempt into a new file startattempt.php
MDL-15538 - Rework attempt.php to use attemptlib.php
2008-07-08 16:33:47 +00:00
tjhunt 373f0afd24 MDL-15494 - No allowance for the possibility that something might go wrong when processing the response to a question. 2008-07-01 13:34:09 +00:00
tjhunt b10c38a37b MDL-15452 - ongoing - Put the OU quiz navigation improvements into the Moodle codebase
* Javadoc comments for most of the code I committed on Friday.
* Implement the get_question_status method.
* Along the way, refactor duplicated logic between two of the question types, questionlib, and the new code - removing inconsistency while doing so.
2008-06-30 16:56:49 +00:00
jamiesensei 455c3efa13 MDL-14204 "Content for Quiz Statistics report table - Random_guess_score" oops ought to give that function name a 'question_' prefix 2008-06-16 13:59:30 +00:00
jamiesensei 6f51ed72be MDL-14204 "Content for Quiz Statistics report table - Random_guess_score" added method random_guess_score to question type objects and a new function in questionlib that calls the question type method. 2008-06-16 13:29:00 +00:00
thepurpleblob 7ba71c513b MDL-15228
The old 1.9 code ignored any multiple results so I guess this can do the
same.
2008-06-13 11:13:31 +00:00
nicolasconnault 415f8c3eeb CONTRIB-490 Fixed minor bugs uncovered by generator script 2008-06-12 12:55:13 +00:00
nicolasconnault b9bd6da4f8 CONTRIB-490 Added support for scripted generation of questions. Calculated type not yet supported (datasets too complicated ;) 2008-06-12 09:15:16 +00:00
skodak 294ce9870f MDL-15189 magic quotes finally removed 2008-06-09 16:53:30 +00:00
skodak eb84a826d5 MDL-15102 dml converted questionlib 2008-06-09 12:16:54 +00:00
skodak 1c69b88529 MDL-14679 removed all instances of set_field_select() 2008-06-01 16:14:59 +00:00
skodak 534792cd82 MDL-14679 removed all instances of get_records_select_menu() 2008-06-01 15:52:12 +00:00
jamiesensei 720be6f2c3 MDL-5241 "When manually grading, identity questions by their number within the quiz as well as by question name"
Also added a drop down box to select question to mark instead of the viewquestions table. The drop down box is available at the top of every page, but only if there is more than one manually gradeable question in the quiz. If there is only one question it is automatically selected for marking.

Also added a new constant QUESTION_EVENTS_GRADED during a general refactoring of UI code in grading report and some improvements to efficiency of SQL in report.

Merged from Moodle 1.9 branch
2008-05-26 11:39:51 +00:00
tjhunt 994c8c3509 MDL-14835 - Grade not checked against valid range when manua grading 2008-05-15 16:02:12 +00:00
dongsheng d89ec019db "MDL-14129, fix print_error" 2008-05-14 08:37:38 +00:00
skodak e2b347e933 MDL-14378 When deleting course category deal with everything that depends on its context; merged from MOODLE_19_STABLE 2008-05-13 21:52:38 +00:00
tjhunt 7453df700f MDL-14804 - question_list_instances is broken - It does not include the each modules lib file before doing function_exists($module->name.'_question_list_instances'). 2008-05-12 17:29:56 +00:00
tjhunt 7fb1b88dc7 MDL-10899 - There is some data associated with some questons that needs to be udpated when moving questions between categories. This commit deals with subquestions, and lays the foundation for fixing the other problem - datasets - which is files as bug 14767. 2008-05-09 15:05:36 +00:00
scyrma 59fa45d0f1 MDL-11113: simplify the code - use only one function to check for html editor availability 2008-05-07 07:40:50 +00:00
dongsheng 5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
tjhunt e2ae84a298 MDL-13189 - replace the $QTYPE_MENU global with a function call, so that we can set up the language strings later, after $COURSE is initialised. This ensures that the quesion names appear in the right language. 2008-02-28 12:53:02 +00:00
tjhunt 8ad877b6ad Unset a meaningless id. This probably does not change anything in moodle, but it was part of a bug fix in the OU version of Moodle that seemed correct, so I am merging it over. 2007-12-17 15:29:48 +00:00
jamiesensei 0f6475b396 fix for error message 2007-11-26 13:32:23 +00:00
tjhunt 6c58e1985b MDL-6376 - fix minor errors in the previous commit.
More significantly, this patch changes the '1 Students have made 1 attempts' string.

To start with, this code was being produced in five different places, so I made a function to do the work!. Next, as you can see, it is not gramatical. Also, some people find it confusing, as in MDL-6376.

Therefore, it now just says 'Attempts: 1'.

Merged from MOODLE_19_STABLE.
2007-10-30 19:29:45 +00:00
tjhunt fca490bca0 MDL-6315 - When processing a manul grading action, if both the comment and the score are blank - as might be the case on the 'Grade all' page of the manual grading when the teacher uses it to grade some, but not all of the students - then do not record the question as graded. Merged from MOODLE_18_STABLE. 2007-09-19 10:56:24 +00:00
jamiesensei 8f0f605ddf moved question_make_default_categories function to questionlib.php since it is needed by other modules outside the question bank editing interface. 2007-09-18 11:23:29 +00:00
jamiesensei d0508099c6 oops. Stray 'as' used for table name alias in SQL. 2007-09-07 08:01:08 +00:00
jamiesensei 9fc3100f27 fix for MDL-11106 Images not showing up in shared categories 2007-09-04 11:55:10 +00:00
jamiesensei 9f1017a0be correct logic error that broke caching. 2007-08-16 05:19:33 +00:00
tjhunt 1e05bf54b2 Space beteen category name and count. 2007-08-15 12:06:21 +00:00
tjhunt d402153a54 MDL-10581 - Each attemtp builds on last & multi-page quizzes was casuing grading errors. Merged from MOODLE_18_STABLE. 2007-08-10 15:22:28 +00:00
jamiesensei 3bee1ead40 merging MOODLE_19_QUESTIONS with HEAD 2007-08-09 21:50:59 +00:00
tjhunt 4f2c86ad81 OU bug 3463 - warnings when you start an attempt in 'each attempt builds on last' mode. 2007-07-17 15:27:59 +00:00
jamiesensei 61d9b9fc5d oops. reverting changes which shouldn't have been committed to HEAD. 2007-05-25 05:49:51 +00:00
tjhunt 6e9debfbf1 Removing remaining references to RQP in core code. I had not realised there were so many. By the way, I am committing this from a pub in York. Pub's with wireless, whatever next? 2007-05-24 17:25:37 +00:00
jamiesensei d92b9d9140 new sql to fetch question counts for categories all in one sql query. Question count now included in drop down box. 2007-05-21 09:26:17 +00:00
jamiesensei 3a3c454ede UI for editing questions changed to support sharing questions in multiple contexts. Also changed import / export and category editing form to use formslib. 2007-05-20 16:17:48 +00:00
poltawski a044c05ddb MDL-9742 - changed tabs to spaces in a few places where there are one
or two
2007-05-08 15:07:25 +00:00
jamiesensei 71e0eda8f7 standardizing params for edit question page. All pages now use courseid instead of course or id. 2007-04-30 06:48:57 +00:00
tjhunt 47e1697814 The question core code was restricting question types unnecessarily. This is a temporary fix, prior to a proper refactoring. 2007-04-25 11:20:22 +00:00
tjhunt 732c472fca Remove duplicate $Id$ 2007-04-24 23:23:25 +00:00
tjhunt 7d87171ba9 MDL-9565 - Question preview links don't work in developer debug mode, and not XHTML strict. Merged from OU Moodle. 2007-04-24 16:59:32 +00:00
tjhunt c73189115f Work round PHP4 being a stinking pile of crap. 2007-04-13 10:03:10 +00:00
tjhunt 0558f04745 Reveted Nick's alleged typo fix. Thank you very much for trying to fix my code, but your change is definitely wrong. get_context_instance needs to be passed a coursemoduleid, not a coursemodule object. Why did you think there was a typo? And neither of us had noticed that I had left some debug code in. Removing that. 2007-04-13 08:12:08 +00:00
nicolasconnault f4c0d852a2 Fixed a typo inadvertently introduced by Tim Hunt in revision 1.85.2.10. 2007-04-13 01:26:22 +00:00
tjhunt b423cff11a MDL-9325 - mod/quiz:ignoretimelimits does not work. This is a really horrific short-term fix to a problem not of my making. Merged from MOODLE_18_STABLE. 2007-04-12 22:16:47 +00:00