Commit Graph

122 Commits

Author SHA1 Message Date
Mark Nelson d8e550e4ac MDL-33791 Portfolio: Fixed security issue with passing file paths. 2012-11-08 00:26:40 +01:00
Rossiani Wijaya 2a336b5ef1 MDL-34650 - accessibility compliance: Add <label> for form input text and select tag 2012-07-31 12:09:18 +08:00
Sam Hemelryk 3211569a6a Revert "MDL-30843 and MDL-30842 - accessibility compliance: Add <label> for form input text and select tag"
This reverts commit f9f281b8fe.
2012-04-11 17:18:58 +12:00
Rossiani Wijaya f9f281b8fe MDL-30843 and MDL-30842 - accessibility compliance: Add <label> for form input text and select tag 2012-03-30 16:26:58 +08:00
Sam Hemelryk 18cdcdbf89 MDL-30989 portfolio: Fixed up phpdocs 2012-02-15 15:33:06 +13:00
Rossiani Wijaya 93dd2725e8 MDL-30989 portfolio: updated portfolio phpdocs. 2012-01-30 15:37:46 +08:00
Andrew Robert Nicols 696c748da7 MDL-31013 Add iconsmall class to 'Export to portfolio' icon 2012-01-04 10:27:08 +00:00
David Mudrak d3996e0705 MDL-27857 Typo in the phpDocs fixed 2011-10-03 10:15:38 +02:00
Sam Hemelryk 91d284c145 MDL-29186 multilang Reviewed the uses of course fullname and ensured things were being formatted consistently 2011-09-08 09:38:46 +12:00
Aparup Banerjee 728ebac7f2 MDL-28135 general Updating all hardcoded "docs.moodle.org/en/Development:" type doc links to "docs.moodle.org/dev/" 2011-07-05 14:27:31 +08:00
Sam Hemelryk 6708a1f525 MDL-27810 portfolio: Added ->portfolioenabled checks before creating portfolio buttons to avoid initialising portfolio requirements 2011-06-21 10:35:53 +08:00
David Mudrak 7e514cd768 MDL-25619 portfolio: exported HTML output can not be cleaned 2010-12-08 23:20:04 +00:00
David Mudrak 628c78409c New icon for portfolio export and improving its position
The old icon was considered "temporary" (according to Penny) and it was
not very clear. Hopefully this one is a bit better.
2010-11-12 08:52:55 +00:00
David Mudrak ac6d26bbd1 Portfolio export link displays title plus obsolete code cleanup 2010-11-11 18:24:49 +00:00
David Mudrak 0ce579fe89 Portfolio strings changed to reflect the heading of the next page
Plus fixed some typos in the portfolio library
2010-11-11 18:04:27 +00:00
David Mudrak d39c651378 Fixed trivial typo in debugging message text 2010-11-11 16:46:41 +00:00
Petr Skoda 365a594107 MDL-24321 switching to stdClass in /lib/ 2010-09-21 08:07:44 +00:00
Petr Skoda 90b2d8f012 fixed misspelled error tracing 2010-09-18 11:19:58 +00:00
Penny Leach 90636e2b41 portfolio MDL-24251 make sure $PAGE context is set up properly 2010-09-17 09:39:56 +00:00
Petr Skoda 39f4aedf3b initialized object 2010-09-17 08:06:15 +00:00
aparup 9c2b287557 assignment NOBUG the assignment submission files repository export had xhtml errors. fixed missing double inverted commas thanks to XHTML validator. 2010-07-27 07:59:38 +00:00
Petr Skoda 78bfb562a0 MDL-21249 improved php docs and adding direct access prevention in core libs 2010-07-25 13:35:05 +00:00
Petr Skoda 64f93798d4 MDL-22950 adding new component column to the files table, unfortunately this change requires changes in all 2.0dev code, please review all custom code that was already upgraded to 2.0; fixing multiple problems and regressions in mod/assignment 2010-07-03 13:37:13 +00:00
Eloy Lafuente b11bbdd16d MDL-22540 portfoliolib - cross db text comparison requires sql_compare_text() to be used 2010-05-23 09:23:05 +00:00
Penny Leach 9d429f0bae portfolio api MDL-14591 fixing small bugs and removing debugging 2010-05-02 18:00:52 +00:00
Penny Leach 3cec7552ef portfolio MDL-21508 removed lots of debuging code (just commenting out because i still have work to do here) 2010-04-13 08:06:23 +00:00
Penny Leach a1e1af19ef portfolio MDL-16124 improved the portfolio_formats conflict resolution 2010-03-21 17:19:56 +00:00
David Mudrak 16be897441 MDL-21652 html_table rendering refactored
* class html_component does not exist any more
* class html_table rendered via html_writer::table()
* html_table, html_table_row and html_table_cell have public $attributes property to set their CSS classes
* dropped rotateheaders feature, should be added again after more research of possible ways (<svg> is not nice IMHO)
* dropped possibility to define CSS classes for table heading, body and footer - can be easily done and better done using just table class and context
2010-03-20 22:15:54 +00:00
Penny Leach 549c1ae680 portfolio MDL-21508 fixed broken forum attachment export
- fixed a lot of logic in the format conflict stuff
- fixed a very specific bug in forum export when exporting a single
  attachment.
2010-03-16 19:07:53 +00:00
Petr Skoda b9bc201962 MDL-21233 escaped parameter is far more importatnt than the overrideparams in out() method - especially all JS urls should be converted to out(false); also it is possible to create new url with overrided parameters in constructor which might be actually work around the double encoding problems in the url (we should never use the out() in moodle_url constructor itself!) 2010-01-17 09:50:55 +00:00
Petr Skoda 340d461269 MDL-21233 simplifying moodle_url->out() api 2010-01-17 09:18:11 +00:00
Petr Skoda 6ea66ff36c MDL-21233 obviously input tag writing does not belong into the moodle_url class, moving to html_writer instead + simplifying api 2010-01-17 09:06:55 +00:00
Penny Leach 8192522e63 portfolio: MDL-21156 portfolio export format specific pluginfile handling 2009-12-18 13:44:35 +00:00
Martin Dougiamas b73d1651fe portfolio/lib MDL-15995 Added a missing global declaration for $CFG that broke cron 2009-12-17 03:33:45 +00:00
Petr Skoda b5d0cafc6f MDL-20787 final switch to new $OUTPUT->pix_url() - yay! 2009-12-16 21:50:45 +00:00
Penny Leach 521a6ab04d portfolio MDL-20896 added the ability to set mime info for "intended" files
This means for places in Moodle that are going to write a file, like a
CSV file, they can set the intended mimetype of the generated file.

Previously you had to use a stored_file object.

This also gets rid of portfolio_fake_add_url function and replaces the
data module implementation with a button.  I also refactored
portfolio_add_button::to_html to use moodle_url so it's easy to return
the same parameters to hidden form fields, an escaped url (for a link),
and a non escaped url (to redirect to, which is what the data module
does)
2009-12-15 12:36:49 +00:00
Penny Leach 24ba58ee9a portfolio MDL-21079 be more selective about including libraries.
this involves moving all formslib includes to where they're actually needed.
it also moves the portfolio stuff from assignment,data,chat,forum and glossary
into a locallib.php which involved creating it for many of those modules.
2009-12-12 11:27:07 +00:00
Penny Leach 59dd457e4b portfolio: MDL-21030 - leap2a portfolio format support.
This commit includes:

- leap2a portfolio format, and xml writer
- proof of concept implementation in forum and assignment modules
- a lot of refactoring of the portfolio formats in general:
    - addition of "abstract" formats - this is necessary for plugins to be able to support groups of formats
    - addition of the idea of portfolio formats conflicting with eachother - eg richhtml & plainhtml

it touches modules other than assignment and forum, because the format api
changed and now each place in moodle that exports portfolio content has to deal
with the formats it supports slightly differently.

At the moment the Mahara portfolio still doesn't support this format, because I
haven't done the Mahara side yet. The "file download" plugin supports it
though.

Still todo:

- Add support for the other places in Moodle (glossary, data, etc)
- Write tests, once the rest of the portfolio tests have been updated to use the new DB mocking stuff
- Fix a bunch of TODOs
2009-12-03 14:26:37 +00:00
Penny Leach b12fbe8e4c portfolio MDL-20905 fixing errors that affected box.net plugin 2009-11-19 07:03:53 +00:00
Penny Leach add93b8f8f portfolio MDL-19356 fixing missing global user in multi-export check 2009-11-19 06:49:57 +00:00
Dan Poltawski a9ec903149 portfolio: MDL-20897 Add additional format types
Added new specific formats for PDF, Document, Presentation and Spreadsheet

Allow the googledocs plugin to support all these formats
2009-11-18 17:33:19 +00:00
Penny Leach 887160c7cb portfolio MDL-20896 added mimetype checking for portfolio plugins for single-file exports 2009-11-18 15:34:58 +00:00
Penny Leach 3ec8d78626 portfolio MDL-20894 better checking of no common formats 2009-11-18 14:06:03 +00:00
Penny Leach edf1fc350a portfolio: MDL-20892 moved portfolio/type/* plugins to portfolio/* 2009-11-18 13:27:38 +00:00
Penny Leach c95a609597 Portfolio MDL-19356 removal of session reliance completely.
For plugins that don't support it, we can work around the external
redirect issue by returning to a special url.

This also adds on selective cancelling/continuing of current exports.

It needs a lot of testing, but seems to be working reasonably well.

Some plugins need updating now, however
2009-11-17 14:01:25 +00:00
Penny Leach f1d2641df6 portfolio: MDL-20850 fixed some navigation/output 2009-11-17 14:01:06 +00:00
Petr Skoda 7c7d3afab5 MDL-20766 message_send() used intead of events, it will enable us to improve performance and solve db transactions issues independedntly from events, hopefully this will give us more options in future too because the events are designed specifically for communication "moodle-->external systems" 2009-11-07 10:27:57 +00:00
Petr Skoda 117bd74897 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 11:31:16 +00:00
nicolasconnault 642816a60c MDL-19799 upgraded calls to print_table, print_single_button, print_user_picture, print_container* and notice_yesno 2009-08-20 08:50:50 +00:00
nicolasconnault aa9a686740 MDL-19799 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:20:12 +00:00