Commit Graph

68 Commits

Author SHA1 Message Date
Petr Skoda 66b3302dec MDL-32405 workaround for non-static PEAR::raise_error() and fixed -1 debug support 2012-04-15 17:02:26 +02:00
Petr Skoda caee6e6c26 MDL-32251 E_STRICT fixes part 3 2012-03-29 15:24:30 +02:00
Petr Skoda 68a7c9a696 MDL-32095 some more E_STRICT fixes 2012-03-26 11:47:15 +02:00
Petr Skoda fabbf4398b MDL-32094 some nasty quickforms hacks that should help with E_STRICT
Note: we have stopped tracking our QuickForms hacks long ago.
2012-03-18 18:39:37 +01:00
Davo Smith 9f9c794733 MDL-29147 Quickform fixed insertElementBefore to ignore duplicate unnamed elements 2012-02-27 20:05:39 +00:00
Tim Hunt 3bbac90b2a MDL-31469 formslib: fix invalid for="" attributes on optional dates 2012-02-02 18:38:01 +00:00
Tim Hunt 820b41e34f MDL-30168 formslib: untangle automatic id generation.
Previously, we had overridden the _generateId method in almost all
subclasses; and then we mostly, but not always; ignored the value that
was generated there, and instead generated new (nicer) values in
MoodleQuickForm_Renderer::renderElement. Of course, that is not really a
logical place to (re)generate ids.

I have fixed the code so that the _generateId method now uses the 'nice
id' algorithm from renderElement. This should make the whole code flow
more logical.

This make all our overriding of _generateId unnecessary.

We do need a special _generateId for radio buttons, because you often
have different radio buttons with the same name but different values.

This change should only change the ids on radio, checkbox and
advcheckbox elements. Previously, those were essentially random, so I
don't think anyone could have been relying on the particular values.

This commit also has new unit tests, first to test the basic _generateId
algorithm, and then to create and render an example form (including some
tricky things like repeat_elements) and chech the acutal ids in the
generated HTML.
2011-12-23 11:51:45 +00:00
Eloy Lafuente (stronk7) a7fc769154 Merge branch 'w42_MDL-29914_m22_codesniffer' of git://github.com/skodak/moodle 2011-10-25 16:34:04 +02:00
Eloy Lafuente (stronk7) bad48c0cbc MDL-29881 pear/console/getopt - deleting one more occurrence 2011-10-25 16:21:35 +02:00
Petr Skoda 9845bd201f MDL-29914 remove unused CodeSniffer lib 2011-10-25 09:14:29 +02:00
Petr Skoda c34724de75 MDL-29881 remove old apd profiling
Profiling is now handled via xhprof extension and new profiling UI.
2011-10-23 10:45:35 +02:00
Marina Glancy 7b5702b681 MDL-19907 rewrote validation for required fields in forms, including support for editor field. Added parameter to use strict (no spaces) required fields validation 2011-07-29 13:51:26 +08:00
Petr Skoda 431ac39634 MDL-26623 fix file permissions
The permissions are now going to be verified as part of the weekly release process.
2011-03-01 12:26:49 +01:00
Petr Skoda 735b8252ea fixed incorrect line endings 2010-09-28 13:19:13 +00:00
Petr Skoda 714dac9f7b MDL-24058 magic quotes are being delat with in our lib/setup.php, no need to use them again in our heavily hacked quickforms 2010-09-02 12:47:59 +00:00
Petr Skoda c1c89e3b21 MDL-16780, MDL-24058 removing PHP4 JSON implementation and related AJAX pear stuff that is not used any more - it is buggy, so we would have to either fix it (waste of time) or we have to remove it; no core code is using this and contrib can be easily updated to use standard json_encode() 2010-09-02 12:27:47 +00:00
Petr Skoda c2a3a44818 MDL-23722 importing latest 1.9.1 PEAR base classes 2010-08-09 16:25:32 +00:00
Petr Skoda bbb13f0619 MDL-23720 importing latest PEAR GeoIP module 2010-08-09 13:10:33 +00:00
Petr Skoda 4806e6d70f MDL-23722 importing Exception from PEAR base 1.9.1 2010-08-09 13:04:46 +00:00
Petr Skoda e56458a7c7 MDL-23486 fixed regression, sorrrrry 2010-07-24 19:19:37 +00:00
Petr Skoda a5e94d4bb3 MDL-23486 ugly ugly ugly hack - hardcoded required text checking in editor element; we should realy create new forms engine in 2.1 :-( 2010-07-23 18:31:31 +00:00
Jonathan Harker 9f24170cb8 MDL-20876 - updating third-party library readme_moodle with changes.
Author: Jonathan Harker <jonathan@catalyst.net.nz>
2010-07-21 01:25:04 +00:00
Jonathan Harker fcbf4b6fac lib/pear MDL-20876 fix deprecated split() calls to use explode, str_split or preg_split
Author: Jonathan Harker <jonathan@catalyst.net.nz>
2010-07-20 01:16:55 +00:00
Petr Skoda db42bc5aaa deprecation notice, use standard PHP libs instead 2010-07-19 08:56:25 +00:00
Petr Skoda b62740391c MDL-19698 deprecated assign new by ref in pear spreadsheet/excel 2010-07-19 08:40:00 +00:00
Petr Skoda 6d504dc07f MDL-19698 deprecated assign new by ref in QuickForms 2010-07-19 08:38:28 +00:00
Petr Skoda 63a544d333 MDL-20821 minor changes in previous cleanup 2009-11-18 10:35:39 +00:00
Petr Skoda f643823edb MDL-20821 minor changes in previous cleanup 2009-11-18 10:25:53 +00:00
Andrew Davis 6959330979 all MDL-20821 Removed more deprecated functions 2009-11-18 06:05:10 +00:00
skodak 66491cf130 MDL-19415 fixing deprecated use of contructors 2009-07-02 14:58:41 +00:00
stronk7 95b588478e MDL-19579 code coverage - added XML/Parser information to README file (New BSD = np) 2009-06-22 18:50:57 +00:00
stronk7 66f29dc2d1 MDL-19579 code coverage - add PEAR/XML lib, required by Spike PHP Coverage. New BSD license. 2009-06-22 18:35:56 +00:00
nicolasconnault b79fe1899c MDL-19247 Few minor adjustments and cleanup of grade_category 2009-05-21 13:30:02 +00:00
nicolasconnault 7f2068f7e9 MDL-19247 Finished cleaning up Sniffer files 2009-05-21 10:07:32 +00:00
nicolasconnault 68a1cf5d93 MDL-19247 Cleaned up most of the sniffer files and adjusted some rules such as do { ... } while (); 2009-05-21 09:48:31 +00:00
nicolasconnault cae4134c47 MDL-19247 Adjusted detection and cleaned up sniff files. 2009-05-21 03:53:28 +00:00
nicolasconnault 70020e5caf MDL-19247 Added detection of malformed package name in file phpdoc, and generation of appropriate package name based on file location 2009-05-20 19:01:42 +00:00
nicolasconnault 2178c7ada9 MDL-19247 Added detection of blank lines before control structures, plus other tidbits. 2009-05-20 14:09:26 +00:00
nicolasconnault 8cc92fb2e6 MDL-19247 Added detection of closing php tag, improved CLI tool and started clean up of Moodle Standard code. 2009-05-20 10:49:59 +00:00
nicolasconnault 84f1ffb8a2 MDL-19247 Reverted CodeSniffer.php and CLI.php to original state, and subclassed them in MoodleCodeSniffer.php and MoodleCLI.php in order to reproduce the small changes. Also updated runsniffer script. 2009-05-20 08:14:38 +00:00
moodler e624cda83b CodeSniffer MDL-19247 I updated the README, moved and renamed phpcs => runsniffer script, and modifed some rules for line length and require statements 2009-05-20 06:35:46 +00:00
nicolasconnault cf72e2dde3 MDL-19247 Minor adjustments to Moodle Coding Standard, mostly switching Errors to Warnings. Added a file to sniff out elseif declarations. Cleaned up grade/lib.php as an example (no more errors). 2009-05-19 21:17:54 +00:00
nicolasconnault d35df1b54a MDL-19247 Added the PHP CodeSniffer tool and lib/thirdpartylibs.xml 2009-05-19 15:22:43 +00:00
skodak 49ba2b61b9 MDL-19030 even uglier hack - do not try to add id to labels of static element - they do not have it; merged from MOODLE_19_STABLE 2009-04-30 10:09:13 +00:00
skodak 5c89242e50 MDL-19030 very ugly hack - do not try to add id to labels of element group - they do not have it; merged from MOODLE_19_STABLE 2009-04-30 10:06:11 +00:00
skodak 8c453e41f7 MDL-19030 fixed xhtml strictness when label attached to frozen element; merged from MOODLE_19_STABLE 2009-04-30 09:50:02 +00:00
jonathanharker 3b8c248237 MDL-17549 auth/radius: add CHAP and MSCHAP auth support, detect PHP extension
* Added support for CHAP and MSCHAP authentication schemes
       contributed by Stanislav Tsymbalov http://www.tsymbalov.net/
       original code at http://sourceforge.net/projects/moodleradius/
     * Tweak the detection of PHP RADIUS extension and Pear code
     * Update the warning notices to use more Moodly CSS classes

    lib/pear: Add RADIUS and CHAP PEAR libs

     * Add PEAR Auth_RADIUS and Crypt_CHAP packages to lib/pear


Author: Jonathan Harker <jonathan@catalyst.net.nz>
2008-12-12 04:44:53 +00:00
nicolasconnault 1e074660da MDL-16780 Merging from MOODLE_19_STABLE 2008-10-03 07:13:16 +00:00
Francois Marier 6800d78e06 Drift between CVS and git
- large deletions
- lucene updates
- error() => print_error()
- NO_MOODLE_COOKIES define
- various other things
2008-06-25 17:31:23 +00:00
martinlanghoff 9f75b5886f MDL-90 PEAR/HTTP/WebDAV: fix file name encoding ... for real this time?
Cherry picked from upstream.
2008-02-27 03:01:56 +00:00