Commit Graph

292 Commits

Author SHA1 Message Date
Sam Hemelryk 2353df33a7 Merge branch 'MDL-36433' of git://github.com/itamart/moodle into MOODLE_23_STABLE 2012-12-10 12:13:10 +13:00
Tim Hunt 500c73ba1e MDL-36760 formslib: fix frozen elements with [] in name.
This was a regression caused by MDL-30845 or, to be precise, the related
issue MDL-32785.

Form elements with names like multipier[0] require special handling,
such as is present in HTML_QuickForm_element::_prepareValue. I have
added equivalent handling to MoodleQuickForm::exportValues. I am afraid
that I could not think of a way to do this reliably without duplicating
code.
2012-11-23 11:31:20 +00:00
Itamar Tzadok 322965e245 MDL-36433 Forms lib - Added dash escaping to validation script getter. 2012-11-07 19:15:25 -05:00
Frederic Massart 98268916ff MDL-35171 Forms: Date selector always gets UTF-8 strings 2012-10-16 17:21:36 +08:00
Tim Hunt eccf42746c MDL-35395 formslib: a method to disable formchangechecker for a form. 2012-10-05 17:45:07 +01:00
Eloy Lafuente (stronk7) 35eb1a0f0c Merge branch 'MDL-35171_m23' of git://github.com/merrill-oakland/moodle into MOODLE_23_STABLE 2012-09-11 02:44:56 +02:00
Adrian Greeve 919105e5d1 MDL-32785 - lib - Ignorning hard frozen fields when submitting data. 2012-09-11 10:48:07 +12:00
Eric Merrill e0b818cde0 MDL-35171 formslib Updating date config array to fix problems with month jumping.
Based on https://bugs.php.net/bug.php?id=49115, if you request a month, but do not
specify a date, it will use your current date, which may be beyon a date in the month
requested, causing the return of the next month. This patch specifies the date (1st).
2012-09-01 10:14:51 -04:00
Aparup Banerjee 2018163468 MDL-34708 Forms library : Fixed incorrect calendar day displayed across timezones. Credit to Matthew Davidson and team at rose-hulman.edu. 2012-08-05 23:32:17 +08:00
Davo Smith 548f536a00 MDL-33927 Filemanager - enforce the maxfiles limit on form submission 2012-07-23 12:01:24 +12:00
Frederic Massart 7397acb145 MDL-31622 Forms: Date selector supports i18n 2012-07-13 08:57:29 +08:00
Tim Hunt b0cf55f145 MDL-34008 formslib: repeat_elements replace {no} for submits & buttons 2012-06-26 10:38:50 +01:00
Petr Skoda a38a17a12a MDL-33015 revert form actions to default back to FULLME
This is a temporary workaround until we fix all admin pages to set up actual url properly in admin_externalpage_setup().
2012-05-21 11:57:55 +08:00
Rajesh Taneja 86b600d67a MDL-31498 formslib: repeat_elements will now set default for group elements 2012-05-02 13:20:40 +08:00
Petr Skoda 66b3302dec MDL-32405 workaround for non-static PEAR::raise_error() and fixed -1 debug support 2012-04-15 17:02:26 +02:00
Rajesh Taneja 91f7f8c1c1 MDL-32150 Libraries: checkbox controller will not check or uncheck freezed checkboxes 2012-03-30 13:04:04 +08:00
Tim Hunt 1851b00b07 MDL-32176 formslib: allow {no} in repeat_element default values. 2012-03-23 15:22:41 +00:00
Petr Skoda fabbf4398b MDL-32094 some nasty quickforms hacks that should help with E_STRICT
Note: we have stopped tracking our QuickForms hacks long ago.
2012-03-18 18:39:37 +01:00
Sam Hemelryk 4dd2af1270 MDL-28972 formslib: Fixed up variable naming 2012-03-14 14:40:12 +13:00
Rajesh Taneja 7f850b23d7 MDL-28972 formslib: orignalvalue is considered and checkboxes are updated depending on orignalvalue of controller 2012-03-12 10:25:21 +08:00
Rajesh Taneja c14584f206 MDL-28972 formslib: Checkbox controller will use yui to select and unselect checkboxes 2012-03-12 10:25:21 +08:00
Eloy Lafuente (stronk7) 2ed7cc2730 Merge branch 'w10_MDL-31301_m23_textlibcleanup' of git://github.com/skodak/moodle 2012-03-06 16:06:53 +01:00
Sam Hemelryk f788011045 Merge branch 'MDL-31660-master-3' of git://git.luns.net.uk/moodle 2012-03-05 10:59:22 +13:00
Petr Skoda 6f3451e540 MDL-31301 remove all uses of moodle_strtolower() and deprecated it 2012-03-03 11:46:26 +01:00
Andrew Robert Nicols 88939271a1 MDL-31660 Rename form change detection javascript file 2012-02-29 14:50:52 +00:00
Sam Hemelryk 58b7d48f9a MDL-30974 forms: Last minute phpdoc fixes 2012-02-21 12:39:35 +13:00
Sam Hemelryk ceaad88222 Merge branch 'wip-mdl-30974' of git://github.com/rajeshtaneja/moodle 2012-02-21 12:07:30 +13:00
Rajesh Taneja 6c1fd30484 MDL-30974 form: Checked and updated docblock for form library 2012-02-15 12:55:06 +08:00
Sam Hemelryk a7986c15ce Merge branch 'MDL-31315-master-6' of git://git.luns.net.uk/moodle 2012-02-14 13:12:01 +13:00
Andrew Robert Nicols 00e8d08dba MDL-31315 Ask before moving away from a modified form 2012-02-09 14:55:18 +00:00
Anthony Forth 0f3f6fed69 MDL-31445 formslib: add a nice id and class to the wrapper div for CSS 2012-02-02 18:37:34 +00:00
Petr Skoda b85b25ebb8 MDL-31006 fix various notices in PHP54
PHP54 compatibility
2012-01-18 01:03:20 +01:00
Petr Skoda 48cbe43ded MDL-31213 fix incorrect modifications of quickforms attributes 2012-01-17 11:18:56 +01:00
Sam Hemelryk 3b53b85b47 Merge branch 'w52_MDL-29917_m23_autocomplete' of git://github.com/skodak/moodle 2012-01-04 10:58:03 +13:00
Petr Skoda 6e9989dbd3 MDL-29917 prevent form autocompletion in most Moodle forms
The password autocompletion in case of Moodle makes sense only on the login page, the form autocompletion in general is most probably useful only on the user signup page.

This patch is compatible with html 5, unfortunately we have to ignore strict warnings in legacy xhtml 1.0 standard.
2011-12-30 14:38:52 +01:00
Tim Hunt 820b41e34f MDL-30168 formslib: untangle automatic id generation.
Previously, we had overridden the _generateId method in almost all
subclasses; and then we mostly, but not always; ignored the value that
was generated there, and instead generated new (nicer) values in
MoodleQuickForm_Renderer::renderElement. Of course, that is not really a
logical place to (re)generate ids.

I have fixed the code so that the _generateId method now uses the 'nice
id' algorithm from renderElement. This should make the whole code flow
more logical.

This make all our overriding of _generateId unnecessary.

We do need a special _generateId for radio buttons, because you often
have different radio buttons with the same name but different values.

This change should only change the ids on radio, checkbox and
advcheckbox elements. Previously, those were essentially random, so I
don't think anyone could have been relying on the particular values.

This commit also has new unit tests, first to test the basic _generateId
algorithm, and then to create and render an example form (including some
tricky things like repeat_elements) and chech the acutal ids in the
generated HTML.
2011-12-23 11:51:45 +00:00
Rajesh Taneja 51070abc78 MDL-30560 Forms Lib: 'type' key for repeat_elements is restored 2011-12-07 11:56:34 +08:00
Aparup Banerjee 03848c4568 MDL-30335 formslib : phpdoc improvement 2011-11-23 11:47:06 +08:00
Aparup Banerjee 5cde86faa9 Merge branch 'MDL-30335' of git://github.com/timhunt/moodle 2011-11-23 11:41:58 +08:00
Tim Hunt 8f6384a9ec MDL-27045 formslib: fix disabledif for advcheckbox
This is based on earlier work by Henning Bostelmann and Tom Potts.
2011-11-17 17:57:27 +00:00
Tim Hunt fa2fa5c698 MDL-30335 formslib: fix repeat_elements for groups that don't appendName 2011-11-17 16:42:13 +00:00
Marina Glancy 6798c63e20 Added form element grading and integrated it with grading_controller 2011-10-12 15:01:53 +08:00
Rajesh Taneja 63d5c4ac85 MDL-25937 Forms Library: Filepicker will respect disable if 2011-10-03 16:26:21 +08:00
Rajesh Taneja c6aa3670d0 MDL-25937 Froms Library: Added server side validation for filepicker and filemanager 2011-09-29 09:39:44 +08:00
Eloy Lafuente (stronk7) ac4a2a8c08 MDL-29512 Revert "MDL-25937 Froms Library: Added server side validation for filepicker and filemanager"
This reverts commit f03a17bb09.
2011-09-25 17:13:40 +02:00
Eloy Lafuente (stronk7) f0e2317087 MDL-29512 Revert "MDL-25937 Forms Library: Added Javascript validation for filepicker and filemanager. Also fixed disbledif rule check for both"
This reverts commit 7dfe3c517b.
2011-09-25 17:10:27 +02:00
Rajesh Taneja 7dfe3c517b MDL-25937 Forms Library: Added Javascript validation for filepicker and filemanager. Also fixed disbledif rule check for both 2011-09-16 09:17:20 +08:00
Rajesh Taneja f03a17bb09 MDL-25937 Froms Library: Added server side validation for filepicker and filemanager 2011-09-16 09:17:19 +08:00
Tom Lanyon af9b14446d MDL-28701 Change uses of make_upload_directory(temp) to make_temp_directory(). 2011-09-10 10:43:49 +02:00
Rajesh Taneja ab978b38c4 MDL-28987 Forms Library: Added tinyMCE onblur event callback for required tinymce fields 2011-09-05 12:19:40 +08:00