Commit Graph

414 Commits

Author SHA1 Message Date
Sara Arjona 23ec91a2c4 Merge branch 'MDL-81112-403' of https://github.com/paulholden/moodle into MOODLE_403_STABLE 2024-03-21 17:11:35 +01:00
Paul Holden d3faf37e8b MDL-81112 gradereport_grader: show user country value correctly. 2024-03-20 23:49:57 +00:00
Paul Holden e7bf300cdf MDL-78438 gradereport_grader: use lang string for collapsed columns. 2024-02-23 09:39:12 +00:00
Paul Holden c58a4359e8 MDL-80766 gradereport_grader: omit max constraint for unlimited grades. 2024-01-31 18:26:40 +00:00
Jun Pataleta 9fdb460330 MDL-79062 gradereport_grader: Set numeric type for grade value inputs
* Set grade inputs for grade items with type set to GRADE_VALUE to
number and add min and max input attributes, where necessary.
2023-11-02 17:34:28 +08:00
Jun Pataleta ccfc156b43 MDL-79062 gradereport_grader: Remove setting of tabindex >= 1
Tab indices that are greater than or equal to 1 break the natural
tab order of the document and may cause problems for keyboard users.
2023-11-02 17:34:27 +08:00
Ilya Tregubov 0de64aa81b MDL-78833 gradereport_grader: Propery align averages and ranges row.
Depending on editing mode or grade display type it can be right or
left aligned
2023-09-12 16:25:01 +08:00
Kevin Percy 14b1796860 MDL-78561 grade: Deprecate grade_helper::get_lang_string() 2023-08-10 11:39:50 +08:00
Nathan Nguyen 1452caac93 MDL-77353 core: examples of new user function usage 2023-05-24 13:05:13 +10:00
Andrew Nicols ba81947f43 Merge branch 'MDL-77849-master' of https://github.com/ilyatregubov/moodle 2023-04-21 11:31:22 +08:00
Ilya Tregubov 2bfd75d9a0 MDL-77849 gradereport_grader: Align properly grade display types 2023-04-21 09:59:30 +08:00
Mihail Geshoski 71241e64a5 MDL-77932 gradereport_grader: Make range row cells collapsible 2023-04-19 10:09:57 +08:00
Mathew May ae6826953e MDL-77902 gradereport_grader: Clear btn & user differentiation 2023-04-18 09:59:13 +08:00
Mathew May fbc51cd591 MDL-77902 gradebook: Ensure dyn search works with pagination 2023-04-17 13:10:56 +08:00
Mathew May 1a1939ac29 MDL-75274 gradereport_grader: Column collapsing 2023-04-13 11:45:17 +08:00
Kevin Percy b976b3bed0 MDL-77030 gradereport_grader: Display feedback in grader report 2023-04-11 13:16:06 +08:00
Shamim Rezaie 880a67aba1 MDL-76150 gradereport_grader: Display category name cell like 2 columns 2023-04-05 11:25:15 +01:00
Shamim Rezaie 21aee2b968 MDL-76150 gradereport_grader: Make numerical grades right-aligned
- state icons follow the alignment of their respective grade type
2023-04-05 11:25:15 +01:00
Shamim Rezaie f5bda6d051 MDL-76150 gradereport_grader: render header cells from template 2023-04-05 11:25:14 +01:00
Ilya Tregubov 9ba802ca0c MDL-77033 cores_grades: Refactor cell menus to be reusable.
We need similar menus on gradebook setup page. So moving from
grader plugin to core
2023-03-30 20:20:10 +08:00
Paul Holden bf3c07834a Merge branch 'MDL-77744-master-2' of https://github.com/ilyatregubov/moodle 2023-03-30 08:34:35 +01:00
Ilya Tregubov b6a5a0bcc2 MDL-77744 core_grades: Use separate attribute for gradeitems/users. 2023-03-29 17:24:55 +08:00
Paul Holden e4317c27b2 Merge branch 'MDL-77339-master' of https://github.com/meirzamoodle/moodle 2023-03-29 10:21:08 +01:00
Andrew Nicols ad15209e1f Merge branch 'MDL-77029-master' of https://github.com/ilyatregubov/moodle 2023-03-28 12:37:01 +08:00
Ilya Tregubov cb00d26105 MDL-77029 gradereport_grader: Fix sorting bug
When column was sorted in descending order, null values
were shown first.
2023-03-28 11:22:45 +08:00
Ilya Tregubov fc9583bae1 MDL-77029 gradereport_grader: Add sorting to grade item columns 2023-03-28 11:22:42 +08:00
Meirza ab2f3f1bda MDL-77339 grade: Added class properties that are not declared
In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.
2023-03-27 22:53:04 +07:00
Shamim Rezaie d6f26ec49d MDL-76149 gradereport_grader: show perpage dropdown 2023-03-27 04:47:49 +11:00
Ilya Tregubov fd2b6f5ca9 MDL-76147 gradereport_grader: Fix collapsing preferences.
At certain cases I didn't see a tick in view mode. For example
when I click grades only and then switch to totals only a tick
next to total only was not shown. I think this is caused since before
mode was changed in circlurar order i.e.
fullmode->grade only->aggregate only->fullmode. But now any order is
possible so we need to respect it
2023-03-24 09:26:45 +08:00
Ilya Tregubov d2fe7362af MDL-76147 gradereport_grader: Remove show calculation setting. 2023-03-24 09:26:45 +08:00
Ilya Tregubov ae79f856e2 MDL-76147 gradereport_grader: Remove show activity icons setting.
We we always show those. Was enabled by default.
2023-03-24 09:26:45 +08:00
Ilya Tregubov 7656f5b6b0 MDL-76147 gradereport_grader: Move grade items and categories icons to action menu. 2023-03-24 09:26:45 +08:00
Ilya Tregubov 1c9d0e57b1 MDL-76147 gradereport_grader: Code style fixes. 2023-03-24 09:26:45 +08:00
Ilya Tregubov 5cb18337cb MDL-76146 gradereport_grader: Remove show grade analysis icon preference 2023-02-17 11:34:09 +08:00
Ilya Tregubov c1a3087f8b MDL-76146 gradereport_grader: Remove show lock icon preference. 2023-02-17 11:34:09 +08:00
Ilya Tregubov 5eff5df97b MDL-76146 gradereport_grader: Remove show show/hide icon preference
Since we move those icons to actions menu we don't need this pref.
2023-02-17 11:34:09 +08:00
Ilya Tregubov 29c220583f MDL-76146 gradereport_grader: Move action icons to action menu. 2023-02-17 11:34:09 +08:00
Ilya Tregubov 149805bc78 MDL-76146 gradereport_grader: Code style fixes. 2023-02-17 11:34:08 +08:00
Ilya Tregubov 67f2669510 MDL-76146 gradereport_grader: Deprecate AJAX grading interface.
Its not stable and not consistent.
2023-02-17 11:34:08 +08:00
Ilya Tregubov a335d50daa MDL-76146 gradereport_grader: Deprecate quick feedback. 2023-02-17 11:34:08 +08:00
Paul Holden 33c1fb4445 MDL-75381 gradereport_grader: ensure valid paging preference value.
Set type of the report paging setting to integer, to ensure usage
of it is predictable. Unsupported operated type errors were thrown
on PHP8.0 when it's value contained a string or was empty.
2022-11-29 08:41:33 +00:00
Paul Holden ab89e3caae MDL-74770 gradereport_grader: allow sorting by all user fields. 2022-08-18 15:58:11 +01:00
Sujith Haridasan 73d604369d MDL-71062 core: Step 1 deprecation of print_error function 2022-07-13 08:20:54 +05:30
Eloy Lafuente (stronk7) 4e2b4a138d MDL-74231 grader report: Fix case where old settings are empty / null
There is an edge case in the conversion from old collapse/expand
settings (stored as user preference) to the new ones that can lead
to notices / warnings / errors.

Before PHP 8, they weren't being detected, but now they are.

Basically, if some of the expected components of the preferences
are missing, then some array (array_diff(), array_intersect()..)
operations now are failing, because now those parameter functions
do require to be arrays (so empty strings or nulls aren't allowed).

Also, there were some cases where the old preference was not being
removed ever, so its removal has been moved to a common place at
the end of the function, where it's always evaluated in case
the preference still exists but is empty of contents.

I've tried to cover all the cases I've been able to imagine with
unit tests (empty information, some component not set, all components
not set...), have moved it to a new unit test because the one
already performing some tests with those old preferences was
already too long to add more cases.
2022-03-29 23:46:45 +02:00
Bas Brands a74c715627 MDL-73612 gradereport_grader: drawer layout issues 2022-01-31 10:09:33 +01:00
Huong Nguyen ffca35b805 MDL-72896 Accessibility: Make html_table responsive
The tables are generated by html_table will responsive across viewports
2021-11-09 09:41:27 +07:00
Bas Brands 6ece030948 MDL-71610 theme_boost: switch to standard editing mode for gradebook
the gradebook need to use the standard $USER->editing to check if editing mode is turned on
2021-09-29 09:25:36 +02:00
Ilya Tregubov 3de9a4db4c Merge branch 'MDL-66549-master' of git://github.com/ilyatregubov/moodle 2021-09-22 19:47:28 +02:00
arjun-kallapur a5ab9e466e MDL-66549 grades: Double arrow sort order should be ascending first 2021-09-22 14:13:14 +02:00
Luca Bösch 1f7fbed812 MDL-71352 gradereport_grader: Add icons for pass/fail. 2021-09-17 13:54:41 +02:00