Tim Hunt
54c489cb73
question bank MDL-24312 problem when deleting a course with orphaned categories.
...
When there was a question category whose parent had somehow been deleted from the question bank, while the child category was still there, then that gave an error because a DB query was still referring to the question_categories.courese coloumn, that was changed to contextid in moodle 1.9.
Backported to from HEAD. Fix thanks to Mahmoud Kassaei.
2010-11-08 16:00:29 +00:00
Tim Hunt
97546dbe14
questionlib: MDL-21828 Fix database query that does not work in Oracle.
...
Bug report and fix thanks to David Binney.
2010-04-07 09:47:17 +00:00
Tim Hunt
b6be82811d
question state loading MDL-9327 and MDL-19114 fix loading the state of ungraded essay questions
...
In two situations, the correct state was not being loaded for essay questions that had
not yet been manually graded:
1. When starting a subsequent attempt in each attempt builds on last mode.
2. In the quiz reports.
This commit fixes the problem. It has one other side-effect. When viewing the individual
question grades in the overview report for an attempt that is still in progress, the
information displayed will be slightly different. This only affects adaptive mode quizzes,
and will acutally cause the report to show slighly more up-to-date information.
Interestingly, the reportlib.php change had already been made in HEAD, as part of MDL 16529
2010-02-05 16:36:59 +00:00
arborrow
373ee66017
MDL-19950 - adding question format (qformat_) language plugin type
2009-06-20 23:33:38 +00:00
tjhunt
d547bb0bd0
qtypes: MDL-18711 Allow qtype plugins to have custom CSS and JavaScript on the editing page.
2009-03-30 09:15:37 +00:00
tjhunt
a756e41f9f
question bank: MDL-18531 Sorry, capability name typo.
2009-03-18 05:34:03 +00:00
tjhunt
0c34967646
question bank: MDL-18531 actually, moodle/question:use would be a better capabilty to check than moodle/question:add.
2009-03-18 05:01:54 +00:00
tjhunt
2113a65fdd
question bank: MDL-18531 if someone can add questions in the quiz context, but no the course context, choose a more sensible default category in the question bank.
2009-03-18 04:45:47 +00:00
tjhunt
c9f0c6e754
questions manual grading: MDL-15147 refine the logic for distinguishing '' and 0, so you can grade an essay 0 without making a comment, but also, grade some, but not all student's work in the manual grading report.
2008-12-12 09:00:03 +00:00
tjhunt
23179e6a47
questionlib: clarify a comment.
2008-12-12 02:50:29 +00:00
tjhunt
4f4fa095e9
question bank: MDL-14376 Errors deleting a course containing Cloze questions.
...
(For some reason, this only seemed to cause problems on MySQL.)
2008-12-11 05:31:41 +00:00
tjhunt
4fb4ff22a6
Simple whitespace cleanup.
2008-12-10 05:32:58 +00:00
tjhunt
5c4bcc266e
questionlib: fix typo.
2008-11-28 02:41:06 +00:00
tjhunt
901c4aae9f
question bank: MDL-14434 Cannot edit the only question category in a context.
2008-11-27 11:50:20 +00:00
tjhunt
d25bee6187
MDL-16683 - add 5/6 as a grading option.
2008-09-26 03:13:30 +00:00
tjhunt
5c6522115b
MDL-14160 SQL in get_categories_for_contexts does not work on Oracle. Thanks to Adrian Smith and Francois Marier for the fix.
2008-09-02 06:55:40 +00:00
tjhunt
b2ece40a6b
MDL-15792 - Images in question don't display. This is a regression from MDL-14279. Fix thanks to Yolanda Ord?ez Rufat.
2008-07-23 10:32:33 +00:00
tjhunt
9b3e993a98
MDL-15693 - print_question_icon does not cope with missing question types
2008-07-17 12:49:22 +00:00
scyrma
4770b4b6b3
MDL-14279: use get_file_url instead of checking $CFG->slashargument manually
2008-07-10 09:48:43 +00:00
tjhunt
79cc2bf137
MDL-15494 - No allowance for the possibility that something might go wrong when processing the response to a question. Backported from HEAD.
2008-07-02 09:14:56 +00:00
nicolasconnault
d2c33621f1
CONTRIB-475 Added CLI and web authentication, plus fixed a few little bugs.
2008-06-16 09:04:31 +00:00
jamiesensei
3a83ce8b5d
MDL-5241 "When manually grading, identity questions by their number within the quiz as well as by question name"
...
Also added a drop down box to select question to mark instead of the viewquestions table. The drop down box is available at the top of every page, but only if there is more than one manually gradeable question in the quiz. If there is only one question it is automatically selected for marking.
Also added a new constant QUESTION_EVENTS_GRADED during a general refactoring of UI code in grading report and some improvements to efficiency of SQL in report.
2008-05-25 11:35:29 +00:00
tjhunt
b209022e74
MDL-14835 - Grade not checked against valid range when manua grading
2008-05-15 16:02:15 +00:00
skodak
ade1ee0deb
MDL-14378 When deleting course category deal with everything that depends on its context
2008-05-13 21:51:46 +00:00
tjhunt
1fca73d04c
MDL-14804 - question_list_instances is broken - It does not include the each modules lib file before doing function_exists($module->name.'_question_list_instances').
2008-05-12 17:29:47 +00:00
tjhunt
c31957babf
MDL-10899 - There is some data associated with some questons that needs to be udpated when moving questions between categories. This commit deals with subquestions, and lays the foundation for fixing the other problem - datasets - which is files as bug 14767.
2008-05-09 15:05:38 +00:00
tjhunt
3747744140
MDL-13189 - replace the $QTYPE_MENU global with a function call, so that we can set up the language strings later, after $COURSE is initialised. This ensures that the quesion names appear in the right language.
2008-02-28 12:52:59 +00:00
tjhunt
833711e3b8
Unset a meaningless id. This probably does not change anything in moodle, but it was part of a bug fix in the OU version of Moodle that seemed correct, so I am merging it over.
2007-12-17 15:29:43 +00:00
jamiesensei
619b3ca8db
fix for error message
2007-11-26 13:34:47 +00:00
tjhunt
3d94c5e08e
MDL-6376 - fix minor errors in the previous commit.
...
More significantly, this patch changes the '1 Students have made 1 attempts' string.
To start with, this code was being produced in five different places, so I made a function to do the work!. Next, as you can see, it is not gramatical. Also, some people find it confusing, as in MDL-6376.
Therefore, it now just says 'Attempts: 1'.
2007-10-30 19:28:05 +00:00
tjhunt
fca490bca0
MDL-6315 - When processing a manul grading action, if both the comment and the score are blank - as might be the case on the 'Grade all' page of the manual grading when the teacher uses it to grade some, but not all of the students - then do not record the question as graded. Merged from MOODLE_18_STABLE.
2007-09-19 10:56:24 +00:00
jamiesensei
8f0f605ddf
moved question_make_default_categories function to questionlib.php since it is needed by other modules outside the question bank editing interface.
2007-09-18 11:23:29 +00:00
jamiesensei
d0508099c6
oops. Stray 'as' used for table name alias in SQL.
2007-09-07 08:01:08 +00:00
jamiesensei
9fc3100f27
fix for MDL-11106 Images not showing up in shared categories
2007-09-04 11:55:10 +00:00
jamiesensei
9f1017a0be
correct logic error that broke caching.
2007-08-16 05:19:33 +00:00
tjhunt
1e05bf54b2
Space beteen category name and count.
2007-08-15 12:06:21 +00:00
tjhunt
d402153a54
MDL-10581 - Each attemtp builds on last & multi-page quizzes was casuing grading errors. Merged from MOODLE_18_STABLE.
2007-08-10 15:22:28 +00:00
jamiesensei
3bee1ead40
merging MOODLE_19_QUESTIONS with HEAD
2007-08-09 21:50:59 +00:00
tjhunt
4f2c86ad81
OU bug 3463 - warnings when you start an attempt in 'each attempt builds on last' mode.
2007-07-17 15:27:59 +00:00
jamiesensei
61d9b9fc5d
oops. reverting changes which shouldn't have been committed to HEAD.
2007-05-25 05:49:51 +00:00
tjhunt
6e9debfbf1
Removing remaining references to RQP in core code. I had not realised there were so many.
By the way, I am committing this from a pub in York. Pub's with wireless, whatever next?
2007-05-24 17:25:37 +00:00
jamiesensei
d92b9d9140
new sql to fetch question counts for categories all in one sql query. Question count now included in drop down box.
2007-05-21 09:26:17 +00:00
jamiesensei
3a3c454ede
UI for editing questions changed to support sharing questions in multiple contexts. Also changed import / export and category editing form to use formslib.
2007-05-20 16:17:48 +00:00
poltawski
a044c05ddb
MDL-9742 - changed tabs to spaces in a few places where there are one
...
or two
2007-05-08 15:07:25 +00:00
jamiesensei
71e0eda8f7
standardizing params for edit question page. All pages now use courseid instead of course or id.
2007-04-30 06:48:57 +00:00
tjhunt
47e1697814
The question core code was restricting question types unnecessarily. This is a temporary fix, prior to a proper refactoring.
2007-04-25 11:20:22 +00:00
tjhunt
732c472fca
Remove duplicate $Id$
2007-04-24 23:23:25 +00:00
tjhunt
7d87171ba9
MDL-9565 - Question preview links don't work in developer debug mode, and not XHTML strict. Merged from OU Moodle.
2007-04-24 16:59:32 +00:00
tjhunt
c73189115f
Work round PHP4 being a stinking pile of crap.
2007-04-13 10:03:10 +00:00
tjhunt
0558f04745
Reveted Nick's alleged typo fix.
Thank you very much for trying to fix my code, but your change is definitely wrong. get_context_instance needs to be passed a coursemoduleid, not a coursemodule object.
Why did you think there was a typo?
And neither of us had noticed that I had left some debug code in. Removing that.
2007-04-13 08:12:08 +00:00