Commit Graph

154 Commits

Author SHA1 Message Date
Damyon Wiese 91bda4cd45 MDL-55417 forms: Render form elements with a template
This change allows form elements to be overridden with a mustache template.
The template can even listen for form validation errors and supply the JS to
change the look of the form element when there is/isn't a validation error.

Initial support is for all core form elements including:

text, select, selectyesno and checkboxes, groups, dateselector, datetimeselector,
autocomplete, modvisible, advcheckbox, button, duration, filemanager, filepicker, editor, static, grading,
warning, textarea, password, url, submit, questioncategory, recaptcha.

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Ryan Wyllie 2bcef5594a MDL-55727 javascript: Add modal module 2016-09-13 02:44:30 +00:00
Ryan Wyllie e845b96b83 MDL-55727 javascript: add custom interaction event module 2016-09-12 01:22:20 +00:00
Eloy Lafuente (stronk7) a1a564c84a Merge branch 'MDL-55717_master' of git://github.com/markn86/moodle 2016-09-05 18:01:21 +02:00
Dan Poltawski 9dd516c432 Merge branch 'MDL-55771_master' of git://github.com/markn86/moodle 2016-09-05 10:18:53 +01:00
Marina Glancy 6f9f8b59fa MDL-55665 charts: correction to stacked bar charts 2016-09-01 09:17:36 +08:00
Mark Nelson 8354d12d39 MDL-55771 core: added title attribute when using JS to render {{pix}} 2016-08-30 14:49:44 +08:00
Simey Lameze b02e738c4f MDL-55710 core: Add support for doughnut charts 2016-08-26 13:30:02 +08:00
Simey Lameze c574995dde MDL-55665 core: Add support for stacked bar charts 2016-08-26 13:30:01 +08:00
Mark Nelson c0abfdabb4 MDL-55717 core: add 'ignoredirty' class to inplace editable 2016-08-25 16:01:53 +08:00
Simey Lameze 787a4da9f1 MDL-55320 core: Add generaltable class to chart data table 2016-08-25 14:38:36 +08:00
Simey Lameze 9698ca2d20 MDL-55352 core: Label values series should override tooltip 2016-07-29 13:22:59 +08:00
Dan Poltawski c41ec1f55a Merge branch 'MDL-54987-master' of git://github.com/danpoltawski/moodle 2016-07-25 15:27:23 +01:00
Simey Lameze 32917a9561 MDL-54987 core: final charts project polishing 2016-07-25 10:43:35 +01:00
Simey Lameze 08501958d3 MDL-55262 core: Add support for series values labels
Part of MDL-54987 epic.
2016-07-25 10:43:28 +01:00
Simey Lameze 5a6da80a5b MDL-55037 core: Define a set of default colors
Part of MDL-54987 epic.
2016-07-25 10:43:26 +01:00
Simey Lameze 01440dccb4 MDL-55219 core: Add support for horizontal bars
Part of MDL-54987 epic.
2016-07-25 10:43:24 +01:00
Simey Lameze f0f1e0310e MDL-55110 core: Add support for smooth lines
Part of MDL-54987 epic.
2016-07-25 10:43:20 +01:00
Frederic Massart cc8438d112 MDL-55146 core: Support custom labels on X axis
Note that this is still limited as the number of labels is locked
to the number of elements in the series.

Part of MDL-54987 epic.
2016-07-25 10:43:14 +01:00
Frederic Massart 2b01f9157a MDL-55146 core: Support multiple axes in charts
Part of MDL-54987 epic.
2016-07-25 10:43:12 +01:00
Frederic Massart 4db37f3ac1 MDL-55039 core: First implementation of HTML table rendering for charts
Part of MDL-54987 epic.
2016-07-25 10:43:08 +01:00
Frederic Massart ccaa2b347d MDL-55038 core: Support multiple colours in the same series
Part of MDL-54987 epic.
2016-07-25 10:43:06 +01:00
Frederic Massart 601da0e693 MDL-55108 core: Document the charting library
Part of MDL-54987 epic.
2016-07-25 10:42:59 +01:00
Frederic Massart 681e1a7652 MDL-55092 core: Add support for custom Y axis labels
Part of MDL-54987 epic.
2016-07-25 10:42:54 +01:00
Frederic Massart 9b28bf0b83 MDL-55045 core: Remove the hardcoded canvas tag for chart.js
Part of MDL-54987 epic.
2016-07-25 10:42:49 +01:00
Frederic Massart 299e9aba66 MDL-55030 core: Bar charts defaults to using a Y axis starting at 0
Part of MDL-54987 epic.
2016-07-25 10:42:42 +01:00
Frederic Massart 826ade18f1 MDL-55030 core: Call class setter when creating a new axis
Part of MDL-54987 epic.
2016-07-25 10:42:39 +01:00
Frederic Massart a6c6faefb7 MDL-55030 core: Support setting defaults in charts
Part of MDL-54987 epic.
2016-07-25 10:42:37 +01:00
Frederic Massart 46de49dc9f MDL-55030 core: Support min and max in axes
Part of MDL-54987 epic.
2016-07-25 10:42:34 +01:00
Frederic Massart 909c5cf207 MDL-55016 core: Support stepSize in chart axes
Part of MDL-54987 epic.
2016-07-25 10:42:32 +01:00
Frederic Massart f5474e65fc MDL-55015 core: Add support for axis label in charts
Part of MDL-54987 epic.
2016-07-25 10:42:28 +01:00
Simey Lameze 858cbfdfd3 MDL-55013 core: add support for title
Part of MDL-54987 epic.
2016-07-25 10:42:19 +01:00
Adrian Greeve b559497393 MDL-54796 forms: Editor restore event created.
The editor restore event is currently being subscribed
to by the change checkers to refresh their savedstate.
2016-07-25 10:42:58 +08:00
Frederic Massart 357ec2d584 MDL-54987 core: New charting API 2016-07-22 17:33:30 +08:00
Frederic Massart 45feaec83b MDL-54987 core: Pull Chart.js in core 2016-07-22 17:33:30 +08:00
Andrew Nicols eb3839dffd MDL-50937 tag: Stop using deprecated context
$.context has been deprecated for a long time - since before this code was
written. Unfortunately jQuery does not emit anything for deprecated code so
this was not picked up sooner.
2016-07-20 11:19:29 +08:00
Damyon Wiese 8d00afb12c MDL-54915 templates: Fix async rendering of js blocks
Mustache JS helper can overwrite JS blocks when using nested templates.

Each call to render should have it's own scope.
2016-07-19 12:55:50 +08:00
Dan Poltawski 5602dc1735 MDL-54944 js: ensure functions are consistent in return val
Mostly we are being incosnistent when giving an early-exit shortcut.

Detected by http://eslint.org/docs/rules/consistent-return
2016-07-07 12:11:07 +01:00
Dan Poltawski 7b7d55e11a MDL-54944 js: split variable intialisations in multiple lines
To increase code clarity, we don't allow multiple intilisations to be
confused with each other.

Detected by http://eslint.org/docs/rules/one-var-declaration-per-line
2016-07-07 12:11:06 +01:00
Dan Poltawski b1c4d0f2d7 MDL-54944 js: Remove uncessary bind() calls
Most of these cases, we are already capturing this in a temporary
variable, so the bind becomes uncessary.

Discovered by http://eslint.org/docs/rules/no-extra-bind
2016-07-07 12:11:06 +01:00
Dan Poltawski 9f5f3dcc83 MDL-54944 js: Fix spacing of objects coding style
Fixed by http://eslint.org/docs/rules/object-curly-spacing
2016-07-07 12:11:05 +01:00
Dan Poltawski 037de71996 MDL-54944 eslint: Add rules from Policy decision
Also bump eslint to v2.13.1 and make the version explicit in
package.json
2016-07-07 12:10:49 +01:00
Mark Johnson 4d9036d6eb MDL-55041 roles: Fix JSON parsing in permission manager 2016-07-01 14:54:01 +01:00
Dan Poltawski c96f55e6f9 MDL-54939 amd: fix lint issues
Mostly correcting jsdoc, some other line wrapping rules and empty
functions.
2016-06-17 09:03:18 +01:00
Dan Poltawski 35be582696 MDL-54939 amd: Fix lint issues fixable with eslint --fix 2016-06-16 19:33:00 +01:00
Dan Poltawski 3adb62b727 MDL-52127 js: check amd files with eslint grunt task
I have spent quite a lot of time working through the current list of
eslint options and configuring them for Moodle style and I think this is
a very good basis to start us at (as well as taking some of out jshint
options out with https://www.npmjs.com/package/polyjuice ). Thanks to
Andrew Nicols, Mark Johnson and Frédéric Massart for some refinements.

With this configuration the grunt build will fail if errors are present
in the js (though you can of course tell jshint to ignore some errors,
as I have done in admin/tool/lp/amd/src/competency_rule_points.js and
defining the Y global in lib/amd/src/yui.js ).

The grunt task will not report warnings by default, but a new
--show-lint-warnings flag will help achieve that. Editor
integrations/stanadalone eslint tool will surely be a better way of
getting eslint errors rather than using the grunt task.
2016-06-11 10:14:35 +01:00
John Okely 811d9ff941 MDL-53988 mod_lti: Fix followup up issues
Fix function naming
Fix param types
Fix error popping up twice with incorrect URL
Add confirm dialog when you delete a tool
Show orphaned tool proxies in list
Fix interface jumping up and down
Change to use notification stack
Change capabilities in db/services.php
Add loading animation after registering tool
Show loading animation until tools are rendered
2016-05-19 11:18:21 +08:00
David Monllao a7bb1dda6e Merge branch 'MDL-53311-master-moregooderer' of git://github.com/cameron1729/moodle 2016-05-17 17:16:07 +08:00
Cameron Ball 4838a19641 MDL-53311 navigation: Move treeitem role on to p
Previously the li elements had the treeitem role, which was not invalid,
but it meant that when a menu item expanded, the entire li was clickable
and clicking anywhere that was not another menu item would cause the
(sub)tree to collapse. This patch moves the treeitem role on to the p
element (which contains the node name) and uses aria-owns to expand

Mad shoutouts to Ryan Wyllie for his assistance 🙌

🌄 ᚳᚱᛒ
2016-05-13 16:01:44 +08:00
Mark Nelson bae0f2375e MDL-54101 core: fixed core/str get_string caching issue 2016-05-12 18:58:56 +08:00