fdbb450f5f
MDL-38311 question manual grading: comment fixes.
2013-03-06 10:37:16 +01:00
ef01018a00
Merge branch 'MDL-38311_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-03-06 01:24:11 +01:00
add7b5a250
Merge branch 'MDL-38119_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-03-05 16:45:42 +01:00
1707b741b6
MDL-38311 questions: manual grading API should accept commentformat
...
Comment format (FORMAT_...) was correctly being processed when the
manual grading happened as the result of a form submission. It was only
when done using the question_usage or question_attempt API method that
there was no way to specify the format. (Although I think the only place
this API as used was in the unit tests.)
Note that question_attempt::manual_grade API had to change, but I don't
think that is a real API change. Calling code should be using
question_usage::question_attempt, which is backwards compatible.
Note that now, if you don't pass format, then no error is generated, but
a developer debugging message is generated.
2013-03-05 11:56:12 +00:00
a78c180efa
MDL-38279 questions: must have default mark positive.
2013-03-01 15:22:05 +00:00
627f31b52c
MDL-37847 / MDL-38119 question engine: document API change.
2013-02-28 18:26:46 +00:00
097404cd2b
Merge branch 'MDL-37967_24' of git://github.com/jmvedrine/moodle into MOODLE_24_STABLE
2013-02-20 00:34:36 +01:00
ff7a518119
Merge branch 'MDL-38051_24' of git://github.com/jmvedrine/moodle into MOODLE_24_STABLE
2013-02-19 11:23:46 +08:00
ddc03b10d5
MDL-37967 Improve XML question import format handling of duplicated files
2013-02-18 07:54:30 +01:00
ffcc444fa7
MDL-38051 Annihilate all the CRLFs present in some questions/fixtures...
2013-02-16 14:41:35 +01:00
58a43ebebe
MDL-37934 Blackboard_six question import fails in some cases
...
Import fails if the same image is used several times
in the same field of the same question.
2013-02-14 14:43:32 +01:00
2de3659810
MDL-37896 qtype_essay: correct PARAM_CLEANHTML -> PARAM_RAW.
...
It turns out that you should almost never use PARAM_CLEANHTML.
2013-02-08 12:49:58 +00:00
65828d8652
Merge branch 'MDL-37847_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-02-04 22:56:03 +01:00
b7f894a403
MDL-37847 plain text essays were screwing up HTML special chars.
...
This was incorrect use of PARAM_CLEANHTML for these inputs.
This fix also adds some unit tests to try to verify that this does not
break again in future.
2013-02-04 12:55:31 +00:00
3f7a6d5331
MDL-37746 qtype_shortanser: avoid normalizer_normalize dangers.
...
When an error occurs, normalizer_normalize just silently returns null,
which is dangerous. Here, we wrap it in a safe helper function.
2013-01-31 11:33:12 +00:00
92a7501ac6
MDL-29691 Improve numerical format in multianswer
...
Allow the use of , as decsep in multianswer numerical subquestions
2013-01-29 16:30:27 +08:00
d53ba71a24
MDL-37172 Hardcoded strings in some question imports formats
...
AMOS BEGIN
CPY [unknownorunhandledtype,qformat_blackboard_six],[unknownorunhandledtype,question]
AMOS END
2013-01-25 22:45:47 +01:00
76c98ace9a
Merge branch 'MDL-37599_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-01-22 11:40:14 +08:00
9970d909a3
MDL-37599 question import: add missing string.
...
AMOS BEGIN
MOV [matcherror,question],[invalidgrade,question]
AMOS END
2013-01-21 12:16:15 +00:00
2b18a45e61
MDL-28512 qtype essay: clean up properly when a question is deleted.
2013-01-18 11:51:47 +00:00
2540839f58
Merge branch 'MDL-37374_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-01-17 10:23:07 +08:00
db1f584cc2
MDL-37374 questions: fix property_exists calls.
2013-01-16 11:20:58 +00:00
d08da96c20
MDL-37313 question: fix trailing whitespace
2013-01-16 09:40:40 +08:00
7a82b70970
Merge branch 'MDL-37313_24' of git://github.com/jmvedrine/moodle into MOODLE_24_STABLE
2013-01-16 09:39:54 +08:00
d9babbcce1
Merge branch 'MDL-37374_24' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2013-01-15 12:59:46 +08:00
8c11e08765
MDL-37431 question preview: cron performance problem.
...
This query was performing badly. The solution seems to be to add a
redundant JOIN and WHERE to the subquery.
I renamed the table aliases in the subquery to avoid name collisions
elsewhere. I am afraid that makes the diff rather unhelpful. The
AND subq_qu.component = :qubacomponent2
line is new. The other lines have just had subq_ added.
2013-01-11 13:05:07 +00:00
4dcede552e
MDL-37374 questions: use property_exists rather than isset
...
$a->field = null; isset($a->field) returns false, which is typical PHP.
I also improve the error handling a bit.
2013-01-11 13:04:31 +00:00
dce48cf576
MDL-37313 Sample files with images for XML import
2013-01-11 09:37:44 +01:00
af8a122872
MDL-37313 Moodle XML import format should use draft file areas, not arrays
2013-01-11 09:37:42 +01:00
0a32dca4bb
MDL-28183 fix for problem during integration
...
Conflicts:
question/type/multianswer/question.php
2013-01-08 12:05:45 +01:00
c33a96f676
MDL-28183 - fix trailing whitespace
2013-01-08 12:18:31 +08:00
9910a5d7eb
Merge branch 'MDL-28183_24' of git://github.com/jmvedrine/moodle into MOODLE_24_STABLE
2013-01-08 12:17:58 +08:00
83a23ea878
MDL-35792 question preview: way to update options without restarting.
...
It is useful, and possible, to update the display options without
restarting the question. You now only have to restart if you are
changing the maximum mark or the behaviour.
2013-01-07 22:36:17 +01:00
f4537d5676
MDL-37157: Normalize short answers before comparison
...
This ensures that ambiguous Unicode representations can be compared sanely.
Also add some tests to ensure it keeps working.
Thanks to Tim Hunt for the syntax check.
2013-01-07 14:00:13 +08:00
56003ca491
MDL-37068 qformat_learnwise: fix UTF8 and other issues.
2013-01-07 13:40:24 +13:00
a7eec81ec6
MDL-28183 add num parts correct and clear wrong to multianswer
2012-12-21 05:18:02 +01:00
94c5a8fe82
MDL-32245 question bank: update URL after moving question between categories.
...
Also, improve the URL when you go to edit the questions in a category.
2012-12-20 12:12:28 +13:00
b70a545c88
MDL-32245 question bank: fix coding style in categories.php
2012-12-18 09:52:30 +13:00
c383f33bbf
MDL-32245 question bank: fix moving categories between contexts.
2012-12-18 09:52:30 +13:00
e958133ca6
MDL-37032 upgrade: define all the 2.4.0 points
2012-12-11 13:12:03 +01:00
cf617e112f
MDL-36243 question->questiontext and question->generalfeedback should always be strings
2012-12-11 16:24:24 +08:00
95ae9d9e5e
MDL-36025 qtype calculated: Fix handling of "-0"
2012-12-11 11:07:24 +08:00
6ff1745873
Merge branch 'MDL-36916' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2012-12-11 15:42:08 +13:00
35cb0e4a4c
Merge branch 'MDL-36942' of git://github.com/timhunt/moodle into MOODLE_24_STABLE
2012-12-11 15:04:22 +13:00
6812769f8f
MDL-36732 Cloze qtype: review marks should not depend on feedback.
...
The various review options should be independent.
2012-12-10 15:18:14 +08:00
0e73e16460
MDL-35404 question export: make it work with slasharguments off.
...
Thanks to Brian King for working out the problem and how to fix it. I am
just committing his patch.
2012-12-10 11:37:17 +08:00
0e7cadca03
MDL-36887 quiz: reorder upgrade.txt's
2012-12-10 11:49:03 +13:00
7e252acff1
MDL-36942 xml question import: don't add spaces.
...
They are not necessary anyway, there is a \n character at the end of
each line.
Thanks to Richard Lobb for fining the problem and how to fix it.
2012-11-30 15:59:11 +00:00
663dbbc2e6
MDL-36933 Bump everything to 2012112900
...
(versions, requires and dependencies)
2012-11-30 03:30:09 +01:00
6e4a2acf93
MDL-36916 quiz/questions: simplify code after MDL-36638.
2012-11-29 09:28:36 +00:00
Tim Hunt